From ee9b09563a98b84aedcbfb8c77de79885988eabd Mon Sep 17 00:00:00 2001 From: donghyeon-ka Date: Sun, 27 Sep 2026 12:58:46 +0900 Subject: [PATCH] fix(presentation): re-translate form errors on locale change (08-10) The form kept translated strings in state, so errors already on screen stayed in the old language. It now keeps message keys and translates on render. Co-Authored-By: Claude Opus 5.5 --- src/presentation/forms/use-app-form.ts | 42 ++++++++++---- tests/component/locale-platform.test.tsx | 71 ++++++++++++++++++++++++ 2 files changed, 101 insertions(+), 12 deletions(-) diff --git a/src/presentation/forms/use-app-form.ts b/src/presentation/forms/use-app-form.ts index 5a4e00a8..bb6e5b7d 100644 --- a/src/presentation/forms/use-app-form.ts +++ b/src/presentation/forms/use-app-form.ts @@ -43,7 +43,7 @@ export function useAppForm< Command, Output, >(options: AppFormOptions) { - const { message } = useLocale(); + const { resolve } = useLocale(); const { schema, defaultValues, @@ -59,10 +59,28 @@ export function useAppForm< const [touched, setTouched] = useState>>( () => new Set(), ); - const [fieldErrors, setFieldErrors] = useState>( + // 08-10. Errors are held as message keys and translated on render, so a + // locale change re-translates the ones already on screen. + const [fieldErrorKeys, setFieldErrors] = useState>( () => ({} as FieldErrors), ); - const [formErrors, setFormErrors] = useState([]); + const [formErrorKeys, setFormErrors] = useState([]); + const fieldErrors = useMemo( + () => + Object.freeze( + Object.fromEntries( + Object.entries(fieldErrorKeys).map(([name, key]) => [ + name, + resolve(String(key)), + ]), + ), + ) as FieldErrors, + [fieldErrorKeys, resolve], + ); + const formErrors = useMemo( + () => formErrorKeys.map((key) => resolve(key)), + [formErrorKeys, resolve], + ); const [pending, setPending] = useState(false); const [result, setResult] = useState("idle"); const [statusFailure, setStatusFailure] = useState(null); @@ -188,7 +206,7 @@ export function useAppForm< const mapped = mapValidationFailureToFields( outcome.error, allowedServerFields, - message, + messageKey, ); setFieldErrors(mapped.fieldErrors); setFormErrors(mapped.formErrors); @@ -208,9 +226,7 @@ export function useAppForm< settleSuccessfulValues(submittedValues); } else if (outcome.error.kind === "CONFLICT") { unknownSubmissionRef.current = null; - setFormErrors([ - message("form.conflict"), - ]); + setFormErrors(["form.conflict"]); setResult("conflict"); } else if ( outcome.error.kind === "FORBIDDEN" || @@ -224,11 +240,11 @@ export function useAppForm< ); } else { unknownSubmissionRef.current = null; - setFormErrors([message("form.unavailable")]); + setFormErrors(["form.unavailable"]); setResult("unavailable"); } }, - [allowedServerFields, focusFirstError, message, settleSuccessfulValues], + [allowedServerFields, focusFirstError, settleSuccessfulValues], ); const validateAndSubmit = useCallback( @@ -241,14 +257,14 @@ export function useAppForm< const errors = issuesToFieldErrors( parsed.error.issues, allowedServerFields, - message, + messageKey, ); setFieldErrors(errors); setFormErrors( parsed.error.issues.some( (issue) => !allowedServerFields.includes(issue.path[0] as FieldName), ) - ? [message("form.validation.configuration")] + ? ["form.validation.configuration"] : [], ); setTouched(new Set(allowedServerFields)); @@ -272,7 +288,6 @@ export function useAppForm< applyOutcome, focusFirstError, mapToCommand, - message, schema, submit, values, @@ -349,6 +364,9 @@ export function useAppForm< }); } +/** Keeps the key: the form translates at render time. */ +const messageKey = (key: ParameterlessMessageKey): string => key; + const STATUS_RESULTS: ReadonlySet = new Set([ "reauth-required", "forbidden", diff --git a/tests/component/locale-platform.test.tsx b/tests/component/locale-platform.test.tsx index f2733277..ea80c3c3 100644 --- a/tests/component/locale-platform.test.tsx +++ b/tests/component/locale-platform.test.tsx @@ -4,6 +4,7 @@ import { render, screen } from "@testing-library/react"; import userEvent from "@testing-library/user-event"; import { useState } from "react"; import { describe, expect, it } from "vitest"; +import { z } from "zod"; import { Button, @@ -16,6 +17,12 @@ import { useLocale, type SupportedLocale, } from "../../src/presentation/i18n/index.ts"; +import { + ErrorSummary, + Form, + FormField, + useAppForm, +} from "../../src/presentation/forms/index.ts"; import { ApplicationProvider } from "../../src/presentation/providers/application-provider.tsx"; import { PreferenceProviders } from "../../src/presentation/providers/preference-providers.tsx"; import { AppRouter } from "../../src/presentation/routes/app-router.tsx"; @@ -54,7 +61,71 @@ function LocaleHarness() { ); } +function LocaleSelect() { + const { locale, message, setLocale } = useLocale(); + return ( + <> + + + + ); +} + +function ValidatedForm() { + const form = useAppForm({ + schema: z.object({ name: z.string().min(2) }).strict(), + defaultValues: { name: "" }, + allowedServerFields: ["name"], + mapToCommand: (values) => values, + submit: async () => ({ ok: true as const, value: null }), + }); + return ( +
void form.submitForm(event)}> + + + + + ); +} + describe("locale provider runtime", () => { + // 08-10. A shown error is kept as a message key, not a translated string. + it("re-translates displayed form errors when the locale changes", async () => { + const user = userEvent.setup(); + render( + + + + , + ); + await user.click(screen.getByRole("button", { name: "Submit" })); + expect(screen.getByRole("alert")).toHaveTextContent( + "입력 내용을 확인해 주세요.Name: 입력값이 너무 짧습니다.", + ); + + await user.selectOptions(screen.getByLabelText("언어"), "en-US"); + expect(screen.getByRole("alert")).toHaveTextContent( + "Review the entered information.Name: This value is too short.", + ); + expect(screen.getByRole("textbox", { name: "Name" })).toHaveAccessibleDescription( + "This value is too short.", + ); + }); + it("switches copy and synchronizes the document language and direction", async () => { const user = userEvent.setup(); render(