feat: enforce frontend architecture boundaries
This commit is contained in:
@@ -0,0 +1,49 @@
|
|||||||
|
/** @type {import("dependency-cruiser").IConfiguration} */
|
||||||
|
module.exports = {
|
||||||
|
forbidden: [
|
||||||
|
{
|
||||||
|
name: "domain-is-framework-neutral",
|
||||||
|
severity: "error",
|
||||||
|
from: { path: "^src/domain" },
|
||||||
|
to: {
|
||||||
|
path: "^(src/(application|presentation|adapters|bootstrap)|react|react-dom|@tanstack)",
|
||||||
|
},
|
||||||
|
},
|
||||||
|
{
|
||||||
|
name: "application-does-not-know-concrete-runtime",
|
||||||
|
severity: "error",
|
||||||
|
from: { path: "^src/application" },
|
||||||
|
to: {
|
||||||
|
path: "^(src/(presentation|adapters|bootstrap)|react|react-dom|@tanstack)",
|
||||||
|
},
|
||||||
|
},
|
||||||
|
{
|
||||||
|
name: "presentation-does-not-know-adapters",
|
||||||
|
severity: "error",
|
||||||
|
from: { path: "^src/presentation" },
|
||||||
|
to: { path: "^(src/(adapters|bootstrap)|@tanstack)" },
|
||||||
|
},
|
||||||
|
{
|
||||||
|
name: "adapters-do-not-know-presentation",
|
||||||
|
severity: "error",
|
||||||
|
from: { path: "^src/adapters" },
|
||||||
|
to: { path: "^src/(presentation|bootstrap)" },
|
||||||
|
},
|
||||||
|
{
|
||||||
|
name: "no-circular-dependencies",
|
||||||
|
severity: "error",
|
||||||
|
from: {},
|
||||||
|
to: { circular: true },
|
||||||
|
},
|
||||||
|
],
|
||||||
|
options: {
|
||||||
|
doNotFollow: { path: "node_modules" },
|
||||||
|
exclude: {
|
||||||
|
path: "^(dist|artifacts|tests/fixtures)",
|
||||||
|
},
|
||||||
|
enhancedResolveOptions: {
|
||||||
|
exportsFields: ["exports"],
|
||||||
|
conditionNames: ["import", "require", "node", "default"],
|
||||||
|
},
|
||||||
|
},
|
||||||
|
};
|
||||||
@@ -0,0 +1,101 @@
|
|||||||
|
import eslint from "@eslint/js";
|
||||||
|
import globals from "globals";
|
||||||
|
|
||||||
|
const layerPatterns = {
|
||||||
|
domain: [
|
||||||
|
"**/application/**",
|
||||||
|
"**/presentation/**",
|
||||||
|
"**/adapters/**",
|
||||||
|
"**/bootstrap/**",
|
||||||
|
"react",
|
||||||
|
"react-dom",
|
||||||
|
"@tanstack/**",
|
||||||
|
],
|
||||||
|
application: [
|
||||||
|
"**/presentation/**",
|
||||||
|
"**/adapters/**",
|
||||||
|
"**/bootstrap/**",
|
||||||
|
"react",
|
||||||
|
"react-dom",
|
||||||
|
"@tanstack/**",
|
||||||
|
],
|
||||||
|
presentation: ["**/adapters/**", "**/bootstrap/**", "@tanstack/**"],
|
||||||
|
adapters: ["**/presentation/**", "**/bootstrap/**"],
|
||||||
|
};
|
||||||
|
|
||||||
|
function restrictedImports(patterns) {
|
||||||
|
return ["error", { patterns }];
|
||||||
|
}
|
||||||
|
|
||||||
|
export default [
|
||||||
|
{
|
||||||
|
ignores: [
|
||||||
|
"dist/**",
|
||||||
|
"node_modules/**",
|
||||||
|
"artifacts/**",
|
||||||
|
"tests/fixtures/typecheck/**",
|
||||||
|
"tests/fixtures/architecture/forbidden/**",
|
||||||
|
],
|
||||||
|
},
|
||||||
|
eslint.configs.recommended,
|
||||||
|
{
|
||||||
|
files: ["**/*.{js,jsx,mjs}"],
|
||||||
|
languageOptions: {
|
||||||
|
ecmaVersion: "latest",
|
||||||
|
sourceType: "module",
|
||||||
|
globals: {
|
||||||
|
...globals.browser,
|
||||||
|
...globals.node,
|
||||||
|
},
|
||||||
|
parserOptions: {
|
||||||
|
ecmaFeatures: { jsx: true },
|
||||||
|
},
|
||||||
|
},
|
||||||
|
},
|
||||||
|
{
|
||||||
|
files: ["src/domain/**/*.{js,jsx}"],
|
||||||
|
rules: {
|
||||||
|
"no-restricted-imports": restrictedImports(layerPatterns.domain),
|
||||||
|
"no-restricted-globals": ["error", "window", "document", "localStorage", "fetch"],
|
||||||
|
},
|
||||||
|
},
|
||||||
|
{
|
||||||
|
files: ["src/application/**/*.{js,jsx}"],
|
||||||
|
rules: {
|
||||||
|
"no-restricted-imports": restrictedImports(layerPatterns.application),
|
||||||
|
"no-restricted-globals": ["error", "window", "document", "localStorage", "fetch"],
|
||||||
|
},
|
||||||
|
},
|
||||||
|
{
|
||||||
|
files: ["src/presentation/**/*.{js,jsx}"],
|
||||||
|
rules: {
|
||||||
|
"no-restricted-imports": restrictedImports(layerPatterns.presentation),
|
||||||
|
},
|
||||||
|
},
|
||||||
|
{
|
||||||
|
files: ["src/adapters/**/*.{js,jsx}"],
|
||||||
|
rules: {
|
||||||
|
"no-restricted-imports": restrictedImports(layerPatterns.adapters),
|
||||||
|
},
|
||||||
|
},
|
||||||
|
{
|
||||||
|
files: ["tests/**/*.{js,jsx}"],
|
||||||
|
languageOptions: {
|
||||||
|
globals: {
|
||||||
|
...globals.browser,
|
||||||
|
...globals.node,
|
||||||
|
},
|
||||||
|
},
|
||||||
|
},
|
||||||
|
{
|
||||||
|
files: ["tests/fixtures/architecture/forbidden/**/*.{js,jsx}"],
|
||||||
|
rules: {
|
||||||
|
"no-restricted-imports": restrictedImports([
|
||||||
|
"**/adapters/**",
|
||||||
|
"@tanstack/**",
|
||||||
|
"react",
|
||||||
|
"react-dom",
|
||||||
|
]),
|
||||||
|
},
|
||||||
|
},
|
||||||
|
];
|
||||||
@@ -12,6 +12,8 @@
|
|||||||
"dev": "vite",
|
"dev": "vite",
|
||||||
"build": "vite build && node scripts/generate-build-manifest.mjs",
|
"build": "vite build && node scripts/generate-build-manifest.mjs",
|
||||||
"preview": "vite preview",
|
"preview": "vite preview",
|
||||||
|
"lint": "eslint src scripts tests vite.config.js vitest.config.js playwright.config.js --max-warnings=0",
|
||||||
|
"check:architecture": "node scripts/check-architecture.mjs",
|
||||||
"check:types": "tsc --allowJs --checkJs --noEmit",
|
"check:types": "tsc --allowJs --checkJs --noEmit",
|
||||||
"check:types:fixture": "tsc --allowJs --checkJs --noEmit --target ES2022 --module NodeNext --moduleResolution NodeNext tests/fixtures/typecheck/invalid-port-call.js",
|
"check:types:fixture": "tsc --allowJs --checkJs --noEmit --target ES2022 --module NodeNext --moduleResolution NodeNext tests/fixtures/typecheck/invalid-port-call.js",
|
||||||
"test:runtime-schema": "vitest run tests/runtime-schema --reporter=default --reporter=junit --outputFile.junit=artifacts/tests/runtime-schema.xml --passWithNoTests",
|
"test:runtime-schema": "vitest run tests/runtime-schema --reporter=default --reporter=junit --outputFile.junit=artifacts/tests/runtime-schema.xml --passWithNoTests",
|
||||||
@@ -28,6 +30,7 @@
|
|||||||
},
|
},
|
||||||
"devDependencies": {
|
"devDependencies": {
|
||||||
"@axe-core/playwright": "4.12.1",
|
"@axe-core/playwright": "4.12.1",
|
||||||
|
"@eslint/js": "10.0.1",
|
||||||
"@playwright/test": "1.62.0",
|
"@playwright/test": "1.62.0",
|
||||||
"@testing-library/jest-dom": "7.0.0",
|
"@testing-library/jest-dom": "7.0.0",
|
||||||
"@testing-library/react": "16.3.2",
|
"@testing-library/react": "16.3.2",
|
||||||
@@ -36,6 +39,9 @@
|
|||||||
"@types/react": "19.2.8",
|
"@types/react": "19.2.8",
|
||||||
"@types/react-dom": "19.2.3",
|
"@types/react-dom": "19.2.3",
|
||||||
"@vitejs/plugin-react": "6.0.4",
|
"@vitejs/plugin-react": "6.0.4",
|
||||||
|
"dependency-cruiser": "18.1.0",
|
||||||
|
"eslint": "10.8.0",
|
||||||
|
"globals": "17.7.0",
|
||||||
"jsdom": "29.1.1",
|
"jsdom": "29.1.1",
|
||||||
"msw": "2.15.0",
|
"msw": "2.15.0",
|
||||||
"typescript": "7.0.2",
|
"typescript": "7.0.2",
|
||||||
|
|||||||
Generated
+839
File diff suppressed because it is too large
Load Diff
@@ -4,3 +4,4 @@ minimumReleaseAgeExclude:
|
|||||||
- '@playwright/test@1.62.0'
|
- '@playwright/test@1.62.0'
|
||||||
- playwright-core@1.62.0
|
- playwright-core@1.62.0
|
||||||
- playwright@1.62.0
|
- playwright@1.62.0
|
||||||
|
- eslint@10.8.0
|
||||||
|
|||||||
@@ -0,0 +1,69 @@
|
|||||||
|
import { mkdir, writeFile } from "node:fs/promises";
|
||||||
|
import { spawnSync } from "node:child_process";
|
||||||
|
|
||||||
|
await mkdir("artifacts/quality", { recursive: true });
|
||||||
|
|
||||||
|
const pnpmCli = /** @type {string} */ (process.env.npm_execpath);
|
||||||
|
|
||||||
|
if (!pnpmCli) {
|
||||||
|
throw new Error("check:architecture must run through the pnpm script");
|
||||||
|
}
|
||||||
|
|
||||||
|
/** @param {string[]} arguments_ */
|
||||||
|
function runPnpm(arguments_) {
|
||||||
|
return spawnSync(process.execPath, [pnpmCli, ...arguments_], {
|
||||||
|
encoding: "utf8",
|
||||||
|
});
|
||||||
|
}
|
||||||
|
|
||||||
|
const production = runPnpm(
|
||||||
|
[
|
||||||
|
"exec",
|
||||||
|
"depcruise",
|
||||||
|
"src",
|
||||||
|
"--config",
|
||||||
|
".dependency-cruiser.cjs",
|
||||||
|
"--output-type",
|
||||||
|
"json",
|
||||||
|
],
|
||||||
|
);
|
||||||
|
|
||||||
|
await writeFile(
|
||||||
|
"artifacts/quality/dependency-report.json",
|
||||||
|
production.stdout || JSON.stringify({ summary: { errors: 1 } }),
|
||||||
|
);
|
||||||
|
|
||||||
|
if (production.status !== 0) {
|
||||||
|
process.stderr.write(
|
||||||
|
production.error?.message ?? production.stderr ?? production.stdout ?? "failed",
|
||||||
|
);
|
||||||
|
process.exit(production.status ?? 1);
|
||||||
|
}
|
||||||
|
|
||||||
|
const allowed = runPnpm(
|
||||||
|
[
|
||||||
|
"exec",
|
||||||
|
"eslint",
|
||||||
|
"tests/fixtures/architecture/allowed",
|
||||||
|
"--no-ignore",
|
||||||
|
"--max-warnings=0",
|
||||||
|
],
|
||||||
|
);
|
||||||
|
|
||||||
|
const forbidden = runPnpm(
|
||||||
|
[
|
||||||
|
"exec",
|
||||||
|
"eslint",
|
||||||
|
"tests/fixtures/architecture/forbidden",
|
||||||
|
"--no-ignore",
|
||||||
|
"--max-warnings=0",
|
||||||
|
],
|
||||||
|
);
|
||||||
|
|
||||||
|
if (allowed.status !== 0 || forbidden.status === 0) {
|
||||||
|
process.stderr.write(allowed.stderr || allowed.stdout);
|
||||||
|
process.stderr.write(forbidden.stderr || forbidden.stdout);
|
||||||
|
process.exit(1);
|
||||||
|
}
|
||||||
|
|
||||||
|
process.stdout.write("Architecture fixtures: allowed PASS, forbidden rejected\n");
|
||||||
@@ -0,0 +1,3 @@
|
|||||||
|
import { createApplication } from "../../../../src/application/create-application.js";
|
||||||
|
|
||||||
|
export const applicationFactory = createApplication;
|
||||||
@@ -0,0 +1,3 @@
|
|||||||
|
import { QueryClient } from "@tanstack/react-query";
|
||||||
|
|
||||||
|
export const invalidClient = new QueryClient();
|
||||||
@@ -0,0 +1,3 @@
|
|||||||
|
import React from "react";
|
||||||
|
|
||||||
|
export const invalidDomainValue = React.createElement("div");
|
||||||
@@ -0,0 +1,3 @@
|
|||||||
|
import "../../../../src/adapters/http/client.js";
|
||||||
|
|
||||||
|
export const invalidEdge = true;
|
||||||
Reference in New Issue
Block a user