ci(release): drill the downloaded promoted archive in the production stage (13-03)
FE-GATE-021..025 rebuilt from source and drilled that build, so the drilled bytes were not the promoted release. production_gate now downloads the promoted-release artifact, extracts it against immutable_build's digest and runs each drill with --release-root; the CI contract rejects a rebuild. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
co-authored by
Claude Opus 5.5
parent
15a946fc46
commit
fa3de53106
@@ -899,7 +899,7 @@ function validateContractSemantics(
|
||||
vulnerability_provider: ["provider", ["immutable_build"], "always"],
|
||||
provenance_provider: ["provider", ["immutable_build"], "always"],
|
||||
promotion: ["promotion", ["immutable_build", "vulnerability_provider", "provenance_provider"], "needs-success"],
|
||||
production_gate: ["gate-matrix", ["promotion"], "production"],
|
||||
production_gate: ["gate-matrix", ["immutable_build", "promotion"], "production"],
|
||||
field_gate: ["gate-single", ["production_gate"], "field"],
|
||||
documentation_gate: ["gate-single", [], "documentation"],
|
||||
};
|
||||
@@ -916,7 +916,7 @@ function validateContractSemantics(
|
||||
vulnerability_provider: ["checkout", "setup-node", "frozen-install", "download", "run-provider", "validate-provider-evidence", "upload"],
|
||||
provenance_provider: ["checkout", "setup-node", "frozen-install", "download", "run-provider", "validate-provider-evidence", "upload"],
|
||||
promotion: ["checkout", "setup-node", "frozen-install", "download", "download", "download", "verify-promotion", "upload", "cleanup-promotion"],
|
||||
production_gate: ["checkout", "setup-node", "frozen-install", "run-gate", "upload"],
|
||||
production_gate: ["checkout", "setup-node", "frozen-install", "download", "extract", "run-gate", "upload"],
|
||||
field_gate: ["checkout", "setup-node", "frozen-install", "run-gate", "upload"],
|
||||
documentation_gate: ["checkout", "setup-node", "frozen-install", "run-gate", "upload"],
|
||||
};
|
||||
@@ -976,7 +976,12 @@ function validateContractSemantics(
|
||||
],
|
||||
// 13-05: FE-GATE-019 probes the promoted release after the provider has
|
||||
// deployed it, so the live base URL belongs to the production stage.
|
||||
production_gate: [{ name: "HOSTING_BASE_URL", value: "${{ vars.HOSTING_BASE_URL }}" }],
|
||||
// 13-03: the drills extract the promoted archive and check it against the
|
||||
// digest immutable_build recorded.
|
||||
production_gate: [
|
||||
{ name: "HOSTING_BASE_URL", value: "${{ vars.HOSTING_BASE_URL }}" },
|
||||
{ name: "CANDIDATE_ARCHIVE_SHA256", value: "${{ needs.immutable_build.outputs.archive_sha256 }}" },
|
||||
],
|
||||
field_gate: [
|
||||
{ name: "FIELD_WEB_VITALS_INPUT", value: "${{ vars.FIELD_WEB_VITALS_INPUT }}" },
|
||||
{ name: "MIN_ELIGIBLE_SAMPLES", value: "${{ vars.MIN_ELIGIBLE_SAMPLES }}" },
|
||||
@@ -1171,6 +1176,38 @@ function validateCanonicalStepFields(
|
||||
) {
|
||||
issue("promotion download fields and finalizer/cleanup step identities must remain linked");
|
||||
}
|
||||
|
||||
// 13-03: the production stage drills the promoted archive it downloads. It
|
||||
// used to rebuild from source, so the drilled bytes were not the release.
|
||||
const production = contract.jobs.find(({ id }) => id === "production_gate");
|
||||
const promotedDownload = production?.steps.find(
|
||||
(step) => step.kind === "download" && step.transferId === "promoted-release",
|
||||
);
|
||||
const promotedExtract = production?.steps.find(({ kind }) => kind === "extract");
|
||||
if (
|
||||
!production ||
|
||||
promotedDownload?.kind !== "download" ||
|
||||
promotedExtract?.kind !== "extract" ||
|
||||
promotedExtract.archivePath !== `${promotedDownload.path}/release-candidate.tar.gz`
|
||||
) {
|
||||
issue("production_gate must download the promoted release and extract its release-candidate.tar.gz");
|
||||
} else {
|
||||
for (const gateId of production.gateIds) {
|
||||
const commands = (contract.gates.find(({ id }) => id === gateId)?.commandIds ?? [])
|
||||
.map((commandId) => contract.commands.find(({ id }) => id === commandId));
|
||||
if (!commands.some((command) => command?.script === "drill:runbook")) continue;
|
||||
if (commands.some((command) => command?.script !== "drill:runbook")) {
|
||||
issue(`production drill gate must drill the promoted archive only, without rebuilding: ${gateId}`);
|
||||
}
|
||||
for (const command of commands) {
|
||||
const args = command?.args ?? [];
|
||||
const releaseRoot = args.indexOf("--release-root");
|
||||
if (releaseRoot < 0 || args[releaseRoot + 1] !== promotedExtract.targetRoot) {
|
||||
issue(`production drill must pass --release-root ${promotedExtract.targetRoot} (the promoted archive): ${command?.id ?? gateId}`);
|
||||
}
|
||||
}
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
function validateJobStepKinds(
|
||||
@@ -1178,7 +1215,7 @@ function validateJobStepKinds(
|
||||
issue: (message: string, path?: PropertyKey[]) => void,
|
||||
): void {
|
||||
const allowed: Readonly<Record<z.infer<typeof jobSchema>["kind"], ReadonlySet<string>>> = {
|
||||
"gate-matrix": new Set(["checkout", "setup-node", "frozen-install", "browser-install", "run-gate", "upload"]),
|
||||
"gate-matrix": new Set(["checkout", "setup-node", "frozen-install", "browser-install", "download", "extract", "run-gate", "upload"]),
|
||||
"gate-single": new Set(["checkout", "setup-node", "frozen-install", "run-gate", "upload"]),
|
||||
immutable: new Set(["checkout", "setup-node", "frozen-install", "run-gate", "archive-candidate", "upload"]),
|
||||
provider: new Set(["checkout", "setup-node", "frozen-install", "download", "extract", "run-provider", "validate-provider-evidence", "upload"]),
|
||||
|
||||
Reference in New Issue
Block a user