문제: SW를 ACTIVE로 켜면 build-frontend 6단계의 SW Vite 빌드가 Vite
기본값대로 public/을 dist에 다시 복사한다. 4단계가 프로필로 만든
dist/config.json이 public/config.json(local, demo 인증,
http://localhost:8080/, 루트 release manifest)으로 덮어써진다. 빌드와
verify-release는 통과하고 release admission만 거절한다. 그래서 SW를 켠
제품은 local이 아닌 릴리스를 만들 수 없다. VITE_ROUTER_BASE_PATH를
쓰면 RELEASE_MANIFEST_URL도 base를 잃는다.
고른 방법: vite.service-worker.config.ts에 publicDir: false를 넣는다.
dist에는 3단계 앱 빌드가 이미 public/을 복사해 두었고, 워커 번들은
public/ 파일을 쓰지 않는다. 같은 repo의 다른 두 번째 Vite 빌드
(scripts/lib/optional-recipe-bundle.ts)도 같은 설정이다.
build-frontend.ts 6단계 주석에 이 조건을 한 줄 적었다.
버린 대안:
- build.copyPublicDir: false. 복사만 끄고 public 디렉터리는 계속
설정에 남는다. 워커 빌드는 public/을 쓸 일이 없어 publicDir: false가
의도를 바로 말한다.
- 앱 빌드 plugin의 closeBundle에서 워커를 만들기, 또는 Vite build()를
configFile: false로 부르는 스크립트. 둘 다 리뷰 5.2절의 대안이다.
two-pass 구조를 바꾸거나 파일이 늘어 이 결함에 비해 범위가 크다.
테스트: tests/unit/service-worker-build-output.test.ts는 임시 복사본에서
SW ACTIVE + APP_PROFILE=production + VITE_ROUTER_BASE_PATH=/app/로 실제
build-frontend.ts를 돌린다. 그리고 dist/config.json이
generateRuntimeConfig("production", env) 결과와 같은지 본다(리뷰의 완료
기준). 설정 객체에서 publicDir === false를 보는 테스트는 수정을 다시
적을 뿐이고, 설정이 5단계 생성물 없이는 로드되지 않아 버렸다. 빌드
1회가 약 2초라 unit 계층에 둔다(build-environment-bundle.test.ts와 같은
방식, docs/testing/taxonomy.md의 짧은 child process 규칙). 복사와 빌드는
e2e 도우미 prepareFixtureBuilds를 재사용하고, 빌드별 env 옵션만
추가했다(기존 호출은 그대로). 이 테스트로 0925/06-10(SW Vite 설정의
dist/config.json 읽기 테스트 없음)도 닫힌다.
위험·한계: 하위 경로에서 사전 캐시 URL이 base를 잃는 문제(0929/06-02)와
워커의 runtime config URL 기본값은 그대로다. 이 테스트는 /app/ 빌드의
설정 문서만 보고 워커 설치는 보지 않는다. Vite 8.1.5 동작 기준이다.
check:architecture는 pnpm 스크립트로만 돌아서 실행하지 않았다(src는
바꾸지 않았다).
검증:
- RED(수정 전): 새 테스트 실패. APP_ENV local(기대 production),
AUTH_MODE demo(기대 external), API_BASE_URL http://localhost:8080/,
RELEASE_MANIFEST_URL /release-manifest.json(기대 /app/...)
- GREEN: 새 테스트 통과(1.9초)
- 수정 전후 production + /app/ 빌드 비교: dist 파일 34개로 같음. 수정 후
RELEASE_TARGET=production check-release-admission ADMITTED, 수정 전 rc 1
- node scripts/run-vitest.ts run tests/unit(pnpm을 띄우는 2파일 제외):
164파일 2343건 통과
- tsc tsconfig.test.json, tsconfig.node.json 통과. 바꾼 4파일 eslint 통과
Refs: docs/reviews/2026-11-01-maturity-review/06-adapters-service-worker-push.md 2절, 13-build-release-supply-chain.md 실험 E-B
max-width 8.5rem과 7rem 때문에 모든 언어에서 선택값이 잘렸다
("Light then", "Englisl", "라이트 테ㅁ"). 커밋된 시각 골든에도 잘린
머리글이 들어 있어, 시각 테스트가 결함을 정답으로 지키고 있었다.
고정 폭을 지웠다. 좁은 화면은 기존 메뉴 서랍 배치가 그대로 맡는다.
새 i18n e2e 테스트가 ko-KR, en-US, en-XA에서 선택 상자 폭을 브라우저가
옵션에 필요한 폭과 비교한다.
위험: 중간 폭에서 머리글이 넓어진다. responsive·app-shell·theme·compact
테스트가 통과했다.
검증: 새 테스트가 고치기 전 실패했고, 고친 뒤 chromium·firefox·webkit
모두 통과했다.
WebKit reports the failed dynamic import as "TypeError: Importing a
module script failed." without the chunk URL, so the strict console
check rejected an expected failure. The recovery assertions already
passed on WebKit; the spec now passes on chromium, firefox and webkit.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
"serves A's removed chunk from the previous cache" needs a route chunk of
A that B no longer ships. Route chunks used to differ only because they
embedded the build ID; since 09-02 (a8111f7) they do not, so A and B
emitted the same route chunks and the test failed in setup. Found by
running the whole e2e suite after integration and bisecting from
4626b73. Build B now appends an export to the not-found page, which a
dynamically imported module keeps.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
d7b81c6 moved the detail route under items/ but this scan still opened
the old path, which now renders the not-found screen, so the @a11y run
would fail waiting for the detail heading. 38 @a11y tests pass on
chromium and firefox.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
With the sample removed every route is public, so comparing access with
session-required no longer typechecked and test:sample-removal failed.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
09-03 moved the application graph behind a dynamic import, but only jsdom
checked it. A real production build whose installed messages collide now
opens in a browser and must show the boot error shell, not the loading shell.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Old-tab chunk recovery in the default configuration only had jsdom tests, and
the old-asset test checked its own hosting fixture. A spec now serves two real
builds: the old tab reloads once into the new one and not a second time. The
fixture test and the acceptance row now say what they cover.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The route spec only checked that the protected screen opened, so a schema
violating 200 or a 503 still passed it. It now asserts the mocked row, and
a new spec saves once and retries after a 429 in a real browser.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
zod probed Function("") on its first object schema, which the production CSP
(no unsafe-eval) reported on every boot. Schema code now imports z from
src/contracts/zod.ts, enforced by a dependency-cruiser rule, and the CSP smoke
drops its init-script workaround.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A direct link to /page#target stayed at the top: the target renders with the
lazy page, after the router scrolled up. PageHeader now scrolls to it below
the sticky header, focus never scrolls, and POP no longer scrolls to top.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
axe ran as soon as `main` showed, which is the app shell's loading surface,
and protected routes were scanned on the sign-in prompt. The specs now wait
for the route's h1, sign in first, and scan the reference list, detail, form
and status states. The state-surfaces baseline was the loading surface.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A worker that stops the page from booting had no exit: every off switch was
page code. A REMOVE_REGISTRATION release now writes a service-worker.js that
skips waiting and unregisters itself (D-5), checked end to end in the browser.
The runbook and rollback doc now name only paths that exist in code.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The check named reference paths from i18n.spec.ts, which the sample
removal keeps, so the removed fixture would carry reference residue.
reference-form.spec.ts is removed with the sample.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The reference feature and home page rendered Korean literals, so en-US
still showed Korean. check:i18n now scans pages and every feature
presentation folder, and its fixture fails unless every fixture is rejected.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
check:test-evidence requires every e2e spec to use the strict fixture, which
fails on the zod eval console error. The smoke now sets zod's global config
jitless before page scripts run and requires zero violations; without that
init script it fails on the known probe.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The declared CSP was never applied in a browser. A Playwright spec now serves
the build with config/hosting/security-headers.json and fails on any
securitypolicyviolation. It found one: zod's Function('') probe, listed in the
spec as a known violation until zod is configured jitless before first use.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
check:adapter-inventory forbids a raw node_modules symlink in fixtures; use
linkFixtureNodeModules like the other fixture builders.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
vite.service-worker.config.ts loaded .generated/frontend-runtime/*.ts with a
bare relative import(). Vite's default `bundle` config loader runs the config
from node_modules/.vite-temp/, so with the ACTIVE selection
`corepack pnpm build` stopped at the worker step. Resolve the paths against
import.meta.url, which every loader keeps pointing at the config file.
The e2e helper no longer patches build-frontend.ts with
`--configLoader native`; the quarantined fixme is replaced by a check that
both unmodified ACTIVE builds emitted service-worker.js.
RED (throwaway copy, ACTIVE selection, unmodified scripts/build-frontend.ts):
TypeError: Required generated module is unavailable:
./.generated/frontend-runtime/service-worker-assets.ts
[cause]: Error [ERR_MODULE_NOT_FOUND]: Cannot find module
'.../node_modules/.vite-temp/.generated/frontend-runtime/service-worker-assets.ts'
build step failed: npx vite build --config vite.service-worker.config.ts
build-frontend exit=1
GREEN: same copy after the fix -> build-frontend exit=0, dist/service-worker.js
emitted; `pnpm test:e2e --project=chromium
tests/e2e/service-worker-update.spec.ts` 5 passed.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Builds the app twice with the ACTIVE selection in a temp copy and serves
either dist from a per-test static server. Covers install with
application/javascript and gzip bodies, update-waiting/reload-required
through the host, and the previous-cache fallback for a removed chunk.
The unmodified ACTIVE build fails (vite.service-worker.config.ts resolves
.generated/ from node_modules/.vite-temp); that case is test.fixme and the
helper builds with --configLoader native.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>