문제: SW를 ACTIVE로 켜면 build-frontend 6단계의 SW Vite 빌드가 Vite
기본값대로 public/을 dist에 다시 복사한다. 4단계가 프로필로 만든
dist/config.json이 public/config.json(local, demo 인증,
http://localhost:8080/, 루트 release manifest)으로 덮어써진다. 빌드와
verify-release는 통과하고 release admission만 거절한다. 그래서 SW를 켠
제품은 local이 아닌 릴리스를 만들 수 없다. VITE_ROUTER_BASE_PATH를
쓰면 RELEASE_MANIFEST_URL도 base를 잃는다.
고른 방법: vite.service-worker.config.ts에 publicDir: false를 넣는다.
dist에는 3단계 앱 빌드가 이미 public/을 복사해 두었고, 워커 번들은
public/ 파일을 쓰지 않는다. 같은 repo의 다른 두 번째 Vite 빌드
(scripts/lib/optional-recipe-bundle.ts)도 같은 설정이다.
build-frontend.ts 6단계 주석에 이 조건을 한 줄 적었다.
버린 대안:
- build.copyPublicDir: false. 복사만 끄고 public 디렉터리는 계속
설정에 남는다. 워커 빌드는 public/을 쓸 일이 없어 publicDir: false가
의도를 바로 말한다.
- 앱 빌드 plugin의 closeBundle에서 워커를 만들기, 또는 Vite build()를
configFile: false로 부르는 스크립트. 둘 다 리뷰 5.2절의 대안이다.
two-pass 구조를 바꾸거나 파일이 늘어 이 결함에 비해 범위가 크다.
테스트: tests/unit/service-worker-build-output.test.ts는 임시 복사본에서
SW ACTIVE + APP_PROFILE=production + VITE_ROUTER_BASE_PATH=/app/로 실제
build-frontend.ts를 돌린다. 그리고 dist/config.json이
generateRuntimeConfig("production", env) 결과와 같은지 본다(리뷰의 완료
기준). 설정 객체에서 publicDir === false를 보는 테스트는 수정을 다시
적을 뿐이고, 설정이 5단계 생성물 없이는 로드되지 않아 버렸다. 빌드
1회가 약 2초라 unit 계층에 둔다(build-environment-bundle.test.ts와 같은
방식, docs/testing/taxonomy.md의 짧은 child process 규칙). 복사와 빌드는
e2e 도우미 prepareFixtureBuilds를 재사용하고, 빌드별 env 옵션만
추가했다(기존 호출은 그대로). 이 테스트로 0925/06-10(SW Vite 설정의
dist/config.json 읽기 테스트 없음)도 닫힌다.
위험·한계: 하위 경로에서 사전 캐시 URL이 base를 잃는 문제(0929/06-02)와
워커의 runtime config URL 기본값은 그대로다. 이 테스트는 /app/ 빌드의
설정 문서만 보고 워커 설치는 보지 않는다. Vite 8.1.5 동작 기준이다.
check:architecture는 pnpm 스크립트로만 돌아서 실행하지 않았다(src는
바꾸지 않았다).
검증:
- RED(수정 전): 새 테스트 실패. APP_ENV local(기대 production),
AUTH_MODE demo(기대 external), API_BASE_URL http://localhost:8080/,
RELEASE_MANIFEST_URL /release-manifest.json(기대 /app/...)
- GREEN: 새 테스트 통과(1.9초)
- 수정 전후 production + /app/ 빌드 비교: dist 파일 34개로 같음. 수정 후
RELEASE_TARGET=production check-release-admission ADMITTED, 수정 전 rc 1
- node scripts/run-vitest.ts run tests/unit(pnpm을 띄우는 2파일 제외):
164파일 2343건 통과
- tsc tsconfig.test.json, tsconfig.node.json 통과. 바꾼 4파일 eslint 통과
Refs: docs/reviews/2026-11-01-maturity-review/06-adapters-service-worker-push.md 2절, 13-build-release-supply-chain.md 실험 E-B
라이트 --color-focus가 흰 패널에서 2.33:1, surface-muted에서 1.95:1로
WCAG 1.4.11 기준(3:1)에 못 미쳤다. 포커스 링은 컨트롤에서 3px 떨어져
그려지므로, 대비를 따질 인접색은 컨트롤 뒤의 표면이다.
라이트 포커스를 oklch(0.52 0.15 230)으로 바꿨다. 가장 낮은 대비가
4.24:1이다. 다크는 그대로다. check:design-system이 두 테마에서 포커스
토큰과 표면 토큰 8종의 대비를 계산하고, 3:1 미만이면 실패한다.
안팎 이중 링은 버렸다. 한 색으로 충분하고 링 모양이 바뀌지 않는다.
위험: 포커스 링 색이 진해져 시각 골든이 바뀐다(별도 커밋에서 갱신).
검증: 토큰을 바꾸기 전 검사가 라이트 표면 8종 모두에서 실패했고,
바꾼 뒤 통과했다. 계산식은 브라우저 실측값 2.33:1과 일치한다
(tests/unit/oklch-contrast.test.ts).
FE-GATE-021..025 rebuilt from source and drilled that build, so the drilled
bytes were not the promoted release. production_gate now downloads the
promoted-release artifact, extracts it against immutable_build's digest and
runs each drill with --release-root; the CI contract rejects a rebuild.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
check-ci-contract only caught test files outside the gates; check:* scripts
such as check:request-fanout and check:remediation-ledger ran nowhere. The
new check reads config/ci/ungated-scripts.json; three checks are now wired
into FE-GATE-010 and FE-GATE-012 and the rest carry a reason.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The growth test read docs/reviews/, which the removal fixtures do not copy and
README lets a project delete, so three removal checks failed with ENOENT. The
rationale now lives in config/scale/feature-shape-ceilings.json and a guard
test keeps code from reading the deletable history documents.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Resolving a policy only rejected predicates that admitted one of seven sample
ids, so a policy also allowing ':', '@' or letters passed BEGIN_PUT and failed
at FINISH_PUT. Writes now require the grammar alongside the policy, and the
samples cover those widenings so they are refused when the policy is resolved.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Early returns before resolve (invalid input, pre-aborted signal, byte-length
mismatch) left the capability registered, so maxActiveCapabilities: 1 refused
the next issuance. The public methods now release it once in a finally.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
VD-01 decision 3 hands unused diagnostics to tsc and turns off ESLint's
no-unused-vars for TS files, but tsconfig.base.json never enabled the
tsc check (D-19). The flag found 46 unused imports, types and helpers
across 22 files; none of them were read, so removing them changes no
behaviour.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
pnpm verifies the install before a script, and a fixture running it with
CI=true against an install made without CI saw other settings and installed
through the linked .pnpm and .bin, rewriting the shared lock.yaml and shims.
Every fixture pnpm run now turns that check off; a test pins it for all.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Each run left 35 directories behind (repository-inventory, inventory-outside,
sw-assets, generator), and thousands piled up. They are now removed after
every test.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
One run decided the release gate, the interaction included Playwright round
trips, and a server already on 4173 was measured instead of the build. Runs
now repeat with every sample kept, time the interaction in the page, use
--strictPort and check the served build, and stop the whole preview group.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The scale evidence came from stub features, so the cost of one app growing
towards its declared ceiling was never measured. Copies of the reference
feature at 25 and 100 are now the baseline, and the acceptance matrix says
what the ceilings rest on and which axes stay unverified.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The worker build read public/config.json, the local profile, even in a
production build (F-8). It now reads dist/config.json and fails when that
document's APP_ENV is not the build's APP_PROFILE.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The fallback opened `${origin}/`, outside the app under a router base path.
The scope host now passes registration.scope and the click adapter opens it,
refusing any app root outside the origin.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Only the capabilities config set forbidOnly, so a committed test.only ran one
e2e, visual or storybook test and passed. The skip check accepted any
quarantine marker without comparing its expiry date to today.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Writes a feature that owns one REST operation, plus its own context, into a
copy of the repository and runs the generator and check-registries there.
Reverting the consumer-directory globs makes the test fail.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Any same-origin GET with a hashed-looking name, API and download URLs
included, was routed through the worker. The fallback now applies only under
the build asset directory of the registration scope.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The checkpoint store still used the File/Cache table, so a missing store read
as NOT_FOUND and a quota failure as retryable. It now uses
mapIndexedDbException, leaving one IndexedDB exception table in the repo.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The worker sent ACTIVATE_REJECTED for a client refusal, a drain timeout and a
failed skipWaiting() alike, so the page blamed a dirty tab. Two worker reply
kinds now carry the timeout and the commit failure.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
ENV_REGISTRY called VITE_BUILD_ID required with no default while every reader
fell back to local-build. Staging and production builds now fail without it;
local builds keep the placeholder, and the registry records that default.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Design 14.1 connect and bounded_poll events had no place to come from, and
an exhausted budget looked the same as a terminal failure. Both coordinators
now emit a closed observation vocabulary through a best-effort sink.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
After an account switch without logout the new session could not name the
stored authority, so enable and reconcile stayed STALE_AUTHORITY. The port
gains revokeForeign: it rotates a fence another fence generation holds and
revokes its association, and leaves the caller's own fence alone.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Cross-origin handoff, retained byte cap, typed preview Blob, native picker
user activation and first-seen-source GAP each get an input that only that
rule rejects. Removing any of the five lines now fails exactly one test.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
An ACTIVE worker whose install failed left a trace only in health(), which
nothing reads. The optional host now emits service-worker.start.failed on the
application telemetry port, and the recipe doc lists what else to wire.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The IDLE_TIMEOUT path had no test, so flipping it to retryable:false (M7)
passed. Two ManualClock tests now fail on that mutation.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A lookup listed the cache names twice and copied the body four times (read
buffer, digest input, stored source, stream). The name list is now shared and
only the read buffer and the per-stream copy remain; WebCrypto copies its
input itself.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
invokeValidator spread result.issues outside its try and treated any truthy
success as valid, so a hand-written validator could throw past the executor
or pass unchecked data. The result is now read inside the try and checked.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The browser picks the read size, so a chunk over 256KB ended the stream as
EVENT_TOO_LARGE even when every event was normal size.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Five tests restore fake timers only at the end of their body, so a failed
assertion left fake timers to the next test in the same file.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The gate only matched one diagnostic string, so widening the telemetry event
name or the diagnostic level still counted as the expected failure. Each
violation now has its own directive and the fixture must compile cleanly.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A worker that stops the page from booting had no exit: every off switch was
page code. A REMOVE_REGISTRATION release now writes a service-worker.js that
skips waiting and unregisters itself (D-5), checked end to end in the browser.
The runbook and rollback doc now name only paths that exist in code.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A cancelled save dialog and a browser handoff were both recorded as
DOWNLOAD SUCCEEDED, so the cancel rate hid inside the handoff success rate.
BrowserDataObservation.outcome gains DISMISSED (additive).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Nothing read severity, telemetryEvent or redaction, yet FE-REG-ERROR guarded
them as policy. They are removed and the registry baseline is re-approved.
A new test fails if createFailure stops clearing retryable for MAYBE_APPLIED (M1).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A type added by a newer backend ended the connection as MALFORMED_EVENT and
left the stream CURRENT. It is now PROTOCOL_MISMATCH/REGISTRY, and any decode
failure after the stream lookup marks that stream UNKNOWN (design 13.1).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
inspect() read only the marker and set verified to true for every candidate,
even one whose entries the browser had evicted. It now runs the same entry
check as activation, so the cost grows with the entry count.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
No test used disabledCleanup: true, so a mutation that skipped the unregister
survived. The new cases pin resolveRuntimeCapabilities and the owned/foreign
unregister outcomes.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
FE-REG-API governs the V2 rows but the V3 descriptors execute, so a V3 path
or limit change passed every check. The test compares method, path, success
statuses, response limit, auth profile and replay policy per operationId.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Preview and download share one lease registry and download leases stay for a
30 s grace, so running out of slots clears on its own. Only a Blob above the
single-lease ceiling stays LIMIT_EXCEEDED without retry.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Tabs share one native subscription and one origin fence. enable, reconcile
and revoke now run under the `web-push-control` Web Lock (D-4), and a
compensation unsubscribes only a subscription its own call created.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A 429/503 Retry-After reached only onRetryHint, so passing the read result
to the reconnect coordinator retried before the server allowed.
readSseForReconnect returns the hint as serverNotBeforeMs.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
public/config.json is the copy dev serves and nothing compared it with
config/runtime/local.json. A unit test now requires it to equal what a local
build writes, and sample removal drops the feature override from it too.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The classifier called type, enum and nullable changes "none" and treated new
keys under strict readers as additive; FE-GATE-014 only checked hand-written
fixtures. It now fails closed and compares the committed baseline with the
schema the build emits. The doc lists per-boundary reader rules.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>