Commit Graph
4 Commits
Author SHA1 Message Date
DongHyeonka bca5fc2796 fix(ci): coverage 증거 검사가 summary의 branchesTrue를 받는다
문제
FE-GATE-005의 증거 검사(scripts/lib/ci-artifact-validator.ts)는
coverage-summary.json 항목마다 lines·statements·functions·branches만
허용하는 .strict() schema를 쓴다. istanbul-lib-coverage 3.2.2는 빈
summary에 branchesTrue를 항상 넣으므로 total에 그 키가 있다. 그래서
테스트가 모두 통과해도 증거 단계에서 게이트가 실패한다. 같은 파일을
읽는 risk-coverage 게이트는 이 키를 허용해 두 검사기가 갈라져 있었다.

고른 방법
- 키 목록을 scripts/lib/coverage-summary-metrics.ts 한 곳에 두고 두
  검사기가 같이 쓴다. 평가하는 네 지표와, 보고기가 더할 수 있는 선택
  지표(branchesTrue)를 나눴다. 선택 지표도 counter 형식(pct 정확성
  포함)은 그대로 검사한다.
- 버린 대안: validator schema에만 branchesTrue를 더하기. 지금 고장의
  원인(두 목록)이 그대로 남는다. 상수를 risk-coverage.ts에서
  export하기. validator가 @babel/eslint-parser까지 읽게 된다.

위험·한계
- 다른 미지의 키는 여전히 거절한다(의도). 보고기를 올리면 새 키가 생길
  수 있다.
- ci:gate FE-GATE-005 전체는 이 커밋에서 돌리지 않았다.

검증
- RED: 새 tests/unit/coverage-summary-artifact.test.ts 3건 중 2건 실패
  (Unrecognized key: "branchesTrue").
- 수정 뒤 coverage-summary-artifact·risk-coverage·risk-coverage-files
  44건 통과. check:types 통과, 바꾼 파일 eslint 통과.

Refs: docs/reviews/2026-11-03-maturity-review/README.md 12-09
2026-11-04 20:22:13 +09:00
DongHyeonkaandClaude Opus 5 dfb7734674 fix: run the provider sandbox and admit a release to a named environment
The provider sandbox never ran. bubblewrap 0.9.0 stops parsing an `--args`
file at the first non-option and never hands the remainder back, so the
command written into that file was silently dropped: bwrap printed its usage
text, exited 1, and the provider produced no evidence at all. The options
still travel in the args file — that is what keeps host paths and credentials
out of `/proc/<pid>/cmdline` — but the command now rides on real argv, and
`encodeProviderBwrapInput` refuses a `--` so the drop cannot come back.

The scope wrapper then could not exit. It read the supervisor's liveness pipe
through `fs`, which runs a blocking `read(2)` on a threadpool thread; the
supervisor holds that pipe open for the scope's whole life, so the read never
returned and closing the descriptor did not interrupt it. Once bubblewrap
finished the wrapper deadlocked in `process.exit`, the scope outlived the
provider, and a completed run was reported as a timeout kill. The channel is
now read through the event loop, so teardown is observable and terminal.

Creation modes were left to the ambient umask. `mkdir(mode)` and `open(mode)`
are requests the kernel subtracts the umask from, so a runner exporting a
restrictive umask produced directories it could not enter and handed `tar` a
file it could not re-open. Private modes are pinned instead of inherited.

Promotion cleanup deleted before it checked. Removals run through a pinned
descriptor, so a leaf substituted after validation had this promotion's exact
five destroyed first and the substitution reported afterwards, leaving a
half-emptied directory a retry could not tell from a completed one. The name
is re-bound to the inode before anything is removed, so the failure is total.

Separately, release coherence proved the artifacts agreed with each other but
never that they belonged where they were going: a build whose runtime document
said `APP_ENV: local`, `AUTH_MODE: demo` and a loopback API is coherent with
itself and passed every gate. `public/` is copied verbatim into `dist/`, so
that local document shipped with every build regardless of what the build was
for. Runtime configuration now comes from a declared profile, and FE-GATE-027
refuses to admit an artifact to an environment it does not match — including
refusing an undeclared destination, so nothing is admitted by omission.

`REQUEST_TIMEOUT_MS` and `VITE_ROUTER_BASE_PATH` were validated and then
dropped: the V3 executor ran every operation on its contract's own deadline,
and Vite emitted root-absolute assets for a sub-path deployment. The timeout is
now a ceiling that may tighten a contract but never loosen one, and one base
path feeds the router, the Service Worker scope and the asset base together.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
2026-08-15 16:38:19 +09:00
DongHyeonka 4dc033cf33 refactor: adapter 구현중.. 2026-08-13 16:02:21 +09:00
DongHyeonka 1bb2cc4a20 refactor: generate CI workflow from gate contracts 2026-08-02 13:53:25 +09:00