fix(test): 템플릿 시험이 사본에 만드는 기능 ID를 예약 접두어로 옮긴다 #26
Closed
donghyeon.kang
wants to merge 0 commits from
donghyeon.kang/fix/r9-reserved-probe-feature-ids AGit into main
pull from: donghyeon.kang/fix/r9-reserved-probe-feature-ids
merge into: :main
:main
:fix/r9-structure-locale
:fix/r9-adapter-carryover
:test/shared-build-lock-order
:ci/dependency-cache-same-filesystem
:ci/release-tag-for-a11y-review
:ci/merge-dependency-cache
:fix/test-timeouts-measured
:fix/feature-residue-word-boundary
:fix/provider-wait-stderr
:fix/provider-job-host-requirements
:fix/ungated-vitest-spec
:fix/a11y-evidence-routes
:fix/verify-parts-diagnostics
:claude/w2-fe-ci-perf-dce080
:fix/child-process-test-timeouts
:chore/layout-rules-r2-r5
:claude/fe-b-docs-korean-645f55
:chore/ci-merge-jobs
:chore/layout-3-merge
:claude/fe-c-harness-0ae061
:chore/layout-2-sample-removal
:chore/layout-1-cleanup
:docs/review-guide-pointer
:fix/maturity-review-2026-11-06
:fix/maturity-review-2026-11-05-b
:docs/improvement-manual
:fix/maturity-review-2026-11-05
:fix/session-subject-required
:fix/ui-design-audit-2026-11-01
:fix/maturity-review-2026-09-25
:lane/D
:lane/B
:fix/src-review-round3
:refactor/domain-scalable
:develop
:feature-frontend-optional-adapter-recipes
:feature-frontend-supply-chain-verification
:feature-frontend-test-registry-evidence-hardening
:frontend-test-registry-evidence-hardening
:feature-frontend-diagnostics-telemetry-runtime
:feature-frontend-i18n-message-formatting-contract
:feature-frontend-design-system-platform
:feature-frontend-form-page-platform
:feature-frontend-reference-feature-vertical-slice
:feature-frontend-routing-release-recovery-runtime
:feature-frontend-http-query-contract-execution
:feature-frontend-application-boundary-runtime
:feature-frontend-typescript-tooling-foundation
:feature-frontend-platform-capability-review
:feature-frontend-performance-route-contract
:feature-frontend-starter-experience-quality-contract
:feature-frontend-responsive-theme-contract
:feature-frontend-ui-primitives-gallery-contract
:feature-frontend-app-shell-navigation-contract
:feature-frontend-runtime-composition-contract
:feature-frontend-ci-quality-gates-contract
:feature-web-vitals-performance-budget-contract
:feature-frontend-release-cache-rollback-contract
:feature-accessibility-baseline-contract
:feature-frontend-project-bootstrap-toolchain-contract
:feature-frontend-operational-runbook-contract
:feature-frontend-contract-compatibility-governance
:feature-frontend-contract-registry-governance
:feature-frontend-browser-security-boundary-contract
:feature-frontend-build-bundle-supply-chain-contract
:feature-tailwind-design-token-styling-contract
:feature-sample-feature-slice-contract-fixture
:feature-frontend-render-recovery-boundary-contract
:feature-routing-navigation-guard-contract
:feature-boundary-mapper-viewmodel-contract
:feature-async-ui-state-contract
:feature-frontend-observability-logging-trace-contract
:feature-frontend-storage-registry-contract
:feature-server-state-caching-contract
:feature-frontend-auth-session-integration-contract
:feature-frontend-error-classification-boundary-contract
:feature-runtime-schema-validation-contract
:feature-api-client-response-envelope-contract
:feature-frontend-env-runtime-config-contract
:feature-frontend-architecture-enforcement-lint-contract
:feature-frontend-test-taxonomy-contract
:feature-frontend-clean-architecture-layering-contract
No Reviewers
Labels
No items
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
donghyeon.kang (동현 강)
Clear assignees
No Assignees
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: donghyeon.kang/clean-architecture-frontend-template#26
Reference in New Issue
Block a user
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
무엇을, 왜
round9 리뷰의 P1(1112/08-02)을 고친다. 템플릿 시험과 드릴이 저장소 사본에 고정 ID로 기능을 만든다: 매뉴얼 코드 조각 시험은
invoice-feature(FE-GATE-005), 생성 기능 e2e는order-feature(FE-GATE-008), scaffold 드릴은scaffold-feature(FE-GATE-020). 사본에는 제품 기능이 그대로 들어 있고create:feature는 같은 ID를 거부한다. 그래서 매뉴얼 1단계 예시대로invoice-feature를 만든 제품은 기능 코드와 상관없이 merge 게이트에서 막힌다.고른 방법과 버린 대안
typecheck-probe-로 옮기고scripts/lib/template-probe-features.ts한 곳에 둔다.invoice-feature기준 그대로 둔다. 시험이 조각과 검사 파일의 이름 넷(INVOICE_,Invoice,invoice-,invoice)을 예약 기능 이름으로 바꿔 넣는다(renameFeatureText, 이름 규칙은create-feature.ts의namesOf를 export해 같은 것을 쓴다).generatedMessageKey).create:feature가 흔한 이름을 거부하기(제품 이름을 막는다).위험과 영향
typecheck-probe-로 시작하는 기능을 만들면 다시 부딪친다. 매뉴얼 01·reference/create-feature.md에 쓰지 말라고 적었고 생성 명령이 막지는 않는다.scripts/test-sample-removal.ts는 w2-fe-2 세션 파일이다. 이 PR은 529행 기능 ID 한 줄과 import 한 줄만 바꾼다. 두 PR이 겹치면 이 두 줄만 다시 맞추면 된다.검증
desktop, CI env,
scripts/verify.sh(flock).5250ff95에 새 시험만):tests/unit/template-probe-features.test.tsrc=1. 로그/tmp/claude-gates/r9f1-red/.invoice-feature생성):manual-code-blocks.test.ts가feature id invoice-feature is already a feature or context로 실패(rc=1). 로그/tmp/claude-gates/r9fe-xgd02/.order-feature --with-create생성 뒤generated-feature.spec.ts): 17 passed. FE-GATE-008 경로는 재현되지 않았다. 이 spec의 ID 변경은 같은 원인을 막는 예방이다.create-feature·manual-code-blocks·template-feature-removal-documentsrc=0, 제품 상태(사본에invoice-feature·order-feature --with-create생성)에서 같은 unit 둘과generated-feature.spec.tsrc=0. 로그/tmp/claude-gates/r9f1-green/.3da7d772= head 트리): FE-GATE-002·003·005·008·020 모두 rc=0. 020의 scaffold 드릴이 예약 ID(typecheck-probe-scaffold-feature등)로 생성·제거를 끝까지 돌았다. 로그/tmp/claude-gates/r9f1-gates2/.scripts/verify.sh docs: OK.리뷰어가 볼 곳
scripts/lib/template-probe-features.ts의renameFeatureText와tests/unit/manual-code-blocks.test.ts의toProbe.scripts/lib/generated-feature.ts: 계약 이름을 ID에서 만든다.관련
docs/reviews/2026-11-round9-08-guardrails-docs.md08-02(PR #23)#40으로 병합됐다(main
ee47480c). 이 PR의 headed8c6204가 #40 브랜치에 merge 커밋으로 들어 있고, #40의 runner merge job 셋이 그 합친 트리로 초록이었다. runner 대기를 줄이려고 이번만 쓴 방식이다(소유자 승인, 2026-11-13).Pull request closed