fix(scripts): verify.sh parts가 음성 fixture의 진단 문구까지 본다 #33
Closed
donghyeon.kang
wants to merge 0 commits from
donghyeon.kang/fix/verify-parts-diagnostics AGit into main
pull from: donghyeon.kang/fix/verify-parts-diagnostics
merge into: :main
:main
:fix/r9-structure-locale
:fix/r9-adapter-carryover
:test/shared-build-lock-order
:ci/dependency-cache-same-filesystem
:ci/release-tag-for-a11y-review
:ci/merge-dependency-cache
:fix/test-timeouts-measured
:fix/feature-residue-word-boundary
:fix/provider-wait-stderr
:fix/provider-job-host-requirements
:fix/ungated-vitest-spec
:fix/a11y-evidence-routes
:fix/verify-parts-diagnostics
:claude/w2-fe-ci-perf-dce080
:fix/child-process-test-timeouts
:chore/layout-rules-r2-r5
:claude/fe-b-docs-korean-645f55
:chore/ci-merge-jobs
:chore/layout-3-merge
:claude/fe-c-harness-0ae061
:chore/layout-2-sample-removal
:chore/layout-1-cleanup
:docs/review-guide-pointer
:fix/maturity-review-2026-11-06
:fix/maturity-review-2026-11-05-b
:docs/improvement-manual
:fix/maturity-review-2026-11-05
:fix/session-subject-required
:fix/ui-design-audit-2026-11-01
:fix/maturity-review-2026-09-25
:lane/D
:lane/B
:fix/src-review-round3
:refactor/domain-scalable
:develop
:feature-frontend-optional-adapter-recipes
:feature-frontend-supply-chain-verification
:feature-frontend-test-registry-evidence-hardening
:frontend-test-registry-evidence-hardening
:feature-frontend-diagnostics-telemetry-runtime
:feature-frontend-i18n-message-formatting-contract
:feature-frontend-design-system-platform
:feature-frontend-form-page-platform
:feature-frontend-reference-feature-vertical-slice
:feature-frontend-routing-release-recovery-runtime
:feature-frontend-http-query-contract-execution
:feature-frontend-application-boundary-runtime
:feature-frontend-typescript-tooling-foundation
:feature-frontend-platform-capability-review
:feature-frontend-performance-route-contract
:feature-frontend-starter-experience-quality-contract
:feature-frontend-responsive-theme-contract
:feature-frontend-ui-primitives-gallery-contract
:feature-frontend-app-shell-navigation-contract
:feature-frontend-runtime-composition-contract
:feature-frontend-ci-quality-gates-contract
:feature-web-vitals-performance-budget-contract
:feature-frontend-release-cache-rollback-contract
:feature-accessibility-baseline-contract
:feature-frontend-project-bootstrap-toolchain-contract
:feature-frontend-operational-runbook-contract
:feature-frontend-contract-compatibility-governance
:feature-frontend-contract-registry-governance
:feature-frontend-browser-security-boundary-contract
:feature-frontend-build-bundle-supply-chain-contract
:feature-tailwind-design-token-styling-contract
:feature-sample-feature-slice-contract-fixture
:feature-frontend-render-recovery-boundary-contract
:feature-routing-navigation-guard-contract
:feature-boundary-mapper-viewmodel-contract
:feature-async-ui-state-contract
:feature-frontend-observability-logging-trace-contract
:feature-frontend-storage-registry-contract
:feature-server-state-caching-contract
:feature-frontend-auth-session-integration-contract
:feature-frontend-error-classification-boundary-contract
:feature-runtime-schema-validation-contract
:feature-api-client-response-envelope-contract
:feature-frontend-env-runtime-config-contract
:feature-frontend-architecture-enforcement-lint-contract
:feature-frontend-test-taxonomy-contract
:feature-frontend-clean-architecture-layering-contract
No Reviewers
Labels
No items
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
donghyeon.kang (동현 강)
Clear assignees
No Assignees
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: donghyeon.kang/clean-architecture-frontend-template#33
Reference in New Issue
Block a user
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
무엇을, 왜
scripts/verify.sh parts <ID>가 음성 fixture(expect: fail)를 종료 코드만으로 판정한다.ci:gate는 정해진 종료 코드와 정해진 진단 문구(expectedDiagnosticId)가 둘 다 있어야 통과시킨다. 그래서 검사기가 깨져 엉뚱한 원인으로 exit 1을 내도 parts는 통과로 센다(round9 발견 1112/08-01 GD-01의 남은 절반. args 절반은 #19가 고쳤다).고른 방법과 버린 대안
expectedDiagnosticId를 함께 읽고, 음성 fixture 명령의 출력을 따로 잡아 문구가 있는지 본다. 판정 규칙은scripts/lib/ci-step-result.ts의classifyGateStepResult와 같다.ci:gate를 명령마다 부르기.ci:gate는 게이트 단위라 명령 하나를 고를 수 없고, parts의 목적(첫 실패 뒤 명령도 끝까지)과 맞지 않는다.위험과 영향
ci:gate도 빈 문구는 늘 맞는다).scripts/verify.sh parts뿐이다.검증
scripts/tests/test_verify.py에 가짜corepack시험: 음성 fixture가 맞는 종료 코드에 엉뚱한 문구를 내면parts FE-GATE-029가 rc=1, 등록된 문구를 내면 rc=0. 고치기 전에는 엉뚱한 문구에도 rc=0으로 시험이 실패했다(RED). 고친 뒤python3 -m unittest scripts.tests.test_verify9개 통과.scripts/verify.sh parts FE-GATE-029rc=0(음성 fixture 9개가 등록된 문구를 냄). 로그/tmp/claude-gates/w2fe2-gd01/.scripts/verify.sh docsOK.리뷰어가 볼 곳
scripts/verify.sh의step(출력 잡기)과run_parts(판정).관련
docs/reviews/2026-11-round9-08-guardrails-docs.mdGD-01(PR #23), 이 repo 1112/08-01.#40으로 병합됐다(main
ee47480c). 이 PR의 head7fa825e5가 #40 브랜치에 merge 커밋으로 들어 있고, #40의 runner merge job 셋이 그 합친 트리로 초록이었다. runner 대기를 줄이려고 이번만 쓴 방식이다(소유자 승인, 2026-11-13).Pull request closed