From 91962e24e3aac577b4eb390ff8f9c4566d4de653 Mon Sep 17 00:00:00 2001 From: DongHyeonka Date: Thu, 12 Nov 2026 09:47:19 +0900 Subject: [PATCH 1/4] =?UTF-8?q?test(setup):=20=EC=9E=90=EC=8B=9D=20?= =?UTF-8?q?=ED=94=84=EB=A1=9C=EC=84=B8=EC=8A=A4=EB=A5=BC=20=EB=9D=84?= =?UTF-8?q?=EC=9A=B0=EB=8A=94=20=EC=8B=9C=ED=97=98=EC=9D=B4=20=EC=9E=B0=20?= =?UTF-8?q?=EC=8B=9C=EA=B0=84=EC=9C=BC=EB=A1=9C=20timeout=EC=9D=84=20?= =?UTF-8?q?=EC=A0=95=ED=95=9C=EB=8B=A4?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit 자식 프로세스를 띄우는 Vitest 시험 91개(24파일)가 기본 timeout 10초에 기대고 있었다. 셋은 FE-GATE-013에서만 도는 tests/system 시험이다. 기본값은 프로세스 안에서 도는 시험에 맞춘 값이다. 부하가 높은 desktop에서는 자식 프로세스 시험이 평소보다 크게 느려진다. FE-GATE-020 drill 사본에서 평소 0.4~1.2초인 문서 시험이 10.6초 걸려 실패했다(2026-11-12). 가장 위험한 것은 tests/architecture/app-build-input .test.ts로, desktop에서 이미 5.7초까지 걸렸다. 무엇을 고칠지는 desktop 계측으로 정했다. - test:coverage 묶음(maxWorkers=4)과 test:unit을 세 번씩 돌렸다. 시험마다 띄운 자식 프로세스는 child_process 함수를 감싸 기록했고, 소요 시간은 JSON reporter로 받았다. - 시험마다 실제 timeout은 task.timeout으로 기록했다. - 자식 프로세스를 띄우는 시험 140개 중 88개가 기본값이었다. tests/system은 그 묶음에 없어서, 아래 검사가 잡은 셋을 따로 세 번 쟀다. 고친 것: - tests/helpers/child-process-timeout.ts의 childProcessTimeout(<잰 최대 ms>)는 그 15배를 30초 단위로 올린 값이다. 15배는 위 0.7초 → 10.6초에서 왔다. 시험마다 자기가 잰 최대값을 인자로 적어 근거가 호출 자리에 남는다. - describe 안의 기본값 시험이 모두 자식 프로세스를 띄우면 describe에, 일부만 띄우면 그 시험에 준다. 프로세스 안에서 도는 시험의 hang을 늦게 잡지 않으려는 것이다. - tests/setup.ts가 child_process 함수를 감싼다. 기본 timeout인 시험이 자식 프로세스를 띄우면 그 호출에서 실패시키고, helper 이름을 알린다. helper나 시험이 import한 스크립트가 띄워도 잡는다. util.promisify가 읽는 속성은 원래 함수에서 옮긴다. - docs/work/reference/testing.md 2절에 값 정하는 법과 이 검사를 적었다. 버린 것: - 전역 testTimeout 올리기: 프로세스 안 시험의 hang을 늦게 잡는다. - 시험마다 손으로 정한 숫자: 근거가 남지 않고, 이미 있는 값도 60_000·120_000처럼 근거가 없었다. - 자식 프로세스를 띄우지 않게 바꾸기: 검사 스크립트를 CLI 그대로 시험하는 것이 이 시험들의 목적이라 범위가 커진다. - 파일에 timeout 선언이 있는지만 보는 정적 검사: helper가 띄우는 경우와 같은 파일의 다른 시험을 놓친다. 위험: - hook(beforeAll 등)에서 띄우는 프로세스는 검사하지 않는다. 계측에서 hook이 띄운 곳은 둘이고, 둘 다 180초를 선언했다. - 같은 파일 안에서 it.concurrent로 도는 시험이 섞이면 어느 시험의 timeout인지 틀릴 수 있다. 지금은 그런 시험이 없다. - 다운스트림 시험이 기본값으로 자식 프로세스를 띄우면 test:unit 등이 실패한다. 메시지가 helper를 알린다. 검증(desktop): - 다섯 검사(test:unit·check:types·check:ci·lint·verify:documentation) rc=0. - 자식 프로세스를 띄우는 시험 파일 40개와 tests/scale: rc=0, 검사 위반 0. - tests/system: 115개 중 18개 실패. 모두 bwrap 호스트 제약이고 검사 위반은 0이다. - 변이: 검사를 끄면 tests/unit/child-process-timeout.test.ts가 실패한다. tracked-artifacts describe의 timeout을 지우면 그 시험이 검사 메시지로 실패한다. - 재현: CPU 10% 제한에서 app-build-input·registry-governance·hosting-probe ·design-system-rules를 돌렸다. main 650d22fa는 11개가 10초 timeout으로 실패했다. 이 커밋은 71개 모두 통과했고, 가장 긴 시험은 17.7초였다. --- docs/work/reference/testing.md | 2 + tests/architecture/app-build-input.test.ts | 7 +-- tests/helpers/child-process-timeout.ts | 27 ++++++++++ .../provider-guardian-transaction.test.ts | 30 ++++++----- .../generate-product-feature-index.test.ts | 3 +- tests/setup.ts | 51 ++++++++++++++++++- .../ci-runner/ci-evidence-freshness.test.ts | 3 +- .../ci-runner/provider-process-group.test.ts | 3 +- tests/unit/backend-contract-drift.test.ts | 5 +- tests/unit/check-bundle-output.test.ts | 5 +- tests/unit/child-process-timeout.test.ts | 40 +++++++++++++++ tests/unit/ci-workflow-generation.test.ts | 5 +- tests/unit/deployment-admission.test.ts | 5 +- tests/unit/design-system-rules.test.ts | 3 +- tests/unit/example-feature-rules.test.ts | 5 +- .../unit/feature-override-diagnostics.test.ts | 3 +- tests/unit/feature-removal-argument.test.ts | 3 +- tests/unit/fixture-node-modules.test.ts | 3 +- tests/unit/hosting-probe.test.ts | 7 +-- tests/unit/http-scenario-evidence.test.ts | 3 +- .../unit/product-feature-index-write.test.ts | 3 +- tests/unit/registry-governance.test.ts | 17 ++++--- tests/unit/repository-layout.test.ts | 13 ++--- tests/unit/risk-coverage.test.ts | 3 +- tests/unit/security-promotion-staging.test.ts | 3 +- .../unit/service-worker-build-output.test.ts | 3 +- tests/unit/tracked-artifacts.test.ts | 3 +- .../v8-coverage-counter-semantics.test.ts | 3 +- 28 files changed, 202 insertions(+), 59 deletions(-) create mode 100644 tests/helpers/child-process-timeout.ts create mode 100644 tests/unit/child-process-timeout.test.ts diff --git a/docs/work/reference/testing.md b/docs/work/reference/testing.md index fc65e0fb..3dcff9a1 100644 --- a/docs/work/reference/testing.md +++ b/docs/work/reference/testing.md @@ -37,6 +37,8 @@ | 한 기능의 테스트 | `tests/features//` | 기능 폴더와 함께 지워진다 | - 스크립트 테스트가 자식 프로세스를 띄우면 그 suite가 자기 timeout을 선언한다. 전역 timeout을 올리지 않는다. + - 값은 desktop에서 잰 가장 긴 실행으로 정한다: `childProcessTimeout()`(`tests/helpers/child-process-timeout.ts`). 부하가 높은 desktop에서 자식 프로세스 테스트가 평소보다 몇 배 느려진 실측을 근거로 둔다. + - 기본 timeout인 테스트가 자식 프로세스를 띄우면 `tests/setup.ts`가 그 호출에서 실패시킨다. helper나 import한 스크립트가 띄워도 같다. hook(`beforeAll` 등)은 보지 않는다. - 플랫폼을 지키는 테스트는 기능·스타터 화면에 묶지 않는다. 테스트 전용 라우트와 플랫폼 소유 MSW 카탈로그(`tests/mocks/`)를 쓴다(결함 패턴 T7). 생성물 탐침 이름은 예약 접두어(`typecheck-probe-*`)를 쓴다. - 기능 테스트가 지워도 되는 문서를 읽으면 제거 드릴이 깨진다([structure.md](structure.md) 4절). - 테스트 작성의 편집 직후 규칙은 `.claude/rules/tests.md`다(Claude Code는 테스트 파일을 열 때 읽는다). diff --git a/tests/architecture/app-build-input.test.ts b/tests/architecture/app-build-input.test.ts index 6c28bbe5..f31752db 100644 --- a/tests/architecture/app-build-input.test.ts +++ b/tests/architecture/app-build-input.test.ts @@ -8,6 +8,7 @@ import { afterAll, describe, expect, it } from "vitest"; import { inspectAppBuildInput } from "../../scripts/check-app-build-input.ts"; import { renderContextIndex, renderFeatureIndex } from "../../scripts/generate-product-feature-index.ts"; import { APP_A, writeFilesystemTopology } from "../scale/filesystem-topology.ts"; +import { childProcessTimeout } from "../helpers/child-process-timeout.ts"; /** * Deployable-app isolation regression gate: the build input of one app must @@ -51,7 +52,7 @@ describe("app build input isolation gate", () => { expect(report.appId).toBe(APP_A.id); expect(report.generatedFeatureImports).toHaveLength(APP_A.contexts * APP_A.featuresPerContext); expect(report.bundle.checked).toBe(true); - }); + }, childProcessTimeout(5_739)); it("rejects a generator regression that imports every discovered feature", async () => { const root = await multiAppRepo(); @@ -70,7 +71,7 @@ describe("app build input isolation gate", () => { expect(report.violations.length).toBeGreaterThan(0); expect(report.violations.join("\n")).toMatch(/imports feature "other-0-ctx0-f0" not owned by app app-a/); expect(report.violations.join("\n")).toMatch(/declares context "other-0-ctx0" not owned/); - }); + }, childProcessTimeout(4_734)); it("rejects a production bundle that contains another app's feature", async () => { const root = await multiAppRepo(); @@ -82,7 +83,7 @@ describe("app build input isolation gate", () => { expect(report.violations).toEqual([ 'production bundle contains feature "other-0-ctx3-f7" not owned by app app-a', ]); - }); + }, childProcessTimeout(4_217)); it("holds for this repository's generated indexes", async () => { // The bundle side is gated after a fresh build (check:app-build-input:bundle). diff --git a/tests/helpers/child-process-timeout.ts b/tests/helpers/child-process-timeout.ts new file mode 100644 index 00000000..a1a73ff9 --- /dev/null +++ b/tests/helpers/child-process-timeout.ts @@ -0,0 +1,27 @@ +/** + * Timeouts for Vitest tests that start a child process + * (docs/work/reference/testing.md 2절: such a test declares its own timeout). + * tests/setup.ts fails a test on the default timeout that starts one. + */ + +/** `testTimeout` in vitest.config.ts, sized for tests that run in process. */ +export const DEFAULT_TEST_TIMEOUT_MS = 10_000; + +/** + * A child process slowed down far more than in-process code on a loaded + * desktop: a documentation test that runs its checker as a child took 0.4 to + * 1.2 s, and 10.6 s once inside an FE-GATE-020 drill (2026-11-12), so it + * failed on the 10 s default. + */ +const LOADED_HOST_SLOWDOWN = 15; +const STEP_MS = 30_000; + +/** + * The timeout for a test, or for a describe, whose longest measured run took + * `longestMeasuredMs`: fifteen times that, rounded up to a 30 s step. Measure + * on desktop with the JSON reporter, with test:coverage and test:unit, and pass + * the longest test of the describe. + */ +export function childProcessTimeout(longestMeasuredMs: number): number { + return Math.max(1, Math.ceil((longestMeasuredMs * LOADED_HOST_SLOWDOWN) / STEP_MS)) * STEP_MS; +} diff --git a/tests/integration/provider-guardian-transaction.test.ts b/tests/integration/provider-guardian-transaction.test.ts index 7cd3fc7b..aad089f5 100644 --- a/tests/integration/provider-guardian-transaction.test.ts +++ b/tests/integration/provider-guardian-transaction.test.ts @@ -17,6 +17,7 @@ import path from "node:path"; import { pathToFileURL } from "node:url"; import { afterEach, describe, expect, it } from "vitest"; +import { childProcessTimeout } from "../helpers/child-process-timeout.ts"; /** * This suite's budget, not the file's. The 10s default is sized for pure-JS @@ -242,7 +243,7 @@ describe("provider guardian transaction protocol", () => { await expect(lstat(rawPath)).rejects.toMatchObject({ code: "ENOENT" }); await expect(lstat(sealedTempPath)).rejects.toMatchObject({ code: "ENOENT" }); await expect(readdir(path.join(workspace, "provider-evidence/untrusted"))).resolves.toEqual([]); - }); + }, childProcessTimeout(253)); it("creates no evidence for empty or truncated guard input", async () => { const { startProviderGuardian } = await import( @@ -279,7 +280,7 @@ describe("provider guardian transaction protocol", () => { await expect(readdir(path.join(workspace, "provider-evidence"))) .resolves.toEqual(["untrusted"]); } - }); + }, childProcessTimeout(1_226)); it.each(["raw", "sealed"] as const)( "cleans the independently bound %s private alias when peer bootstrap validation fails", @@ -308,6 +309,7 @@ describe("provider guardian transaction protocol", () => { await expect(readdir(path.join(workspace, "provider-evidence"))) .resolves.toEqual(["untrusted"]); }, + childProcessTimeout(250), ); it("cleans guardian-created objects when the parent closes immediately after guard", async () => { @@ -321,7 +323,7 @@ describe("provider guardian transaction protocol", () => { .resolves.toEqual({ code: 125, signal: null }); await expect(readdir(path.join(workspace, "provider-evidence/untrusted"))).resolves.toEqual([]); await expect(readdir(path.join(workspace, "provider-evidence"))).resolves.toEqual(["untrusted"]); - }); + }, childProcessTimeout(314)); // G-1: a guardian that rejects its guard must exit then, not when the parent // finally closes stdin. The client waits for READY with stdin open, so a @@ -340,7 +342,7 @@ describe("provider guardian transaction protocol", () => { } await expect(readdir(path.join(workspace, "provider-evidence/untrusted"))).resolves.toEqual([]); await expect(readdir(path.join(workspace, "provider-evidence"))).resolves.toEqual(["untrusted"]); - }); + }, childProcessTimeout(430)); it("publishes the pinned sealed inode and preserves it only after commit EOF", async () => { const { @@ -410,7 +412,7 @@ describe("provider guardian transaction protocol", () => { }); await expect(lstat(rawPath)).rejects.toMatchObject({ code: "ENOENT" }); await expect(readFile(sealedPath)).resolves.toEqual(bytes); - }); + }, childProcessTimeout(448)); it("owns raw and sealed publication through the authenticated client lease", async () => { const client = await import("../../scripts/lib/provider-guardian-client.ts") as @@ -460,7 +462,7 @@ describe("provider guardian transaction protocol", () => { await lease.commit(); await expect(lstat(lease.rawPath)).rejects.toMatchObject({ code: "ENOENT" }); await expect(readFile(lease.sealedPath)).resolves.toEqual(bytes); - }); + }, childProcessTimeout(383)); it("cleans published evidence on EOF before commit and permits a same-workspace retry", async () => { const workspace = await createWorkspace("provider-guardian-published-eof-"); @@ -483,7 +485,7 @@ describe("provider guardian transaction protocol", () => { await retry.abort(); await expect(readdir(path.join(workspace, "provider-evidence/untrusted"))).resolves.toEqual([]); await expect(readdir(path.join(workspace, "provider-evidence"))).resolves.toEqual(["untrusted"]); - }); + }, childProcessTimeout(429)); it("fails closed when a separate trailing frame arrives after commit", async () => { const { encodeProviderGuardianCommit } = await import( @@ -501,7 +503,7 @@ describe("provider guardian transaction protocol", () => { await expect(within(transaction.completion, PROCESS_HANDSHAKE_WATCHDOG_MS, "guardian trailing frame")) .resolves.toEqual({ code: 126, signal: null }); await assertTransactionAbsent(transaction); - }); + }, childProcessTimeout(301)); it("uses pinned fallback identities after a guardian hard death", async () => { const { startProviderGuardian } = await import( @@ -522,7 +524,7 @@ describe("provider guardian transaction protocol", () => { await expect(lstat(lease.rawPath)).rejects.toMatchObject({ code: "ENOENT" }); await expect(lstat(lease.sealedTempPath)).rejects.toMatchObject({ code: "ENOENT" }); await expect(lstat(lease.sealedPath)).rejects.toMatchObject({ code: "ENOENT" }); - }); + }, childProcessTimeout(380)); it("cleans a linked raw inode when killed before READY and retries immediately", async () => { const { startProviderGuardian } = await import( @@ -568,7 +570,7 @@ describe("provider guardian transaction protocol", () => { await retry.abort(); await expect(readdir(rawDirectory)).resolves.toEqual([]); await expect(readdir(evidenceRoot)).resolves.toEqual(["untrusted"]); - }); + }, childProcessTimeout(524)); it("preserves an external raw canary created after startup checks", async () => { const { startProviderGuardian } = await import( @@ -618,7 +620,7 @@ describe("provider guardian transaction protocol", () => { .resolves.toEqual([]); await expect(readdir(path.join(workspace, "provider-evidence"))) .resolves.toEqual(["untrusted"]); - }); + }, childProcessTimeout(425)); it("allows exactly one same-kind guardian without deleting the winner", async () => { const { startProviderGuardian } = await import( @@ -655,7 +657,7 @@ describe("provider guardian transaction protocol", () => { .resolves.toEqual([]); await expect(readdir(path.join(workspace, "provider-evidence"))) .resolves.toEqual(["untrusted"]); - }); + }, childProcessTimeout(945)); it("exits nonzero after cleanup when the diagnostic stderr pipe is closed", async () => { const { decodeProviderGuardianReady } = await import( @@ -683,7 +685,7 @@ describe("provider guardian transaction protocol", () => { .rejects.toMatchObject({ code: "ENOENT" }); await expect(lstat(path.join(evidenceRoot, ready.sealedTempLeaf))) .rejects.toMatchObject({ code: "ENOENT" }); - }); + }, childProcessTimeout(469)); it("expires an uncommitted lease only after cleaning every owned object", async () => { const { decodeProviderGuardianReady } = await import( @@ -733,7 +735,7 @@ describe("provider guardian transaction protocol", () => { await lease.commit(); await expect(lstat(lease.rawPath)).rejects.toMatchObject({ code: "ENOENT" }); await expect(readFile(lease.sealedPath)).resolves.toEqual(bytes); - }); + }, childProcessTimeout(1_126)); it("signals guardian exit only while the provider scope latch is active", async () => { const lifecycle = await import("../../scripts/lib/provider-guardian-client.ts") as diff --git a/tests/scripts/generate-product-feature-index.test.ts b/tests/scripts/generate-product-feature-index.test.ts index 9bf4026f..92adbcf0 100644 --- a/tests/scripts/generate-product-feature-index.test.ts +++ b/tests/scripts/generate-product-feature-index.test.ts @@ -9,6 +9,7 @@ import { selectAppIndexes, type TopologyDeclarationSource, } from "../../scripts/generate-product-feature-index.ts"; +import { childProcessTimeout } from "../helpers/child-process-timeout.ts"; describe("feature index generator", () => { it("is deterministic by normalized id", () => { @@ -275,5 +276,5 @@ describe("build-time product selection (09-02)", () => { ); expect(run.status).not.toBe(0); expect(run.stderr).toMatch(/does not contain: reference-featrue/u); - }); + }, childProcessTimeout(157)); }); diff --git a/tests/setup.ts b/tests/setup.ts index 1272638d..cfacea77 100644 --- a/tests/setup.ts +++ b/tests/setup.ts @@ -1,6 +1,10 @@ import "@testing-library/jest-dom/vitest"; +import { createRequire, syncBuiltinESMExports } from "node:module"; + import { cleanup, configure } from "@testing-library/react"; -import { afterEach, vi } from "vitest"; +import { afterEach, beforeEach, vi } from "vitest"; + +import { DEFAULT_TEST_TIMEOUT_MS } from "./helpers/child-process-timeout.ts"; // findBy*/waitFor settle on the DOM change itself; their deadline only reports // a hang. Routes render through React.lazy, and React 19 holds every Suspense @@ -18,3 +22,48 @@ afterEach(() => { // timers to the next test in the file. vi.useRealTimers(); }); + +/** + * A test that starts a child process declares its own timeout + * (docs/work/reference/testing.md 2절). On a loaded desktop a 0.7 s + * documentation test took 10.6 s and failed FE-GATE-020 on the default, which + * is sized for tests that run in process. A test still on the default fails + * here, at the call, also when a helper or a script it imports starts the + * process. Hooks are not checked: they have no test of their own. + */ +type ChildProcessCall = (this: unknown, ...args: unknown[]) => unknown; +const guard = globalThis as typeof globalThis & { + __childProcessTimeoutGuard?: { timeout: number | undefined }; +}; +if (!guard.__childProcessTimeoutGuard) { + const state: { timeout: number | undefined } = { timeout: undefined }; + guard.__childProcessTimeoutGuard = state; + const childProcess = createRequire(import.meta.url)("node:child_process") as Record; + for (const name of ["spawn", "spawnSync", "exec", "execSync", "execFile", "execFileSync", "fork"]) { + const original = childProcess[name]!; + const checked: ChildProcessCall = function (this: unknown, ...args: unknown[]) { + if (state.timeout === DEFAULT_TEST_TIMEOUT_MS) { + throw new Error( + `${name}(${String(args[0])}) ran in a test on the default ${DEFAULT_TEST_TIMEOUT_MS} ms timeout. ` + + "Give the test, or its describe, childProcessTimeout() from tests/helpers/child-process-timeout.ts.", + ); + } + return original.apply(this, args); + }; + // util.promisify(execFile) and the like read properties of the function. + for (const key of Reflect.ownKeys(original)) { + if (key !== "length" && key !== "name" && key !== "prototype") { + Object.defineProperty(checked, key, Reflect.getOwnPropertyDescriptor(original, key)!); + } + } + childProcess[name] = checked; + } + syncBuiltinESMExports(); +} +const childProcessGuard = guard.__childProcessTimeoutGuard; +beforeEach((context) => { + childProcessGuard.timeout = context.task.timeout; +}); +afterEach(() => { + childProcessGuard.timeout = undefined; +}); diff --git a/tests/system/ci-runner/ci-evidence-freshness.test.ts b/tests/system/ci-runner/ci-evidence-freshness.test.ts index c434ce81..aea8290b 100644 --- a/tests/system/ci-runner/ci-evidence-freshness.test.ts +++ b/tests/system/ci-runner/ci-evidence-freshness.test.ts @@ -8,6 +8,7 @@ import { afterEach, describe, expect, it } from "vitest"; import { loadCiGateContract } from "../../../scripts/contracts/ci-gates.ts"; import { DEPENDENCY_ADVISORIES_RECORD_PATH } from "../../../scripts/lib/dependency-advisories.ts"; import { FIXTURE_PNPM_ENVIRONMENT } from "../../../scripts/lib/fixture-node-modules.ts"; +import { childProcessTimeout } from "../../helpers/child-process-timeout.ts"; // F-12. The temp roots have a package.json but no node_modules or lockfile. // Run directly (not under pnpm), pnpm's pre-script install check started an @@ -24,7 +25,7 @@ afterEach(async () => { ); }); -describe("CI-runner command-generated evidence freshness", () => { +describe("CI-runner command-generated evidence freshness", { timeout: childProcessTimeout(871) }, () => { it("rejects stale command-generated evidence from a successful no-op producer", async () => { const root = await mkdtemp(path.join(tmpdir(), "ci-gate-stale-evidence-")); temporaryRoots.push(root); diff --git a/tests/system/ci-runner/provider-process-group.test.ts b/tests/system/ci-runner/provider-process-group.test.ts index a6db0ac0..f1bc7304 100644 --- a/tests/system/ci-runner/provider-process-group.test.ts +++ b/tests/system/ci-runner/provider-process-group.test.ts @@ -5,8 +5,9 @@ import path from "node:path"; import { describe, expect, it } from "vitest"; import { runProviderProcess } from "../../../scripts/lib/provider-process-runner.ts"; +import { childProcessTimeout } from "../../helpers/child-process-timeout.ts"; -describe("CI-runner provider process-group lifecycle", () => { +describe("CI-runner provider process-group lifecycle", { timeout: childProcessTimeout(263) }, () => { it("kills and reaps a stubborn provider process group including its descendant", async () => { const root = await mkdtemp(path.join(tmpdir(), "provider-process-group-")); const descendantPidPath = path.join(root, "descendant.pid"); diff --git a/tests/unit/backend-contract-drift.test.ts b/tests/unit/backend-contract-drift.test.ts index 343276e1..2917d909 100644 --- a/tests/unit/backend-contract-drift.test.ts +++ b/tests/unit/backend-contract-drift.test.ts @@ -4,6 +4,7 @@ import { tmpdir } from "node:os"; import path from "node:path"; import { afterEach, describe, expect, it } from "vitest"; +import { childProcessTimeout } from "../helpers/child-process-timeout.ts"; /** * 1105/07-01. `check:backend-contract-drift` on a fake paired backend: a git @@ -224,7 +225,7 @@ async function drift( }; } -describe("check:backend-contract-drift (1105/07-01)", () => { +describe("check:backend-contract-drift (1105/07-01)", { timeout: childProcessTimeout(450) }, () => { it("passes when the excerpt and the answer table match the pinned document", async () => { const result = await drift(); @@ -311,7 +312,7 @@ describe("check:backend-contract-drift (1105/07-01)", () => { * `docs/web/http-contract.md`, so a backend that changed its scaffold left * the frontend generator writing another path, limit or code with no signal. */ -describe("check:backend-contract-drift scaffold sources (1105/16-02)", () => { +describe("check:backend-contract-drift scaffold sources (1105/16-02)", { timeout: childProcessTimeout(502) }, () => { it("reports a scaffold source the generator copies from, with where the copy is", async () => { const result = await drift({ scaffoldHead: "public static final int NAME_MAX_LENGTH = 120;\n" }); diff --git a/tests/unit/check-bundle-output.test.ts b/tests/unit/check-bundle-output.test.ts index 6eec892d..fd6e094e 100644 --- a/tests/unit/check-bundle-output.test.ts +++ b/tests/unit/check-bundle-output.test.ts @@ -4,6 +4,7 @@ import { tmpdir } from "node:os"; import path from "node:path"; import { afterEach, describe, expect, it } from "vitest"; +import { childProcessTimeout } from "../helpers/child-process-timeout.ts"; /** * 1103/15-03. An over-budget build printed only @@ -77,7 +78,7 @@ const OUTPUTS = [ ]; const BUDGETS = { initialJsGzipBytes: 1_000, initialJsFiles: 2, lazyChunkGzipBytes: 400 }; -describe("check:bundle failure output (1103/15-03)", () => { +describe("check:bundle failure output (1103/15-03)", { timeout: childProcessTimeout(730) }, () => { it("passes and prints the total within budget", async () => { const result = await checkBundle({ outputs: OUTPUTS, manifest: MANIFEST, budgets: BUDGETS }); expect(result.stderr).toBe(""); @@ -142,7 +143,7 @@ describe("check:bundle failure output (1103/15-03)", () => { * build over budget under .tmp/ passed on the checkout's earlier build * (review run 12-R2). Both stop and name the variable instead. */ -describe("check:bundle with RUN_OUTPUT_ROOT (1106/12-02)", () => { +describe("check:bundle with RUN_OUTPUT_ROOT (1106/12-02)", { timeout: childProcessTimeout(1_041) }, () => { it("does not pass the checkout's earlier build while the build writes elsewhere", async () => { const result = await checkBundle({ outputs: OUTPUTS, diff --git a/tests/unit/child-process-timeout.test.ts b/tests/unit/child-process-timeout.test.ts new file mode 100644 index 00000000..f4b8ec71 --- /dev/null +++ b/tests/unit/child-process-timeout.test.ts @@ -0,0 +1,40 @@ +import { execFile, spawnSync } from "node:child_process"; +import { promisify } from "node:util"; + +import { describe, expect, it } from "vitest"; + +import config from "../../vitest.config.ts"; +import { childProcessTimeout, DEFAULT_TEST_TIMEOUT_MS } from "../helpers/child-process-timeout.ts"; + +const NODE_ARGS = ["-e", "process.stdout.write('ran')"]; + +// tests/setup.ts fails a test on the default timeout that starts a child process. +describe("a child process in a test on the default timeout", () => { + it("fails at the call, naming the call and the helper", () => { + expect(() => spawnSync(process.execPath, NODE_ARGS)).toThrow( + /spawnSync\(.+\) ran in a test on the default 10000 ms timeout\. .*childProcessTimeout/u, + ); + expect(() => execFile(process.execPath, NODE_ARGS)).toThrow(/execFile\(.+\) ran in a test on the default/u); + }); + + it("is the default vitest.config.ts sets", () => { + expect(config.test?.testTimeout).toBe(DEFAULT_TEST_TIMEOUT_MS); + }); +}); + +describe("a child process in a test with its own timeout", { timeout: childProcessTimeout(100) }, () => { + it("runs", async () => { + expect(spawnSync(process.execPath, NODE_ARGS, { encoding: "utf8" }).stdout).toBe("ran"); + // The guard keeps what util.promisify reads from the original function. + await expect(promisify(execFile)(process.execPath, NODE_ARGS)).resolves.toEqual({ stdout: "ran", stderr: "" }); + }); +}); + +describe("childProcessTimeout", () => { + it("is fifteen times the longest measured run, rounded up to 30 s steps", () => { + expect(childProcessTimeout(0)).toBe(30_000); + expect(childProcessTimeout(1_999)).toBe(30_000); + expect(childProcessTimeout(2_001)).toBe(60_000); + expect(childProcessTimeout(5_739)).toBe(90_000); + }); +}); diff --git a/tests/unit/ci-workflow-generation.test.ts b/tests/unit/ci-workflow-generation.test.ts index 02f08d4c..4448e86d 100644 --- a/tests/unit/ci-workflow-generation.test.ts +++ b/tests/unit/ci-workflow-generation.test.ts @@ -29,6 +29,7 @@ import { validatePackageScriptGraph, } from "../../scripts/lib/package-script-graph.ts"; import { VISUAL_TEST_FONT_PACKAGES } from "../../scripts/lib/visual-test-fonts.ts"; +import { childProcessTimeout } from "../helpers/child-process-timeout.ts"; const temporaryRoots: string[] = []; const npmPostScriptForeignScopeCommands = [ @@ -1537,7 +1538,7 @@ describe("CI gate contract", () => { const result = spawnSync(process.execPath, [path.resolve("scripts/run-ci-gate.ts"), "FE-GATE-010"], { cwd: root, encoding: "utf8" }); expect(result.status).not.toBe(0); await expect(readFile(marker)).rejects.toMatchObject({ code: "ENOENT" }); - }); + }, childProcessTimeout(1_298)); it("records checked-in workflow drift as a failing typed report", async () => { const root = await mkdtemp(path.join(tmpdir(), "ci-contract-workflow-drift-")); @@ -1564,7 +1565,7 @@ describe("CI gate contract", () => { expect(report.workflowSha256).toBe( await import("node:crypto").then(({ createHash }) => createHash("sha256").update(drift).digest("hex")), ); - }); + }, childProcessTimeout(1_376)); }); diff --git a/tests/unit/deployment-admission.test.ts b/tests/unit/deployment-admission.test.ts index 0617f17c..3fe1a5f3 100644 --- a/tests/unit/deployment-admission.test.ts +++ b/tests/unit/deployment-admission.test.ts @@ -16,6 +16,7 @@ import { ENV_REGISTRY, getBuildConfig } from "../../src/contracts/env.ts"; import { EXPECTED_CONTRACT_SET_PACKAGES } from "../../src/features/installed-contract-contributions.ts"; import { runtimeConfigV2ArtifactSchema } from "../../src/contracts/release-artifacts.ts"; import { generateRuntimeConfig } from "../../scripts/generate-runtime-config.ts"; +import { childProcessTimeout } from "../helpers/child-process-timeout.ts"; const PRODUCTION_ARTIFACT: AdmissionInput = Object.freeze({ APP_ENV: "production", @@ -357,13 +358,13 @@ describe("runtime config profiles", () => { } finally { await rm(root, { recursive: true, force: true }); } - }); + }, childProcessTimeout(513)); }); // 1101/13-05. The emergency switches (CAPABILITY_OVERRIDES, FEATURE_OVERRIDES) // are changed in the deployed config.json without a rebuild. A typo there stops // every boot, so the edited copy is checked against the deployed one first. -describe("checking an edited copy of the deployed runtime config", () => { +describe("checking an edited copy of the deployed runtime config", { timeout: childProcessTimeout(795) }, () => { async function check( edit: (deployed: Record) => Record, args: readonly string[] = ["--config", "edited.json", "--original", "deployed.json"], diff --git a/tests/unit/design-system-rules.test.ts b/tests/unit/design-system-rules.test.ts index d300a2d7..cbc9eded 100644 --- a/tests/unit/design-system-rules.test.ts +++ b/tests/unit/design-system-rules.test.ts @@ -12,10 +12,11 @@ import { hueMixFailures, unreadTokenFailures, } from "../../scripts/lib/design-system-rules.ts"; +import { childProcessTimeout } from "../helpers/child-process-timeout.ts"; const css = (source: string) => ({ file: "probe.css", source }); -describe("design system rules", () => { +describe("design system rules", { timeout: childProcessTimeout(3_540) }, () => { describe("UI-01 focus ring contrast", () => { const tokens = (focus: string) => new Map([ diff --git a/tests/unit/example-feature-rules.test.ts b/tests/unit/example-feature-rules.test.ts index 6fac3dbe..277fd42a 100644 --- a/tests/unit/example-feature-rules.test.ts +++ b/tests/unit/example-feature-rules.test.ts @@ -13,6 +13,7 @@ import { } from "../../scripts/lib/removable-template-features.ts"; import { PLATFORM_ROUTE_REGISTRY } from "../../src/contracts/routes.ts"; import { ROUTE_FEATURE_OWNER, ROUTE_REGISTRY } from "../../src/features/installed-feature-contracts.ts"; +import { childProcessTimeout } from "../helpers/child-process-timeout.ts"; /** * R4 and R5 of docs/manual/03-outside-feature-folder.md. A sample feature @@ -257,7 +258,7 @@ describe("gate targets (R5)", () => { expect(targets.artifacts.some((artifact) => artifact.startsWith("docs/accessibility/route-reviews/"))).toBe(true); expect(targets.gateScripts.length).toBeGreaterThan(20); expect(sampleGateTargets(samplesOf(REMOVABLE_TEMPLATE_FEATURES), repositoryRoutes(), targets)).toEqual([]); - }); + }, childProcessTimeout(176)); it("finds this repository's targets once a sample owns what they point at", async () => { // As if the platform overview screen, the design system and the message catalog were a sample's. @@ -278,7 +279,7 @@ describe("gate targets (R5)", () => { "FE-GATE-008 runs test:visual, a script of sample overview-sample", ]), ); - }); + }, childProcessTimeout(85)); it("follows routes, imports, route reviews, scripts and the scale record of a synthetic sample", () => { const sample: Sample = { diff --git a/tests/unit/feature-override-diagnostics.test.ts b/tests/unit/feature-override-diagnostics.test.ts index 538639b3..3992d36b 100644 --- a/tests/unit/feature-override-diagnostics.test.ts +++ b/tests/unit/feature-override-diagnostics.test.ts @@ -9,6 +9,7 @@ import { createRuntimeAdapters } from "../../src/bootstrap/runtime-adapters.ts"; import { COMPILED_PRODUCT_FEATURE_IDS } from "../../src/features/installed-product-manifest.ts"; import { generateRuntimeConfig } from "../../scripts/generate-runtime-config.ts"; import { testRuntimeConfig } from "../helpers/runtime-config.ts"; +import { childProcessTimeout } from "../helpers/child-process-timeout.ts"; type Runtime = Parameters[0]["runtime"]; @@ -120,5 +121,5 @@ describe("unknown feature override keys (09-09)", () => { } finally { await rm(root, { recursive: true, force: true }); } - }); + }, childProcessTimeout(464)); }); diff --git a/tests/unit/feature-removal-argument.test.ts b/tests/unit/feature-removal-argument.test.ts index 54db1c99..c6438e38 100644 --- a/tests/unit/feature-removal-argument.test.ts +++ b/tests/unit/feature-removal-argument.test.ts @@ -6,11 +6,12 @@ import path from "node:path"; import { describe, expect, it } from "vitest"; import { REMOVABLE_TEMPLATE_FEATURES } from "../../scripts/lib/removable-template-features.ts"; +import { childProcessTimeout } from "../helpers/child-process-timeout.ts"; // 09-07 (D-10). The removal gate takes the feature to remove as an argument // instead of hard-coding the sample; an id no feature declares stops it before // any fixture is built. -describe("feature removal argument", () => { +describe("feature removal argument", { timeout: childProcessTimeout(1_348) }, () => { it("refuses a feature id that no installed feature declares", () => { const run = spawnSync( process.execPath, diff --git a/tests/unit/fixture-node-modules.test.ts b/tests/unit/fixture-node-modules.test.ts index 3e0a0d71..98b42814 100644 --- a/tests/unit/fixture-node-modules.test.ts +++ b/tests/unit/fixture-node-modules.test.ts @@ -20,6 +20,7 @@ import { linkFixtureNodeModules, } from "../../scripts/lib/fixture-node-modules.ts"; import { selectRepositoryPaths } from "../../scripts/lib/repository-layout.ts"; +import { childProcessTimeout } from "../helpers/child-process-timeout.ts"; /** * A removal or provider fixture runs `pnpm` inside a throwaway copy of the @@ -171,7 +172,7 @@ describe("fixture node_modules linking", () => { * from pnpm and was safe; the same fixture started directly * (`node scripts/run-vitest.ts run `) was not. */ -describe("pnpm inside a linked fixture (F-4)", () => { +describe("pnpm inside a linked fixture (F-4)", { timeout: childProcessTimeout(94) }, () => { const scratch: string[] = []; afterEach(async () => { await Promise.all( diff --git a/tests/unit/hosting-probe.test.ts b/tests/unit/hosting-probe.test.ts index 1e221633..bf2484db 100644 --- a/tests/unit/hosting-probe.test.ts +++ b/tests/unit/hosting-probe.test.ts @@ -16,6 +16,7 @@ import { servedEntryScript, } from "../../scripts/lib/hosting-probe.ts"; import { SERVICE_WORKER_SCRIPT_PATH } from "../../src/contracts/service-worker.ts"; +import { childProcessTimeout } from "../helpers/child-process-timeout.ts"; describe("public service worker in dist", () => { const app = ["index.html", "config.json", "assets/index-abc.js"]; @@ -563,7 +564,7 @@ describe("verify-hosting-headers on a promoted release root (1101/13-01)", () => const result = await verify({ ...DIST, "assets/index-A1.js.map": "{}" }); expect(result.failed, result.stderr).toEqual(["sourceMap public"]); expect(result.status).toBe(1); - }); + }, childProcessTimeout(1_931)); it("ends UNVERIFIED without probing the host when the deployment slot is empty", async () => { const result = await verify(DIST, { @@ -574,7 +575,7 @@ describe("verify-hosting-headers on a promoted release root (1101/13-01)", () => expect(result.mode).toBe("fixture"); expect(result.status).toBe(3); expect(result.stderr).toContain("deployment slot"); - }); + }, childProcessTimeout(984)); // 1103/13-02. The bundle budget counts gzip bytes; an uncompressed entry // script means about three times as many bytes on the wire. @@ -595,5 +596,5 @@ describe("verify-hosting-headers on a promoted release root (1101/13-01)", () => }); expect(result.failed, result.stderr).toEqual(["hashedAsset content-encoding"]); expect(result.status).toBe(1); - }); + }, childProcessTimeout(763)); }); diff --git a/tests/unit/http-scenario-evidence.test.ts b/tests/unit/http-scenario-evidence.test.ts index 36f96ec6..0c7ad029 100644 --- a/tests/unit/http-scenario-evidence.test.ts +++ b/tests/unit/http-scenario-evidence.test.ts @@ -22,6 +22,7 @@ import { type HttpScenarioAssertionGroups, type HttpScenarioExpectation, } from "../../scripts/lib/http-scenario-evidence.ts"; +import { childProcessTimeout } from "../helpers/child-process-timeout.ts"; type MutableReceipt = { schemaVersion: number; @@ -356,5 +357,5 @@ describe("HTTP scenario evidence receipt schema", () => { expect(result.error).toBeUndefined(); expect(result.status).toBe(1); expect(`${result.stdout}\n${result.stderr}`).toContain(fixture.diagnostic); - }); + }, childProcessTimeout(962)); }); diff --git a/tests/unit/product-feature-index-write.test.ts b/tests/unit/product-feature-index-write.test.ts index 5439e35c..43fc604f 100644 --- a/tests/unit/product-feature-index-write.test.ts +++ b/tests/unit/product-feature-index-write.test.ts @@ -4,6 +4,7 @@ import { tmpdir } from "node:os"; import path from "node:path"; import { afterEach, describe, expect, it } from "vitest"; +import { childProcessTimeout } from "../helpers/child-process-timeout.ts"; /** * 1105/12-04. Every build, dev server, type check and test run renders @@ -53,7 +54,7 @@ async function identity(file: string): Promise { return `${metadata.ino}:${metadata.mtimeNs}`; } -describe("product feature index writes (1105/12-04)", () => { +describe("product feature index writes (1105/12-04)", { timeout: childProcessTimeout(566) }, () => { it("leaves an index that has not changed untouched", async () => { const root = await declarationCopy(); const files = OUTPUTS.map((name) => path.join(root, "src/.generated", name)); diff --git a/tests/unit/registry-governance.test.ts b/tests/unit/registry-governance.test.ts index e9541785..03313e4d 100644 --- a/tests/unit/registry-governance.test.ts +++ b/tests/unit/registry-governance.test.ts @@ -11,6 +11,7 @@ import { validateBreakingEvidence, verifyRegistryBaselineApproval, } from "../../scripts/lib/registry-compatibility.ts"; +import { childProcessTimeout } from "../helpers/child-process-timeout.ts"; type RegistryDefinition = Readonly<{ registryId: string; @@ -172,7 +173,7 @@ describe("registry governance manifest", () => { } finally { await rm(directory, { recursive: true, force: true }); } - }); + }, childProcessTimeout(907)); it("requires explicit evidence for post-baseline graph and version drift", async () => { const directory = await mkdtemp( @@ -302,7 +303,7 @@ describe("registry governance manifest", () => { } finally { await rm(directory, { recursive: true, force: true }); } - }); + }, childProcessTimeout(1_150)); it("pins the full invalidation graph and versions in the approved repository baseline", async () => { const baseline = JSON.parse( @@ -421,7 +422,7 @@ describe("registry governance manifest", () => { } finally { await rm(directory, { recursive: true, force: true }); } - }); + }, childProcessTimeout(288)); it("rejects duplicate composite invalidation edges after projection", async () => { const directory = await mkdtemp( @@ -454,7 +455,7 @@ describe("registry governance manifest", () => { } finally { await rm(directory, { recursive: true, force: true }); } - }); + }, childProcessTimeout(1_113)); // 0929/07-03. loadingSurface is a name, checked for its form, not a list. it("rejects a route loading surface that is not a kebab-case name", async () => { @@ -485,7 +486,7 @@ describe("registry governance manifest", () => { } finally { await rm(directory, { recursive: true, force: true }); } - }); + }, childProcessTimeout(1_424)); it("names the load error of a registry source that exists but fails to import", async () => { const directory = await mkdtemp(path.join(tmpdir(), "registry-source-error-")); @@ -537,7 +538,7 @@ describe("registry governance manifest", () => { } finally { await rm(directory, { recursive: true, force: true }); } - }); + }, childProcessTimeout(871)); // 1103/14-06. A contract contribution that fails to compose throws while // the registry source loads. The gate names the cause the error carries in @@ -648,7 +649,7 @@ describe("registry governance manifest", () => { } finally { await rm(directory, { recursive: true, force: true }); } - }); + }, childProcessTimeout(2_222)); // 1105/09-03. The real composition error already ends its message with the // reason (1103/09-07). The gate prints that cause once, not again in @@ -709,5 +710,5 @@ describe("registry governance manifest", () => { } finally { await rm(directory, { recursive: true, force: true }); } - }); + }, childProcessTimeout(1_065)); }); diff --git a/tests/unit/repository-layout.test.ts b/tests/unit/repository-layout.test.ts index b5e597f9..bb84b773 100644 --- a/tests/unit/repository-layout.test.ts +++ b/tests/unit/repository-layout.test.ts @@ -13,6 +13,7 @@ import { selectRepositoryPaths, } from "../../scripts/lib/repository-layout.ts"; import { REMOVAL_FIXTURE_DOCUMENT_TESTS } from "../../scripts/lib/removal-fixture.ts"; +import { childProcessTimeout } from "../helpers/child-process-timeout.ts"; /** * The repository layout rules of docs/manual/03-outside-feature-folder.md @@ -46,14 +47,14 @@ describe("repository layout registry (R1)", () => { [...roots].filter((root) => !rootItemNames.has(root)).sort(), `add an entry with its role to ${REPOSITORY_LAYOUT_FILE}`, ).toEqual([]); - }); + }, childProcessTimeout(31)); it("lists untracked items that have no tracked file", () => { const tracked = new Set(trackedFiles().map((file) => file.split("/")[0]!)); const untracked = REPOSITORY_LAYOUT.filter(({ kind }) => kind === "untracked"); expect(untracked.length).toBeGreaterThan(0); expect(untracked.filter(({ path: item }) => tracked.has(item)).map(({ path: item }) => item)).toEqual([]); - }); + }, childProcessTimeout(20)); it("rejects an entry that is not a root item, a duplicate and a path outside its item", () => { const entry = { path: "src", kind: "source", role: "app", readBy: "build" }; @@ -164,7 +165,7 @@ describe("root path lists (R2)", () => { ), "MADE_UP_REPOSITORY_LISTS entries that match no list any more", ).toEqual([]); - }); + }, childProcessTimeout(177)); it("finds a literal root list, also after -- in an argument vector, and nothing else", () => { const tracked = new Set(["alpha", "beta"]); @@ -203,7 +204,7 @@ describe("root path lists (R2)", () => { unreadBy(readers.filter(({ file }) => !documentTests.has(file))), "sets only REMOVAL_FIXTURE_DOCUMENT_TESTS select (DOCUMENT_TEST_SETS)", ).toEqual(DOCUMENT_TEST_SETS); - }); + }, childProcessTimeout(310)); // A removal fixture deletes some of these inputs on purpose — removing the // browser file/storage capability takes the whole browser-capability harness @@ -231,7 +232,7 @@ describe("infrastructure configuration (R7)", () => { .filter((file) => /\.ya?ml$/u.test(file) && existsSync(file)) .filter((file) => KUBERNETES_MANIFEST.test(readFileSync(file, "utf8"))); expect([...files.filter((file) => INFRASTRUCTURE_FILE.test(file)), ...manifests]).toEqual([]); - }); + }, childProcessTimeout(11)); it("recognises the file kinds the rule names", () => { expect(["deploy/nginx.conf", "infra/main.tf", "chart/Chart.yaml", "kustomization.yml"].filter((file) => @@ -273,7 +274,7 @@ function sameOptionTsconfigs(files: readonly string[]): string[] { ); } -describe("tsconfig files (R9)", () => { +describe("tsconfig files (R9)", { timeout: childProcessTimeout(29) }, () => { // tests/fixtures/typecheck had 23 one-file tsconfigs with one set of // options until 2026-11-08; scripts/check-type-fixtures.ts runs them now. it("differ in lib, types or module resolution, not only in their files", () => { diff --git a/tests/unit/risk-coverage.test.ts b/tests/unit/risk-coverage.test.ts index 0c89a678..46a377a6 100644 --- a/tests/unit/risk-coverage.test.ts +++ b/tests/unit/risk-coverage.test.ts @@ -23,6 +23,7 @@ import { parseRiskCoveragePolicy, type ProductionModuleInventory, } from "../../scripts/lib/risk-coverage.ts"; +import { childProcessTimeout } from "../helpers/child-process-timeout.ts"; /** * This suite's budget, not the file's. The 10s default is sized for pure-JS @@ -263,7 +264,7 @@ describe("repository-aware risk coverage", () => { expect(artifact).not.toHaveProperty("instrumentedExecutableTotal"); expect(artifact).not.toHaveProperty("nonExecutableTotal"); expect(artifact).not.toHaveProperty("nonExecutableModules"); - }); + }, childProcessTimeout(2_637)); it("rejects arbitrary coverage paths instead of silently allowing inflation", () => { const parsedPolicy = parseRiskCoveragePolicy( diff --git a/tests/unit/security-promotion-staging.test.ts b/tests/unit/security-promotion-staging.test.ts index 9668adc7..e71a0d83 100644 --- a/tests/unit/security-promotion-staging.test.ts +++ b/tests/unit/security-promotion-staging.test.ts @@ -24,6 +24,7 @@ import { privatePromotionFiles, syntheticSignedPromotionBundle, } from "./security-followup-fixture.ts"; +import { childProcessTimeout } from "../helpers/child-process-timeout.ts"; describe("security private promotion staging contracts", () => { it("forces exact private staging modes in an isolated child with umask 077", async () => { @@ -69,7 +70,7 @@ describe("security private promotion staging contracts", () => { } finally { await rm(root, { recursive: true, force: true }); } - }); + }, childProcessTimeout(2_361)); it("rejects a staged file unlinked and recreated after its original write", async () => { const root = await mkdtemp(path.join(tmpdir(), "promotion-seal-recreate-")); diff --git a/tests/unit/service-worker-build-output.test.ts b/tests/unit/service-worker-build-output.test.ts index 813e3936..fb41e643 100644 --- a/tests/unit/service-worker-build-output.test.ts +++ b/tests/unit/service-worker-build-output.test.ts @@ -23,6 +23,7 @@ import { ACTIVE_VALUE, turnOnServiceWorker, } from "../e2e/support/service-worker-builds.ts"; +import { childProcessTimeout } from "../helpers/child-process-timeout.ts"; /** * 0929/06-01. Step 6 of `scripts/build-frontend.ts`, the Service Worker Vite @@ -107,7 +108,7 @@ describe("Service Worker build output (0929/06-01, 0929/06-02)", () => { // recover a client without a page. Served from an edge that caches root `.js` // for long, they stay out of reach for that TTL, so a build that ships a // worker has its script's Cache-Control checked like the page's. -describe("worker script hosting headers (0929/06-05)", () => { +describe("worker script hosting headers (0929/06-05)", { timeout: childProcessTimeout(934) }, () => { async function verifyHosting(workerCacheControl: string) { const root = builds!.root; await rm(path.join(root, "dist"), { recursive: true, force: true }); diff --git a/tests/unit/tracked-artifacts.test.ts b/tests/unit/tracked-artifacts.test.ts index b4639ea1..0f9aecec 100644 --- a/tests/unit/tracked-artifacts.test.ts +++ b/tests/unit/tracked-artifacts.test.ts @@ -1,6 +1,7 @@ import { spawnSync } from "node:child_process"; import { describe, expect, it } from "vitest"; +import { childProcessTimeout } from "../helpers/child-process-timeout.ts"; /** * 0929/14-01. `artifacts/` is run output, but screenshots and a coverage @@ -26,7 +27,7 @@ function trackedArtifacts(): string[] { return listed.stdout.split("\0").filter((file) => file !== ""); } -describe("tracked artifacts", () => { +describe("tracked artifacts", { timeout: childProcessTimeout(20) }, () => { it("are only the folder markers", () => { expect( trackedArtifacts().filter((file) => !ALLOWED.some((pattern) => pattern.test(file))), diff --git a/tests/unit/v8-coverage-counter-semantics.test.ts b/tests/unit/v8-coverage-counter-semantics.test.ts index 5d617546..07c97b69 100644 --- a/tests/unit/v8-coverage-counter-semantics.test.ts +++ b/tests/unit/v8-coverage-counter-semantics.test.ts @@ -15,6 +15,7 @@ import { assertV8CoverageCounterSemantics, checkV8CoverageCounterSemantics, } from "../../scripts/lib/v8-coverage-counter-semantics.ts"; +import { childProcessTimeout } from "../helpers/child-process-timeout.ts"; const roots: string[] = []; const execFileAsync = promisify(execFile); @@ -210,5 +211,5 @@ describe("V8 coverage counter semantics", () => { ); expect(JSON.parse(await readFile(outputPath, "utf8"))).toEqual([]); - }); + }, childProcessTimeout(1_104)); }); -- 2.54.0 From 77c01b03c1dd1623624af894fcacf73b7a15a899 Mon Sep 17 00:00:00 2001 From: DongHyeonka Date: Thu, 12 Nov 2026 10:52:54 +0900 Subject: [PATCH 2/4] =?UTF-8?q?test(guardian):=20lease=EA=B0=80=20?= =?UTF-8?q?=EC=8B=9C=ED=97=98=20=EB=8C=80=EC=83=81=EC=9D=B4=20=EC=95=84?= =?UTF-8?q?=EB=8B=88=EB=A9=B4=20=EC=8B=9C=ED=97=98=20timeout=EB=A7=8C?= =?UTF-8?q?=ED=81=BC=20=EC=A4=80=EB=8B=A4?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit tests/integration/provider-guardian-transaction.test.ts가 부하 때 lease 만료로 실패한다. guardian이 스스로 SIGKILL한 것이다. desktop 기록 둘: - FE-GATE-007: 「still publishes near the lease deadline」 - FE-GATE-020 drill: 「owns raw and sealed publication through the authenticated client lease」 FE-B 실행에서도 load 28에 같은 실패가 2건 났다. 다시 돌리면 통과한다. 원인은 두 가지다. - startProviderGuardian은 guardian을 띄우자마자 절대 deadline (Date.now() + leaseMs)을 찍는다. 그래서 client 경로 시험의 2~3초 lease가 node 시작 시간까지 낸다. 부하 때 시작에는 상한이 없다. - 직접 프로토콜 시험은 guardian이 load를 마친 뒤 가드를 보낸다 (c8620042). 그래도 가드 → READY 처리는 실제 시계로 돈다. desktop에서 CPU 25%로 제한하면 이 구간이 17ms에서 334ms로 늘어나, 350ms lease로 만료를 보는 시험의 여유가 거의 없다. lease가 시험 대상인지로 나눠 고쳤다. - lease가 대상이 아닌 15곳(client 경로 10, 직접 경로 5)은 LEASE_NOT_UNDER_TEST_MS다. 값은 시험 timeout과 같아서, lease가 시험보다 먼저 끝날 수 없다. guardian이 멈추면 시험 timeout이 잡는다. - lease 만료를 보는 시험은 350ms → 2초다. 가드 → READY의 CPU 25% 최대 334ms의 여섯 배다. - near-deadline 시험은 client 경로에서 직접 프로토콜로 옮겼다. - deadline이 guardian load 뒤에 시작해서 시작 시간이 빠진다. - sendGuard가 보낸 deadline을 돌려준다. - 시험은 lease 4초의 마지막 2초 안에 publish·commit을 보내고, 그 구간에 있었는지 단언한다. - 2초는 publish·commit의 CPU 25% 최대 104ms의 약 스무 배다. - client의 publish·commit은 「owns raw and sealed publication」이 그대로 본다. 버린 것: - guardian에 가짜 시계 주입: 운영 스크립트에 시험용 훅을 넣어야 한다 (c8620042와 같은 이유). - client가 guardian load 뒤에 deadline을 찍게 바꾸기: 운영 프로토콜에 준비 신호를 더해야 한다. 이 PR 범위를 넘는다. - 모든 lease를 늘리기: 만료와 near-deadline 시험은 lease가 대상이라 늘리면 보는 것이 흐려진다. 위험: - 시험이 실패하면 guardian이 lease 끝까지(최대 30초) 남을 수 있다. 전에는 2~3초였다. - near-deadline 시험에는 실제 시계 구간이 남는다. publish·commit이 2초를 넘으면 실패한다. 잰 최대의 약 스무 배다. - 운영 client가 lease에 node 시작 시간을 포함하는 것은 그대로다. 운영 lease는 분 단위라 시험만큼 빠듯하지 않다. 검증(desktop): - 이 파일을 10회 돌려 22개 모두 통과했다(load 3~4). - CPU 20% 제한에서 main d2239c67은 5회 모두 1~6개 실패했다. 원인은 가드 처리 중 deadline 지남(126), READY·PUBLISHED 대기 시간 초과, EPIPE였다. 같은 조건에서 이 커밋은 5회 모두 통과했다. - 시험 timeout은 잰 최대로 고쳤다. near-deadline 3.2초, 만료 2.1초. - 첫 최종 실행에서 FE-GATE-007이 near-deadline 시험의 「마지막 2초 안」 단언으로 실패했다(남은 2,001ms). 타이머가 Date.now()보다 1ms 일찍 깼다. 목표 시각에 닿을 때까지 다시 기다리게 고쳤다. 고친 뒤 이 파일을 30회(load 3.6~21), CPU 20% 제한으로 5회 돌려 모두 통과했다. --- .../provider-guardian-transaction.test.ts | 152 ++++++++++++------ 1 file changed, 104 insertions(+), 48 deletions(-) diff --git a/tests/integration/provider-guardian-transaction.test.ts b/tests/integration/provider-guardian-transaction.test.ts index aad089f5..d7fb0f42 100644 --- a/tests/integration/provider-guardian-transaction.test.ts +++ b/tests/integration/provider-guardian-transaction.test.ts @@ -35,6 +35,26 @@ const PROCESS_HEAVY_TIMEOUT_MS = 30_000; const PROCESS_HANDSHAKE_WATCHDOG_MS = 5_000; /** The extra pipe on which spawnGuardian's wrapper reports the guardian loaded. */ const GUARDIAN_LOADED_FD = 7; +/** + * The lease of a test whose subject is not the lease: as long as the test's + * timeout, so the guardian's deadline cannot end a test first. A guard carries + * an absolute deadline. Under load a 2 to 3 s lease ran out before commit and + * the guardian killed itself (FE-GATE-007 and FE-GATE-020 drills on desktop, + * 2026-11-12, load average 28): startProviderGuardian stamps the deadline when + * it spawns the guardian, so its lease also paid for node start-up. + */ +const LEASE_NOT_UNDER_TEST_MS = PROCESS_HEAVY_TIMEOUT_MS; +/* + * The leases a test measures come from desktop runs of the direct-protocol + * publish test (2026-11-12, eight runs each, with and without a 25% CPU + * quota): guard to READY took at most 17 ms, 334 ms under the quota; publish + * and commit at most 34 ms, 104 ms under the quota. + */ +/** Has to outlast guard to READY before it expires: six times the 334 ms. */ +const EXPIRING_LEASE_MS = 2_000; +/** Publish and commit go out in the lease's last NEAR_DEADLINE_MARGIN_MS, twenty times the 104 ms. */ +const NEAR_DEADLINE_LEASE_MS = 4_000; +const NEAR_DEADLINE_MARGIN_MS = 2_000; const roots: string[] = []; @@ -218,7 +238,7 @@ describe("provider guardian transaction protocol", () => { const child = spawnGuardian(workspace, nonce); const completion = waitForChild(child); const readyPayload = readFrame(child.stdout!); - await sendGuard(child, nonce, 2_000); + await sendGuard(child, nonce, LEASE_NOT_UNDER_TEST_MS); const ready = decodeProviderGuardianReady( await within(readyPayload, PROCESS_HANDSHAKE_WATCHDOG_MS, "guardian READY"), @@ -243,7 +263,7 @@ describe("provider guardian transaction protocol", () => { await expect(lstat(rawPath)).rejects.toMatchObject({ code: "ENOENT" }); await expect(lstat(sealedTempPath)).rejects.toMatchObject({ code: "ENOENT" }); await expect(readdir(path.join(workspace, "provider-evidence/untrusted"))).resolves.toEqual([]); - }, childProcessTimeout(253)); + }, childProcessTimeout(854)); it("creates no evidence for empty or truncated guard input", async () => { const { startProviderGuardian } = await import( @@ -271,7 +291,7 @@ describe("provider guardian transaction protocol", () => { const retry = await startProviderGuardian({ kind: "vulnerability", workspaceRoot: workspace, - leaseMs: 3_000, + leaseMs: LEASE_NOT_UNDER_TEST_MS, guardianScript: path.resolve("scripts/lib/provider-raw-guardian.ts"), }); await retry.abort(); @@ -280,7 +300,7 @@ describe("provider guardian transaction protocol", () => { await expect(readdir(path.join(workspace, "provider-evidence"))) .resolves.toEqual(["untrusted"]); } - }, childProcessTimeout(1_226)); + }, childProcessTimeout(1_516)); it.each(["raw", "sealed"] as const)( "cleans the independently bound %s private alias when peer bootstrap validation fails", @@ -317,7 +337,7 @@ describe("provider guardian transaction protocol", () => { const nonce = Buffer.alloc(32, 0x2b); const child = spawnGuardian(workspace, nonce); const completion = waitForChild(child); - await sendGuard(child, nonce, 2_000, { closeInput: true }); + await sendGuard(child, nonce, LEASE_NOT_UNDER_TEST_MS, { closeInput: true }); await expect(within(completion, PROCESS_HANDSHAKE_WATCHDOG_MS, "guardian parent startup death")) .resolves.toEqual({ code: 125, signal: null }); @@ -334,7 +354,7 @@ describe("provider guardian transaction protocol", () => { const completion = waitForChild(child); try { // A different nonce than the inherited private aliases were named for. - await sendGuard(child, Buffer.alloc(32, 0x3e), 2_000); + await sendGuard(child, Buffer.alloc(32, 0x3e), LEASE_NOT_UNDER_TEST_MS); await expect(within(completion, PROCESS_HANDSHAKE_WATCHDOG_MS, "rejected-guard guardian exit")) .resolves.toEqual({ code: 126, signal: null }); } finally { @@ -359,7 +379,7 @@ describe("provider guardian transaction protocol", () => { const child = spawnGuardian(workspace, nonce); const completion = waitForChild(child); const readyPayload = readFrame(child.stdout!); - await sendGuard(child, nonce, 3_000); + await sendGuard(child, nonce, LEASE_NOT_UNDER_TEST_MS); const ready = decodeProviderGuardianReady( await within(readyPayload, PROCESS_HANDSHAKE_WATCHDOG_MS, "guardian READY"), nonce, @@ -438,7 +458,7 @@ describe("provider guardian transaction protocol", () => { const lease = await start({ kind: "vulnerability", workspaceRoot: workspace, - leaseMs: 3_000, + leaseMs: LEASE_NOT_UNDER_TEST_MS, guardianScript, }); expect((await readFile(`/proc/${lease.pid}/cmdline`)).toString("utf8") @@ -479,13 +499,13 @@ describe("provider guardian transaction protocol", () => { const retry = await startProviderGuardian({ kind: "vulnerability", workspaceRoot: workspace, - leaseMs: 2_000, + leaseMs: LEASE_NOT_UNDER_TEST_MS, guardianScript: path.resolve("scripts/lib/provider-raw-guardian.ts"), }); await retry.abort(); await expect(readdir(path.join(workspace, "provider-evidence/untrusted"))).resolves.toEqual([]); await expect(readdir(path.join(workspace, "provider-evidence"))).resolves.toEqual(["untrusted"]); - }, childProcessTimeout(429)); + }, childProcessTimeout(2_455)); it("fails closed when a separate trailing frame arrives after commit", async () => { const { encodeProviderGuardianCommit } = await import( @@ -513,7 +533,7 @@ describe("provider guardian transaction protocol", () => { const lease = await startProviderGuardian({ kind: "vulnerability", workspaceRoot: workspace, - leaseMs: 3_000, + leaseMs: LEASE_NOT_UNDER_TEST_MS, guardianScript: path.resolve("scripts/lib/provider-raw-guardian.ts"), }); @@ -539,7 +559,7 @@ describe("provider guardian transaction protocol", () => { const starting = startProviderGuardian({ kind: "vulnerability", workspaceRoot: workspace, - leaseMs: 3_000, + leaseMs: LEASE_NOT_UNDER_TEST_MS, guardianScript, }); const guardianPid = await waitForNewDirectChild(existingChildren); @@ -561,7 +581,7 @@ describe("provider guardian transaction protocol", () => { const retry = await startProviderGuardian({ kind: "vulnerability", workspaceRoot: workspace, - leaseMs: 3_000, + leaseMs: LEASE_NOT_UNDER_TEST_MS, guardianScript: path.resolve("scripts/lib/provider-raw-guardian.ts"), }); expect(path.basename(retry.sealedTempPath)).toMatch( @@ -585,7 +605,7 @@ describe("provider guardian transaction protocol", () => { const starting = startProviderGuardian({ kind: "vulnerability", workspaceRoot: workspace, - leaseMs: 3_000, + leaseMs: LEASE_NOT_UNDER_TEST_MS, guardianScript, }); const guardianPid = Number(await waitForFile(markerPath)); @@ -612,7 +632,7 @@ describe("provider guardian transaction protocol", () => { const retry = await startProviderGuardian({ kind: "vulnerability", workspaceRoot: workspace, - leaseMs: 3_000, + leaseMs: LEASE_NOT_UNDER_TEST_MS, guardianScript: path.resolve("scripts/lib/provider-raw-guardian.ts"), }); await retry.abort(); @@ -630,7 +650,7 @@ describe("provider guardian transaction protocol", () => { const input = { kind: "vulnerability" as const, workspaceRoot: workspace, - leaseMs: 10_000, + leaseMs: LEASE_NOT_UNDER_TEST_MS, guardianScript: path.resolve("scripts/lib/provider-raw-guardian.ts"), }; @@ -670,7 +690,7 @@ describe("provider guardian transaction protocol", () => { const child = spawnGuardian(workspace, nonce); const completion = waitForChild(child); const readyPayload = readFrame(child.stdout!); - await sendGuard(child, nonce, 3_000); + await sendGuard(child, nonce, LEASE_NOT_UNDER_TEST_MS); const ready = decodeProviderGuardianReady( await within(readyPayload, PROCESS_HANDSHAKE_WATCHDOG_MS, "closed-stderr guardian READY"), nonce, @@ -685,7 +705,7 @@ describe("provider guardian transaction protocol", () => { .rejects.toMatchObject({ code: "ENOENT" }); await expect(lstat(path.join(evidenceRoot, ready.sealedTempLeaf))) .rejects.toMatchObject({ code: "ENOENT" }); - }, childProcessTimeout(469)); + }, childProcessTimeout(576)); it("expires an uncommitted lease only after cleaning every owned object", async () => { const { decodeProviderGuardianReady } = await import( @@ -698,7 +718,7 @@ describe("provider guardian transaction protocol", () => { const child = spawnGuardian(workspace, nonce); const completion = waitForChild(child); const readyPayload = readFrame(child.stdout!); - await sendGuard(child, nonce, 350); + await sendGuard(child, nonce, EXPIRING_LEASE_MS); const ready = decodeProviderGuardianReady( await within(readyPayload, PROCESS_HANDSHAKE_WATCHDOG_MS, "deadline guardian READY"), nonce, @@ -710,32 +730,70 @@ describe("provider guardian transaction protocol", () => { await expect(lstat(rawPath)).rejects.toMatchObject({ code: "ENOENT" }); await expect(lstat(sealedTempPath)).rejects.toMatchObject({ code: "ENOENT" }); await expect(readdir(evidenceRoot)).resolves.toEqual(["untrusted"]); - }, PROCESS_HEAVY_TIMEOUT_MS); + }, childProcessTimeout(2_114)); it("still publishes near the lease deadline when post-processing completes in time", async () => { - const { startProviderGuardian } = await import( - "../../scripts/lib/provider-guardian-client.ts" - ); + const { + decodeProviderGuardianPublished, + decodeProviderGuardianReady, + encodeProviderGuardianCommit, + encodeProviderGuardianPublish, + } = await import("../../scripts/lib/provider-guardian-protocol.ts"); const workspace = await createWorkspace("provider-guardian-near-timeout-"); - // The client stamps the deadline after it spawns the guardian, so the - // deadline is at least 2s from here. Waking 1s from here, not 1s after - // start-up returns, keeps publish and commit 1s on a slow host too. - const startedAt = Date.now(); - const lease = await startProviderGuardian({ - kind: "vulnerability", - workspaceRoot: workspace, - leaseMs: 2_000, - guardianScript: path.resolve("scripts/lib/provider-raw-guardian.ts"), - }); - await new Promise((resolve) => - setTimeout(resolve, Math.max(0, startedAt + 1_000 - Date.now()))); + const evidenceRoot = path.join(workspace, "provider-evidence"); + const rawPath = path.join(evidenceRoot, "untrusted/vulnerability-report.json"); + const sealedPath = path.join(evidenceRoot, "vulnerability-report.json"); + const nonce = Buffer.alloc(32, 0x5d); + const child = spawnGuardian(workspace, nonce); + const completion = waitForChild(child); + const readyPayload = readFrame(child.stdout!); + // The direct protocol starts the deadline once the guardian has loaded, + // so start-up on a loaded host does not use up the lease. Only publish + // and commit run on the real clock, inside NEAR_DEADLINE_MARGIN_MS. + const deadlineEpochMs = await sendGuard(child, nonce, NEAR_DEADLINE_LEASE_MS); + const ready = decodeProviderGuardianReady( + await within(readyPayload, PROCESS_HANDSHAKE_WATCHDOG_MS, "near-deadline guardian READY"), + nonce, + ); const bytes = Buffer.from('{"validated":"near-timeout"}\n'); + const handle = await open( + path.join(evidenceRoot, ready.sealedTempLeaf), + constants.O_WRONLY | constants.O_NOFOLLOW, + ); + try { + await handle.writeFile(bytes); + await handle.chmod(0o400); + await handle.sync(); + } finally { + await handle.close(); + } + // A timer can fire a millisecond before Date.now() reaches its target, so + // wait again until it has. + const nearDeadlineEpochMs = deadlineEpochMs - NEAR_DEADLINE_MARGIN_MS; + while (Date.now() < nearDeadlineEpochMs) { + await new Promise((resolve) => setTimeout(resolve, nearDeadlineEpochMs - Date.now())); + } + expect(deadlineEpochMs - Date.now()).toBeLessThanOrEqual(NEAR_DEADLINE_MARGIN_MS); - await lease.publish(bytes); - await lease.commit(); - await expect(lstat(lease.rawPath)).rejects.toMatchObject({ code: "ENOENT" }); - await expect(readFile(lease.sealedPath)).resolves.toEqual(bytes); - }, childProcessTimeout(1_126)); + const publishedPayload = readFrame(child.stdout!); + child.stdin!.write(encodeProviderGuardianPublish({ + nonce, + sealedDev: ready.sealedDev, + sealedIno: ready.sealedIno, + size: bytes.byteLength, + sha256: createHash("sha256").update(bytes).digest("hex"), + })); + decodeProviderGuardianPublished( + await within(publishedPayload, PROCESS_HANDSHAKE_WATCHDOG_MS, "near-deadline guardian PUBLISHED"), + nonce, + { dev: ready.sealedDev, ino: ready.sealedIno }, + ); + child.stdin!.end(encodeProviderGuardianCommit(nonce)); + await expect(within(completion, PROCESS_HANDSHAKE_WATCHDOG_MS, "near-deadline guardian commit EOF")) + .resolves.toEqual({ code: 0, signal: null }); + await expect(lstat(rawPath)).rejects.toMatchObject({ code: "ENOENT" }); + await expect(readFile(sealedPath)).resolves.toEqual(bytes); + }, childProcessTimeout(3_234)); it("signals guardian exit only while the provider scope latch is active", async () => { const lifecycle = await import("../../scripts/lib/provider-guardian-client.ts") as @@ -875,7 +933,7 @@ async function establishPublishedGuardian( const child = spawnGuardian(workspace, nonce); const completion = waitForChild(child); const readyPayload = readFrame(child.stdout!); - await sendGuard(child, nonce, 3_000); + await sendGuard(child, nonce, LEASE_NOT_UNDER_TEST_MS); const ready = decodeProviderGuardianReady( await within(readyPayload, PROCESS_HANDSHAKE_WATCHDOG_MS, "guardian READY"), nonce, @@ -1007,7 +1065,7 @@ function spawnGuardian( /** * A guard carries an absolute deadline, so it goes out only once the guardian - * reads stdin. Sent at spawn, the lease also pays for process start-up, which + * reads stdin. Returns that deadline. Sent at spawn, the lease also pays for process start-up, which * has no bound on a loaded host: a 350ms lease then expires before the * guardian decodes the guard. */ @@ -1016,7 +1074,7 @@ async function sendGuard( nonce: Buffer, leaseMs: number, options: Readonly<{ closeInput?: boolean }> = {}, -): Promise { +): Promise { const { encodeProviderGuardianGuard } = await import( "../../scripts/lib/provider-guardian-protocol.ts" ); @@ -1025,13 +1083,11 @@ async function sendGuard( loaded.once("data", () => resolve()); loaded.once("end", () => reject(new Error("guardian exited before it loaded"))); }), PROCESS_HANDSHAKE_WATCHDOG_MS, "guardian start-up"); - const guard = encodeProviderGuardianGuard({ - kind: "vulnerability", - nonce, - deadlineEpochMs: Date.now() + leaseMs, - }); + const deadlineEpochMs = Date.now() + leaseMs; + const guard = encodeProviderGuardianGuard({ kind: "vulnerability", nonce, deadlineEpochMs }); if (options.closeInput) child.stdin!.end(guard); else child.stdin!.write(guard); + return deadlineEpochMs; } function spawnGuardianWithPrivateModes( -- 2.54.0 From db4c632d531cf38584efc66d45a383a2bf0d4675 Mon Sep 17 00:00:00 2001 From: DongHyeonka Date: Thu, 12 Nov 2026 11:35:59 +0900 Subject: [PATCH 3/4] =?UTF-8?q?test(archive):=20=EB=8B=A4=EB=A5=B8=20?= =?UTF-8?q?=EC=8B=9C=ED=97=98=EC=9D=B4=20=EC=93=B0=EB=8A=94=20=EC=A4=91?= =?UTF-8?q?=EC=9D=B8=20=EC=9E=84=EC=8B=9C=20=ED=8C=8C=EC=9D=BC=EC=9D=80=20?= =?UTF-8?q?=EC=82=AC=EB=B3=B8=EC=97=90=20=EB=B3=B5=EC=82=AC=ED=95=98?= =?UTF-8?q?=EC=A7=80=20=EC=95=8A=EB=8A=94=EB=8B=A4?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit tests/integration/security-followup-archive.test.ts는 후보 빌드에 쓸 증거를 얻으려고 checkout의 artifacts/를 통째로 사본에 복사한다. 같은 integration 실행에서 tests/integration/http-scenario-catalog.test.ts가 artifacts/tests/http-scenario-executions.json을 임시 파일에 쓰고 rename한다. 복사가 목록을 읽은 뒤 그 임시 파일이 rename되면 ENOENT로 실패한다. desktop FE-GATE-007(2026-11-12, load 9)에서 났다. 복사 filter가 원자적 쓰기의 임시 파일(.<이름>.<무작위>.tmp)을 건너뛴다. 그런 파일은 쓰는 중이라 증거가 아니다. fs.cp는 filter를 stat보다 먼저 부르므로, 건너뛴 파일은 사라져도 오류가 없다. 버린 것: - 필요한 증거 경로만 복사: 공급망 생성이 추적 파일(artifacts의 .gitkeep 포함)을 모두 lstat하고 build가 읽는 증거가 여러 곳이라, 목록을 따로 관리해야 한다. - 두 시험을 같이 돌지 않게 하기: integration 층 전체를 직렬로 돌려야 한다. 위험: 임시 파일이 아닌 파일을 다른 시험이 지우는 경합은 남는다. 지금 artifacts/ 아래에서 그렇게 하는 시험은 찾지 못했다. 검증(desktop): - 다른 프로세스가 artifacts/tests에 임시 파일 10개를 계속 만들고 rename하는 동안 이 시험을 돌렸다. main 6b4f703c는 3회 중 2회가 같은 ENOENT(.tmp)로 실패했고, 이 커밋은 3회 모두 통과했다. - test:unit, check:types, check:ci, lint, verify:documentation. --- tests/integration/security-followup-archive.test.ts | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/tests/integration/security-followup-archive.test.ts b/tests/integration/security-followup-archive.test.ts index 837863c6..b0f7c233 100644 --- a/tests/integration/security-followup-archive.test.ts +++ b/tests/integration/security-followup-archive.test.ts @@ -21,6 +21,9 @@ import { } from "../../scripts/lib/fixture-node-modules.ts"; import { selectRepositoryPaths } from "../../scripts/lib/repository-layout.ts"; +/** The temporary file of an atomic write: `...tmp`. */ +const IN_FLIGHT_WRITE = /^\..+\.tmp$/u; + it( "builds a real candidate assessment and passes the default archived verifier from the captured archive", async () => { @@ -36,8 +39,13 @@ it( return !selectRepositoryPaths("supply-chain-fixture-skip").includes(first ?? ""); }, }); + // Other test files write their receipts under artifacts/ while this one + // copies it: a temporary file of an atomic write (...tmp) was + // renamed between the listing and the copy, and the copy failed with + // ENOENT (FE-GATE-007 on desktop, 2026-11-12). It is never evidence. await cp(path.join(sourceRoot, "artifacts"), path.join(fixtureRoot, "artifacts"), { recursive: true, + filter: (source) => !IN_FLIGHT_WRITE.test(path.basename(source)), }); await rm(path.join(fixtureRoot, "artifacts/release"), { recursive: true, -- 2.54.0 From a593feb2525761262d2e0ca3b5c80c6a386736d8 Mon Sep 17 00:00:00 2001 From: DongHyeonka Date: Thu, 12 Nov 2026 11:01:39 +0900 Subject: [PATCH 4/4] =?UTF-8?q?docs(changelog):=20=EC=9E=90=EC=8B=9D=20?= =?UTF-8?q?=ED=94=84=EB=A1=9C=EC=84=B8=EC=8A=A4=20=EC=8B=9C=ED=97=98=20tim?= =?UTF-8?q?eout=EA=B3=BC=20=ED=9D=94=EB=93=A4=EB=A6=AC=EB=8D=98=20?= =?UTF-8?q?=EC=8B=9C=ED=97=98=20=EB=91=98=EC=9D=98=20=EA=B3=A0=EC=B9=A8?= =?UTF-8?q?=EC=9D=84=20=EC=A0=81=EB=8A=94=EB=8B=A4?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit 정리 단계 절에 이 브랜치의 범위를 넣었다. 먼저 할 일 17을 더했다: 기본 timeout인 Vitest 시험이 자식 프로세스를 띄우면 실패하니, 다운스트림은 자기 시험에 childProcessTimeout(<잰 ms>)을 준다. 옮긴 뒤 확인 1에는 test:integration과 17단계를 더했다. 계약 표 한 줄과, 그 밖의 수정에 guardian lease 고침과 archive 시험의 임시 파일 경합 고침을 한 줄씩 적었다. 검증(desktop): verify:documentation, test:unit. --- CHANGELOG.md | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 415ef9ce..19965034 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -43,7 +43,7 @@ ## 미출시 — `48c7695b` → 정리 단계 -2026-11-07 소유자가 지시한 저장소 정리다(design-docs `repo-structure/04-frontend-layout.md` 9.2절, 결정은 `repo-structure/README.md` 3.4절). 범위는 `main` `48c7695b`(PR #9 병합) 다음부터다. 1단계(PR #11, `85f941c4`~`121e1125`, `main` `f33e4778`에 합침), 2단계(브랜치 `chore/layout-2-sample-removal`, `c7e80f2f`~`ad3a071f`), 3단계(합치기)와 4단계(배치 규칙 검사)(브랜치 `chore/layout-3-merge`, `bf485f44`~`c54c3813`), CI 재편(브랜치 `chore/ci-merge-jobs`, `0739f26b`부터 브랜치 끝까지), 문서 체계 단계(브랜치 `claude/fe-b-docs-korean-645f55`, `99e76e87`부터 브랜치 끝까지. design-docs `conventions/docs-system.md`), 4단계에 남은 R2·R5 검사(브랜치 `chore/layout-rules-r2-r5`, `3f64c689`부터 브랜치 끝까지), 문서 체계 후속(브랜치 `claude/fe-b-docs-followup`, `8acf07c2`부터 브랜치 끝까지. 브랜치 `claude/fe-b-docs-followup-2`, `1b3eee41`부터 브랜치 끝까지)을 담는다. 기준점 `48c7695b`를 빼면 이 절의 해시는 모두 이 범위에 있다. +2026-11-07 소유자가 지시한 저장소 정리다(design-docs `repo-structure/04-frontend-layout.md` 9.2절, 결정은 `repo-structure/README.md` 3.4절). 범위는 `main` `48c7695b`(PR #9 병합) 다음부터다. 1단계(PR #11, `85f941c4`~`121e1125`, `main` `f33e4778`에 합침), 2단계(브랜치 `chore/layout-2-sample-removal`, `c7e80f2f`~`ad3a071f`), 3단계(합치기)와 4단계(배치 규칙 검사)(브랜치 `chore/layout-3-merge`, `bf485f44`~`c54c3813`), CI 재편(브랜치 `chore/ci-merge-jobs`, `0739f26b`부터 브랜치 끝까지), 문서 체계 단계(브랜치 `claude/fe-b-docs-korean-645f55`, `99e76e87`부터 브랜치 끝까지. design-docs `conventions/docs-system.md`), 4단계에 남은 R2·R5 검사(브랜치 `chore/layout-rules-r2-r5`, `3f64c689`부터 브랜치 끝까지), 문서 체계 후속(브랜치 `claude/fe-b-docs-followup`, `8acf07c2`부터 브랜치 끝까지. 브랜치 `claude/fe-b-docs-followup-2`, `1b3eee41`부터 브랜치 끝까지), 자식 프로세스 시험 timeout(브랜치 `fix/child-process-test-timeouts`, `91962e24`부터 브랜치 끝까지)을 담는다. 기준점 `48c7695b`를 빼면 이 절의 해시는 모두 이 범위에 있다. ### 먼저 할 일 (BREAKING) @@ -73,13 +73,14 @@ 14. **merge 단계 job 이름이 바뀌었다.** 게이트마다 하나이던 행렬 job(`FE-GATE-NNN / <이름>`)이 `merge / static checks`(`merge_static`), `merge / tests`(`merge_test`), `merge / browser tests`(`merge_browser`) 셋이 됐다. 게이트는 job 안의 단계 이름(`FE-GATE-NNN / <이름>`)으로 남는다. Gitea 브랜치 보호의 필수 검사를 옛 job 이름으로 걸었으면 새 job 셋으로 바꾼다. 증거 업로드 이름도 `FE-GATE-NNN-`에서 `merge-static-`·`merge-test-`·`merge-browser-`으로 바뀌었다 (`0739f26b`) 15. **코드에 적은 루트 경로 목록을 등록부 집합으로 바꾼다.** R2 검사가 등록부를 쓰는 7곳이 아니라 추적되는 코드 파일 전체를 본다. 루트 항목(이나 그 안 경로)만 담은 문자열 배열에 추적되는 루트 이름이 둘 이상이면 `tests/unit/repository-layout.test.ts`가 `choose a set from config/repository-layout.json with selectRepositoryPaths`로 실패한다. 템플릿의 19개 목록은 집합 12개로 옮겼다. 자기 목록은 맞는 집합을 고르거나, 없으면 `scripts/lib/repository-layout.ts`의 `REPOSITORY_LAYOUT_SETS`와 등록부 `sets` 설명에 집합을 더해 고른다. 시험이 메모리 안에 만드는 가상 저장소의 경로 목록(실제 루트 항목을 옮겨도 바뀌지 않는 것)은 `tests/unit/repository-layout.test.ts`의 `MADE_UP_REPOSITORY_LISTS`에 파일·목록·이유를 적는다. 사본이 건너뛰는 `node_modules`·`dist` 같은 추적 안 하는 항목은 종류 `untracked`, `optional: true`로 적는다(매뉴얼 03 E절 R1·R2) (`3f64c689`) 16. **샘플을 목록에 둔 프로젝트는 게이트 대상이 샘플 소유가 아닌지 본다.** R5 검사가 문자열 검색 대신 대상의 소유자를 따라간다: goto 경로 → 라우트 표의 기능, workshop story id → stories 파일, spec의 import → 불러오는 파일, 게이트 명령 → package script와 경로 인자, `sourceFeature` → 기능. `config/ci/gates.json`의 수동 a11y 기록이 라우트 표에 없는 라우트를 가리켜도 실패한다(지운 기능의 기록을 남긴 경우) (`1f57c38e`) +17. **자식 프로세스를 띄우는 자기 시험에 잰 timeout을 준다.** 기본 timeout(10초)인 Vitest 시험이 자식 프로세스를 띄우면 `tests/setup.ts`가 그 호출에서 `spawnSync(<명령>) ran in a test on the default 10000 ms timeout`처럼 실패시킨다. 시험이 import한 helper나 스크립트가 띄워도 같다. desktop에서 그 시험의 가장 긴 실행을 재서 `childProcessTimeout()`(`tests/helpers/child-process-timeout.ts`)을 시험이나 describe에 준다. 템플릿의 시험은 그렇게 고쳤다(`docs/work/reference/testing.md` 2절) (`91962e24`) 7. **자기 문서를 새 문서 검사에 맞춘다.** `verify:documentation`(FE-GATE-017)이 살아 있는 문서 전부(루트 `README.md`, `docs/` 아래 기록 밖 문서, 모듈 README)를 본다: 본문이 한국어인지, 「~한다」 체인지, 버전·개수를 복사하지 않았는지, 적은 경로·script·게이트 ID가 있는지. 루트 README는 `## 프로젝트 구조`부터 `## 규칙과 기여`까지 정해진 절을 순서대로 가져야 하고, `docs/README.md`는 `docs/` 아래 모든 폴더를 표 첫 칸 `폴더/`로 덮어야 한다. 자기 기록(`docs/design/`, `docs/history/`, `docs/adr/`)은 맨 위에 머리 블록을 단다(형식은 템플릿 `docs/README.md` 3절). 한 번에 다 고칠 수 없으면 걸린 줄을 `scripts/docs-system-exceptions.txt`에 기준선으로 적고 그 지문을 `scripts/lib/docs-system.ts`의 `FROZEN`에 넣는다. 그 목록은 줄기만 한다 (`7a9aefdf`) 8. **README의 바뀐 절 이름을 따른다.** 「Files you can delete after copying」은 「복사한 뒤 지워도 되는 것」이다. `verify:documentation`이 이 제목 아래 표의 첫 칸으로 지워도 되는 경로를 읽는다. 자기 README를 템플릿 README로 받았으면 이 제목을 지킨다 (`7a9aefdf`) #### 옮긴 뒤 확인 -1. 로컬 merge 게이트 14개를 돈다. 이 절 때문에 먼저 볼 것: `check:registries`(3단계), `check:ci`(4·12단계), `test:unit`(5·9·11·15·16단계), `generate:feature-index`(6단계), `check:types`·`check:types:fixtures`(7·8단계), `verify:documentation`(지운 샘플 경로를 적은 자기 문서, 9단계, 매뉴얼 03 E절 R6·R7), `test:sample-removal`(인자 없이 돌면 목록이 빈 템플릿에서는 `SKIP`을 출력한다). +1. 로컬 merge 게이트 14개를 돈다. 이 절 때문에 먼저 볼 것: `check:registries`(3단계), `check:ci`(4·12단계), `test:unit`·`test:integration`(5·9·11·15·16·17단계), `generate:feature-index`(6단계), `check:types`·`check:types:fixtures`(7·8단계), `verify:documentation`(지운 샘플 경로를 적은 자기 문서, 9단계, 매뉴얼 03 E절 R6·R7), `test:sample-removal`(인자 없이 돌면 목록이 빈 템플릿에서는 `SKIP`을 출력한다). - 검사기의 음성 fixture 명령 15개와 ungated 검사(`check:ci:gating`)는 PR이 아니라 브랜치 push의 FE-GATE-029(`main_gate`)에서 돈다. 새 시험 파일이나 검증 script를 게이트에 걸지 않으면 PR은 통과하고 main push가 실패한다. 로컬에서는 `corepack pnpm ci:gate FE-GATE-029`로 미리 본다 (`f6b2b96c`). 2. 시각 골든: 갤러리 두 장(`design-system-gallery-dark`, `state-surfaces-light`)은 이제 Storybook 정적 빌드의 story를 찍는다. 자기 골든을 다시 찍은 프로젝트는 `corepack pnpm test:visual:update`로 그 둘을 다시 찍는다. 3. `/examples/ui`·`/examples/states`·`/examples/auth`를 열던 자기 e2e는 플랫폼 라우트나 자기 화면으로 옮긴다. 템플릿의 그런 spec은 옮겼다(아래 표). @@ -100,6 +101,7 @@ | [계약] | 저장소 배치 규칙 R1~R10을 매뉴얼 03 E절에 적고, 기계로 볼 수 있는 것을 게이트에 넣었다: R1·R2·R7(파일)·R9 `tests/unit/repository-layout.test.ts`, R3 `tests/unit/tracked-artifacts.test.ts`, R4·R5 `tests/unit/example-feature-rules.test.ts`(이상 FE-GATE-005), R6·R7(문서) `verify:documentation`(FE-GATE-017, 산출물에 `layoutRuleViolations`), R8 FE-GATE-003 | `docs/manual/03-outside-feature-folder.md`, `scripts/verify-documentation-readiness.ts`, `scripts/contracts/release-artifacts.ts` | `e902e657` | | [계약] **BREAKING** | R2 검사를 추적되는 코드 파일 전체로 넓히고 남은 루트 경로 목록 19개를 등록부 집합 12개로 옮겼다. 등록부에 종류 `untracked`가 생겼다. R5 검사는 게이트 대상을 라우트 표·stories 파일·import·package script 그래프·규모 기록 필드로 따라가 소유자를 본다. 위 "먼저 할 일" 15·16 | `config/repository-layout.json`, `scripts/lib/repository-layout.ts`, `tests/unit/repository-layout.test.ts`, `tests/unit/example-feature-rules.test.ts` | `3f64c689`, `1f57c38e` | | [계약] **BREAKING** | merge 단계 job 14개(게이트마다 행렬 하나)를 셋으로 합쳤다. job마다 설치를 한 번 하고 게이트를 차례로 돈다. 앞 게이트가 실패해도 다음 게이트가 돈다(`if: ${{ !cancelled() }}`). release 단계는 세 job을 모두 기다린다. 위 "먼저 할 일" 14 | `config/ci/gates.json` `jobs`, `scripts/contracts/ci-gates.ts`, `scripts/generate-ci-workflow.ts`, `.gitea/workflows/quality-gates.yml` | `0739f26b` | +| [계약] **BREAKING** | 기본 timeout인 Vitest 시험이 자식 프로세스를 띄우면 실패한다. 자식 프로세스를 띄우던 시험 91개에 desktop에서 잰 가장 긴 실행의 15배를 30초 단위로 올린 timeout을 줬다. CPU 10% 제한에서 main은 그중 11개가 10초 timeout으로 실패했고 고친 뒤 통과했다. 위 "먼저 할 일" 17 | `tests/setup.ts`, `tests/helpers/child-process-timeout.ts`, `tests/` | `91962e24` | | [계약] **BREAKING** | 새 단계 `main`(`MAIN_READY`, 승격을 막지 않음)과 게이트 FE-GATE-029 `checker-self-tests`. FE-GATE-001·005·008·010·013의 `*:fixture` 명령 15개와 그 증거, `check:ci`의 ungated 검사(`check:ci:gating`으로 뗌)를 옮겼다. merge 단계 명령 참조 64 → 49. 음성 타입 fixture(`check:types:fixtures`)는 src 타입 계약 시험이라 merge에 남겼다. CI 계약 기준선 파일은 지웠다. 위 "먼저 할 일" 13 | `config/ci/gates.json`, `scripts/check-ci-gating.ts`, `scripts/lib/promotion-readiness.ts` | `f6b2b96c` | | [계약] **BREAKING** | 문서 체계 검사가 생겼다. `verify:documentation`이 백엔드 `check-docs.py`와 같은 규칙 여섯(language, head, number, map, readme, style)을 `scripts/lib/docs-system.ts`로 돌리고, 참조 검사의 대상이 `docs/README.md` 1절이 링크한 문서에서 살아 있는 문서 전부로 넓어졌다. pull request에서는 FE-GATE-005의 `tests/unit/documentation-readiness.test.ts`가 이 repo로 `verify:documentation`을 돌리므로 문서가 걸리면 merge 단계가 실패한다. 예외 목록(`scripts/docs-system-exceptions.txt`)은 비어 있고 줄기만 한다. 위 "먼저 할 일" 7 | `scripts/lib/docs-system.ts`, `scripts/verify-documentation-readiness.ts`, `scripts/docs-system-exceptions.txt`, `docs/README.md` | `7a9aefdf` | | [계약] | 문서를 수명으로 나눠 옮겼다. 설계서는 `docs/design/`(옛 `docs/superpowers/specs/`와 `docs/architecture/`의 목표 설계 16개는 `<작성일>-<이름>-design.md`로), 계획서는 `docs/history/plans/`(옛 `docs/superpowers/plans/`, 루트 `SPEC.md`는 `docs/history/plans/2026-09-25-review-fix-round/`), 결정 기록 VD는 `docs/adr/`(번호 그대로)다. 기록 67개에 한국어 머리 블록(상태·작성일·요약·현재 정본)을 달았다. 코드 주석의 문서 경로도 고쳤다. 위 "먼저 할 일" 옮기기 전 | `docs/design/`, `docs/history/`, `docs/adr/`, `.dependency-cruiser.json`, `tests/component/router.test.tsx` | `99e76e87`, `e632b230`, `9540bf81`, `75fad73a`, `2b8a348c` | @@ -130,6 +132,8 @@ - desktop의 FE-GATE-013은 실패가 user namespace 제한 하나뿐이고 `scripts/verify.sh parts FE-GATE-013`의 뒤 명령이 모두 rc=0이면 merge 판정에서 뺀다. 게이트 충족은 조건을 갖춘 runner에서 통과한 것으로만 센다(`docs/work/reference/gates.md` 3절, 결정 색인 2.2절). 열린 결정에서 뺐다 (`bdda84f8`). - 스킬이 인용하는 절 이름·번호가 그 문서에 있는지 `scripts/tests/test_claude_setup.py`가 대조한다. 번역으로 사라진 절을 가리키던 9곳을 지금 제목으로 고쳤다. 자기 문서의 절 이름을 바꾸면 그 절을 인용하는 스킬도 같이 고친다 (`1b3eee41`). - `config/ci/ungated-tests.json`의 `reason`을 한국어로 옮겼다 (`ac19de85`). +- provider guardian 시험(`tests/integration/provider-guardian-transaction.test.ts`)이 부하 때 lease 만료로 SIGKILL되던 것을 고쳤다. lease가 시험 대상이 아닌 곳은 시험 timeout만큼 주고, 만료와 마감 직전 publish를 보는 두 시험은 desktop에서 잰 값으로 정했다. 마감 직전 시험은 guardian이 load를 마친 뒤 마감이 시작되는 직접 프로토콜로 옮겼다. CPU 20% 제한에서 고치기 전 5회 모두 실패, 고친 뒤 5회 모두 통과 (`77c01b03`). +- `tests/integration/security-followup-archive.test.ts`가 checkout의 `artifacts/`를 복사하는 동안 다른 시험이 쓰던 원자적 쓰기의 임시 파일이 rename되면 ENOENT로 실패하던 것을 고쳤다. 복사가 `.<이름>.<무작위>.tmp`를 건너뛴다. 임시 파일을 계속 만드는 프로세스를 옆에 두고 돌리면 고치기 전 3회 중 2회 실패, 고친 뒤 3회 모두 통과 (`db4c632d`). ### 알려진 제한 -- 2.54.0