문제: fixture spec 여섯(old-tab-chunk-recovery, generated-feature, preload-use, boot-module-failure, service-worker-update·recovery)이 beforeAll에서 저장소를 복사해 vite build를 동기로 돈다. chromium· firefox·webkit project가 그 hook을 따로 돌아, e2e 한 번에 같은 build를 세 번(약 9 build × 3) 만든다. 그 build는 옆 worker의 브라우저와 CPU를 다툰다. FE-GATE-008이 가끔 떨어진 firefox 시험(runner run 127, desktop p5·fea-v8: `old-tab-chunk-recovery`·`app-shell`·`accessibility`의 첫 goto 뒤 요소 없음)은 이 build가 도는 구간과 겹쳤다. 다만 아래 6회 실행에서 고치기 전·후 모두 재현되지 않아, 이것이 원인이라고는 확정하지 못했다. 고른 방법: e2e 설정의 global setup이 run마다 공유 폴더를 만들고 (`SHARED_FIXTURE_BUILD_ROOT`), `prepareFixtureBuilds`와 `prepareServiceWorkerBuilds`가 key마다 처음 닿은 worker만 build한다. 나머지 worker는 그 결과를 기다려 쓴다(`mkdir` 잠금, 결과 JSON을 rename으로 공개, 실패는 `.failed`로 전한다). 같은 key를 다른 정의로 부르면 거절한다. build는 엔진과 무관하고 시험이 build 폴더에 쓰는 곳은 없다(edit는 build 전에만 돈다). global teardown이 폴더를 지운다. - old-tab spec은 edit 안에서 정하던 기능 목록을 build 뒤에 root에서도 읽는다. 다른 project의 build를 쓴 worker는 edit를 돌지 않는다. - 공유 폴더가 없으면(Vitest 시험, 다른 Playwright 설정) 예전처럼 호출마다 자기 사본을 만든다. - 버린 대안: expect timeout 늘리기·worker 줄이기(규칙 밖), fixture spec을 한 브라우저만 돌리기(브라우저별 계약이 줄어든다). 위험·한계: build를 기다리는 worker는 자기 hook timeout(180~300초) 안에서 기다린다. build한 worker가 죽으면 기다리는 쪽은 그 timeout으로 실패한다. 2026-11-01 리뷰의 R-1(두 helper 중복 정리)은 하지 않았다. 검증(desktop, `taskset -c 0-5` + worker 6으로 runner 모양, 같은 세션에서 고치기 전·후 번갈아 3회): e2e 전체 벽시계 172/150/141 → 123/141/113초 (중앙값 150 → 123초), 6회 모두 183개 통과. 공유 시험 6개 통과, check:types·eslint rc=0. 로그 /tmp/claude-gates/w2fe2-e2eab/, w2fe2-shared1/.
136 lines
4.7 KiB
TypeScript
136 lines
4.7 KiB
TypeScript
import { mkdir, mkdtemp, readFile, rename, rm, writeFile } from "node:fs/promises";
|
|
import { tmpdir } from "node:os";
|
|
import path from "node:path";
|
|
|
|
/**
|
|
* One fixture build per Playwright run instead of one per browser project.
|
|
*
|
|
* The fixture specs build a copy of the repository in `beforeAll`, and every
|
|
* browser project runs that hook again: one e2e run made the same builds
|
|
* three times, synchronously, while the other workers drove browsers. Those
|
|
* builds took the CPU from the browsers next to them, and Firefox's first
|
|
* render in a test then missed its 5 s expectation (FE-GATE-008, desktop and
|
|
* runner). Builds are the same for every engine and no test writes into them.
|
|
*
|
|
* With `SHARED_FIXTURE_BUILD_ROOT` set (the e2e config's global setup sets it
|
|
* for the run), the first worker that needs `key` builds it under that root and
|
|
* the others wait for it and reuse it; the global teardown removes the root.
|
|
* Unset (a Vitest test, another config), every call builds its own copy in a
|
|
* new temp folder as before.
|
|
*/
|
|
export const SHARED_FIXTURE_BUILD_ROOT_VARIABLE = "SHARED_FIXTURE_BUILD_ROOT";
|
|
|
|
const POLL_MS = 200;
|
|
const KEY = /^[a-z0-9][a-z0-9-]{0,63}$/u;
|
|
|
|
export type SharedFixtureBuild<Value> = Readonly<{
|
|
/** The folder `create` built into. */
|
|
root: string;
|
|
value: Value;
|
|
/** Owned by the run (not removable by the spec) when true. */
|
|
shared: boolean;
|
|
}>;
|
|
|
|
type BuildRecord = Readonly<{ fingerprint: string; value: unknown }>;
|
|
|
|
function hasCode(error: unknown, code: string): boolean {
|
|
return typeof error === "object" && error !== null && "code" in error && error.code === code;
|
|
}
|
|
|
|
async function readRecord(file: string): Promise<BuildRecord | undefined> {
|
|
try {
|
|
return JSON.parse(await readFile(file, "utf8")) as BuildRecord;
|
|
} catch (error) {
|
|
if (hasCode(error, "ENOENT")) return undefined;
|
|
throw error;
|
|
}
|
|
}
|
|
|
|
async function readFailure(file: string): Promise<string | undefined> {
|
|
try {
|
|
return await readFile(file, "utf8");
|
|
} catch (error) {
|
|
if (hasCode(error, "ENOENT")) return undefined;
|
|
throw error;
|
|
}
|
|
}
|
|
|
|
/**
|
|
* `create(root)` fills the empty folder `root` and returns a JSON value that
|
|
* describes it (paths under `root`). `fingerprint` names what `create` builds;
|
|
* a second caller of the same `key` with another fingerprint is refused.
|
|
*/
|
|
export async function sharedFixtureBuild<Value>(
|
|
key: string,
|
|
fingerprint: string,
|
|
create: (root: string) => Promise<Value>,
|
|
environment: NodeJS.ProcessEnv = process.env,
|
|
): Promise<SharedFixtureBuild<Value>> {
|
|
if (!KEY.test(key)) throw new Error(`Invalid fixture build key: ${key}`);
|
|
const sharedRoot = environment[SHARED_FIXTURE_BUILD_ROOT_VARIABLE];
|
|
if (!sharedRoot) {
|
|
const root = await mkdtemp(path.join(tmpdir(), `${key}-`));
|
|
try {
|
|
return { root, value: await create(root), shared: false };
|
|
} catch (error) {
|
|
await rm(root, { recursive: true, force: true });
|
|
throw error;
|
|
}
|
|
}
|
|
|
|
const root = path.join(sharedRoot, key);
|
|
const recordFile = `${root}.json`;
|
|
const failureFile = `${root}.failed`;
|
|
let owner = true;
|
|
try {
|
|
await mkdir(root);
|
|
} catch (error) {
|
|
if (!hasCode(error, "EEXIST")) throw error;
|
|
owner = false;
|
|
}
|
|
|
|
if (owner) {
|
|
let value: Value;
|
|
try {
|
|
value = await create(root);
|
|
} catch (error) {
|
|
await writeFile(failureFile, String(error instanceof Error ? error.stack : error));
|
|
throw error;
|
|
}
|
|
const temporary = `${recordFile}.${process.pid}.tmp`;
|
|
await writeFile(temporary, JSON.stringify({ fingerprint, value }));
|
|
await rename(temporary, recordFile);
|
|
return { root, value, shared: true };
|
|
}
|
|
|
|
// Another worker builds `key`; the spec's own hook timeout bounds this wait.
|
|
for (;;) {
|
|
const record = await readRecord(recordFile);
|
|
if (record) {
|
|
if (record.fingerprint !== fingerprint) {
|
|
throw new Error(
|
|
`Fixture build ${key} was built from another definition in this run.`,
|
|
);
|
|
}
|
|
return { root, value: record.value as Value, shared: true };
|
|
}
|
|
const failure = await readFailure(failureFile);
|
|
if (failure !== undefined) {
|
|
throw new Error(`Fixture build ${key} failed in another worker:\n${failure}`);
|
|
}
|
|
await new Promise((resolve) => setTimeout(resolve, POLL_MS));
|
|
}
|
|
}
|
|
|
|
/** The e2e config's global setup: a shared root for this run, and its teardown. */
|
|
export async function startSharedFixtureBuilds(
|
|
environment: NodeJS.ProcessEnv = process.env,
|
|
): Promise<() => Promise<void>> {
|
|
const root = await mkdtemp(path.join(tmpdir(), "e2e-fixture-builds-"));
|
|
environment[SHARED_FIXTURE_BUILD_ROOT_VARIABLE] = root;
|
|
return async () => {
|
|
delete environment[SHARED_FIXTURE_BUILD_ROOT_VARIABLE];
|
|
await rm(root, { recursive: true, force: true });
|
|
};
|
|
}
|