Files
clean-architecture-frontend…/tests/scale/global-local-independence.test.ts
DongHyeonka ceaf316f65
frontend-quality-gates / merge / static checks (pull_request) Canceled after 0s
frontend-quality-gates / merge / tests (pull_request) Canceled after 0s
frontend-quality-gates / merge / browser tests (pull_request) Canceled after 0s
frontend-quality-gates / FE-GATE-014 / config-compatibility (pull_request) Canceled after 0s
frontend-quality-gates / FE-GATE-026 / lab-performance (pull_request) Canceled after 0s
frontend-quality-gates / FE-GATE-028 / manual-accessibility-review (pull_request) Canceled after 0s
frontend-quality-gates / FE-GATE-015 / immutable-release-candidate (pull_request) Canceled after 0s
frontend-quality-gates / external-vulnerability-provider (pull_request) Canceled after 0s
frontend-quality-gates / external-provenance-provider (pull_request) Canceled after 0s
frontend-quality-gates / promote-verified-immutable-candidate (pull_request) Canceled after 0s
frontend-quality-gates / deploy-promoted-release (pull_request) Canceled after 0s
frontend-quality-gates / main / self-tests and removal drills (pull_request) Canceled after 0s
frontend-quality-gates / FE-GATE-019 / hosting-header (pull_request) Canceled after 0s
frontend-quality-gates / FE-GATE-021 / runbook-boot-config (pull_request) Canceled after 0s
frontend-quality-gates / FE-GATE-022 / runbook-chunk-mismatch (pull_request) Canceled after 0s
frontend-quality-gates / FE-GATE-023 / runbook-api-degradation (pull_request) Canceled after 0s
frontend-quality-gates / FE-GATE-024 / runbook-telemetry (pull_request) Canceled after 0s
frontend-quality-gates / FE-GATE-025 / runbook-release-rollback (pull_request) Canceled after 0s
frontend-quality-gates / FE-GATE-018 / field-web-vitals (pull_request) Canceled after 0s
frontend-quality-gates / FE-GATE-017 / diagram-review (pull_request) Canceled after 0s
test(setup): 시험 timeout을 모두 desktop 실측값으로 주고 손 숫자를 거절한다
문제: 자식 프로세스 시험의 timeout은 `childProcessTimeout(<잰 ms>)`로
정한다(docs/work/reference/testing.md 2절). 그런데 기본값이 아니라서
`tests/setup.ts` 검사에 걸리지 않는 손 숫자가 남았다. 리뷰가 센 54곳 중
둘(`browser-soak.contract.test.ts`의 `evaluateSoak` 인자)은 timeout이 아니고,
AST로 다시 세면 80곳이다: 시험·describe·hook에 쓴 숫자, `VERIFY_TIMEOUT`·
`PROCESS_HEAVY_TIMEOUT_MS`(파일 넷에 따로)·`PROVIDER_BASE_FIXTURE_TIMEOUT_MS`
같은 상수, `PROCESS_WATCHDOG_MS * 3` 같은 식. taxonomy는 옛 상수를 예로
들었다. 실측으로 보면 손 숫자 하나가 모자랐다: system 시험의 provider 묶음
30초는 desktop 여섯 번 중 두 번 넘겼다.

고친 것:
- 80곳을 desktop에서 잰 가장 긴 실행으로 `childProcessTimeout(<ms>)`에
  넘긴다. coverage 묶음(maxWorkers=4)·test:unit 각 9회, integration 3회,
  scale(traffic·session·composition·global-local) 3회, 시스템 컨테이너의
  tests/system 6회, JSON reporter로 받았다. hook은 파일 시간에서 시험 합을
  뺀 값이다. 시간 초과로 끝난 실행은 그 시간을 하한으로 넣었다.
- 상수 사본은 지운다. 한 파일 안에서 여럿이 쓰는 값만
  `const X = childProcessTimeout(...)`로 둔다(`VERIFY_TIMEOUT`). guardian
  시험의 lease는 시험 timeout이 아니라 `childProcessTimeout(0)`(helper의 최소
  30초)로 둔다.
- `tests/unit/test-timeout-declarations.test.ts`가 tests/의 Vitest 파일을
  Babel로 읽어 시험·describe·hook의 timeout 인자가 helper 호출(또는 그것을
  담은 파일 상수)이 아니면 파일과 줄로 실패한다. 프로세스 안에서 도는 긴
  시험(scale tier)도 같은 helper를 쓴다.
- taxonomy 예시, testing.md 2절, `.claude/rules/tests.md` 9번, helper 머리
  주석을 같은 방법으로 맞춘다.

버린 대안:
- `tests/setup.ts` 검사를 「helper가 만든 값이 아닌 timeout」까지 넓히기.
  helper 값은 30초 단위 숫자라 손으로 쓴 60_000과 가릴 수 없고, hook과
  프로세스 안 시험은 보지 못한다.
- 프로세스 안 시험은 손 숫자 그대로 두기. 근거 없는 숫자가 남고 검사가
  예외를 가져야 한다.

위험·한계:
- 값이 커진 곳이 있다(15배 규칙): `manual-code-blocks` 300초 → 900초,
  provider 묶음 30초 → 480초 등. hang을 늦게 잡는다. 줄어든 곳도 있다
  (scale traffic 60초 → 30초 등, 잰 값의 15배 안).
- 측정은 desktop 부하 6~35에서 했다. runner가 더 느리면 다시 잰다.
- 검사 시험은 Vitest 파일 전부를 파싱해 coverage 묶음에서 최대 13.5초
  걸렸고, 그 값으로 자기 timeout을 준다. 이름 있는 함수를 콜백으로 넘긴
  시험(`it("x", run, 30_000)`)은 못 찾는다.
- 다운스트림: 손 숫자 timeout이 있는 제품 시험은 test:unit에서 이 검사에
  걸린다. 메시지가 helper를 알린다.

검증(desktop):
- RED: 검사 시험이 고치기 전 80곳을 파일·줄로 내고 실패. GREEN: 검사·
  child-process-timeout 6개 통과. check:types·eslint(바뀐 34파일) rc=0,
  verify:documentation PASS_SCOPED, 노트북 `scripts/verify.sh docs` OK.
- 측정 원자료: /tmp/claude-gates/w2fe2-t08m, -t08m2, -t08m3.
- 게이트 결과는 PR 본문에 적는다.

Refs: 1112/03-08
2026-11-13 06:47:02 +09:00

174 lines
7.9 KiB
TypeScript

import { spawnSync } from "node:child_process";
import { createHash } from "node:crypto";
import { mkdtemp, readFile, rm } from "node:fs/promises";
import { tmpdir } from "node:os";
import path from "node:path";
import { afterAll, describe, expect, it } from "vitest";
import {
generateAppIndexes,
selectAppIndexes,
} from "../../scripts/generate-product-feature-index.ts";
import {
APP_A,
reachableSourceGraph,
writeFilesystemTopology,
writeSyntheticApps,
} from "./filesystem-topology.ts";
import { APP_CONTEXT_BUDGET, CONTEXT_FEATURE_BUDGET, SCALE_PROFILES } from "./scale-profile.ts";
import {
createSyntheticTopology,
declarationSource,
selectAppInputs,
} from "./synthetic-topology.ts";
import { childProcessTimeout } from "../helpers/child-process-timeout.ts";
/**
* scale-architecture.md §37. The central 1M architectural proof, on the production path.
*
* - S0-S2: real on-disk repositories, generated by the production command
* (`scripts/generate-product-feature-index.ts --app=`), whose discovery reads
* app/context/feature ownership declarations.
* - S3/S4: the same production selection (`selectAppIndexes`) over a
* declaration source that models 100k/1M logical features without writing
* them; an equivalence test pins that source to the filesystem one.
*/
const GENERATOR = path.resolve("scripts/generate-product-feature-index.ts");
const OUTPUTS = [
"src/.generated/product-feature-index.ts",
"src/.generated/product-context-index.ts",
"src/.generated/product-app.ts",
] as const;
const roots: string[] = [];
afterAll(async () => {
await Promise.all(roots.map((root) => rm(root, { recursive: true, force: true })));
});
async function productionBuildInputs(globalFeatures: number) {
const root = await mkdtemp(path.join(tmpdir(), `topology-${globalFeatures}-`));
roots.push(root);
const written = await writeFilesystemTopology(root, { globalFeatures });
const run = spawnSync(process.execPath, [GENERATOR, `--root=${root}`, `--app=${APP_A.id}`], {
encoding: "utf8",
});
if (run.status !== 0) throw new Error(`generator failed: ${run.stderr}`);
const generated = await Promise.all(
OUTPUTS.map((file) => readFile(path.join(root, file), "utf8")),
);
const graph = await reachableSourceGraph(root, OUTPUTS);
return { written, generated, graph };
}
describe("global-to-local independence on the production generator path", () => {
it(
"keeps App A's generated indexes and reachable source graph identical from S0 to S2 on disk",
async () => {
const s0 = await productionBuildInputs(SCALE_PROFILES.S0);
const s1 = await productionBuildInputs(SCALE_PROFILES.S1);
const s2 = await productionBuildInputs(SCALE_PROFILES.S2);
expect(s2.written.features).toBe(SCALE_PROFILES.S2);
expect(s2.written.apps).toBeGreaterThan(s0.written.apps);
expect(s1.generated).toEqual(s0.generated);
expect(s2.generated).toEqual(s0.generated);
expect(s2.graph).toEqual(s0.graph);
const hash = (texts: readonly string[]) =>
texts.map((text) => createHash("sha256").update(text).digest("hex"));
expect(hash(s2.generated)).toEqual(hash(s0.generated));
const localFeatures = APP_A.contexts * APP_A.featuresPerContext;
// Generated indexes + (feature-module, context-routes, page) per local feature.
expect(s2.graph).toHaveLength(OUTPUTS.length + localFeatures * 3);
expect(s2.graph.some((file) => file.includes("other-"))).toBe(false);
expect(s2.generated[1]?.match(/defineBoundedContextModule\(\{/gu)).toHaveLength(APP_A.contexts);
},
childProcessTimeout(8_959),
);
it("selects another app from the same repository without App A's features", async () => {
const root = await mkdtemp(path.join(tmpdir(), "topology-select-"));
roots.push(root);
await writeFilesystemTopology(root, { globalFeatures: 1_100 });
const other = await generateAppIndexes(root, "other-0");
expect(other.app.id).toBe("other-0");
expect(other.entries.every((entry) => entry.contextId.startsWith("other-0-"))).toBe(true);
await expect(generateAppIndexes(root, undefined)).rejects.toThrow(/Select a deployable app/);
await expect(generateAppIndexes(root, "missing")).rejects.toThrow(/Unknown deployable app/);
});
it("produces the same output from the filesystem source and the S3/S4 declaration source", async () => {
const topology = createSyntheticTopology({ globalFeatures: SCALE_PROFILES.S0 * 3 });
const root = await mkdtemp(path.join(tmpdir(), "topology-equivalence-"));
roots.push(root);
await writeSyntheticApps(
root,
["app-0", "app-1", "app-2"].map((id) => ({
id,
maxContexts: APP_CONTEXT_BUDGET,
contexts: topology.app(id).contexts.map((context) => ({
...context,
maxFeatures: CONTEXT_FEATURE_BUDGET,
})),
})),
);
const fromDisk = await generateAppIndexes(root, "app-0");
const fromModel = selectAppIndexes(declarationSource(topology), "app-0");
expect(fromModel.featureIndex).toBe(fromDisk.featureIndex);
expect(fromModel.contextIndex).toBe(fromDisk.contextIndex);
expect(fromModel.appIndex).toBe(fromDisk.appIndex);
});
it("keeps one unchanged app's production indexes identical from S0 to S4", () => {
const s0 = selectAppInputs(createSyntheticTopology({ globalFeatures: SCALE_PROFILES.S0 }), "app-0");
for (const globalFeatures of Object.values(SCALE_PROFILES)) {
const current = selectAppInputs(createSyntheticTopology({ globalFeatures }), "app-0");
expect(current.contextIds).toEqual(s0.contextIds);
expect(current.featureIds).toEqual(s0.featureIds);
expect(current.routeRootIds).toEqual(s0.routeRootIds);
expect(current.generatedFeatureIndex).toBe(s0.generatedFeatureIndex);
expect(current.generatedContextIndex).toBe(s0.generatedContextIndex);
expect(current.generatedAppIndex).toBe(s0.generatedAppIndex);
expect(current.generatedHashes).toEqual(s0.generatedHashes);
expect(current.compileInputPaths).toEqual(s0.compileInputPaths);
}
// The compile input is App A's own modules only: one feature module and
// one lazy route module per local feature, plus the context descriptor.
const featureOwned = s0.compileInputPaths.filter((file) => /^src\/features\/[^/]+\//u.test(file));
expect(featureOwned).toHaveLength(s0.featureIds.length * 2);
expect(featureOwned.every((file) => file.startsWith("src/features/app0-"))).toBe(true);
});
it("reads only the selected app's declarations, even at 1,000,000 logical features", () => {
const inputs = selectAppInputs(
createSyntheticTopology({ globalFeatures: SCALE_PROFILES.S4 }),
"app-0",
);
expect(inputs.reads.apps).toBe(1);
expect(inputs.reads.contexts).toBe(inputs.contextIds.length);
expect(inputs.reads.features).toBe(inputs.featureIds.length);
expect(inputs.featureIds.length).toBeLessThan(SCALE_PROFILES.S0 + 1);
});
it("boots only direct context roots, never the global feature table", () => {
const inputs = selectAppInputs(
createSyntheticTopology({ globalFeatures: SCALE_PROFILES.S4 }),
"app-0",
);
expect(inputs.routeRootIds.length).toBe(inputs.contextIds.length);
expect(inputs.routeRootIds.length).toBeLessThanOrEqual(inputs.contextBudget);
// Feature executables sit behind the lazy context loader, not in boot imports.
expect(inputs.generatedContextIndex).toContain("async loadRoutes()");
expect(inputs.generatedContextIndex).toMatch(/import\("\.\.\/features\//u);
});
it("keeps an app deep in the S4 topology within the same local shape", () => {
const topology = createSyntheticTopology({ globalFeatures: SCALE_PROFILES.S4 });
const first = selectAppInputs(topology, "app-0");
const last = selectAppInputs(topology, `app-${topology.appCount - 1}`);
expect(last.featureIds.length).toBe(first.featureIds.length);
expect(last.contextIds.length).toBe(first.contextIds.length);
});
});