DongHyeonkaandClaude Opus 5
250531aa43
Four fixtures linked the installed dependencies into a throwaway root with a single directory symlink at <fixture>/node_modules, then ran pnpm inside that root. pnpm does not recognise the modules directory it finds there and purges it; with CI=true it does so without a prompt. The purge followed the symlink and deleted the repository's own node_modules mid-run, so a test suite uninstalled the workspace it was running in. That is what produced the cascading, file-unrelated failures a full test:unit run reported, and it happened twice while running the suites for the adapter re-review. scripts/lib/fixture-node-modules.ts replaces all four sites: node_modules is a real directory whose entries are individual symlinks, so a recursive delete unlinks the fixture's own links instead of walking through one link into the shared tree. Resolution is unchanged. tests/unit/fixture-node-modules.test.ts performs the exact recursive delete pnpm performs and asserts the source tree survives, and check:adapter-inventory now fails on any reintroduction of the directory-symlink form — verified by putting the old line back and watching the gate reject it. A full tests/unit + tests/integration run now leaves the dependencies intact. removal-fixture, supply-chain and security-followup-archive, the three suites that had to be excluded before, pass in that run. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
32 lines
1.3 KiB
TypeScript
32 lines
1.3 KiB
TypeScript
import { lstat, mkdir, readdir, symlink } from "node:fs/promises";
|
|
import path from "node:path";
|
|
|
|
/**
|
|
* Links the repository's installed dependencies into a throwaway fixture root.
|
|
*
|
|
* The obvious form — one directory symlink at `<fixture>/node_modules` — is
|
|
* destructive. A fixture runs `pnpm` inside itself, pnpm does not recognise the
|
|
* modules directory it finds there, and its purge follows the symlink and
|
|
* deletes the *repository's* real dependencies mid-run. With `CI=true` that
|
|
* happens without a prompt, so a test suite silently uninstalls the workspace
|
|
* it is running in.
|
|
*
|
|
* `node_modules` is therefore a real directory here, and every entry inside it
|
|
* is an individual symlink. Package resolution is unchanged, but a recursive
|
|
* delete unlinks the fixture's own symlinks instead of walking through one link
|
|
* into the shared tree.
|
|
*/
|
|
export async function linkFixtureNodeModules(
|
|
fixtureRoot: string,
|
|
sourceRoot: string = process.cwd(),
|
|
): Promise<void> {
|
|
const source = path.join(sourceRoot, "node_modules");
|
|
const target = path.join(fixtureRoot, "node_modules");
|
|
await mkdir(target, { recursive: true });
|
|
for (const entry of await readdir(source)) {
|
|
const from = path.join(source, entry);
|
|
const stats = await lstat(from);
|
|
await symlink(from, path.join(target, entry), stats.isDirectory() ? "dir" : "file");
|
|
}
|
|
}
|