Files
clean-architecture-frontend…/scripts/test-feature-scaffold.ts
DongHyeonka 2e4595e2ff fix(scaffold): 기능 생성 드릴이 생성 뒤 초기 JS 기록을 다시 쓴다
문제
test:feature-scaffold(12-02)는 기능 둘을 생성한 fixture에서 merge 단계
명령을 돈다. 15-02의 test:unit은 초기 JS 기록
(config/scale/feature-shape-ceilings.json)을 빌드와 대조한다. 두 브랜치를
합치자 드릴 안의 test:unit·test:coverage가 "initialJavascript is stale"로
실패해 FE-GATE-020이 떨어진다. 제품은 생성 명령 Next: 3번대로 기록을 다시
쓰지만 드릴은 그 단계를 하지 않았다.

고른 방법
- 생성이 성공하면 fixture를 봉인하기 전에 measure-feature-shape-growth.ts
  --initial-baseline --write를 돌린다. 측정 스크립트가 없으면(샘플이 없으면)
  건너뛴다. 결과는 별도 검사(initial-javascript-record)로 보고한다.

위험·한계
- 드릴이 빌드 한 번만큼 길어진다.

검증
- check:types, eslint 통과. FE-GATE-020은 깨끗한 clone에서 다시 돈다.

Refs: docs/reviews/2026-11-03-maturity-review/12-guardrails-ci.md 12-02, 15-performance.md 15-02
2026-11-05 02:22:27 +09:00

122 lines
5.0 KiB
TypeScript

import { spawnSync } from "node:child_process";
import { existsSync } from "node:fs";
import { mkdir, rm, writeFile } from "node:fs/promises";
import path from "node:path";
import { loadCiGateContract } from "./contracts/ci-gates.ts";
import {
runScaffoldDrillCommand,
scaffoldDrillCommands,
} from "./lib/feature-scaffold-drill.ts";
import {
createRemovalFixtureRoot,
prepareRemovalFixture,
REMOVAL_FIXTURE_COPY_TARGETS,
REMOVAL_FIXTURE_DOCUMENT_TARGETS,
renderRemovalJunit,
requireRemovalFixtureEnvironment,
runRemovalFixtureCheck,
sealRemovalFixtureRepository,
type RemovalCheck,
} from "./lib/removal-fixture.ts";
/**
* U7. A feature from `create:feature` passes the merge gates without an edit
* and breaks no other test. A copy of the repository, sample feature
* included, gets a default feature and a `--with-create --keyed` one, then
* runs the merge stage of its
* config/ci/gates.json: every command except those
* SCAFFOLD_DRILL_EXCLUDED_SCRIPTS names with a reason (the browser gates,
* test:system, the install check and the removal drills). 1103/12-02: this
* used to be a hand-kept list of 15 commands.
*
* 1103/16-02. The generated feature is then removed again with
* `test:sample-removal -- --feature=<id>`, the path the manual tells every
* product feature to take and that no gate ran.
*
* test:sample-removal repeats the generation after deleting the sample
* (decision 4), which proves the command needs nothing from it.
*/
const FEATURE_ID = "scaffold-feature";
/** 1103/09-06. The `--with-create --keyed` slice, in its own context. */
const WRITE_FEATURE_ID = "scaffold-write-feature";
const REPORT = "artifacts/tests/feature-scaffold.xml";
const pnpmCli = requireRemovalFixtureEnvironment("npm_execpath");
const fixtureRoot = await createRemovalFixtureRoot("feature-scaffold");
function fixtureCommit(root: string): string {
const head = spawnSync("git", ["rev-parse", "HEAD"], { cwd: root, encoding: "utf8" });
if (head.status !== 0) throw new Error(`feature scaffold fixture has no commit: ${head.stderr}`);
return head.stdout.trim();
}
function check(name: string, script: string, extra: readonly string[] = []): RemovalCheck {
return runRemovalFixtureCheck(name, fixtureRoot, pnpmCli, script, extra);
}
try {
// verify:documentation and the documentation tests read these.
await prepareRemovalFixture(fixtureRoot, [
...REMOVAL_FIXTURE_COPY_TARGETS,
...REMOVAL_FIXTURE_DOCUMENT_TARGETS,
]);
const created = check("create-feature", "create:feature", [FEATURE_ID]);
const createdWrite = check("create-feature-write", "create:feature", [
WRITE_FEATURE_ID,
"--with-create",
"--keyed",
]);
const checks: RemovalCheck[] = [created, createdWrite];
if (created.passed && createdWrite.passed) {
// The generator's Next: 3. A project re-records the initial JavaScript
// with its features (config/scale/feature-shape-ceilings.json, which
// test:unit compares with a build) and commits it with them. Without the
// sample there is no record to keep.
const measurement = "scripts/scale/measure-feature-shape-growth.ts";
if (existsSync(path.join(fixtureRoot, measurement))) {
const recorded = spawnSync(process.execPath, [measurement, "--initial-baseline", "--write"], {
cwd: fixtureRoot,
stdio: "inherit",
}).status;
checks.push(
recorded === 0
? { name: "initial-javascript-record", passed: true }
: {
name: "initial-javascript-record",
passed: false,
failure: `node ${measurement} --initial-baseline --write exited ${recorded ?? "on a signal"}`,
},
);
}
// Commits the copy with the feature, as a project would: git-based
// checks (git grep, git ls-files) then see the feature's files.
sealRemovalFixtureRepository(fixtureRoot);
// build:release-candidate records the build's commit and refuses one that
// is not a commit ID. CI sets VITE_COMMIT_SHA for the whole workflow; a
// local run gets the copy's own sealed commit instead of "local".
if (!process.env["VITE_COMMIT_SHA"]?.trim()) {
process.env["VITE_COMMIT_SHA"] = fixtureCommit(fixtureRoot);
}
for (const command of scaffoldDrillCommands(await loadCiGateContract(fixtureRoot))) {
checks.push(runScaffoldDrillCommand(command, fixtureRoot, pnpmCli));
}
checks.push(check("feature-removal", "test:sample-removal", ["--", `--feature=${FEATURE_ID}`]));
}
const failed = checks.filter((entry) => !entry.passed);
await mkdir("artifacts/tests", { recursive: true });
await writeFile(REPORT, renderRemovalJunit("feature-scaffold", checks));
if (failed.length > 0) {
process.stderr.write(
`feature scaffold failed:\n${failed
.map((entry) => ` ${entry.name}: ${entry.failure ?? "failed"}`)
.join("\n")}\n`,
);
process.exitCode = 1;
} else {
process.stdout.write(`feature scaffold: PASS (${checks.length} checks)\n`);
}
} finally {
await rm(fixtureRoot, { recursive: true, force: true });
}