Files
clean-architecture-frontend…/tests/e2e/support/fixture-builds.ts
DongHyeonka b693600103 fix(ci): 테스트가 만드는 로컬 빌드는 CI=true에서도 release 빌드로 검사되지 않는다
문제
workflow는 모든 job에 CI=true와 CI 빌드 식별값을 준다. 메인 세션이 깨끗한
clone에서 그 env 그대로(CI=true 포함) merge 단계 14개를 돌리자 FE-GATE-005·
008·020이 실패했다.
- vitest 안의 fixture 빌드(tests/e2e/support/fixture-builds.ts →
  build-frontend.ts)가 CI=true를 물려받아 release 빌드처럼 검사된다.
  af312de가 vitest에서 VITE_COMMIT_SHA를 지워 "missing required CI build
  environment: VITE_COMMIT_SHA"로 멈춘다(service-worker-build-output 7건이
  돌지 않음, 제거 드릴 안에서도 같다).
- 시각 골든 build(9bddfa5)가 VITE_COMMIT_SHA="local"을 받는데 CI=true가
  40·64자리 hex를 요구해 webServer가 뜨지 않는다.
내 X4가 CI=true 없이 돌아 놓쳤다. 1103/11-07과 같은 원인이다.

고른 방법
- scripts/lib/build-environment.ts에 둘을 둔다.
  - localBuildEnvironment(env): spawn하는 로컬 빌드용. CI와 CI 빌드 식별값을
    뺀 사본. fixture-builds.ts, service-worker-builds.ts가 쓴다.
  - LOCAL_BUILD_IDENTITY: Playwright web server용. Playwright가 env를
    process.env 위에 합치므로 CI를 지우지 않고 ""로 덮는다(검사는
    CI === "true"일 때만). visual·capabilities·dev 설정이 쓴다.
- assertCiBuildEnvironment의 CI=true 검사는 그대로다. job 자신의 release
  빌드(build:release-candidate 등)는 계속 검사된다.
- 버린 대안: 로컬 빌드에 유효한 가짜 커밋 id(0×40)를 주기. CI=true 검사의
  다른 칸(CI_RUNNER_IMAGE, SOURCE_DATE_EPOCH)도 함께 맞춰야 하고, 로컬
  빌드가 release 빌드인 척한다.

위험·한계
- 로컬 빌드 안에서 CI를 읽어 동작을 바꾸는 코드가 있으면 그 빌드는 이제
  CI가 아닌 쪽으로 돈다(지금은 build-environment 검사뿐이다).

검증
- tests/unit/local-build-environment.test.ts 3건: 구현 전 2건 실패(RED),
  CI job 자체 검사는 유지.
- CI=true·VITE_COMMIT_SHA·VITE_BUILD_ID=gitea-41-1·RELEASE_ID·
  CI_RUNNER_IMAGE·SOURCE_DATE_EPOCH로: service-worker-build-output 7건,
  test:visual 6/6, test:unit 2,883, test:component 270, test:integration 189
  통과. 수정 전 service-worker-build-output은 7건 미실행.
- check:types, lint 통과.

Refs: docs/reviews/2026-11-03-maturity-review/README.md 13절 11-08
2026-11-05 04:26:44 +09:00

107 lines
3.4 KiB
TypeScript

import { spawnSync } from "node:child_process";
import { cp, mkdtemp, readFile, rename, rm, writeFile } from "node:fs/promises";
import { tmpdir } from "node:os";
import path from "node:path";
import { localBuildEnvironment } from "../../../scripts/lib/build-environment.ts";
import { linkFixtureNodeModules } from "../../../scripts/lib/fixture-node-modules.ts";
/**
* Real production builds of an edited temp copy of the repository, in the
* template's default configuration (`serviceWorker: null`). `edit` changes the
* copy right before that build runs, and edits persist into later builds. The
* working tree and its `dist` (served by the e2e preview server) are never
* touched. Serve the result with `startBuildServer` from
* `service-worker-builds.ts`.
*/
const repoRoot = path.resolve(import.meta.dirname, "../../..");
const skipped = new Set([
"node_modules",
".git",
".claude",
".generated",
".tmp",
"dist",
"artifacts",
"graphify-out",
]);
export type FixtureBuild<Name extends string> = Readonly<{
name: Name;
edit?: (root: string) => Promise<void>;
/** Extra build variables for this build only (e.g. `APP_PROFILE`). */
env?: Readonly<Record<string, string>>;
}>;
export type FixtureBuilds<Name extends string> = Readonly<{
root: string;
dist: Readonly<Record<Name, string>>;
}>;
/** Replaces the one occurrence of `search` in `file` of the copy. */
export async function editOnce(
file: string,
search: string,
replacement: string,
): Promise<void> {
const source = await readFile(file, "utf8");
if (source.split(search).length !== 2) {
throw new Error(`Expected exactly one "${search}" in ${file}.`);
}
await writeFile(file, source.replace(search, replacement));
}
function run(
cwd: string,
script: string,
buildId: string,
env: Readonly<Record<string, string>> = {},
): void {
const result = spawnSync("node", [script], {
cwd,
encoding: "utf8",
// 1103/11-08. A local build, not the CI job's release build.
env: { ...localBuildEnvironment(), ...env, VITE_BUILD_ID: buildId, RELEASE_ID: buildId },
});
if (result.status !== 0) {
throw new Error(
`${script} failed for ${buildId}:\n${result.stdout}\n${result.stderr}`,
);
}
}
export async function prepareFixtureBuilds<Name extends string>(
prefix: string,
builds: readonly FixtureBuild<Name>[],
): Promise<FixtureBuilds<Name>> {
const root = await mkdtemp(path.join(tmpdir(), `${prefix}-`));
try {
await cp(repoRoot, root, {
recursive: true,
filter: (source) =>
!skipped.has(path.relative(repoRoot, source).split(path.sep)[0]!),
});
await linkFixtureNodeModules(root, repoRoot);
const dist = {} as Record<Name, string>;
for (const build of builds) {
await build.edit?.(root);
const buildId = `${prefix}-${build.name}`;
run(root, "scripts/generate-product-feature-index.ts", buildId, build.env);
run(root, "scripts/build-frontend.ts", buildId, build.env);
dist[build.name] = path.join(root, `dist-${build.name}`);
await rename(path.join(root, "dist"), dist[build.name]);
}
return { root, dist };
} catch (error) {
await rm(root, { recursive: true, force: true });
throw error;
}
}
export async function removeFixtureBuilds(
builds: Readonly<{ root: string }> | undefined,
): Promise<void> {
if (builds) await rm(builds.root, { recursive: true, force: true });
}