Files
clean-architecture-frontend…/scripts/check-system-test-prerequisites.ts
DongHyeonka 9ebd0856a1
frontend-quality-gates / FE-GATE-022 / runbook-chunk-mismatch (pull_request) Canceled after 0s
frontend-quality-gates / FE-GATE-018 / field-web-vitals (pull_request) Canceled after 0s
frontend-quality-gates / FE-GATE-017 / diagram-review (pull_request) Canceled after 0s
frontend-quality-gates / main / self-tests and removal drills (pull_request) Canceled after 0s
frontend-quality-gates / merge / static checks (pull_request) Canceled after 0s
frontend-quality-gates / merge / tests (pull_request) Canceled after 0s
frontend-quality-gates / merge / browser tests (pull_request) Canceled after 0s
frontend-quality-gates / FE-GATE-014 / config-compatibility (pull_request) Canceled after 0s
frontend-quality-gates / FE-GATE-026 / lab-performance (pull_request) Canceled after 0s
frontend-quality-gates / FE-GATE-028 / manual-accessibility-review (pull_request) Canceled after 0s
frontend-quality-gates / FE-GATE-015 / immutable-release-candidate (pull_request) Canceled after 0s
frontend-quality-gates / external-vulnerability-provider (pull_request) Canceled after 0s
frontend-quality-gates / external-provenance-provider (pull_request) Canceled after 0s
frontend-quality-gates / promote-verified-immutable-candidate (pull_request) Canceled after 0s
frontend-quality-gates / deploy-promoted-release (pull_request) Canceled after 0s
frontend-quality-gates / FE-GATE-019 / hosting-header (pull_request) Canceled after 0s
frontend-quality-gates / FE-GATE-021 / runbook-boot-config (pull_request) Canceled after 0s
frontend-quality-gates / FE-GATE-023 / runbook-api-degradation (pull_request) Canceled after 0s
frontend-quality-gates / FE-GATE-024 / runbook-telemetry (pull_request) Canceled after 0s
frontend-quality-gates / FE-GATE-025 / runbook-release-rollback (pull_request) Canceled after 0s
fix(ci): provider job에 sandbox runner 요구를 적고 시작 때 namespace를 점검한다
문제: release의 provider job 둘(vulnerability·provenance)은 FE-GATE-013과
같은 provider sandbox(systemd-run scope, bwrap --unshare-pid/ipc/uts/net)를
돈다. 그런데 생성 workflow의 runner 요구 주석은 게이트의
hostRequirements에서 나와 merge_test에만 붙고, provider job에는 없다.
provider 감독 스크립트의 시작 점검도 실행 파일이 있는지만 봐서, 비특권
user namespace를 막는 runner에서는 나중에 bwrap 원문 오류로 끝난다.

고른 방법:
- 계약 job에 선택 칸 `hostRequirements`를 두고 provider job 둘에
  FE-GATE-013과 같은 요구를 적는다. 계약이 provider job의 요구가
  FE-GATE-013과 같은지 보고(갈라지면 거절), provider 밖 job은 이 칸을 못
  쓴다. 생성기가 그 job의 runs-on 옆에 주석을 쓴다.
- `check-system-test-prerequisites.ts`에서 namespace 점검만 함수로 내보내고
  (`findProviderSandboxNamespaceFailure`), `run-and-validate-provider.ts`가
  provider를 띄우기 전에 부른다. 실패하면 test:system 사전 점검과 같은
  문구(제한 이름, bwrap stderr, host 설정, 고치는 법)로 멈춘다.
- 버린 대안: 생성기가 hostEnvironment 게이트의 요구를 provider job에
  저절로 붙이기. 연결이 계약에 보이지 않는다.

위험·한계: provider job은 release 단계라 PR run에서 돌지 않는다. 새
점검은 desktop FE-GATE-013의 provider 시스템 시험(감독 스크립트를 실제로
띄움)으로 본다. 「provider 없이 배포할 때」 문서 절은 소유자 결정이라
이 커밋에 없다.

검증(desktop): 구현을 main으로 되돌리고 새 시험만 둔 상태에서 4개 실패
(RED), 고친 뒤 system-test-prerequisites·ci-workflow-generation 445개 통과,
generate:ci-workflow·스냅샷 갱신, check:ci·check:types·eslint rc=0,
verify:documentation PASS_SCOPED. desktop `scripts/verify.sh gate FE-GATE-013`
rc=0 226초(시스템 컨테이너, system 시험 115개 통과 — provider 감독
스크립트를 실제로 띄워 새 점검을 거친다). 로그 /tmp/claude-gates/w2fe2-prov1/,
w2fe2-prov013/.

Refs: 1101/13-03
2026-11-13 05:02:16 +09:00

165 lines
6.3 KiB
TypeScript

import { constants } from "node:fs";
import { access, readFile } from "node:fs/promises";
import { spawnSync } from "node:child_process";
import path from "node:path";
import { fileURLToPath } from "node:url";
import { PROVIDER_SANDBOX_NAMESPACE_ARGUMENTS } from "./lib/provider-sandbox-namespaces.ts";
/** What the check reads from the host; a test passes a fake. */
export type SystemTestHost = Readonly<{
/** Resolves when `target` is executable, rejects otherwise. */
access(target: string): Promise<void>;
readFile(target: string): Promise<string>;
spawn(
command: string,
args: readonly string[],
timeoutMs: number,
): Readonly<{ status: number | null; stderr: string; error?: Error | undefined }>;
}>;
export const nodeSystemTestHost: SystemTestHost = Object.freeze({
access: async (target: string) => access(target, constants.X_OK),
readFile: async (target: string) => readFile(target, "utf8"),
spawn: (command: string, args: readonly string[], timeoutMs: number) => {
const result = spawnSync(command, [...args], { encoding: "utf8", timeout: timeoutMs });
return { status: result.status, stderr: result.stderr ?? "", error: result.error };
},
});
const BWRAP = "/usr/bin/bwrap";
const SYSTEMCTL = "/usr/bin/systemctl";
/**
* 1105/12-01. The provider sandbox's own namespace options on /bin/true. The
* check used to see only that /usr/bin/bwrap was executable, so a host that
* refuses unprivileged user namespaces passed it and then failed 18 provider
* tests with `bwrap: loopback: Failed RTM_NEWADDR: Operation not permitted`.
*/
export const NAMESPACE_PROBE_ARGUMENTS: readonly string[] = Object.freeze([
...PROVIDER_SANDBOX_NAMESPACE_ARGUMENTS,
"--ro-bind", "/", "/",
"--", "/bin/true",
]);
/** Host settings that decide whether an unprivileged process may create user namespaces. */
const USER_NAMESPACE_SETTINGS = Object.freeze([
["kernel.apparmor_restrict_unprivileged_userns", "/proc/sys/kernel/apparmor_restrict_unprivileged_userns"],
["kernel.unprivileged_userns_clone", "/proc/sys/kernel/unprivileged_userns_clone"],
["user.max_user_namespaces", "/proc/sys/user/max_user_namespaces"],
] as const);
const PROBE_TIMEOUT_MS = 5_000;
const MAX_REPORTED_STDERR_LINES = 4;
export async function findSystemTestPrerequisiteFailures(
host: SystemTestHost = nodeSystemTestHost,
): Promise<string[]> {
const failures: string[] = [];
const executable = new Map<string, boolean>();
for (const [target, label] of [
[BWRAP, "bubblewrap"],
[SYSTEMCTL, "systemctl"],
["/usr/bin/tar", "tar"],
] as const) {
try {
await host.access(target);
executable.set(target, true);
} catch {
executable.set(target, false);
failures.push(`${label} is required at ${target}`);
}
}
try {
const controllers = await host.readFile("/sys/fs/cgroup/cgroup.controllers");
if (controllers.trim().length === 0) {
failures.push("cgroup v2 controllers are unavailable");
}
} catch {
failures.push("cgroup v2 is required at /sys/fs/cgroup/cgroup.controllers");
}
if (executable.get(SYSTEMCTL)) {
const probe = host.spawn(SYSTEMCTL, ["show-environment"], 3_000);
if (probe.error || probe.status !== 0) {
failures.push("a reachable systemd manager bus is required");
}
}
if (executable.get(BWRAP)) {
const failure = await findProviderSandboxNamespaceFailure(host);
if (failure !== undefined) failures.push(failure);
}
return failures;
}
/**
* 1101/13-03. Whether this host lets the provider sandbox create its
* namespaces, and if not, why and what to do. The release provider jobs run
* it before the provider (scripts/run-and-validate-provider.ts).
*/
export async function findProviderSandboxNamespaceFailure(
host: SystemTestHost = nodeSystemTestHost,
): Promise<string | undefined> {
const probe = host.spawn(BWRAP, NAMESPACE_PROBE_ARGUMENTS, PROBE_TIMEOUT_MS);
return probe.error || probe.status !== 0 ? namespaceFailure(host, probe) : undefined;
}
async function namespaceFailure(
host: SystemTestHost,
probe: ReturnType<SystemTestHost["spawn"]>,
): Promise<string> {
const settings: string[] = [];
for (const [name, file] of USER_NAMESPACE_SETTINGS) {
try {
settings.push(`${name} = ${(await host.readFile(file)).trim()}`);
} catch {
// Absent on this kernel; the others still say what the host allows.
}
}
const stderr = probe.stderr
.split("\n")
.map((line) => line.trim())
.filter((line) => line.length > 0)
.slice(0, MAX_REPORTED_STDERR_LINES);
const outcome = probe.error
? `did not finish: ${probe.error.message}`
: `exited ${String(probe.status)}`;
return [
"this host does not allow unprivileged user and network namespaces, which the provider " +
`sandbox needs (bwrap ${PROVIDER_SANDBOX_NAMESPACE_ARGUMENTS.join(" ")}).`,
` probe: ${BWRAP} ${NAMESPACE_PROBE_ARGUMENTS.join(" ")} ${outcome}`,
...(stderr.length > 0 ? stderr.map((line) => ` bwrap stderr: ${line}`) : [" bwrap stderr: (empty)"]),
...(settings.length > 0 ? [` host settings: ${settings.join(", ")}`] : []),
" To fix, do one of these:",
" - give /usr/bin/bwrap an AppArmor profile that allows `userns` (Ubuntu 23.10 and later),",
" - on a host you own, set sysctl kernel.apparmor_restrict_unprivileged_userns=0",
" (or kernel.unprivileged_userns_clone=1 where that setting exists),",
" - run FE-GATE-013 on another runner that allows them.",
" Runner requirements: docs/operations/ci-quality-gates.md.",
].join("\n");
}
export function formatSystemTestPrerequisiteReport(failures: readonly string[]): string {
return [
"System/CI-runner test prerequisites are unavailable:",
...failures.map((failure) => ` - ${failure}`),
"",
"Run test:unit/test:contract/test:component/test:integration for the",
"developer loop. test:system is intentionally reserved for a compatible",
"Linux CI-runner host.",
"",
].join("\n");
}
const isCli = process.argv[1] !== undefined && path.resolve(process.argv[1]) === fileURLToPath(import.meta.url);
if (isCli) {
const failures = await findSystemTestPrerequisiteFailures();
if (failures.length > 0) {
process.stderr.write(formatSystemTestPrerequisiteReport(failures));
process.exit(1);
}
process.stdout.write("System test prerequisites: PASS\n");
}