The signed review is per release candidate, so the merge gate could never pass. FE-GATE-009 now checks only the record format; the checked-in records are source-controlled evidence, not command output. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
106 lines
3.8 KiB
TypeScript
106 lines
3.8 KiB
TypeScript
import { describe, expect, it } from "vitest";
|
|
|
|
import { readFileSync } from "node:fs";
|
|
|
|
import {
|
|
MANUAL_A11Y_ROUTE_IDS,
|
|
validateManualA11yEvidence,
|
|
validateManualA11yRecordFormat,
|
|
} from "../../scripts/lib/manual-a11y-evidence.ts";
|
|
import { ROUTE_REGISTRY } from "../../src/features/installed-feature-contracts.ts";
|
|
|
|
const reviewed = `Status: reviewed
|
|
Route ID: APP_HOME
|
|
Release ID: release-1
|
|
Reviewer: reviewer@example.test
|
|
Reviewed at: 2026-07-25T12:00:00Z
|
|
Signature: review-record-1
|
|
Attestation: accepted
|
|
M1 Keyboard: pass
|
|
M2 Visible focus: pass
|
|
M3 Route focus: pass
|
|
M4 Modal focus: not-applicable (no modal)
|
|
M5 Error association: not-applicable (no form error)
|
|
M6 Color signal: pass
|
|
M7 Reduced motion: pass
|
|
Screen reader: pass
|
|
Notes: no defects`;
|
|
|
|
describe("manual accessibility evidence", () => {
|
|
it("requires evidence for every registered user-visible route", () => {
|
|
expect([...MANUAL_A11Y_ROUTE_IDS].sort()).toEqual(
|
|
Object.keys(ROUTE_REGISTRY).sort(),
|
|
);
|
|
});
|
|
|
|
it("accepts a complete signed human review record", () => {
|
|
expect(validateManualA11yEvidence(reviewed)).toMatchObject({
|
|
failures: [],
|
|
passed: true,
|
|
});
|
|
});
|
|
|
|
it("rejects pending, unsigned, or incomplete evidence", () => {
|
|
expect(
|
|
validateManualA11yEvidence(
|
|
reviewed
|
|
.replace("Status: reviewed", "Status: pending-manual-review")
|
|
.replace("Signature: review-record-1", "Signature:")
|
|
.replace("Screen reader: pass", "Screen reader: pending"),
|
|
),
|
|
).toMatchObject({
|
|
failures: ["Status", "Signature", "Screen reader"],
|
|
passed: false,
|
|
});
|
|
});
|
|
|
|
it("does not treat an unexplained not-applicable verdict as evidence", () => {
|
|
expect(
|
|
validateManualA11yEvidence(
|
|
reviewed.replace(
|
|
"M4 Modal focus: not-applicable (no modal)",
|
|
"M4 Modal focus: not-applicable",
|
|
),
|
|
),
|
|
).toMatchObject({
|
|
failures: ["M4 Modal focus"],
|
|
passed: false,
|
|
});
|
|
});
|
|
|
|
// 08-06: the merge stage checks only that each record keeps the template's
|
|
// shape; the signed review itself is a release-stage gate (FE-GATE-028).
|
|
describe("record format", () => {
|
|
const pending = reviewed
|
|
.replace("Status: reviewed", "Status: pending-manual-review")
|
|
.replace("Release ID: release-1", "Release ID:")
|
|
.replace("Reviewer: reviewer@example.test", "Reviewer:")
|
|
.replace("Reviewed at: 2026-07-25T12:00:00Z", "Reviewed at:")
|
|
.replace("Signature: review-record-1", "Signature:")
|
|
.replace("Attestation: accepted", "Attestation: pending")
|
|
.replace("M1 Keyboard: pass", "M1 Keyboard: pending");
|
|
|
|
it("accepts a pending template and a signed record", () => {
|
|
expect(validateManualA11yRecordFormat(pending, "APP_HOME")).toEqual([]);
|
|
expect(validateManualA11yRecordFormat(reviewed, "APP_HOME")).toEqual([]);
|
|
});
|
|
|
|
it("accepts every checked-in route record", () => {
|
|
for (const routeId of MANUAL_A11Y_ROUTE_IDS) {
|
|
const record = readFileSync(`artifacts/tests/a11y-manual/${routeId}.md`, "utf8");
|
|
expect(validateManualA11yRecordFormat(record, routeId), routeId).toEqual([]);
|
|
}
|
|
});
|
|
|
|
it.each([
|
|
["a missing field", pending.replace("Signature:\n", ""), "APP_HOME", "Signature"],
|
|
["an unknown status", pending.replace("Status: pending-manual-review", "Status: done"), "APP_HOME", "Status"],
|
|
["an unknown verdict", pending.replace("M1 Keyboard: pending", "M1 Keyboard: ok"), "APP_HOME", "M1 Keyboard"],
|
|
["another route's record", pending, "NOT_FOUND", "Route ID"],
|
|
["a reviewed record that is not complete", reviewed.replace("Signature: review-record-1", "Signature:"), "APP_HOME", "Signature"],
|
|
])("rejects %s", (_name, record, routeId, field) => {
|
|
expect(validateManualA11yRecordFormat(record, routeId)).toContain(field);
|
|
});
|
|
});
|
|
});
|