DongHyeonkaandClaude Opus 5
dfb7734674
The provider sandbox never ran. bubblewrap 0.9.0 stops parsing an `--args` file at the first non-option and never hands the remainder back, so the command written into that file was silently dropped: bwrap printed its usage text, exited 1, and the provider produced no evidence at all. The options still travel in the args file — that is what keeps host paths and credentials out of `/proc/<pid>/cmdline` — but the command now rides on real argv, and `encodeProviderBwrapInput` refuses a `--` so the drop cannot come back. The scope wrapper then could not exit. It read the supervisor's liveness pipe through `fs`, which runs a blocking `read(2)` on a threadpool thread; the supervisor holds that pipe open for the scope's whole life, so the read never returned and closing the descriptor did not interrupt it. Once bubblewrap finished the wrapper deadlocked in `process.exit`, the scope outlived the provider, and a completed run was reported as a timeout kill. The channel is now read through the event loop, so teardown is observable and terminal. Creation modes were left to the ambient umask. `mkdir(mode)` and `open(mode)` are requests the kernel subtracts the umask from, so a runner exporting a restrictive umask produced directories it could not enter and handed `tar` a file it could not re-open. Private modes are pinned instead of inherited. Promotion cleanup deleted before it checked. Removals run through a pinned descriptor, so a leaf substituted after validation had this promotion's exact five destroyed first and the substitution reported afterwards, leaving a half-emptied directory a retry could not tell from a completed one. The name is re-bound to the inode before anything is removed, so the failure is total. Separately, release coherence proved the artifacts agreed with each other but never that they belonged where they were going: a build whose runtime document said `APP_ENV: local`, `AUTH_MODE: demo` and a loopback API is coherent with itself and passed every gate. `public/` is copied verbatim into `dist/`, so that local document shipped with every build regardless of what the build was for. Runtime configuration now comes from a declared profile, and FE-GATE-027 refuses to admit an artifact to an environment it does not match — including refusing an undeclared destination, so nothing is admitted by omission. `REQUEST_TIMEOUT_MS` and `VITE_ROUTER_BASE_PATH` were validated and then dropped: the V3 executor ran every operation on its contract's own deadline, and Vite emitted root-absolute assets for a sub-path deployment. The timeout is now a ceiling that may tighten a contract but never loosen one, and one base path feeds the router, the Service Worker scope and the asset base together. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
37 lines
1.4 KiB
TypeScript
37 lines
1.4 KiB
TypeScript
import { mkdirSync, mkdtempSync } from "node:fs";
|
|
|
|
/**
|
|
* Creation modes that must not depend on the caller's ambient umask.
|
|
*
|
|
* `mkdir(path, { mode: 0o700 })` and `open(path, ..., 0o600)` are requests, not
|
|
* guarantees: the kernel subtracts the process umask from every one of them. A
|
|
* runner hardened with `umask 0777` therefore produces directories nobody can
|
|
* enter and files nobody can read, and the failure surfaces far from its cause
|
|
* — as `tar` failing to mkdir a nested path, or as EACCES opening a staging
|
|
* leaf this process created moments earlier.
|
|
*
|
|
* Release evidence has to be exactly private, so the mode is pinned rather than
|
|
* inherited. The pin is held across a synchronous call only: nothing else in
|
|
* this process can interleave, so the global umask is never observably changed.
|
|
*/
|
|
const PRIVATE_UMASK = 0o077;
|
|
|
|
export function withPrivateUmask<T>(operation: () => T): T {
|
|
const previous = process.umask(PRIVATE_UMASK);
|
|
try {
|
|
return operation();
|
|
} finally {
|
|
process.umask(previous);
|
|
}
|
|
}
|
|
|
|
/** Creates a uniquely named private directory under `prefix`. */
|
|
export function makePrivateTemporaryDirectory(prefix: string): string {
|
|
return withPrivateUmask(() => mkdtempSync(prefix));
|
|
}
|
|
|
|
/** Creates `target` privately, failing if it already exists. */
|
|
export function makePrivateDirectory(target: string): void {
|
|
withPrivateUmask(() => mkdirSync(target, { mode: 0o700 }));
|
|
}
|