DongHyeonkaandClaude Opus 5
4fe924ee0f
N-05: the conditional-validator key was a colon join over components that may themselves contain colons, so two distinct valid bindings could collide and one definition's ETag could be prepared for another. The key is now a validated, byte-bounded fixed tuple encoded with JSON.stringify. N-09: capture localStorage exactly once and compare StorageEvent.storageArea against that object identity, so a pulse from sessionStorage or any other area is rejected instead of matching on key and value alone. The pulse key is registered in the storage registry as CACHE_INVALIDATION_PULSE. N-10: race loadPage against the caller signal and re-check before observing a page, so a non-cooperative loader can neither hold loadAll forever nor have a post-abort completion accumulated into a successful result. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
92 lines
3.0 KiB
TypeScript
92 lines
3.0 KiB
TypeScript
import { describe, expect, it } from "vitest";
|
|
|
|
import { createConditionalValidatorStore } from "../../src/adapters/query-cache/conditional-validator-store.ts";
|
|
import { createRuntimeIdentityRegistry } from "../../src/contracts/query-keys.ts";
|
|
|
|
function scope() {
|
|
let current = true;
|
|
const lifetime = new AbortController();
|
|
return {
|
|
snapshot: {
|
|
generation: 3,
|
|
fingerprint: "scope-token-00000003",
|
|
identities: createRuntimeIdentityRegistry({
|
|
tokenFactory: () => crypto.randomUUID(),
|
|
}),
|
|
signal: lifetime.signal,
|
|
isCurrent: () => current,
|
|
},
|
|
expire: () => {
|
|
current = false;
|
|
lifetime.abort();
|
|
},
|
|
};
|
|
}
|
|
|
|
describe("conditional validator CAS sidecar", () => {
|
|
it("accepts 304 only for the exact scope, representation and cache revision", () => {
|
|
const selectedScope = scope();
|
|
const binding = {
|
|
definitionId: "resource-detail-v1",
|
|
identityToken: "identity-token-00000001",
|
|
representationVersion: 1,
|
|
scope: selectedScope.snapshot,
|
|
};
|
|
const store = createConditionalValidatorStore();
|
|
expect(store.install(binding, '"etag-a"', 7)).toBe(true);
|
|
expect(store.prepare(binding, 7)).toBe('"etag-a"');
|
|
expect(store.acceptNotModified(binding, 7, true)).toBe(true);
|
|
expect(store.acceptNotModified(binding, 8, true)).toBe(false);
|
|
expect(store.acceptNotModified(binding, 7, false)).toBe(false);
|
|
|
|
selectedScope.expire();
|
|
expect(store.prepare(binding, 7)).toBeNull();
|
|
expect(store.acceptNotModified(binding, 7, true)).toBe(false);
|
|
});
|
|
|
|
it("keeps colon-bearing validator tuples injective", () => {
|
|
const selectedScope = scope();
|
|
// N-05. Both bindings are individually valid and, under a delimiter join,
|
|
// encode to the same key.
|
|
const first = {
|
|
definitionId: "resource:detail",
|
|
identityToken: "identity-token-00000001",
|
|
representationVersion: 1,
|
|
scope: selectedScope.snapshot,
|
|
};
|
|
const second = {
|
|
definitionId: "resource",
|
|
identityToken: "detail:identity-token-00000001",
|
|
representationVersion: 1,
|
|
scope: selectedScope.snapshot,
|
|
};
|
|
const store = createConditionalValidatorStore();
|
|
|
|
expect(store.install(first, '"etag-a"', 7)).toBe(true);
|
|
expect(store.install(second, '"etag-b"', 7)).toBe(true);
|
|
|
|
expect(store.prepare(first, 7)).toBe('"etag-a"');
|
|
expect(store.prepare(second, 7)).toBe('"etag-b"');
|
|
});
|
|
|
|
it("rejects malformed validators and bounded-capacity overflow", () => {
|
|
const firstScope = scope();
|
|
const store = createConditionalValidatorStore(1);
|
|
const first = {
|
|
definitionId: "resource-detail-v1",
|
|
identityToken: "identity-token-00000001",
|
|
representationVersion: 1,
|
|
scope: firstScope.snapshot,
|
|
};
|
|
expect(store.install(first, "raw-etag", 1)).toBe(false);
|
|
expect(store.install(first, 'W/"etag-a"', 1)).toBe(true);
|
|
expect(
|
|
store.install(
|
|
{ ...first, identityToken: "identity-token-00000002" },
|
|
'"etag-b"',
|
|
1,
|
|
),
|
|
).toBe(false);
|
|
});
|
|
});
|