문제: FE-GATE-013의 test:system은 provider sandbox를 실제로 띄운다. systemd user manager(systemd-run --user --scope)와 cgroup v2 위임, bubblewrap(--unshare-net 등)이 필요하다. runner의 job 컨테이너는 entrypoint가 sleep이라 systemd가 없고 bwrap도 없어 사전 점검에서 실패한다 (run 56·80·81). desktop 호스트는 다 있지만 Ubuntu 24.04의 apparmor_restrict_unprivileged_userns=1이 비특권 bwrap을 막는다. 그래서 이 게이트는 runner와 desktop 어디서도 초록인 적이 없다. 고른 방법(소유자 결정 2026-11-11 5절 e: 조건이 되는 실행 환경을 찾는다): - config/ci/system-container.Dockerfile: Ubuntu 24.04(digest 고정) + systemd PID 1 + root linger + bubblewrap 등 hostRequirements의 도구. - scripts/run-in-system-container.sh: 이미지(Dockerfile 해시 태그)가 없으면 만들고, privileged·자체 cgroup namespace로 띄워 systemd와 root user manager를 기다린 뒤, 작업 트리·git 이력·호출한 쪽의 node와 corepack을 복사해 명령을 root로 돌리고 artifacts/를 되가져온 다음 지운다. root는 호스트의 userns 제한을 받지 않는다. - gates.json 게이트 필드 hostEnvironment: "system-container"(FE-GATE-013). 생성기는 그 게이트의 run 줄에 래퍼를 붙이고, 실행 검사 (workflowGateExecutionFailures)는 계약이 정한 접두어로 돈 줄만 센다. scripts/verify.sh gate·parts·stage도 같은 래퍼로 돌린다. - CI에서는 runner의 Docker proxy로 안쪽 dind daemon을 쓴다(platform-core gitea-runner README가 「남은 위험」으로 적은 길: proxy가 privileged 컨테이너를 막지 않는다). - 버린 대안: 전용 VM runner(문서 조건을 그대로 만족하지만 platform-core 변경과 VM 자원·runner 등록이 필요), 호스트 AppArmor profile(호스트 userns 제한을 푸는 보안 설정 변경, 소유자 sudo). 위험·한계: - root로 돌아 「비특권 runner에서 bwrap userns」 조건 자체는 증명하지 않는다. release 단계 provider job 둘은 아직 job 컨테이너에서 돈다(범위 밖, 같은 래퍼나 VM runner가 필요). - runner가 rootless dind로 바뀌면 privileged 컨테이너를 못 띄워 깨진다. - 래퍼 준비(이미지 확인·기동·복사)에 desktop에서 50~60초가 든다. 검증(desktop): 래퍼로 check-system-test-prerequisites → PASS(root), tests/system/ci-runner/provider-process-group.test.ts 1개 통과. python3 -m unittest scripts.tests.test_verify 통과, check:ci PASS(게이트 28), ci-workflow-generation 시험 통과. 게이트 전체(test:system 116개 포함)는 이 브랜치 끝의 merge 단계에서 돈다.
89 lines
4.8 KiB
Bash
Executable File
89 lines
4.8 KiB
Bash
Executable File
#!/usr/bin/env bash
|
|
# Runs one command in a disposable systemd container, for a gate whose host requirements a CI job
|
|
# container or a developer shell does not meet (config/ci/gates.json `hostEnvironment: "system-container"`,
|
|
# FE-GATE-013's provider sandbox: bubblewrap, a systemd user manager, delegated cgroup v2).
|
|
#
|
|
# scripts/run-in-system-container.sh <command…> e.g. corepack pnpm ci:gate -- FE-GATE-013
|
|
#
|
|
# The container is privileged with its own cgroup namespace and boots systemd (config/ci/system-container.Dockerfile).
|
|
# The command runs as root there, so bubblewrap needs no unprivileged user namespace from the host kernel
|
|
# (Ubuntu 23.10+ refuses those to unconfined processes). Node and pnpm come from the caller, copied in with the
|
|
# working tree and its git history; artifacts/ is copied back and the container removed, whatever the result.
|
|
# Docker: the CI job reaches the runner's own daemon through its Docker proxy
|
|
# (platform-core infrastructure/ci/gitea-runner); on desktop it is the host daemon.
|
|
# Environment: SYSTEM_CONTAINER_DOCKER (default docker), SYSTEM_CONTAINER_KEEP=1 keeps the container for debugging.
|
|
# Exit code: the command's, or 3 when the container could not be prepared.
|
|
set -euo pipefail
|
|
|
|
[ $# -gt 0 ] || { sed -n '2,13p' "$0" | sed 's/^# \{0,1\}//' >&2; exit 2; }
|
|
docker=${SYSTEM_CONTAINER_DOCKER:-docker}
|
|
root=$(git rev-parse --show-toplevel)
|
|
cd "$root"
|
|
dockerfile=config/ci/system-container.Dockerfile
|
|
tag="fe-system-container:$(sha256sum "$dockerfile" | cut -c1-16)"
|
|
node_root=$(dirname "$(dirname "$(command -v node)")")
|
|
corepack_home=${COREPACK_HOME:-$HOME/.cache/node/corepack}
|
|
# The environment the gate reads (scripts/verify.sh ci_env, the workflow's global env).
|
|
pass_env=(CI VITE_BUILD_ID VITE_COMMIT_SHA RELEASE_ID CI_RUNNER_IMAGE SOURCE_DATE_EPOCH APP_PROFILE RELEASE_TARGET)
|
|
|
|
say() { echo "system-container: $*" >&2; }
|
|
fail() { say "$*"; exit 3; }
|
|
|
|
if ! $docker image inspect "$tag" > /dev/null 2>&1; then
|
|
say "building $tag"
|
|
$docker build -q -t "$tag" -f "$dockerfile" config/ci > /dev/null || fail "image build failed"
|
|
fi
|
|
cid=$($docker run -d --privileged --cgroupns=private --tmpfs /run --tmpfs /run/lock "$tag") \
|
|
|| fail "container did not start"
|
|
cleanup() {
|
|
if [ "${SYSTEM_CONTAINER_KEEP:-0}" = 1 ]; then say "kept container $cid"; else $docker rm -f "$cid" > /dev/null 2>&1 || :; fi
|
|
}
|
|
trap cleanup EXIT
|
|
|
|
# systemd reaches a final state, then root's lingering user manager opens its bus. Until PID 1 has its own
|
|
# bus up, systemctl cannot connect and answers nothing, so ask again for up to a minute.
|
|
state=""
|
|
for _ in $(seq 1 120); do
|
|
state=$($docker exec "$cid" systemctl is-system-running --wait 2>/dev/null || :)
|
|
case "$state" in running | degraded) break ;; esac
|
|
sleep 0.5
|
|
done
|
|
case "$state" in running | degraded) ;; *) fail "systemd did not start (state: ${state:-none})" ;; esac
|
|
$docker exec "$cid" sh -c 'for i in $(seq 1 120); do [ -S /run/user/0/bus ] && exit 0; sleep 0.5; done; exit 1' \
|
|
|| fail "the root user manager did not start"
|
|
|
|
# The working tree as it is (node_modules included) and its history. A linked worktree's .git is a file
|
|
# naming a directory outside the tree, so the history goes in as a bundle of HEAD instead.
|
|
tar -C "$root" --exclude=./.git --exclude=./.tmp -cf - . | $docker exec -i "$cid" sh -c 'mkdir -p /work && tar -C /work --no-same-owner -xf -' \
|
|
|| fail "copying the working tree failed"
|
|
if [ -d .git ]; then
|
|
tar -C "$root" -cf - .git | $docker exec -i "$cid" tar -C /work --no-same-owner -xf - || fail "copying .git failed"
|
|
else
|
|
bundle=$(mktemp)
|
|
git bundle create -q "$bundle" HEAD
|
|
$docker exec -i "$cid" sh -c 'cat > /tmp/head.bundle' < "$bundle"
|
|
rm -f "$bundle"
|
|
$docker exec -w /work "$cid" sh -c 'git init -q . && git fetch -q /tmp/head.bundle HEAD && git update-ref HEAD FETCH_HEAD && git reset -q' \
|
|
|| fail "restoring the git history failed"
|
|
fi
|
|
tar -C "$node_root" -cf - . | $docker exec -i "$cid" sh -c 'mkdir -p /opt/node && tar -C /opt/node --no-same-owner -xf -' \
|
|
|| fail "copying node failed"
|
|
if [ -d "$corepack_home" ]; then
|
|
tar -C "$corepack_home" -cf - . | $docker exec -i "$cid" sh -c 'mkdir -p /opt/corepack && tar -C /opt/corepack --no-same-owner -xf -' \
|
|
|| fail "copying the corepack cache failed"
|
|
fi
|
|
|
|
exec_env=(-e PATH=/opt/node/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin
|
|
-e COREPACK_HOME=/opt/corepack -e HOME=/root
|
|
-e XDG_RUNTIME_DIR=/run/user/0 -e DBUS_SESSION_BUS_ADDRESS=unix:path=/run/user/0/bus)
|
|
for name in "${pass_env[@]}"; do
|
|
[ -z "${!name+x}" ] || exec_env+=(-e "$name=${!name}")
|
|
done
|
|
rc=0
|
|
$docker exec -w /work "${exec_env[@]}" "$cid" "$@" || rc=$?
|
|
# The gate's log and evidence come back even when it failed.
|
|
mkdir -p artifacts
|
|
$docker exec "$cid" sh -c '[ -d /work/artifacts ] && tar -C /work -cf - artifacts' | tar -C "$root" -xf - \
|
|
|| say "copying artifacts back failed"
|
|
exit "$rc"
|