앞 커밋은 Popover와 보이는 Tooltip이 Escape를 document capture 단계에서 받아 기본 동작을 막게 했다(1112/05-11). 그런데 대상이 어디인지 보지 않는다. 열린 popover를 Tab으로 벗어나 키보드로 Dialog를 열거나, tooltip이 보이는 채로 Dialog가 열리면, Dialog 안의 첫 Escape를 뒤쪽 층이 먹고 Dialog는 닫히지 않는다. 고치기 전에는 둘 다 닫혔다(확인 리뷰). 고른 방법: escape-layer.ts의 escapeIsForLayer가 Escape를 누른 곳이 그 층을 품지 않은 dialog 안이면 그 Escape를 dialog 것으로 본다. 층 안, 층을 품은 dialog 안, 요소 밖(포커스가 body)에서 누른 Escape는 층의 것이다. Popover와 Tooltip이 이것을 묻는다. 버린 대안: 대상이 층 안일 때만 받기(WebKit은 클릭한 버튼에 포커스를 주지 않아 열린 popover가 Escape로 닫히지 않는다). 위험·한계: native <dialog>가 아닌 modal(role="dialog"만 단 것)은 이 판정이 모른다. 템플릿의 Dialog·Drawer는 <dialog>다. 검증: design-system-a11y.test.tsx의 새 시험 셋(Dialog 밖 Popover, Dialog 밖 Tooltip, body에서 누른 Escape)이 고치기 전 코드에서 앞 둘이 실패하고 셋째는 통과(대조)하며, 고친 뒤 모두 통과한다(desktop, PR 본문). Refs: 1112/05-11
271 lines
8.6 KiB
TypeScript
271 lines
8.6 KiB
TypeScript
// @vitest-environment jsdom
|
|
|
|
import { render, screen, within } from "@testing-library/react";
|
|
import userEvent from "@testing-library/user-event";
|
|
import { useState } from "react";
|
|
import { describe, expect, it, vi } from "vitest";
|
|
|
|
import {
|
|
Button,
|
|
Checkbox,
|
|
Dialog,
|
|
Menu,
|
|
Popover,
|
|
SearchField,
|
|
TextArea,
|
|
ToastProvider,
|
|
Tooltip,
|
|
useToast,
|
|
} from "../../src/presentation/design-system/index.ts";
|
|
|
|
/**
|
|
* 1112/05-10, 05-11, 05-13, 05-14, 05-17. What the shared primitives promise
|
|
* a keyboard and screen reader user (docs/design/2026-07-26-design-system-platform-design.md
|
|
* 8.1·8.2절, WCAG 2.2 AA): a named dialog, Escape that closes the innermost
|
|
* layer only, required shown both ways, focus that does not fall to the body,
|
|
* and a counter that is not announced on every key.
|
|
*/
|
|
|
|
function DialogWith({ onClose, children }: Readonly<{ onClose(): void; children: React.ReactNode }>) {
|
|
return (
|
|
<Dialog open onClose={onClose} title="설정">
|
|
{children}
|
|
</Dialog>
|
|
);
|
|
}
|
|
|
|
describe("Popover", () => {
|
|
it("names its dialog after the trigger", async () => {
|
|
const user = userEvent.setup();
|
|
render(
|
|
<Popover triggerLabel="설명 열기">
|
|
<Button>내부 작업</Button>
|
|
</Popover>,
|
|
);
|
|
|
|
await user.click(screen.getByRole("button", { name: "설명 열기" }));
|
|
|
|
expect(screen.getByRole("dialog", { name: "설명 열기" })).toBeVisible();
|
|
});
|
|
});
|
|
|
|
describe("Escape inside a Dialog", () => {
|
|
it("closes an open Popover and keeps the Dialog", async () => {
|
|
const user = userEvent.setup();
|
|
const onClose = vi.fn();
|
|
render(
|
|
<DialogWith onClose={onClose}>
|
|
<Popover triggerLabel="설명 열기">
|
|
<Button>내부 작업</Button>
|
|
</Popover>
|
|
</DialogWith>,
|
|
);
|
|
await user.click(screen.getByRole("button", { name: "설명 열기" }));
|
|
await user.click(screen.getByRole("button", { name: "내부 작업" }));
|
|
|
|
await user.keyboard("{Escape}");
|
|
|
|
expect(screen.queryByRole("button", { name: "내부 작업" })).not.toBeInTheDocument();
|
|
expect(screen.getByRole("button", { name: "설명 열기" })).toHaveFocus();
|
|
expect(onClose).not.toHaveBeenCalled();
|
|
});
|
|
|
|
it("closes an open Menu and keeps the Dialog", async () => {
|
|
const user = userEvent.setup();
|
|
const onClose = vi.fn();
|
|
render(
|
|
<DialogWith onClose={onClose}>
|
|
<Menu triggerLabel="더 보기" items={[{ id: "copy", label: "복사", onSelect: () => {} }]} />
|
|
</DialogWith>,
|
|
);
|
|
await user.click(screen.getByRole("button", { name: "더 보기" }));
|
|
expect(screen.getByRole("menu")).toBeVisible();
|
|
|
|
await user.keyboard("{Escape}");
|
|
|
|
expect(screen.queryByRole("menu")).not.toBeInTheDocument();
|
|
expect(onClose).not.toHaveBeenCalled();
|
|
});
|
|
|
|
it("hides a shown Tooltip and keeps the Dialog", async () => {
|
|
const user = userEvent.setup();
|
|
const onClose = vi.fn();
|
|
render(
|
|
<DialogWith onClose={onClose}>
|
|
<Tooltip content="자세한 설명">
|
|
<Button>도움말</Button>
|
|
</Tooltip>
|
|
</DialogWith>,
|
|
);
|
|
await user.hover(screen.getByRole("button", { name: "도움말" }));
|
|
|
|
await user.keyboard("{Escape}");
|
|
|
|
expect(screen.getByRole("tooltip", { hidden: true })).not.toBeVisible();
|
|
expect(onClose).not.toHaveBeenCalled();
|
|
});
|
|
|
|
// round9 confirm review. A popover or tooltip left open outside a Dialog
|
|
// does not take the Dialog's Escape: the Escape belongs to the Dialog it
|
|
// was pressed in.
|
|
it.each([
|
|
[
|
|
"a Popover",
|
|
(
|
|
<Popover key="layer" triggerLabel="설명 열기">
|
|
<Button>내부 작업</Button>
|
|
</Popover>
|
|
),
|
|
(user: ReturnType<typeof userEvent.setup>) => user.click(screen.getByRole("button", { name: "설명 열기" })),
|
|
],
|
|
[
|
|
"a Tooltip",
|
|
(
|
|
<Tooltip key="layer" content="자세한 설명">
|
|
<Button>도움말</Button>
|
|
</Tooltip>
|
|
),
|
|
(user: ReturnType<typeof userEvent.setup>) => user.hover(screen.getByRole("button", { name: "도움말" })),
|
|
],
|
|
])("closes the Dialog when %s outside it is open", async (_label, layer, openLayer) => {
|
|
const user = userEvent.setup();
|
|
const onClose = vi.fn();
|
|
render(
|
|
<>
|
|
{layer}
|
|
<DialogWith onClose={onClose}>
|
|
<Button>안쪽 버튼</Button>
|
|
</DialogWith>
|
|
</>,
|
|
);
|
|
await openLayer(user);
|
|
screen.getByRole("button", { name: "안쪽 버튼" }).focus();
|
|
|
|
await user.keyboard("{Escape}");
|
|
|
|
expect(onClose).toHaveBeenCalledTimes(1);
|
|
});
|
|
|
|
// WebKit does not focus a clicked button: an Escape with focus on the body
|
|
// still closes the open Popover.
|
|
it("closes an open Popover on an Escape from the body", async () => {
|
|
const user = userEvent.setup();
|
|
render(
|
|
<Popover triggerLabel="설명 열기">
|
|
<Button>내부 작업</Button>
|
|
</Popover>,
|
|
);
|
|
await user.click(screen.getByRole("button", { name: "설명 열기" }));
|
|
(document.activeElement as HTMLElement | null)?.blur();
|
|
|
|
await user.keyboard("{Escape}");
|
|
|
|
expect(screen.queryByRole("button", { name: "내부 작업" })).not.toBeInTheDocument();
|
|
});
|
|
|
|
it("closes the Dialog when no inner layer is open", async () => {
|
|
const user = userEvent.setup();
|
|
const onClose = vi.fn();
|
|
render(
|
|
<DialogWith onClose={onClose}>
|
|
<Button>안쪽 버튼</Button>
|
|
</DialogWith>,
|
|
);
|
|
screen.getByRole("button", { name: "안쪽 버튼" }).focus();
|
|
|
|
await user.keyboard("{Escape}");
|
|
|
|
expect(onClose).toHaveBeenCalledTimes(1);
|
|
});
|
|
});
|
|
|
|
describe("required fields", () => {
|
|
it("marks a required SearchField both on the input and with the symbol", () => {
|
|
render(<SearchField label="검색" required value="" onChange={() => {}} clearLabel="지우기" onClear={() => {}} />);
|
|
|
|
expect(screen.getByRole("searchbox", { name: /검색/u })).toBeRequired();
|
|
expect(screen.getByText("*", { exact: false })).toHaveAttribute("aria-hidden", "true");
|
|
});
|
|
|
|
it("marks a required Checkbox both on the input and with the symbol", () => {
|
|
render(<Checkbox label="약관에 동의" required />);
|
|
|
|
const checkbox = screen.getByRole("checkbox", { name: /약관에 동의/u });
|
|
expect(checkbox).toBeRequired();
|
|
const label = checkbox.closest("label");
|
|
if (!label) throw new Error("expected the checkbox label");
|
|
expect(within(label).getByText("*", { exact: false })).toHaveAttribute("aria-hidden", "true");
|
|
});
|
|
});
|
|
|
|
describe("Toast focus when it is closed", () => {
|
|
function Harness({ count }: Readonly<{ count: number }>) {
|
|
const toast = useToast();
|
|
return (
|
|
<Button
|
|
onClick={() => {
|
|
for (let index = 0; index < count; index += 1) {
|
|
toast.push({ id: `toast-${index}`, title: `알림 ${index}`, durationMs: 60_000 });
|
|
}
|
|
}}
|
|
>
|
|
알림 보이기
|
|
</Button>
|
|
);
|
|
}
|
|
|
|
it("moves focus to the next toast's close button", async () => {
|
|
const user = userEvent.setup();
|
|
render(
|
|
<ToastProvider>
|
|
<Harness count={2} />
|
|
</ToastProvider>,
|
|
);
|
|
await user.click(screen.getByRole("button", { name: "알림 보이기" }));
|
|
const [first] = screen.getAllByRole("button", { name: /닫기/u });
|
|
if (!first) throw new Error("expected two close buttons");
|
|
first.focus();
|
|
|
|
await user.click(first);
|
|
|
|
expect(document.activeElement).not.toBe(document.body);
|
|
expect(document.activeElement).toBe(screen.getByRole("button", { name: /닫기/u }));
|
|
});
|
|
|
|
it("returns focus to where it was before the last toast took it", async () => {
|
|
const user = userEvent.setup();
|
|
render(
|
|
<ToastProvider>
|
|
<Harness count={1} />
|
|
</ToastProvider>,
|
|
);
|
|
const trigger = screen.getByRole("button", { name: "알림 보이기" });
|
|
await user.click(trigger);
|
|
await user.tab();
|
|
const close = screen.getByRole("button", { name: /닫기/u });
|
|
expect(close).toHaveFocus();
|
|
|
|
await user.keyboard("{Enter}");
|
|
|
|
expect(screen.queryByRole("article")).not.toBeInTheDocument();
|
|
expect(trigger).toHaveFocus();
|
|
});
|
|
});
|
|
|
|
describe("TextArea counter", () => {
|
|
it("describes the field without announcing every key", async () => {
|
|
const user = userEvent.setup();
|
|
function Controlled() {
|
|
const [value, setValue] = useState("");
|
|
return <TextArea label="메모" maxLength={30} value={value} onChange={(event) => setValue(event.currentTarget.value)} />;
|
|
}
|
|
render(<Controlled />);
|
|
const field = screen.getByRole("textbox", { name: "메모" });
|
|
|
|
await user.type(field, "가나다");
|
|
|
|
expect(screen.queryByRole("status")).not.toBeInTheDocument();
|
|
expect(field).toHaveAccessibleDescription(/27/u);
|
|
});
|
|
});
|