Files
clean-architecture-frontend…/tests/unit/template-feature-removal-documents.test.ts
T
donghyeon.kang 568f332892
frontend-quality-gates / FE-GATE-001 / manifest-lockfile (pull_request) Successful in 1m20s
frontend-quality-gates / FE-GATE-002 / lint (pull_request) Successful in 1m13s
frontend-quality-gates / FE-GATE-003 / typecheck (pull_request) Successful in 1m2s
frontend-quality-gates / FE-GATE-004 / runtime-schema (pull_request) Successful in 1m4s
frontend-quality-gates / FE-GATE-005 / unit (pull_request) Failing after 2m13s
frontend-quality-gates / FE-GATE-006 / component (pull_request) Successful in 1m12s
frontend-quality-gates / FE-GATE-007 / integration (pull_request) Successful in 1m17s
frontend-quality-gates / FE-GATE-010 / architecture (pull_request) Successful in 1m38s
frontend-quality-gates / FE-GATE-011 / build (pull_request) Successful in 57s
frontend-quality-gates / FE-GATE-012 / bundle (pull_request) Successful in 53s
frontend-quality-gates / FE-GATE-013 / security (pull_request) Failing after 36s
frontend-quality-gates / FE-GATE-020 / removability (pull_request) Failing after 12m49s
frontend-quality-gates / FE-GATE-008 / e2e (pull_request) Successful in 9m9s
frontend-quality-gates / FE-GATE-009 / accessibility (pull_request) Failing after 6m43s
frontend-quality-gates / FE-GATE-017 / diagram-review (pull_request) Skipped
frontend-quality-gates / FE-GATE-014 / config-compatibility (pull_request) Skipped
frontend-quality-gates / FE-GATE-028 / manual-accessibility-review (pull_request) Skipped
frontend-quality-gates / FE-GATE-026 / lab-performance (pull_request) Skipped
frontend-quality-gates / FE-GATE-015 / immutable-release-candidate (pull_request) Skipped
frontend-quality-gates / external-vulnerability-provider (pull_request) Skipped
frontend-quality-gates / external-provenance-provider (pull_request) Skipped
frontend-quality-gates / promote-verified-immutable-candidate (pull_request) Skipped
frontend-quality-gates / deploy-promoted-release (pull_request) Skipped
frontend-quality-gates / FE-GATE-019 / hosting-header (pull_request) Skipped
frontend-quality-gates / FE-GATE-021 / runbook-boot-config (pull_request) Skipped
frontend-quality-gates / FE-GATE-022 / runbook-chunk-mismatch (pull_request) Skipped
frontend-quality-gates / FE-GATE-023 / runbook-api-degradation (pull_request) Skipped
frontend-quality-gates / FE-GATE-024 / runbook-telemetry (pull_request) Skipped
frontend-quality-gates / FE-GATE-025 / runbook-release-rollback (pull_request) Skipped
frontend-quality-gates / FE-GATE-018 / field-web-vitals (pull_request) Skipped
chore(merge): 하네스 PR #13이 들어간 main을 받는다
main(d1b9c087)에 하네스 PR #13이 들어가 루트에 `AGENTS.md`, `.claude/`,
`.gitattributes`가 생겼다. 이 브랜치는 그 셋을 루트 등록부에 optional로
미리 적어 두었다.

충돌 둘을 풀었다.
- `scripts/lib/removal-fixture.ts`: main은 문서 복사 목록에 `AGENTS.md`를
  더했고 이 브랜치는 그 목록을 등록부의 `fixture-documents` 집합으로
  바꿨다. 등록부의 `AGENTS.md` 항목에 그 집합을 적었다.
- `tests/unit/template-feature-removal-documents.test.ts`: main은 문서
  목록에 `AGENTS.md`와 옛 a11y 기록 폴더를 더했다. a11y 기록은 이
  브랜치에서 `docs/`로 옮겼으므로 `AGENTS.md`만 남겼다.

등록부의 `AGENTS.md`·`.claude`·`.gitattributes`는 이제 추적되는 항목이라
optional을 빼고 역할을 실제 내용으로 고쳤다. 추적되는 루트 항목과
등록부 항목이 서로 남는 것 없이 같다.

검증(desktop): 커밋별 5검사와 merge 게이트 14개, verify:documentation.
2026-11-11 20:29:01 +09:00

187 lines
8.2 KiB
TypeScript

import { spawnSync } from "node:child_process";
import { existsSync } from "node:fs";
import { cp, mkdtemp, readFile, rm, writeFile } from "node:fs/promises";
import { tmpdir } from "node:os";
import path from "node:path";
import { describe, expect, it } from "vitest";
import { linkFixtureNodeModules } from "../../scripts/lib/fixture-node-modules.ts";
import {
REMOVABLE_TEMPLATE_FEATURES,
removableTemplateFeaturePaths,
} from "../../scripts/lib/removable-template-features.ts";
import { REMOVAL_FIXTURE_COPY_TARGETS } from "../../scripts/lib/removal-fixture.ts";
/**
* 1105/14-01. A copy that deleted a sample listed in
* scripts/lib/removable-template-features.ts failed verify:documentation and
* the FE-GATE-005 copy of it ("passes the documents as they are") wherever
* the documents named the sample's folders. The template lists no sample
* since 2026-11-07, so the copy here gets one: the feature `create:feature`
* writes, listed and named in a document, then deleted.
*/
const CHECKER = "scripts/verify-documentation-readiness.ts";
/** What verify:documentation reads besides the code. */
const DOCUMENTS = Object.freeze(["README.md", "CHANGELOG.md", "docs", "AGENTS.md"]);
const LISTED_SAMPLE = Object.freeze({
featureId: "listed-sample-feature",
contextDirectory: "src/contexts/listed-sample-context",
extraPaths: Object.freeze([]),
scripts: Object.freeze([]),
});
const NAMING_DOCUMENT = "docs/architecture/starter-experience.md";
/**
* A copy of the repository with LISTED_SAMPLE installed, listed and named in
* NAMING_DOCUMENT (its module and a file it does not have). `verify` runs the
* copy's verify:documentation; `remove` deletes the sample as a product does
* (its paths and route records), then generates the feature index again.
*/
async function copyWithListedSample() {
const parent = await mkdtemp(path.join(tmpdir(), "template-feature-removal-"));
const root = path.join(parent, "frontend");
for (const entry of [...REMOVAL_FIXTURE_COPY_TARGETS, ...DOCUMENTS]) {
// A drill runs this test in a copy that has already lost some of them.
if (!existsSync(entry)) continue;
await cp(entry, path.join(root, entry), {
recursive: true,
filter: (source) => !source.includes(`${path.sep}.generated`),
});
}
await linkFixtureNodeModules(root);
const node = (args: readonly string[]) =>
spawnSync(process.execPath, args, { cwd: root, encoding: "utf8" });
for (const args of [
["scripts/generate-product-feature-index.ts"],
["scripts/create-feature.ts", LISTED_SAMPLE.featureId],
]) {
const result = node(args);
expect(result.status, `${result.stdout}${result.stderr}`).toBe(0);
}
const list = path.join(root, "scripts/lib/removable-template-features.ts");
const listed = (await readFile(list, "utf8")).replace(
"Object.freeze([]);",
`Object.freeze([${JSON.stringify(LISTED_SAMPLE)}]);`,
);
expect(listed).toContain(LISTED_SAMPLE.featureId);
await writeFile(list, listed);
const named = [
`src/features/${LISTED_SAMPLE.featureId}/feature-module.ts`,
`src/features/${LISTED_SAMPLE.featureId}/no-such-module.ts`,
];
const document = path.join(root, NAMING_DOCUMENT);
await writeFile(
document,
`${await readFile(document, "utf8")}\n${named.map((file) => `- \`${file}\``).join("\n")}\n`,
);
return {
named,
verify: () => node([CHECKER]),
async remove() {
for (const entry of removableTemplateFeaturePaths(LISTED_SAMPLE)) {
await rm(path.join(root, entry), { recursive: true, force: true });
}
await rm(path.join(root, "docs/accessibility/route-reviews/LISTED_SAMPLE_LIST.md"), { force: true });
expect(node(["scripts/generate-product-feature-index.ts"]).status).toBe(0);
},
cleanUp: () => rm(parent, { recursive: true, force: true }),
};
}
/**
* Runs this repository's verify:documentation on a copy of the documents
* with `mutate` applied to `document`; the code facts are this repository's.
* `documents` are the ones it checked (docs/README.md §1 and what it links).
*/
async function verifyDocuments(document: string, mutate: (text: string) => string = (text) => text) {
const parent = await mkdtemp(path.join(tmpdir(), "template-feature-documents-"));
const root = path.join(parent, "frontend");
try {
// The pin says which commit of the paired backend the documents describe.
const inputs = ["README.md", "docs", "config/contracts/backend-contract-pin.json"];
for (const entry of inputs) await cp(entry, path.join(root, entry), { recursive: true });
const target = path.join(root, document);
await writeFile(target, mutate(await readFile(target, "utf8")));
const result = spawnSync(process.execPath, [path.resolve(CHECKER)], { cwd: root, encoding: "utf8" });
const report = JSON.parse(
await readFile(path.join(root, "artifacts/quality/documentation-review.json"), "utf8"),
) as { documentReferences: { path: string }[] };
return { ...result, documents: report.documentReferences.map((entry) => entry.path) };
} finally {
await rm(parent, { recursive: true, force: true });
}
}
describe("verify:documentation after a listed sample is deleted (1105/14-01)", () => {
// Only a deleted sample's paths are let through. While it is installed a
// missing path under it fails; once it is deleted, the documents that name
// it pass.
it("fails on a missing path under an installed sample and passes once it is deleted", async () => {
const copy = await copyWithListedSample();
try {
const installed = copy.verify();
expect(installed.status).toBe(1);
expect(installed.stderr).toContain(`${NAMING_DOCUMENT} names paths that do not exist:`);
expect(installed.stderr).toContain(copy.named[1]);
expect(installed.stderr).not.toContain(copy.named[0]);
await copy.remove();
const deleted = copy.verify();
expect(deleted.status, deleted.stderr).toBe(0);
} finally {
await copy.cleanUp();
}
}, 180_000);
it("still fails on a feature folder that is not on the list", async () => {
const missing = "src/features/no-such-template-feature/feature-module.ts";
const result = await verifyDocuments(NAMING_DOCUMENT, (text) => `${text}\n- \`${missing}\`\n`);
expect(result.status).toBe(1);
expect(result.stderr).toContain(`${NAMING_DOCUMENT} names paths that do not exist:`);
expect(result.stderr).toContain(missing);
}, 60_000);
});
/** Fenced blocks whose command lines verify:documentation reads. */
const SHELL_FENCE = /^(?:bash|sh|shell|console|zsh)?$/u;
/**
* 1105/14-03. The fix for 1103/14-04 wrote the reference sample's paths
* without backticks so that a copy without the sample passed, which also took
* 26 lines out of the check while the sample is installed: renaming one of
* its files left the manual pointing at nothing. Deleted features' paths are
* accepted now (above), so a current contract document names a removable
* template feature's path or script only where verify:documentation reads
* it: in an inline code span, a link target or a shell code block.
*/
describe("removable template features in the current contract documents (1105/14-03)", () => {
it("names their paths and scripts only where verify:documentation checks them", async () => {
const { documents } = await verifyDocuments("docs/README.md");
const owned = REMOVABLE_TEMPLATE_FEATURES.flatMap((feature) => [
...removableTemplateFeaturePaths(feature),
...feature.scripts,
]);
const unchecked: string[] = [];
for (const document of documents) {
const lines = (await readFile(document, "utf8")).split("\n");
let fence: string | null = null;
for (const [index, line] of lines.entries()) {
const marker = /^\s*```(\w*)/u.exec(line);
if (marker) {
fence = fence === null ? (marker[1] ?? "") : null;
continue;
}
if (fence !== null && SHELL_FENCE.test(fence)) continue;
const prose = line.replace(/`[^`\n]+`/gu, "").replace(/\]\([^)\s]+\)/gu, "]");
for (const entry of owned) {
if (prose.includes(entry)) unchecked.push(`${document}:${index + 1}: ${entry}`);
}
}
}
expect(documents).toContain("docs/manual/01-add-a-feature.md");
expect(unchecked).toEqual([]);
}, 60_000);
});