frontend-quality-gates / merge / static checks (pull_request) Canceled after 0s
frontend-quality-gates / merge / tests (pull_request) Canceled after 0s
frontend-quality-gates / merge / browser tests (pull_request) Canceled after 0s
frontend-quality-gates / FE-GATE-014 / config-compatibility (pull_request) Canceled after 0s
frontend-quality-gates / FE-GATE-026 / lab-performance (pull_request) Canceled after 0s
frontend-quality-gates / FE-GATE-028 / manual-accessibility-review (pull_request) Canceled after 0s
frontend-quality-gates / FE-GATE-015 / immutable-release-candidate (pull_request) Canceled after 0s
frontend-quality-gates / external-vulnerability-provider (pull_request) Canceled after 0s
frontend-quality-gates / external-provenance-provider (pull_request) Canceled after 0s
frontend-quality-gates / promote-verified-immutable-candidate (pull_request) Canceled after 0s
frontend-quality-gates / deploy-promoted-release (pull_request) Canceled after 0s
frontend-quality-gates / main / self-tests and removal drills (pull_request) Canceled after 0s
frontend-quality-gates / FE-GATE-019 / hosting-header (pull_request) Canceled after 0s
frontend-quality-gates / FE-GATE-021 / runbook-boot-config (pull_request) Canceled after 0s
frontend-quality-gates / FE-GATE-022 / runbook-chunk-mismatch (pull_request) Canceled after 0s
frontend-quality-gates / FE-GATE-023 / runbook-api-degradation (pull_request) Canceled after 0s
frontend-quality-gates / FE-GATE-024 / runbook-telemetry (pull_request) Canceled after 0s
frontend-quality-gates / FE-GATE-025 / runbook-release-rollback (pull_request) Canceled after 0s
frontend-quality-gates / FE-GATE-018 / field-web-vitals (pull_request) Canceled after 0s
frontend-quality-gates / FE-GATE-017 / diagram-review (pull_request) Canceled after 0s
문제: 자식 프로세스 시험의 timeout은 `childProcessTimeout(<잰 ms>)`로
정한다(docs/work/reference/testing.md 2절). 그런데 기본값이 아니라서
`tests/setup.ts` 검사에 걸리지 않는 손 숫자가 남았다. 리뷰가 센 54곳 중
둘(`browser-soak.contract.test.ts`의 `evaluateSoak` 인자)은 timeout이 아니고,
AST로 다시 세면 80곳이다: 시험·describe·hook에 쓴 숫자, `VERIFY_TIMEOUT`·
`PROCESS_HEAVY_TIMEOUT_MS`(파일 넷에 따로)·`PROVIDER_BASE_FIXTURE_TIMEOUT_MS`
같은 상수, `PROCESS_WATCHDOG_MS * 3` 같은 식. taxonomy는 옛 상수를 예로
들었다. 실측으로 보면 손 숫자 하나가 모자랐다: system 시험의 provider 묶음
30초는 desktop 여섯 번 중 두 번 넘겼다.
고친 것:
- 80곳을 desktop에서 잰 가장 긴 실행으로 `childProcessTimeout(<ms>)`에
넘긴다. coverage 묶음(maxWorkers=4)·test:unit 각 9회, integration 3회,
scale(traffic·session·composition·global-local) 3회, 시스템 컨테이너의
tests/system 6회, JSON reporter로 받았다. hook은 파일 시간에서 시험 합을
뺀 값이다. 시간 초과로 끝난 실행은 그 시간을 하한으로 넣었다.
- 상수 사본은 지운다. 한 파일 안에서 여럿이 쓰는 값만
`const X = childProcessTimeout(...)`로 둔다(`VERIFY_TIMEOUT`). guardian
시험의 lease는 시험 timeout이 아니라 `childProcessTimeout(0)`(helper의 최소
30초)로 둔다.
- `tests/unit/test-timeout-declarations.test.ts`가 tests/의 Vitest 파일을
Babel로 읽어 시험·describe·hook의 timeout 인자가 helper 호출(또는 그것을
담은 파일 상수)이 아니면 파일과 줄로 실패한다. 프로세스 안에서 도는 긴
시험(scale tier)도 같은 helper를 쓴다.
- taxonomy 예시, testing.md 2절, `.claude/rules/tests.md` 9번, helper 머리
주석을 같은 방법으로 맞춘다.
버린 대안:
- `tests/setup.ts` 검사를 「helper가 만든 값이 아닌 timeout」까지 넓히기.
helper 값은 30초 단위 숫자라 손으로 쓴 60_000과 가릴 수 없고, hook과
프로세스 안 시험은 보지 못한다.
- 프로세스 안 시험은 손 숫자 그대로 두기. 근거 없는 숫자가 남고 검사가
예외를 가져야 한다.
위험·한계:
- 값이 커진 곳이 있다(15배 규칙): `manual-code-blocks` 300초 → 900초,
provider 묶음 30초 → 480초 등. hang을 늦게 잡는다. 줄어든 곳도 있다
(scale traffic 60초 → 30초 등, 잰 값의 15배 안).
- 측정은 desktop 부하 6~35에서 했다. runner가 더 느리면 다시 잰다.
- 검사 시험은 Vitest 파일 전부를 파싱해 coverage 묶음에서 최대 13.5초
걸렸고, 그 값으로 자기 timeout을 준다. 이름 있는 함수를 콜백으로 넘긴
시험(`it("x", run, 30_000)`)은 못 찾는다.
- 다운스트림: 손 숫자 timeout이 있는 제품 시험은 test:unit에서 이 검사에
걸린다. 메시지가 helper를 알린다.
검증(desktop):
- RED: 검사 시험이 고치기 전 80곳을 파일·줄로 내고 실패. GREEN: 검사·
child-process-timeout 6개 통과. check:types·eslint(바뀐 34파일) rc=0,
verify:documentation PASS_SCOPED, 노트북 `scripts/verify.sh docs` OK.
- 측정 원자료: /tmp/claude-gates/w2fe2-t08m, -t08m2, -t08m3.
- 게이트 결과는 PR 본문에 적는다.
Refs: 1112/03-08
293 lines
12 KiB
TypeScript
293 lines
12 KiB
TypeScript
import { spawnSync } from "node:child_process";
|
|
import {
|
|
copyFile,
|
|
lstat,
|
|
mkdtemp,
|
|
mkdir,
|
|
readdir,
|
|
readFile,
|
|
rm,
|
|
stat,
|
|
writeFile,
|
|
} from "node:fs/promises";
|
|
import { tmpdir } from "node:os";
|
|
import path from "node:path";
|
|
|
|
import { afterEach, describe, expect, it } from "vitest";
|
|
|
|
import {
|
|
FIXTURE_PNPM_ENVIRONMENT,
|
|
linkFixtureNodeModules,
|
|
} from "../../scripts/lib/fixture-node-modules.ts";
|
|
import { selectRepositoryPaths } from "../../scripts/lib/repository-layout.ts";
|
|
import { childProcessTimeout } from "../helpers/child-process-timeout.ts";
|
|
|
|
/**
|
|
* A removal or provider fixture runs `pnpm` inside a throwaway copy of the
|
|
* repository. pnpm does not recognise the modules directory it finds there and
|
|
* purges it, and with `CI=true` it does so without a prompt. When
|
|
* `<fixture>/node_modules` was a single directory symlink, that purge followed
|
|
* the link and deleted the repository's own installed dependencies mid-run —
|
|
* a test suite uninstalling the workspace it was running in.
|
|
*/
|
|
describe("fixture node_modules linking", () => {
|
|
async function sourceTree() {
|
|
const source = await mkdtemp(path.join(tmpdir(), "fixture-source-"));
|
|
const modules = path.join(source, "node_modules");
|
|
await mkdir(path.join(modules, "left", "lib"), { recursive: true });
|
|
await mkdir(path.join(modules, "@scope", "right"), { recursive: true });
|
|
await mkdir(path.join(modules, ".bin"), { recursive: true });
|
|
await writeFile(path.join(modules, "left", "lib", "index.js"), "export default 1;\n");
|
|
await writeFile(path.join(modules, "@scope", "right", "package.json"), "{}\n");
|
|
await writeFile(path.join(modules, ".modules.yaml"), "{}\n");
|
|
return source;
|
|
}
|
|
|
|
it("survives a recursive delete of the fixture's node_modules", async () => {
|
|
const source = await sourceTree();
|
|
const fixture = await mkdtemp(path.join(tmpdir(), "fixture-root-"));
|
|
try {
|
|
await linkFixtureNodeModules(fixture, source);
|
|
|
|
// The fixture resolves the same packages...
|
|
expect(
|
|
await readFile(
|
|
path.join(fixture, "node_modules/left/lib/index.js"),
|
|
"utf8",
|
|
),
|
|
).toContain("export default 1;");
|
|
expect(
|
|
(await readdir(path.join(fixture, "node_modules"))).sort(),
|
|
).toEqual([".bin", ".modules.yaml", "@scope", "left"]);
|
|
|
|
// ...and this is exactly what pnpm's purge does.
|
|
await rm(path.join(fixture, "node_modules"), {
|
|
recursive: true,
|
|
force: true,
|
|
});
|
|
|
|
// The repository's real dependencies are untouched.
|
|
expect(
|
|
await readFile(
|
|
path.join(source, "node_modules/left/lib/index.js"),
|
|
"utf8",
|
|
),
|
|
).toContain("export default 1;");
|
|
expect(
|
|
await stat(path.join(source, "node_modules/@scope/right/package.json")),
|
|
).toBeDefined();
|
|
expect(
|
|
(await readdir(path.join(source, "node_modules"))).sort(),
|
|
).toEqual([".bin", ".modules.yaml", "@scope", "left"]);
|
|
} finally {
|
|
await rm(source, { recursive: true, force: true });
|
|
await rm(fixture, { recursive: true, force: true });
|
|
}
|
|
});
|
|
|
|
// pnpm rewrites `.pnpm-workspace-state-v1.json` in place when it runs inside
|
|
// the fixture. Through a symlink that write landed in the repository's own
|
|
// state file, so the next pnpm command there re-verified the install.
|
|
it("copies the pnpm state files instead of linking them", async () => {
|
|
const source = await sourceTree();
|
|
const fixture = await mkdtemp(path.join(tmpdir(), "fixture-root-"));
|
|
const stateFiles = [".modules.yaml", ".package-map.json", ".pnpm-workspace-state-v1.json"];
|
|
try {
|
|
for (const file of stateFiles) {
|
|
await writeFile(path.join(source, "node_modules", file), `{"projects":{"${source}":{}}}\n`);
|
|
}
|
|
await linkFixtureNodeModules(fixture, source);
|
|
|
|
for (const file of stateFiles) {
|
|
const copied = path.join(fixture, "node_modules", file);
|
|
expect((await lstat(copied)).isSymbolicLink(), file).toBe(false);
|
|
await writeFile(copied, `{"projects":{"${fixture}":{}}}\n`);
|
|
expect(await readFile(path.join(source, "node_modules", file), "utf8"), file)
|
|
.toBe(`{"projects":{"${source}":{}}}\n`);
|
|
}
|
|
} finally {
|
|
await rm(source, { recursive: true, force: true });
|
|
await rm(fixture, { recursive: true, force: true });
|
|
}
|
|
});
|
|
|
|
// A copied state file still names the repository as the validated project,
|
|
// so pnpm inside the fixture re-verified the install and started one through
|
|
// the linked directories. Pointing it at the fixture keeps pnpm from
|
|
// installing into a tree whose packages are shared with the repository.
|
|
it("points the copied workspace state at the fixture root", async () => {
|
|
const source = await sourceTree();
|
|
const fixture = await mkdtemp(path.join(tmpdir(), "fixture-root-"));
|
|
const statePath = ".pnpm-workspace-state-v1.json";
|
|
try {
|
|
await writeFile(
|
|
path.join(source, "node_modules", statePath),
|
|
JSON.stringify({
|
|
lastValidatedTimestamp: 1,
|
|
projects: { [source]: { name: "template", version: "0.1.0" } },
|
|
settings: { dev: true },
|
|
}),
|
|
);
|
|
const before = Date.now();
|
|
await linkFixtureNodeModules(fixture, source);
|
|
|
|
const state = JSON.parse(
|
|
await readFile(path.join(fixture, "node_modules", statePath), "utf8"),
|
|
);
|
|
expect(state.projects).toEqual({
|
|
[fixture]: { name: "template", version: "0.1.0" },
|
|
});
|
|
expect(state.lastValidatedTimestamp).toBeGreaterThanOrEqual(before);
|
|
expect(state.settings).toEqual({ dev: true });
|
|
} finally {
|
|
await rm(source, { recursive: true, force: true });
|
|
await rm(fixture, { recursive: true, force: true });
|
|
}
|
|
});
|
|
|
|
it("creates node_modules as a real directory, never a symlink", async () => {
|
|
const source = await sourceTree();
|
|
const fixture = await mkdtemp(path.join(tmpdir(), "fixture-root-"));
|
|
try {
|
|
await linkFixtureNodeModules(fixture, source);
|
|
const entry = await lstat(path.join(fixture, "node_modules"));
|
|
expect(entry.isSymbolicLink()).toBe(false);
|
|
expect(entry.isDirectory()).toBe(true);
|
|
expect(
|
|
(await lstat(path.join(fixture, "node_modules/left"))).isSymbolicLink(),
|
|
).toBe(true);
|
|
} finally {
|
|
await rm(source, { recursive: true, force: true });
|
|
await rm(fixture, { recursive: true, force: true });
|
|
}
|
|
});
|
|
});
|
|
|
|
/**
|
|
* F-4. pnpm 11 verifies the install before it runs a script and, finding the
|
|
* fixture's copied state unfamiliar, installs. `.pnpm` and `.bin` are
|
|
* directory links into the repository's own node_modules, so that install
|
|
* rewrote the shared `.pnpm/lock.yaml` and bin shims. A fixture launched
|
|
* through `pnpm <script>` inherited `pnpm_config_verify_deps_before_run=false`
|
|
* from pnpm and was safe; the same fixture started directly
|
|
* (`node scripts/run-vitest.ts run <file>`) was not.
|
|
*/
|
|
describe("pnpm inside a linked fixture (F-4)", { timeout: childProcessTimeout(94) }, () => {
|
|
const scratch: string[] = [];
|
|
afterEach(async () => {
|
|
await Promise.all(
|
|
scratch.splice(0).map((root) => rm(root, { recursive: true, force: true })),
|
|
);
|
|
});
|
|
|
|
/** A tiny installed workspace standing in for the repository, offline. */
|
|
async function installedSource() {
|
|
const root = await mkdtemp(path.join(tmpdir(), "fixture-pnpm-"));
|
|
scratch.push(root);
|
|
const tool = path.join(root, "tool");
|
|
const source = path.join(root, "source");
|
|
await mkdir(tool, { recursive: true });
|
|
await mkdir(source, { recursive: true });
|
|
await writeFile(
|
|
path.join(tool, "package.json"),
|
|
JSON.stringify({ name: "tool", version: "1.0.0", bin: { tool: "cli.js" } }),
|
|
);
|
|
await writeFile(path.join(tool, "cli.js"), "#!/usr/bin/env node\n");
|
|
await writeFile(
|
|
path.join(source, "package.json"),
|
|
JSON.stringify({
|
|
name: "fixture-source",
|
|
version: "1.0.0",
|
|
private: true,
|
|
packageManager: "pnpm@11.17.0",
|
|
scripts: { hello: "echo hello-from-fixture" },
|
|
dependencies: { tool: "file:../tool" },
|
|
}),
|
|
);
|
|
await writeFile(path.join(source, "pnpm-workspace.yaml"), "allowBuilds: {}\n");
|
|
const environment: NodeJS.ProcessEnv = {
|
|
...pnpmFreeEnvironment(),
|
|
pnpm_config_store_dir: path.join(root, "store"),
|
|
};
|
|
// Installed on a developer machine (no CI); the fixtures then run pnpm
|
|
// with CI=true, which pnpm reads as different settings and reinstalls.
|
|
// pnpm also takes GITEA_ACTIONS, GITHUB_ACTIONS and other vendor
|
|
// variables for CI, so a runner job without CI still looked like CI and
|
|
// nothing was reinstalled. CI=false makes pnpm skip those checks.
|
|
const developer: NodeJS.ProcessEnv = { ...environment, CI: "false" };
|
|
const install = spawnSync("corepack", ["pnpm", "install", "--offline"], {
|
|
cwd: source,
|
|
encoding: "utf8",
|
|
env: developer,
|
|
});
|
|
expect(install.status, install.stdout + install.stderr).toBe(0);
|
|
return { root, source, environment };
|
|
}
|
|
|
|
// The test runner itself may run under pnpm, which exports the setting.
|
|
function pnpmFreeEnvironment(): NodeJS.ProcessEnv {
|
|
const environment: NodeJS.ProcessEnv = { ...process.env, CI: "true" };
|
|
delete environment.pnpm_config_verify_deps_before_run;
|
|
return environment;
|
|
}
|
|
|
|
async function sharedState(source: string) {
|
|
const lock = await stat(path.join(source, "node_modules/.pnpm/lock.yaml"));
|
|
const bin = await stat(path.join(source, "node_modules/.bin/tool"));
|
|
return [lock.mtimeMs, lock.ino, bin.mtimeMs, bin.ino];
|
|
}
|
|
|
|
async function runInFixture(
|
|
root: string,
|
|
source: string,
|
|
environment: NodeJS.ProcessEnv,
|
|
) {
|
|
const fixture = path.join(root, `fixture-${scratch.length}-${Date.now()}`);
|
|
await mkdir(fixture);
|
|
for (const file of selectRepositoryPaths("package-manifest")) {
|
|
await copyFile(path.join(source, file), path.join(fixture, file));
|
|
}
|
|
await linkFixtureNodeModules(fixture, source);
|
|
const before = await sharedState(source);
|
|
const result = spawnSync("corepack", ["pnpm", "hello"], {
|
|
cwd: fixture,
|
|
encoding: "utf8",
|
|
env: environment,
|
|
});
|
|
return { result, changed: (await sharedState(source)).join() !== before.join() };
|
|
}
|
|
|
|
it("installs through the linked directories unless told not to", async () => {
|
|
const { root, source, environment } = await installedSource();
|
|
|
|
// The hazard: the default re-verification installs into the shared tree.
|
|
expect((await runInFixture(root, source, environment)).changed).toBe(true);
|
|
|
|
const guarded = await runInFixture(root, source, {
|
|
...environment,
|
|
...FIXTURE_PNPM_ENVIRONMENT,
|
|
});
|
|
expect(guarded.result.status, guarded.result.stderr).toBe(0);
|
|
expect(guarded.result.stdout).toContain("hello-from-fixture");
|
|
expect(guarded.changed).toBe(false);
|
|
}, childProcessTimeout(9_876));
|
|
|
|
it("is used by every fixture that links node_modules and runs pnpm", async () => {
|
|
const listed = spawnSync(
|
|
"git",
|
|
["grep", "-l", "linkFixtureNodeModules(", "--", ...selectRepositoryPaths("fixture-code")],
|
|
{ encoding: "utf8" },
|
|
);
|
|
expect(listed.status, listed.stderr).toBe(0);
|
|
const offenders: string[] = [];
|
|
for (const file of listed.stdout.trim().split("\n")) {
|
|
if (file === "scripts/lib/fixture-node-modules.ts") continue;
|
|
if (file === "tests/unit/fixture-node-modules.test.ts") continue;
|
|
const source = await readFile(file, "utf8");
|
|
const runsPnpm = /\["pnpm"|\[pnpmCli\b/u.test(source);
|
|
if (runsPnpm && !source.includes("FIXTURE_PNPM_ENVIRONMENT")) offenders.push(file);
|
|
}
|
|
expect(offenders).toEqual([]);
|
|
});
|
|
});
|