셸·페이지 템플릿·카드 CSS가 간격·글자·반경·층·그림자 토큰을 건너뛰고 날 값을 쓴다(`src/presentation/styles/theme/*.css`에서 규칙에 걸리는 선언 118개). `shell.css`·`pages.css`·`templates.css`는 `var(--space-*)`를 한 번도 쓰지 않았고, z-index 100·30·10, 카드·헤더의 손 그림자, `999px`, `min-height: 2.75rem`이 토큰과 같은 값을 다시 적었다. 필수 semantic 토큰 가운데 `--layer-navigation`·`--layer-modal`·`--opacity-scrim`· `--opacity-skeleton`·`--elevation-panel`·`--color-disabled-content`· `--color-action-pressed`를 읽는 스타일이 없었다. 그래서 파생 서비스가 밀도·층·그림자를 토큰으로 바꿔도 화면이 그대로다. 그리고 component.css의 가림막 토큰 셋이 `REQUIRED_COMPONENT_TOKENS`에 없어 UI-03 밖이었다(04-12). 고른 방법: - 날 값을 토큰으로 바꾼다. 맞는 단계가 없는 간격은 가까운 `--space-*`로 반올림했다(0.15~0.35rem → 1, 0.4~0.55 → 2, 0.65~0.85 → 3, 0.9 → 4). 큰 값 3.5rem·4rem은 `--space-14`·`--space-16`을 더했다. 글자 크기도 가까운 단계(0.8 → xs, 0.8125~0.9 → sm, 1.05 → md, 1.1 → lg, 1.35 → xl), 굵기 600·650 → semibold, 700·750·800 → bold, 줄 높이 1.5~1.6 → normal, 1.65·1.7 → relaxed. 페이지 h1은 semantic `--font-size-heading-1`· `--line-height-heading-1`(새 primitive 단계 3xl·4xl·compact)을 읽는다. - 층: skip link는 `--layer-navigation`, sticky 헤더와 sticky 폼 버튼은 `--layer-sticky`. 그림자: 카드·패널·갤러리 안내는 `--elevation-panel`, 헤더는 새 `--elevation-sticky`(`--shadow-sticky`). `.ui-panel`의 Tailwind `shadow-sm`도 `--elevation-panel`로 바꿔 카드와 같은 높이가 됐다. dialog는 `--radius-modal`, 가림막 비율은 `--opacity-scrim`을 읽고 `--dialog-backdrop-weight`는 지웠다. - 읽는 곳이 없던 semantic 토큰: skeleton 깜박임이 `--opacity-skeleton`, 꺼진 입력이 `--color-disabled-content`·`--color-disabled-surface`, 누른 primary 버튼이 새 component 토큰 `--button-primary-pressed` (`--color-action-pressed`)를 읽는다. `--layer-modal`은 native `<dialog>`가 top layer에 열려 z-index가 닿지 않으므로 이유와 함께 `SEMANTIC_TOKENS_WITHOUT_TEMPLATE_READER`에 둔다. - `check:design-system`에 셋을 더한다. UI-06: styles 아래 간격·글자·반경· z-index·그림자의 날 값을 줄 번호와 함께 거절한다. UI-03을 필수 semantic 토큰으로 넓힌다. component.css `@theme`의 토큰이 모두 계약에 있어야 한다. 계약에 `--button-primary-pressed`, `--dialog-backdrop`, `--dialog-backdrop-on-surface`를 더했다. - 버린 대안: 맞는 단계가 없는 값마다 primitive 단계를 더하기(단계가 두 배로 늘어 scale이 무의미해진다). `--layer-modal`을 dialog에 z-index로 읽히기 (top layer에서는 효과가 없는 가짜 읽기다). 위험·한계: 반올림과 패널 그림자 때문에 화면이 조금 바뀐다(간격 최대 0.15rem, 굵기 800 → 750, 패널 그림자 크기). 시각 골든은 이 커밋에서 다시 찍고 차이를 PR 본문에 적는다. 다운스트림이 styles에 날 값을 더해 두었으면 UI-06이 그 줄을 알린다. 너비·높이·위치(top 등)와 opacity는 UI-06 밖이다. 검증: 규칙 단위 시험과 check-design-system 연결 시험, 새 검사기로 고치기 전 CSS를 돌린 결과(RED), 시각 골든은 desktop에서 돌려 PR 본문에 적는다. Refs: 1112/04-08, 1112/04-12
206 lines
8.6 KiB
TypeScript
206 lines
8.6 KiB
TypeScript
// The CSS rules scripts/check-design-system.ts runs over the token files and
|
|
// the style sheets. Each rule takes file contents and
|
|
// returns failure messages, so a test can hand it a violation directly.
|
|
|
|
import { contrastRatio, resolveColor, resolveValue } from "./oklch-contrast.ts";
|
|
|
|
export interface CssSource {
|
|
readonly file: string;
|
|
readonly source: string;
|
|
}
|
|
|
|
// Comments keep old code around, and the browser never draws it. They turn
|
|
// into spaces, newlines kept, so a reported line number stays the file's.
|
|
// Limit: a "/*" inside a quoted string would start a false comment. No
|
|
// CSS here has one; switch to a CSS tokenizer if that changes.
|
|
function withoutComments(css: string): string {
|
|
return css.replace(/\/\*[\s\S]*?\*\//g, (comment) => comment.replace(/[^\n]/g, " "));
|
|
}
|
|
|
|
// UI-01. The focus ring is drawn 3px away from its control, so the colour
|
|
// next to it is the surface behind the control, not the control itself.
|
|
// WCAG 1.4.11 asks 3:1 against that neighbour, in both themes.
|
|
export const FOCUS_RING_BACKGROUNDS = [
|
|
"--color-surface",
|
|
"--color-surface-muted",
|
|
"--color-panel",
|
|
"--color-surface-elevated",
|
|
"--color-info-surface",
|
|
"--color-success-surface",
|
|
"--color-warning-surface",
|
|
"--color-danger-surface",
|
|
] as const;
|
|
|
|
// A colour-mix() or translucent value depends on what is drawn beneath it,
|
|
// so the rule refuses it rather than guess (12-04). The message says which
|
|
// token and which form it can compute.
|
|
export function focusContrastFailures(
|
|
theme: string,
|
|
properties: ReadonlyMap<string, string>,
|
|
): string[] {
|
|
const unreadable = (token: string) =>
|
|
`${theme} ${token} is ${resolveValue(token, properties) ?? "not defined"}; ` +
|
|
"contrast needs an opaque oklch(L C H), hue in degrees with or without deg";
|
|
const focus = resolveColor("--color-focus", properties);
|
|
if (!focus) return [unreadable("--color-focus")];
|
|
const failures: string[] = [];
|
|
for (const background of FOCUS_RING_BACKGROUNDS) {
|
|
const surface = resolveColor(background, properties);
|
|
if (!surface) {
|
|
failures.push(unreadable(background));
|
|
continue;
|
|
}
|
|
const ratio = contrastRatio(focus, surface);
|
|
if (ratio < 3) {
|
|
failures.push(
|
|
`${theme} --color-focus contrast ${ratio.toFixed(2)}:1 against ${background} is below 3:1`,
|
|
);
|
|
}
|
|
}
|
|
return failures;
|
|
}
|
|
|
|
// UI-02. Hue-based spaces interpolate the hue angle, and an achromatic
|
|
// stop such as oklch(1 0 0) carries hue 0: 14% blue into white came out
|
|
// pink. oklab mixes on straight lines and has no hue to drag. CSS
|
|
// function names and keywords ignore ASCII case, so OKLCH counts too.
|
|
export function hueMixFailures({ file, source }: CssSource): string[] {
|
|
const mixes = withoutComments(source).matchAll(
|
|
/color-mix\(\s*in\s+(oklch|lch|hsl|hwb)\b/gi,
|
|
);
|
|
return [...mixes].map((match) => `${file} mixes colours in ${match[1]}; use oklab`);
|
|
}
|
|
|
|
// UI-03. A component token nobody reads is a second copy of a decision:
|
|
// the style that should use it repeats the formula instead, and a product
|
|
// that rebrands through the token sees nothing change.
|
|
// A read is var(--name) or var(--name, fallback) with the whole name: a
|
|
// prefix match took var(--field-border-invalid) for a read of
|
|
// --field-border (12-01). "var" ignores case; custom property names don't.
|
|
export function unreadTokenFailures(
|
|
tokens: readonly string[],
|
|
styles: readonly CssSource[],
|
|
layer: "component" | "semantic" = "component",
|
|
): string[] {
|
|
const read = new Set(
|
|
styles.flatMap(({ source }) =>
|
|
[...withoutComments(source).matchAll(/var\(\s*(--[^\s,)]+)\s*[,)]/gi)]
|
|
.map((match) => match[1]),
|
|
),
|
|
);
|
|
return tokens
|
|
.filter((token) => !read.has(token))
|
|
.map((token) => `${layer} token ${token} is defined but no style reads it`);
|
|
}
|
|
|
|
// UI-03 (contract). A component token outside REQUIRED_COMPONENT_TOKENS is
|
|
// outside UI-03 too: the reader check only walks the contract list, so a
|
|
// token defined in component.css and read by nothing passed (1112/04-12).
|
|
// Only the @theme block counts: the forced-colors block redefines semantic
|
|
// roles, not component tokens.
|
|
export function undeclaredComponentTokenFailures(
|
|
{ file, source }: CssSource,
|
|
contract: readonly string[],
|
|
): string[] {
|
|
const theme = /@theme\s*\{([\s\S]*?)\n\}/.exec(withoutComments(source))?.[1] ?? "";
|
|
return [...theme.matchAll(/(--[a-z0-9-]+)\s*:/g)]
|
|
.map((match) => match[1])
|
|
.filter((token) => !contract.includes(token))
|
|
.map(
|
|
(token) =>
|
|
`${file} defines ${token}, which REQUIRED_COMPONENT_TOKENS in token-contract.ts does not list`,
|
|
);
|
|
}
|
|
|
|
// UI-05. --font-sans named Inter first, but nothing loads Inter, so most
|
|
// machines drew another font and Hangul never came from Inter at all.
|
|
// The first family must be a generic keyword, a browser name for the
|
|
// system font, one this repo ships, or one the product declares it loads
|
|
// (PRODUCT_LOADED_FONT_FAMILIES in token-contract.ts, 12-04).
|
|
const GENERIC_FONT_FAMILIES = new Set([
|
|
"system-ui",
|
|
"-apple-system",
|
|
"BlinkMacSystemFont",
|
|
"ui-sans-serif",
|
|
"ui-serif",
|
|
"ui-monospace",
|
|
"sans-serif",
|
|
"serif",
|
|
"monospace",
|
|
]);
|
|
|
|
export function firstFontFamilyFailures(
|
|
fontSans: string,
|
|
styles: readonly CssSource[],
|
|
productLoaded: readonly string[] = [],
|
|
): string[] {
|
|
const shipped = new Set([
|
|
...productLoaded,
|
|
...styles.flatMap(({ source }) =>
|
|
[...source.matchAll(/@font-face\s*\{[^}]*font-family:\s*["']?([^;"']+)/g)]
|
|
.map((match) => match[1].trim()),
|
|
),
|
|
]);
|
|
const first = fontSans.split(",")[0]?.trim().replace(/^["']|["']$/g, "") ?? "";
|
|
if (GENERIC_FONT_FAMILIES.has(first) || shipped.has(first)) return [];
|
|
return [
|
|
`--font-sans starts with "${first}", which is neither a generic family, loaded by @font-face, nor listed in PRODUCT_LOADED_FONT_FAMILIES`,
|
|
];
|
|
}
|
|
|
|
// UI-07. The semantic layer names roles and reads its colours from the
|
|
// palette in primitive.css. A colour written straight into semantic.css is
|
|
// out of reach of a rebrand that edits the palette: 36 such values kept the
|
|
// status colours, the focus ring and most of the dark theme as they were
|
|
// (1112/04-13).
|
|
const RAW_COLOUR = /#[0-9a-f]{3,8}\b|\b(?:oklch|oklab|lch|lab|rgba?|hsla?|hwb|color)\(/i;
|
|
|
|
export function rawSemanticColourFailures({ file, source }: CssSource): string[] {
|
|
return [...withoutComments(source).matchAll(/(--[a-z0-9-]+)\s*:\s*([^;]+);/gi)]
|
|
.filter((match) => RAW_COLOUR.test(match[2]))
|
|
.map(
|
|
(match) =>
|
|
`${file} ${match[1]} is the raw colour ${match[2].trim()}; name it in primitive.css and read it with var()`,
|
|
);
|
|
}
|
|
|
|
// UI-06. A style that writes a spacing, type, radius, layer or shadow value
|
|
// by hand does not move when the token does: changing --space-*, --layer-*,
|
|
// --elevation-panel or --radius-modal left the shell, the page templates and
|
|
// the cards as they were (1112/04-08). Allowed: a token read (var()), 0,
|
|
// auto, keywords, %, viewport units, a 1px hairline in margin or padding,
|
|
// line-height 1, z-index 0 or -1, and em sizes relative to the parent font.
|
|
const LENGTH = /(?<![\w.-])-?(?:\d+\.?\d*|\.\d+)(?:px|rem|em)\b/g;
|
|
const NUMBER = /(?<![\w.(-])-?(?:\d+\.?\d*|\.\d+)(?![\w.%])/g;
|
|
const SPACING_PROPERTY =
|
|
/^(?:padding|margin)(?:-(?:top|right|bottom|left|block|inline)(?:-(?:start|end))?)?$|^(?:row-|column-)?gap$/;
|
|
|
|
function handWrittenValues(property: string, value: string): string[] {
|
|
const tokensRemoved = value.replace(/var\([^)]*\)/g, "");
|
|
const lengths = tokensRemoved.match(LENGTH) ?? [];
|
|
const numbers = tokensRemoved.replace(LENGTH, "").match(NUMBER) ?? [];
|
|
if (SPACING_PROPERTY.test(property)) return lengths.filter((length) => !["1px", "-1px"].includes(length));
|
|
if (property === "font-size") return lengths.filter((length) => !/(?<!r)em$/.test(length));
|
|
if (property === "font-weight") return numbers;
|
|
if (property === "line-height") return [...lengths, ...numbers].filter((item) => item !== "1");
|
|
if (/^border(?:-[a-z]+)*-radius$/.test(property)) return lengths;
|
|
if (property === "z-index") return numbers.filter((item) => !["0", "-1"].includes(item));
|
|
if (property === "box-shadow") return [...lengths, ...numbers];
|
|
return [];
|
|
}
|
|
|
|
export function rawStyleValueFailures({ file, source }: CssSource): string[] {
|
|
const css = withoutComments(source);
|
|
const failures: string[] = [];
|
|
for (const match of css.matchAll(/(?<![\w-])([a-z-]+)\s*:\s*([^;{}]+);/g)) {
|
|
const [, property, value] = match;
|
|
const raw = handWrittenValues(property, value);
|
|
if (raw.length === 0) continue;
|
|
const line = css.slice(0, match.index).split("\n").length;
|
|
failures.push(
|
|
`${file}:${line} ${property}: ${value.trim()} writes ${raw.join(", ")} by hand; read a token (docs/styling/design-tokens.md UI-06)`,
|
|
);
|
|
}
|
|
return failures;
|
|
}
|