Files
clean-architecture-frontend…/tests/unit/two-feature-install-typecheck.test.ts
T
DongHyeonkaandClaude Opus 5.5 2a1591a2fe test(features): link fixture node_modules through the shared helper (09-01, 09-02)
check:adapter-inventory allows only linkFixtureNodeModules for fixture
dependencies; a single directory symlink lets a pnpm purge in the fixture
reach the repository's own node_modules.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-09-25 23:32:40 +09:00

182 lines
6.2 KiB
TypeScript

import { spawnSync } from "node:child_process";
import { cp, mkdir, mkdtemp, readFile, rm, writeFile } from "node:fs/promises";
import { tmpdir } from "node:os";
import path from "node:path";
import { afterAll, describe, expect, it } from "vitest";
import { linkFixtureNodeModules } from "../../scripts/lib/fixture-node-modules.ts";
/**
* 09-01. The central composers (`src/features/installed-*`) are typed from the
* generated feature index, so the repository's own typecheck only ever sees
* the features it ships. This installs two more into a copy of `src`, in a
* context of their own so the check survives the sample's removal: one with a
* route, a runtime and both locales but no adapter, and one shaped differently
* on every composed axis (an adapter that needs telemetry, no routes, no
* runtime, one locale). It regenerates the index
* with the production generator and runs the app typecheck over the copy.
*/
const SECOND_FEATURE_MODULE = `import { defineFeatureAdapterContribution } from "../feature-adapter-contribution.ts";
import { defineFeatureModule } from "../feature-module.ts";
type SecondFeatureInput = Readonly<{ ping(): string }>;
declare module "../../application/ports/in/application-api.ts" {
interface ApplicationFeatureInputs {
"second-feature": SecondFeatureInput;
}
}
export const FEATURE_MODULE_ID = "second-feature";
export const FEATURE_CONTEXT_ID = "two-feature-context";
export const FEATURE_MODULE = defineFeatureModule({
id: FEATURE_MODULE_ID,
contracts: {
featureId: FEATURE_MODULE_ID,
routes: {},
routeRuntimeContracts: {},
apiOperations: {},
// Frozen empty arrays type as \`readonly never[]\`, not \`readonly []\`.
invalidation: {
topics: Object.freeze([]),
namespaces: Object.freeze([]),
edges: Object.freeze([]),
},
topicVersions: Object.freeze([]),
schemas: {},
runtimeSchemas: {},
mappers: {},
},
routes: {},
adapters: [
defineFeatureAdapterContribution({
featureId: FEATURE_MODULE_ID,
needs: ["telemetry"] as const,
createInput: () =>
Object.freeze({
featureId: FEATURE_MODULE_ID,
input: Object.freeze({ ping: () => "pong" }),
}),
}),
],
runtimes: [],
messages: { "en-US": { "secondFeature.title": "Second feature" } },
contractContributions: [],
} as const);
`;
const SECOND_FEATURE_ROUTES = `import type { RouteObject } from "react-router-dom";
export const FEATURE_CONTEXT_ROUTES: readonly RouteObject[] = Object.freeze([]);
`;
const ROUTED_FEATURE_MODULE = `import { defineFeatureModule } from "../feature-module.ts";
export const FEATURE_MODULE_ID = "routed-feature";
export const FEATURE_CONTEXT_ID = "two-feature-context";
const ROUTES = {
ROUTED_ITEMS: {
routeId: "ROUTED_ITEMS",
path: "/two-feature/items",
paramsSchema: null,
searchSchema: null,
access: "public",
loadingSurface: "routed-items",
errorSurface: "feature-boundary",
chunkId: "route-routed-items",
title: "route.ROUTED_ITEMS.title",
navigationLabel: null,
navigationOrder: null,
},
} as const;
const MESSAGES = {
"route.ROUTED_ITEMS.title": "Routed items",
"route.ROUTED_ITEMS.navigation": "Routed items",
} as const;
export const FEATURE_MODULE = defineFeatureModule({
id: FEATURE_MODULE_ID,
contracts: {
featureId: FEATURE_MODULE_ID,
routes: ROUTES,
routeRuntimeContracts: {
ROUTED_ITEMS: {
routeId: "ROUTED_ITEMS",
moduleId: "routed-items-page",
paramsCodec: "none",
searchCodec: "none",
},
},
apiOperations: {},
invalidation: { topics: [], namespaces: [], edges: [] },
topicVersions: [],
schemas: {},
runtimeSchemas: {},
mappers: {},
},
routes: ROUTES,
adapters: [],
runtimes: [{ featureId: FEATURE_MODULE_ID, routeCodecs: {}, routeRuntime: {} }],
messages: { "ko-KR": MESSAGES, "en-US": MESSAGES },
contractContributions: [],
} as const);
`;
const CONTEXT_MODULE = `export const CONTEXT_MODULE_ID = "two-feature-context";
export const CONTEXT_APP_ID = "template-app";
export const CONTEXT_ROUTE_PATH = "two-feature/*";
export const CONTEXT_MAX_FEATURES = 2;
`;
const roots: string[] = [];
afterAll(async () => {
await Promise.all(roots.map((root) => rm(root, { recursive: true, force: true })));
});
describe("installing a second feature (09-01)", () => {
it("keeps the app typecheck green with two differently shaped features", async () => {
const root = await mkdtemp(path.join(tmpdir(), "two-feature-install-"));
roots.push(root);
await cp(path.resolve("src"), path.join(root, "src"), { recursive: true });
for (const config of ["tsconfig.base.json", "tsconfig.app.json"]) {
await cp(path.resolve(config), path.join(root, config));
}
await linkFixtureNodeModules(root);
const files: Readonly<Record<string, string>> = {
"src/contexts/two-feature-context/context-module.ts": CONTEXT_MODULE,
"src/features/routed-feature/feature-module.ts": ROUTED_FEATURE_MODULE,
"src/features/routed-feature/context-routes.ts": SECOND_FEATURE_ROUTES,
"src/features/second-feature/feature-module.ts": SECOND_FEATURE_MODULE,
"src/features/second-feature/context-routes.ts": SECOND_FEATURE_ROUTES,
};
for (const [file, content] of Object.entries(files)) {
await mkdir(path.dirname(path.join(root, file)), { recursive: true });
await writeFile(path.join(root, file), content);
}
const generated = spawnSync(
process.execPath,
[path.resolve("scripts/generate-product-feature-index.ts"), `--root=${root}`],
{ encoding: "utf8" },
);
expect(generated.stderr).toBe("");
expect(generated.status).toBe(0);
const index = await readFile(path.join(root, "src/.generated/product-feature-index.ts"), "utf8");
expect(index).toContain("../features/second-feature/feature-module.ts");
expect(index).toContain("../features/routed-feature/feature-module.ts");
const typecheck = spawnSync(
path.resolve("node_modules/.bin/tsc"),
["--project", path.join(root, "tsconfig.app.json")],
{ encoding: "utf8" },
);
expect(typecheck.stdout + typecheck.stderr).toBe("");
expect(typecheck.status).toBe(0);
}, 60_000);
});