V3 returned the same UNAUTHENTICATED outcome for "no credential, nothing sent" and for a server 401, and the composition root called onUnauthenticated() for both. With the demo owner that overwrote a recovery-pending session with "unauthenticated", and the demo setState notified even when the value did not change, which fed the scope-fence loop. - V3: the server-401 UNAUTHENTICATED outcome now carries its response `metadata` (additive optional field). The pre-dispatch one does not. - runtime-adapters: onUnauthenticated() only when metadata is present. - demo session: setState is a no-op for the current value. RED before fix: reference-runtime-composition.test.ts "does not report a request refused before dispatch as a sign-out" (state became "unauthenticated"), auth-session-adapter.test.ts "does not notify when the demo state is set to its current value" (1 notification), http-execution-v3.test.ts "tells a missing credential apart from a server 401" (no metadata). Pinned: "still signs out when the server answers 401". Gates: check:architecture, check:types:app, check:types:test, lint, test:component, test:integration, test:reference-feature, test:contract pass. test:unit passes except removal-fixture.test.ts (needs generated artifacts/ release evidence absent in a fresh worktree; unrelated). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
114 lines
3.7 KiB
TypeScript
114 lines
3.7 KiB
TypeScript
import { describe, expect, it, vi } from "vitest";
|
|
|
|
import {
|
|
createAnonymousSessionAdapter,
|
|
createDemoSessionAdapter,
|
|
createExternalAuthSessionAdapter,
|
|
} from "../../src/adapters/auth/external-session-adapter.ts";
|
|
|
|
describe("external AuthSessionPort adapter", () => {
|
|
it("attaches opaque credentials without exposing a token-shaped session", async () => {
|
|
const adapter = createExternalAuthSessionAdapter({
|
|
readState: () => "authenticated",
|
|
subscribe: () => () => {},
|
|
beginSignIn: async () => {},
|
|
signOut: async () => {},
|
|
attachCredential: async () => ({
|
|
headers: { Authorization: "Bearer opaque" },
|
|
}),
|
|
recoverSession: async () => "restored",
|
|
notifyUnauthenticated: vi.fn(),
|
|
});
|
|
|
|
const patch = await adapter.credentialPatch({
|
|
origin: "https://api.test",
|
|
method: "GET",
|
|
operationId: "GET_RESOURCE",
|
|
});
|
|
expect(patch.headers.authorization).toBe("Bearer opaque");
|
|
expect(adapter.getState()).toBe("authenticated");
|
|
expect(adapter).not.toHaveProperty("accessToken");
|
|
expect(adapter).not.toHaveProperty("refreshToken");
|
|
});
|
|
|
|
it("fails invalid recovery states closed", async () => {
|
|
const adapter = createExternalAuthSessionAdapter({
|
|
readState: () => "authenticated",
|
|
subscribe: () => () => {},
|
|
beginSignIn: async () => {},
|
|
signOut: async () => {},
|
|
attachCredential: async () => ({ headers: {} }),
|
|
// @ts-expect-error Deliberately violates the external-owner contract.
|
|
recoverSession: async () => "unexpected",
|
|
notifyUnauthenticated: vi.fn(),
|
|
});
|
|
|
|
await expect(adapter.recover()).rejects.toThrow("invalid recovery state");
|
|
});
|
|
|
|
it("rejects credential patches that can alter transport-owned headers", async () => {
|
|
const adapter = createExternalAuthSessionAdapter({
|
|
readState: () => "authenticated",
|
|
subscribe: () => () => {},
|
|
beginSignIn: async () => {},
|
|
signOut: async () => {},
|
|
attachCredential: async () => ({
|
|
headers: { Host: "attacker.test" },
|
|
}),
|
|
recoverSession: async () => "restored",
|
|
notifyUnauthenticated: vi.fn(),
|
|
});
|
|
|
|
await expect(
|
|
adapter.credentialPatch({
|
|
origin: "https://api.test",
|
|
method: "GET",
|
|
operationId: "GET_RESOURCE",
|
|
}),
|
|
).rejects.toThrow("forbidden credential patch");
|
|
});
|
|
|
|
it("provides a safe anonymous adapter", async () => {
|
|
const adapter = createAnonymousSessionAdapter();
|
|
expect(adapter.getState()).toBe("unauthenticated");
|
|
await expect(adapter.recover()).resolves.toBe("no-session");
|
|
});
|
|
|
|
it("provides a reactive credential-free demo seam", async () => {
|
|
const adapter = createDemoSessionAdapter();
|
|
let notifications = 0;
|
|
const unsubscribe = adapter.subscribe(() => {
|
|
notifications += 1;
|
|
});
|
|
|
|
expect(adapter.getState()).toBe("unauthenticated");
|
|
await adapter.beginSignIn();
|
|
expect(adapter.getState()).toBe("authenticated");
|
|
await adapter.signOut();
|
|
expect(adapter.getState()).toBe("unauthenticated");
|
|
expect(notifications).toBe(2);
|
|
unsubscribe();
|
|
});
|
|
|
|
it("does not notify when the demo state is set to its current value", async () => {
|
|
const adapter = createDemoSessionAdapter("recovery-pending");
|
|
let notifications = 0;
|
|
adapter.subscribe(() => {
|
|
notifications += 1;
|
|
});
|
|
|
|
adapter.setState("recovery-pending");
|
|
expect(notifications).toBe(0);
|
|
|
|
adapter.setState("authenticated");
|
|
await adapter.beginSignIn();
|
|
expect(notifications).toBe(1);
|
|
|
|
adapter.onUnauthenticated();
|
|
adapter.onUnauthenticated();
|
|
await adapter.signOut();
|
|
expect(adapter.getState()).toBe("unauthenticated");
|
|
expect(notifications).toBe(2);
|
|
});
|
|
});
|