A path value of "." or ".." survives encodeURIComponent unchanged, and URL
resolution (V3 `new URL`, V2 `pathname =` assignment) then collapses it into
a parent path that still sits under the base URL, so `URL_ORIGIN_ESCAPED`
never fired. `/members/{m}` with m=".." pointed at the project instead.
The V3 bridge now returns PATH_VALUE_INVALID and the V2 request builder
returns PATH_PARAMETER_INVALID for exactly those two values.
RED before fix: tests/unit/http-contract-bridge.test.ts "rejects the dot
segment ..." and tests/unit/request-builder.test.ts "rejects the dot segment
..." returned ok/success with a parent URL.
Gates: check:architecture, check:types:app, check:types:test, lint,
test:component pass. test:unit passes except removal-fixture.test.ts, which
needs generated artifacts/ release evidence absent in a fresh worktree
(unrelated to this change).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
31 lines
943 B
TypeScript
31 lines
943 B
TypeScript
import { describe, expect, it } from "vitest";
|
|
|
|
import { projectRequest } from "../../src/adapters/http/http-contract-bridge.ts";
|
|
import { TEST_DETAIL_HTTP_CONTRACT } from "../helpers/external-contract-fixture.ts";
|
|
|
|
describe("descriptor-driven path projection", () => {
|
|
it.each([".", ".."])(
|
|
"rejects the dot segment %j instead of letting URL resolution move the target",
|
|
(entityId) => {
|
|
expect(
|
|
projectRequest(
|
|
TEST_DETAIL_HTTP_CONTRACT,
|
|
{ entityId },
|
|
"https://api.test/base/",
|
|
),
|
|
).toEqual({ ok: false, failure: "PATH_VALUE_INVALID" });
|
|
},
|
|
);
|
|
|
|
it("still encodes an ordinary value containing dots", () => {
|
|
const outcome = projectRequest(
|
|
TEST_DETAIL_HTTP_CONTRACT,
|
|
{ entityId: "..a." },
|
|
"https://api.test/base/",
|
|
);
|
|
expect(outcome.ok && outcome.request.url).toBe(
|
|
"https://api.test/base/api/test-entities/..a.",
|
|
);
|
|
});
|
|
});
|