DongHyeonka
a145f30b48
fix(web-push): dot segment가 든 registry path를 생성 때 거절한다
...
문제
registry path는 router base path를 뺀 앱 경로이고, 정상 클릭은
`${appBasePath}${path}`를 URL로 풀어 연다. registry 검사는 `/` 시작,
`//`·`\`·`#` 금지, 같은 origin만 본다. URL parser는 `..`와 `%2e%2e`를
dot segment로 풀기 때문에 scope `/app/`에서 `/../admin`과
`/%2e%2e/admin`이 모두 `https://app.example.test/admin `을 연다(리뷰
실험 ⑤). 검사를 통과한 경로가 앱 밖을 연다.
고른 방법
- safePath가 `new URL(path, base)`의 pathname + search가 입력과 같을 때만
받는다. `..`·`.`·`%2e%2e`(대소문자 무관)는 parser가 바꾸므로 거절된다.
query는 그대로 남는다.
- 버린 대안: 클릭 때 target.pathname이 앱 루트 아래인지 보기. 잘못된
registry가 클릭할 때에야 드러난다. registry는 제품 코드라 생성 시점에
throw하는 쪽이 이르고 작다(리뷰 5.3 (a)).
위험·한계
- 정규화되지 않은 경로(인코딩 안 된 비ASCII 문자, 빈 query `?`)도
거절된다. registry를 쓰는 제품 코드는 아직 없다.
- registry가 서버가 내려주는 런타임 데이터가 되면 클릭 때 검사도 함께
둬야 한다(리뷰 재검토 조건).
검증
- 새 테스트를 옛 코드에 돌림: 5건 실패(RED). 새 코드: web-push 단위
6파일 76건 통과.
- 바꾼 파일 eslint 통과.
Refs: docs/reviews/2026-11-03-maturity-review/06-adapters-service-worker-push.md 06-02
2026-11-04 20:24:14 +09:00
..
2026-11-03 00:56:00 +09:00
2026-11-03 00:55:33 +09:00
2026-11-04 20:23:21 +09:00
2026-09-24 15:33:13 +09:00
2026-11-03 21:37:48 +09:00
2026-11-01 23:44:29 +09:00
2026-09-25 22:37:21 +09:00
2026-09-25 22:49:32 +09:00
2026-09-25 22:58:37 +09:00
2026-09-24 16:25:22 +09:00
2026-11-03 21:12:34 +09:00
2026-09-24 00:42:21 +09:00
2026-09-26 00:29:34 +09:00
2026-11-01 23:14:47 +09:00
2026-09-26 00:29:34 +09:00
2026-09-24 00:42:21 +09:00
2026-11-01 23:14:47 +09:00
2026-11-01 22:25:41 +09:00
2026-09-24 00:42:21 +09:00
2026-11-03 01:24:31 +09:00
2026-09-24 00:42:21 +09:00
2026-09-24 00:42:21 +09:00
2026-09-25 22:54:40 +09:00
2026-11-01 22:49:13 +09:00
2026-09-24 00:42:21 +09:00
2026-09-24 13:58:35 +09:00
2026-09-24 00:42:21 +09:00
2026-11-03 06:52:43 +09:00
2026-09-24 00:42:21 +09:00
2026-09-26 00:04:25 +09:00
2026-09-24 13:41:45 +09:00
2026-09-24 13:45:37 +09:00
2026-11-03 00:55:33 +09:00
2026-11-03 21:37:48 +09:00
2026-09-24 13:45:37 +09:00
2026-11-03 00:55:33 +09:00
2026-11-03 20:10:51 +09:00
2026-11-01 23:14:47 +09:00
2026-09-24 13:41:45 +09:00
2026-11-03 07:17:49 +09:00
2026-11-03 06:52:43 +09:00
2026-09-24 00:42:21 +09:00
2026-11-03 01:24:31 +09:00
2026-11-03 01:24:31 +09:00
2026-09-24 00:42:21 +09:00
2026-09-25 22:52:33 +09:00
2026-11-03 01:13:16 +09:00
2026-11-03 20:25:01 +09:00
2026-09-26 00:16:55 +09:00
2026-11-03 01:58:38 +09:00
2026-09-25 23:25:24 +09:00
2026-09-25 23:10:19 +09:00
2026-11-03 00:55:33 +09:00
2026-09-24 00:42:21 +09:00
2026-09-27 13:20:12 +09:00
2026-11-03 00:56:00 +09:00
2026-09-24 12:25:01 +09:00
2026-09-25 22:56:22 +09:00
2026-09-24 00:42:21 +09:00
2026-09-24 00:42:21 +09:00
2026-09-25 23:58:52 +09:00
2026-09-24 13:32:37 +09:00
2026-09-24 00:42:21 +09:00
2026-11-01 23:14:47 +09:00
2026-09-24 00:42:21 +09:00
2026-09-25 22:57:51 +09:00
2026-09-25 22:33:44 +09:00
2026-11-03 01:23:05 +09:00
2026-09-25 22:52:29 +09:00
2026-09-24 13:30:26 +09:00
2026-09-25 21:18:39 +09:00
2026-09-24 00:42:21 +09:00
2026-09-27 13:14:03 +09:00
2026-11-03 02:00:45 +09:00
2026-09-25 23:00:43 +09:00
2026-09-24 00:42:21 +09:00
2026-09-25 22:07:53 +09:00
2026-09-25 22:18:00 +09:00
2026-09-24 00:42:21 +09:00
2026-11-01 23:18:45 +09:00
2026-09-25 21:18:39 +09:00
2026-11-01 22:16:26 +09:00
2026-11-03 01:23:05 +09:00
2026-11-03 20:22:49 +09:00
2026-09-24 00:42:21 +09:00
2026-11-01 22:56:29 +09:00
2026-09-24 13:58:35 +09:00
2026-09-27 13:32:33 +09:00
2026-09-27 13:47:35 +09:00
2026-09-25 22:25:44 +09:00
2026-09-27 13:47:35 +09:00
2026-09-27 13:32:33 +09:00
2026-11-03 20:23:14 +09:00
2026-11-01 21:57:53 +09:00
2026-11-03 01:52:18 +09:00
2026-11-01 22:16:26 +09:00
2026-11-01 21:57:53 +09:00
2026-09-24 00:42:21 +09:00
2026-11-01 20:50:00 +09:00
2026-09-24 13:39:59 +09:00
2026-09-24 00:42:21 +09:00
2026-11-01 23:14:48 +09:00
2026-09-26 00:26:17 +09:00
2026-09-24 00:42:21 +09:00
2026-09-24 00:42:21 +09:00
2026-09-24 00:42:21 +09:00
2026-09-24 00:42:21 +09:00
2026-11-03 01:50:12 +09:00
2026-11-03 02:15:31 +09:00
2026-09-25 23:19:41 +09:00
2026-09-25 22:15:59 +09:00
2026-09-25 23:19:09 +09:00
2026-09-27 13:16:31 +09:00
2026-11-03 22:22:35 +09:00
2026-09-26 00:36:49 +09:00
2026-09-25 22:36:00 +09:00
2026-11-01 23:14:47 +09:00
2026-11-01 23:14:48 +09:00
2026-09-25 22:25:44 +09:00
2026-11-03 00:36:28 +09:00
2026-09-24 11:55:57 +09:00
2026-09-27 13:32:33 +09:00
2026-09-24 00:42:21 +09:00
2026-11-03 21:12:34 +09:00
2026-11-01 23:44:29 +09:00
2026-09-24 00:42:21 +09:00
2026-09-25 22:58:37 +09:00
2026-11-03 00:55:33 +09:00
2026-11-03 20:23:14 +09:00
2026-11-03 21:12:34 +09:00
2026-09-24 00:42:21 +09:00
2026-11-03 21:37:48 +09:00
2026-09-24 00:42:21 +09:00
2026-09-24 00:42:21 +09:00
2026-09-27 13:32:33 +09:00
2026-09-24 00:42:21 +09:00
2026-09-24 16:25:22 +09:00
2026-09-27 12:57:41 +09:00
2026-11-03 00:56:00 +09:00
2026-09-26 01:01:47 +09:00
2026-11-01 22:49:38 +09:00
2026-09-24 00:42:21 +09:00
2026-11-01 22:25:41 +09:00
2026-09-25 22:38:34 +09:00
2026-09-25 21:34:12 +09:00
2026-09-24 00:42:21 +09:00
2026-11-01 22:42:44 +09:00
2026-09-25 21:34:12 +09:00
2026-11-03 07:17:49 +09:00
2026-09-26 01:01:49 +09:00
2026-09-26 00:22:16 +09:00
2026-11-03 21:37:48 +09:00
2026-09-24 00:42:21 +09:00
2026-11-03 01:24:31 +09:00
2026-09-25 22:23:01 +09:00
2026-09-24 00:42:21 +09:00
2026-09-24 00:42:21 +09:00
2026-09-24 00:42:21 +09:00
2026-11-01 23:18:45 +09:00
2026-09-25 23:19:41 +09:00
2026-09-24 13:54:42 +09:00
2026-09-24 00:42:21 +09:00
2026-09-24 00:42:21 +09:00
2026-09-24 00:42:21 +09:00
2026-09-26 00:32:19 +09:00
2026-11-04 20:24:14 +09:00
2026-11-03 01:58:38 +09:00