Realtime kept three DataSnapshot readers and about ten hand-written abort/timeout races, and two parsers had drifted copies in other adapters. Snapshot: reconnect-coordinator and bounded-poll now use result.ts captureRealtimeDataSnapshot (+ `source`, variadic hasExactSnapshotKeys). Kept the result.ts rules, the stricter ones: Object.hasOwn instead of `"value" in` (prototype pollution), enumerable fields only, keys read from one descriptor snapshot, frozen computed at snapshot time instead of a later Object.isFrozen. Poll therefore now rejects non-enumerable fields; it also accepts null-prototype records, which the other two copies already did (pure data, no inherited accessors). Characterization test added for both in bounded-poll-coordinator.test.ts. Race: one raceRealtimeTask(task, signal, deadline) in result.ts, built on kernel createAbortableOperation, replaces fetch-sse timed/cancelReader, reconnect race/drain (the drain keeps a host timer via timerDeadline, since the clock itself may hang), poll awaitTaskOrAbort/awaitWithinLease, live-poll checkpoint + two quiescence races (now one), stream-coordinator deadline/recovery-wait/close-drain, and the two WS inline races. Kept semantics: deadline armed first and wins a tie (poll lease), task still starts when the clock throws (reader cancel), collaborator rejections still reach stream-coordinator callers, scheduler install failure still fails closed as a timeout. Small change: nothing starts once the signal is already aborted (WS apply / SSE onEvent / reader.read could run just before being reported ABORTED). The mapping adds one microtask per race, so the reconnect test flush() helper gets 16 turns instead of 8. Kernel: parseRetryAfterDelay moves to platform/retry-after.ts (realtime re-exports it; http retry-policy parseRetryAfter now delegates, so it rejects "", " ", "1e3", "1.5", "0x10" and non-IMF dates it used to accept). json-member-scanner moves to platform/; web-push push-codec uses it instead of its top-level-only duplicate-key check, so nested duplicates are rejected too. INVENTORY 136 -> 137, detail tables updated. Tests: RED for http strict Retry-After, web-push nested duplicate, poll snapshot rules; new direct raceRealtimeTask tests. Gates: architecture, types app/test (+ service-worker/web-worker), lint, adapter-inventory (abort ratchet 21/21), test:unit, test:component, realtime-boundaries, integration/platform all pass. Realtime bundle 40346 -> 39433 gzip. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
58 lines
1.8 KiB
TypeScript
58 lines
1.8 KiB
TypeScript
import { describe, expect, it } from "vitest";
|
|
|
|
import {
|
|
calculateBackoff,
|
|
parseRetryAfter,
|
|
retryDelay,
|
|
shouldRetry,
|
|
} from "../../src/adapters/http/retry-policy.ts";
|
|
|
|
describe("HTTP retry policy", () => {
|
|
it("uses capped exponential full jitter", () => {
|
|
expect(calculateBackoff(0, () => 0.5)).toBe(125);
|
|
expect(calculateBackoff(8, () => 1)).toBe(2_000);
|
|
});
|
|
|
|
it("parses retry-after and chooses the longer bounded delay", () => {
|
|
expect(parseRetryAfter("2", 0)).toBe(2_000);
|
|
expect(parseRetryAfter(" 2 ", 0)).toBe(2_000);
|
|
expect(parseRetryAfter("Thu, 01 Jan 1970 00:00:05 GMT", 1_000)).toBe(
|
|
4_000,
|
|
);
|
|
expect(retryDelay({ kind: "RATE_LIMITED", retryAfterMs: 500 }, 0, () => 0)).toBe(
|
|
500,
|
|
);
|
|
});
|
|
|
|
it("rejects Retry-After values that are not delta-seconds or an HTTP date", () => {
|
|
for (const value of ["", " ", "1e3", "1.5", "-1", "0x10", "2024-01-01"]) {
|
|
expect(parseRetryAfter(value, 0)).toBeNull();
|
|
}
|
|
});
|
|
|
|
it("allows at most two retries for safe or keyed requests", () => {
|
|
const failure = { kind: "SERVER_FAILURE" };
|
|
expect(shouldRetry({ idempotency: "safe" }, failure, 0)).toBe(true);
|
|
expect(shouldRetry({ idempotency: "keyed" }, failure, 1)).toBe(true);
|
|
expect(shouldRetry({ idempotency: "safe" }, failure, 2)).toBe(false);
|
|
expect(shouldRetry({ idempotency: "none" }, failure, 0)).toBe(false);
|
|
expect(
|
|
shouldRetry(
|
|
{ idempotency: "safe" },
|
|
{ kind: "SERVER_FAILURE", httpStatus: 500 },
|
|
0,
|
|
),
|
|
).toBe(false);
|
|
});
|
|
|
|
it("does not automatically wait beyond 30 seconds", () => {
|
|
expect(
|
|
shouldRetry(
|
|
{ idempotency: "safe" },
|
|
{ kind: "RATE_LIMITED", retryAfterMs: 31_000 },
|
|
0,
|
|
),
|
|
).toBe(false);
|
|
});
|
|
});
|