DongHyeonka
92d5019c6d
fix(ci): 제품 merge 게이트가 실패하면 같은 run의 release 단계를 멈춘다
...
문제
제품 overlay(config/ci/product-gates.json)의 mergeGates는 product_merge_gate
job으로 렌더링되는데, 다른 job이 이 job을 기다리지 않는다. release_gate는
merge_gate만 기다린다. 그래서 제품 검사(예: 짝 백엔드 계약 검사)가 실패해도
같은 run의 release·immutable_build·promotion·deployment는 그대로 돈다. 브랜치
필수 검사는 PR merge만 막는다. job 그래프는 계약이 고정해서(ci-gates.ts의
expectedJobGraph) 제품이 연결을 더할 방법도 없다.
고른 방법
- overlay에 게이트가 있으면 release_gate의 needs에 product_merge_gate를 더해
렌더링한다(`needs: [merge_gate, product_merge_gate]`). release_gate는 release
단계의 첫 job이고 뒤의 job은 모두 그것을 거쳐 기다린다. 템플릿 게이트가
release를 막는 방식과 같다.
- 연결은 렌더링에서만 더한다. gates.json과 계약 그래프 검사는 그대로라 템플릿
job 그래프와 check:ci의 엄격함은 바뀌지 않는다. 게이트가 없으면 workflow
바이트가 같다(.gitea/workflows/quality-gates.yml 변경 없음).
- workflowGateExecutionFailures(check:ci가 부름)가 제품 게이트가 있는데
release_gate가 product_merge_gate를 기다리지 않는 workflow를 거절한다.
"실행된다"와 "막는다"를 따로 본다.
- 문서(ci-quality-gates.md, README)에 release 단계가 제품 job을 기다린다고
적었다.
- 버린 대안: (a) 문서에만 "막지 않는다"고 적기. 제품이 막을 방법이 계속 없다.
(c) 게이트마다 blocksRelease 칸. 선택권은 주지만 칸이 늘고, 불안정한 제품
검사가 생기기 전에는 필요가 없다. 계약 그래프 검사에 overlay 예외를 넣는 것:
템플릿 계약이 제품 overlay를 알아야 한다.
위험·한계
- 불안정한 제품 게이트는 이제 release도 멈춘다. 그때는 (c)로 간다.
- Gitea가 needs와 기본 success() 조건을 GitHub Actions처럼 처리한다고 본다.
실제 runner에서는 확인하지 못했다(Actions 꺼짐).
- 제품 게이트를 이미 쓰는 다운스트림은 generate:ci-workflow를 다시 돌려야
check:ci를 통과한다(생성 YAML의 release_gate needs 한 줄이 바뀐다).
검증
- desktop batch에서 확인: node scripts/run-vitest.ts run
tests/unit/product-ci-overlay.test.ts tests/unit/ci-workflow-generation.test.ts,
corepack pnpm check:ci.
- RED 기대: "holds the release stage until the product merge gates pass",
"runs product merge gates in a job of their own, apart from the template gates".
Refs: 1105/13-02
2026-11-05 22:41:50 +09:00
..
2026-11-05 22:12:30 +09:00
2026-11-03 00:55:33 +09:00
2026-11-04 21:28:13 +09:00
2026-11-04 22:59:03 +09:00
2026-09-24 15:33:13 +09:00
2026-11-04 22:56:52 +09:00
2026-11-01 23:44:29 +09:00
2026-11-04 21:10:19 +09:00
2026-09-25 22:37:21 +09:00
2026-09-25 22:49:32 +09:00
2026-09-25 22:58:37 +09:00
2026-09-24 16:25:22 +09:00
2026-11-04 21:03:40 +09:00
2026-11-04 20:38:12 +09:00
2026-11-03 21:12:34 +09:00
2026-09-24 00:42:21 +09:00
2026-11-04 20:59:25 +09:00
2026-11-04 20:59:25 +09:00
2026-09-26 00:29:34 +09:00
2026-11-04 21:18:51 +09:00
2026-11-01 23:14:47 +09:00
2026-11-01 22:25:41 +09:00
2026-09-24 00:42:21 +09:00
2026-11-04 20:25:48 +09:00
2026-09-24 00:42:21 +09:00
2026-11-04 20:22:27 +09:00
2026-09-25 22:54:40 +09:00
2026-11-01 22:49:13 +09:00
2026-11-04 20:22:27 +09:00
2026-09-24 00:42:21 +09:00
2026-09-24 13:58:35 +09:00
2026-09-24 00:42:21 +09:00
2026-11-05 22:12:30 +09:00
2026-09-24 00:42:21 +09:00
2026-11-04 22:59:48 +09:00
2026-09-26 00:04:25 +09:00
2026-09-24 13:41:45 +09:00
2026-09-24 13:45:37 +09:00
2026-11-03 00:55:33 +09:00
2026-11-03 21:37:48 +09:00
2026-09-24 13:45:37 +09:00
2026-11-03 00:55:33 +09:00
2026-11-04 20:22:13 +09:00
2026-11-04 23:42:00 +09:00
2026-11-01 23:14:47 +09:00
2026-09-24 13:41:45 +09:00
2026-11-03 07:17:49 +09:00
2026-11-04 22:50:22 +09:00
2026-11-03 06:52:43 +09:00
2026-09-24 00:42:21 +09:00
2026-11-03 01:24:31 +09:00
2026-11-03 01:24:31 +09:00
2026-11-05 03:30:56 +09:00
2026-09-24 00:42:21 +09:00
2026-09-25 22:52:33 +09:00
2026-11-05 22:29:19 +09:00
2026-11-04 20:28:49 +09:00
2026-09-26 00:16:55 +09:00
2026-11-04 22:56:52 +09:00
2026-11-04 20:30:47 +09:00
2026-09-25 23:10:19 +09:00
2026-11-04 21:31:16 +09:00
2026-11-04 20:34:39 +09:00
2026-09-24 00:42:21 +09:00
2026-09-27 13:20:12 +09:00
2026-11-05 01:26:27 +09:00
2026-09-24 12:25:01 +09:00
2026-11-04 20:57:17 +09:00
2026-09-24 00:42:21 +09:00
2026-09-24 00:42:21 +09:00
2026-09-25 23:58:52 +09:00
2026-09-24 13:32:37 +09:00
2026-09-24 00:42:21 +09:00
2026-11-01 23:14:47 +09:00
2026-09-24 00:42:21 +09:00
2026-09-25 22:57:51 +09:00
2026-09-25 22:33:44 +09:00
2026-11-04 20:38:17 +09:00
2026-09-25 22:52:29 +09:00
2026-09-24 13:30:26 +09:00
2026-09-25 21:18:39 +09:00
2026-09-24 00:42:21 +09:00
2026-09-27 13:14:03 +09:00
2026-11-03 02:00:45 +09:00
2026-11-05 04:26:44 +09:00
2026-09-25 23:00:43 +09:00
2026-09-24 00:42:21 +09:00
2026-09-25 22:07:53 +09:00
2026-09-25 22:18:00 +09:00
2026-11-04 22:34:58 +09:00
2026-11-01 23:18:45 +09:00
2026-11-04 20:54:24 +09:00
2026-11-01 22:16:26 +09:00
2026-11-04 20:29:34 +09:00
2026-11-04 20:56:03 +09:00
2026-09-24 00:42:21 +09:00
2026-11-01 22:56:29 +09:00
2026-11-04 20:22:27 +09:00
2026-11-04 22:28:30 +09:00
2026-09-27 13:32:33 +09:00
2026-09-27 13:47:35 +09:00
2026-09-25 22:25:44 +09:00
2026-09-27 13:47:35 +09:00
2026-09-27 13:32:33 +09:00
2026-11-05 22:41:50 +09:00
2026-11-03 20:23:14 +09:00
2026-11-05 22:05:52 +09:00
2026-11-05 03:30:56 +09:00
2026-11-03 01:52:18 +09:00
2026-11-01 22:16:26 +09:00
2026-11-04 20:35:11 +09:00
2026-11-04 20:46:40 +09:00
2026-11-01 21:57:53 +09:00
2026-09-24 00:42:21 +09:00
2026-11-01 20:50:00 +09:00
2026-11-04 21:00:22 +09:00
2026-09-24 00:42:21 +09:00
2026-11-04 21:01:49 +09:00
2026-09-26 00:26:17 +09:00
2026-09-24 00:42:21 +09:00
2026-09-24 00:42:21 +09:00
2026-09-24 00:42:21 +09:00
2026-09-24 00:42:21 +09:00
2026-11-03 01:50:12 +09:00
2026-11-04 20:38:14 +09:00
2026-09-25 23:19:41 +09:00
2026-11-04 20:30:47 +09:00
2026-11-04 21:31:16 +09:00
2026-09-27 13:16:31 +09:00
2026-11-04 20:19:33 +09:00
2026-09-26 00:36:49 +09:00
2026-11-04 20:20:51 +09:00
2026-11-01 23:14:47 +09:00
2026-11-01 23:14:48 +09:00
2026-09-25 22:25:44 +09:00
2026-11-04 20:59:31 +09:00
2026-09-24 11:55:57 +09:00
2026-09-27 13:32:33 +09:00
2026-09-24 00:42:21 +09:00
2026-11-03 21:12:34 +09:00
2026-11-01 23:44:29 +09:00
2026-09-24 00:42:21 +09:00
2026-11-04 21:23:52 +09:00
2026-11-04 20:30:47 +09:00
2026-11-04 20:30:47 +09:00
2026-11-04 21:50:30 +09:00
2026-11-04 23:04:17 +09:00
2026-09-24 00:42:21 +09:00
2026-11-04 23:35:33 +09:00
2026-11-04 23:35:33 +09:00
2026-09-24 00:42:21 +09:00
2026-09-24 00:42:21 +09:00
2026-09-27 13:32:33 +09:00
2026-09-24 00:42:21 +09:00
2026-09-24 16:25:22 +09:00
2026-09-27 12:57:41 +09:00
2026-11-04 20:35:11 +09:00
2026-11-04 20:40:11 +09:00
2026-11-01 22:49:38 +09:00
2026-09-24 00:42:21 +09:00
2026-11-04 20:57:19 +09:00
2026-09-25 22:38:34 +09:00
2026-09-25 21:34:12 +09:00
2026-09-24 00:42:21 +09:00
2026-11-05 22:06:59 +09:00
2026-11-01 22:42:44 +09:00
2026-11-04 20:32:17 +09:00
2026-11-03 07:17:49 +09:00
2026-09-26 01:01:49 +09:00
2026-09-26 00:22:16 +09:00
2026-11-03 21:37:48 +09:00
2026-09-24 00:42:21 +09:00
2026-11-03 01:24:31 +09:00
2026-09-25 22:23:01 +09:00
2026-09-24 00:42:21 +09:00
2026-09-24 00:42:21 +09:00
2026-09-24 00:42:21 +09:00
2026-11-01 23:18:45 +09:00
2026-09-25 23:19:41 +09:00
2026-09-24 13:54:42 +09:00
2026-09-24 00:42:21 +09:00
2026-09-24 00:42:21 +09:00
2026-09-24 00:42:21 +09:00
2026-09-26 00:32:19 +09:00
2026-11-04 20:24:14 +09:00
2026-11-03 01:58:38 +09:00