문제 계약 문서 6.1절(ed0e4b1, 백엔드 5786126c 코드 기준)은 400·409·422 code마다 쓰기 전 거절인지를 정했다. 쓰기 전이라 적용 안 됨인 것은 400 VALIDATION_FAILED(details 모양과 상관없음), 400 IDEMPOTENCY_KEY_INVALID, 422 IDEMPOTENT_REQUEST_MISMATCH뿐이고, 표에 없는 400·409·422는 쓰기 뒤에도 나올 수 있어 결과 불명이다. 지금 판정은 이 표와 세 곳이 다르다. - V2: 필드 목록 없는 400 VALIDATION_FAILED({cause}, details 없음, {field, code})에 effect가 없다. 결과 불명으로 붙들려 다시 저장할 수 없다. - V2: 422는 code와 상관없이 적용 안 됨이다. fileserver의 422 INTEGRITY_MISMATCH·MALWARE_DETECTED는 레코드를 쓴 뒤 던진다. - V3 Envelope operation(7db32e1): 위 V2 규칙을 같이 쓰고, 표 밖 400·409·422는 classifyProblem에 맡긴다. 400·422를 모두 적용 안 됨으로 보는 분류기면 BAD_PARAMETER·도메인 400이 틀린다. 고른 방법 - backend-envelope.ts에 표 REFUSED_BEFORE_WRITE(code → status, 진단 reason)를 하나 두고 V2 client.ts, V3 실행기가 envelopeFailureEffect로 같이 읽는다. 표에 있으면 NOT_APPLIED, 그 밖의 400·409·422와 503 IDEMPOTENCY_UNAVAILABLE은 MAYBE_APPLIED, 나머지 status는 undefined (V2는 effect 없음, V3는 classifyProblem)다. 진단 reason도 같은 표에서 읽는다. - kind와 validationIssues 판정(isFieldValidationFailure)은 그대로 둔다. 필드 목록 없는 400 VALIDATION_FAILED는 UNKNOWN_CLIENT_FAILURE, 422는 VALIDATION_REJECTED다. 적용 여부만 바뀐다. - V3 Envelope operation에서는 400·409·422를 표가 정하고 classifyProblem이 바꾸지 못한다. 버린 대안 - V2와 V3에 표를 따로 두기:7db32e1전처럼 두 벌이 갈라진다. - 표 밖 400·409·422를 classifyProblem에 맡기기: 6.1절이 표 밖은 MAYBE_APPLIED로 정했고, 적용 안 됨을 잘못 내면 다음 저장이 새 키를 써 같은 작업이 두 번 적용된다. 잘못된 MAYBE_APPLIED는 결과 불명 화면만 남긴다. - 422 전부를 필드 검증(적용 안 됨)으로 남기기: 짝 백엔드는 필드 검증을 400으로 보내고, fileserver 422는 쓴 뒤 던진다. - V3 참조 기능 분류기 고치기: 참조 기능은 Envelope operation이 아니고 fixture가 problem details라 이 표의 대상이 아니다. 고치지 않았다. 위험·한계 - 필드 검증을 422로 보내는 다른 백엔드를 V2로 쓰는 프로젝트는 422 뒤에 폼에서 다시 저장할 수 없다(결과 불명). 프론트 계약 문서 4.2절의 "422 field validation" 행과 어긋난다. 그 문서는 이 커밋에서 고치지 않았다. - 표는 백엔드 5786126c 기준이다. 백엔드가 쓰기 전 거절 code를 새로 만들면 6.1절과 이 표를 함께 고쳐야 한다. 두 repo를 비교하는 검사는 없다. - 6.1절의 남은 위험: 백엔드가 use case 안에서 VALIDATION_FAILED를 내게 되면 적용 안 됨 판정이 틀린다. 검증 - RED: 바뀐 행 8건 실패. tests/integration/http-client.test.ts 필드 목록 없는 400 VALIDATION_FAILED 3모양의 effect, http-diagnostics.test.ts의 "unrelated 422"(effect NOT_APPLIED), http-execution-v3-envelope.test.ts의 고정 판정 2건(VALIDATION_FAILED 3모양 NOT_APPLIED, BAD_PARAMETER·도메인 409·fileserver 422 MAYBE_APPLIED), form-foundation.test.tsx 2건({cause} 실패 뒤 다시 저장, 422 뒤 저장 버튼 꺼짐). - GREEN: 위 4개 파일 128건 통과. V2와 V3에 같은 응답 11가지를 보내 판정을 비교하는 행이 모두 같다. - check:types, lint, check:architecture, check:diagnostics, check:ci, check:registries, check:adapter-inventory 통과. test:unit 2,604, test:integration 209, test:component 245, tests/features·tests/contract 124건 통과. check:bundle 203,354 / 204,800 B. Refs: docs/architecture/backend-api-and-server-state-contract.md 6.1 (ed0e4b1), docs/reviews/2026-11-01-maturity-review/README.md 14.4, 14.6
739 lines
26 KiB
TypeScript
739 lines
26 KiB
TypeScript
// @vitest-environment jsdom
|
|
|
|
import { render, screen, waitFor } from "@testing-library/react";
|
|
import userEvent from "@testing-library/user-event";
|
|
import { useState } from "react";
|
|
import { createMemoryRouter, RouterProvider, useNavigate } from "react-router-dom";
|
|
import { z } from "zod";
|
|
import { describe, expect, it, vi } from "vitest";
|
|
|
|
import { createHttpClient } from "../../src/adapters/http/client.ts";
|
|
import { createFailure } from "../../src/contracts/errors.ts";
|
|
import { createRuntimeIdentityRegistry } from "../../src/contracts/query-keys.ts";
|
|
import { useApplicationMutation } from "../../src/presentation/adapters/query/application-query.ts";
|
|
import { TEST_HTTP_CONTRACT } from "../helpers/http-contract-fixture.ts";
|
|
import { queryClient, scopeSnapshot, wrapper } from "./application-query-fixture.tsx";
|
|
import { Button } from "../../src/presentation/components/ui/button.ts";
|
|
import {
|
|
DirtyNavigationDialog,
|
|
ErrorSummary,
|
|
Form,
|
|
FormFailureStatus,
|
|
FormField,
|
|
useAppForm,
|
|
useDirtyNavigationGuard,
|
|
} from "../../src/presentation/forms/index.ts";
|
|
|
|
type Values = Readonly<Record<"name" | "note", string>>;
|
|
|
|
const schema = z
|
|
.object({
|
|
name: z.string().trim().min(2),
|
|
note: z.string().trim().default(""),
|
|
})
|
|
.strict();
|
|
const defaults: Values = { name: "", note: "" };
|
|
|
|
function FormHarness(props: Readonly<{
|
|
submit(command: Readonly<{ name: string; note?: string }>): Promise<
|
|
| Readonly<{ ok: true; value: string }>
|
|
| Readonly<{ ok: false; error: ReturnType<typeof createFailure> }>
|
|
>;
|
|
resetOnSuccess?: boolean;
|
|
onFailureAction?(): void;
|
|
}>) {
|
|
const form = useAppForm({
|
|
schema,
|
|
defaultValues: defaults,
|
|
allowedServerFields: ["name", "note"],
|
|
mapToCommand(values) {
|
|
return {
|
|
name: values.name,
|
|
...(values.note ? { note: values.note } : {}),
|
|
};
|
|
},
|
|
submit: props.submit,
|
|
resetOnSuccess: props.resetOnSuccess,
|
|
});
|
|
return (
|
|
<Form pending={form.pending} onSubmit={(event) => void form.submitForm(event)}>
|
|
<ErrorSummary
|
|
fieldErrors={form.fieldErrors}
|
|
formErrors={form.formErrors}
|
|
fieldLabels={{ name: "Name", note: "Note" }}
|
|
fieldId={form.fieldId}
|
|
onFocusField={form.focusField}
|
|
/>
|
|
<FormFailureStatus
|
|
failure={form.failure}
|
|
onAction={
|
|
form.result === "retry-later"
|
|
? () => void form.submitForm()
|
|
: props.onFailureAction
|
|
}
|
|
/>
|
|
<FormField {...form.field("name")} label="Name" required />
|
|
<FormField {...form.field("note")} label="Note" />
|
|
<Button type="submit" disabled={form.pending}>
|
|
{form.pending ? "Pending" : "Submit"}
|
|
</Button>
|
|
<Button onClick={() => form.reset()} disabled={!form.dirty}>
|
|
Reset
|
|
</Button>
|
|
<Button onClick={() => form.settleApplied()}>Confirm applied</Button>
|
|
<Button onClick={() => form.settleNotApplied()}>
|
|
Confirm not applied
|
|
</Button>
|
|
<output data-testid="dirty">{String(form.dirty)}</output>
|
|
<output data-testid="result">{form.result}</output>
|
|
<output data-testid="support">{form.supportReference ?? ""}</output>
|
|
</Form>
|
|
);
|
|
}
|
|
|
|
describe("local form facade", () => {
|
|
it("focuses the first invalid field and performs no command", async () => {
|
|
const user = userEvent.setup();
|
|
const submit = vi.fn();
|
|
render(<FormHarness submit={submit} />);
|
|
|
|
await user.click(screen.getByRole("button", { name: "Submit" }));
|
|
|
|
expect(submit).not.toHaveBeenCalled();
|
|
expect(screen.getByRole("textbox", { name: /Name/ })).toHaveFocus();
|
|
expect(screen.getByRole("alert")).toHaveTextContent("Name");
|
|
});
|
|
|
|
it("submits transformed data once and clears dirty state after success", async () => {
|
|
const user = userEvent.setup();
|
|
let finish: ((value: { ok: true; value: string }) => void) | undefined;
|
|
const submit = vi.fn(
|
|
() =>
|
|
new Promise<{ ok: true; value: string }>((resolve) => {
|
|
finish = resolve;
|
|
}),
|
|
);
|
|
render(<FormHarness submit={submit} />);
|
|
await user.type(screen.getByRole("textbox", { name: /Name/ }), " Ready ");
|
|
await user.type(screen.getByRole("textbox", { name: "Note" }), " Safe ");
|
|
|
|
await user.dblClick(screen.getByRole("button", { name: "Submit" }));
|
|
await waitFor(() => expect(submit).toHaveBeenCalledOnce());
|
|
expect(submit).toHaveBeenCalledWith({ name: "Ready", note: "Safe" });
|
|
expect(screen.getByRole("button", { name: "Pending" })).toBeDisabled();
|
|
finish?.({ ok: true, value: "saved" });
|
|
|
|
await waitFor(() => expect(screen.getByTestId("dirty")).toHaveTextContent("false"));
|
|
expect(screen.getByTestId("result")).toHaveTextContent("success");
|
|
});
|
|
|
|
it("maps only approved 422 fields and never renders backend copy", async () => {
|
|
const user = userEvent.setup();
|
|
const failure = createFailure(
|
|
"VALIDATION_REJECTED",
|
|
"CREATE_ENTITY",
|
|
0,
|
|
{
|
|
validationIssues: [
|
|
{ path: "name", code: "REQUIRED" },
|
|
{ path: "serverOnly", code: "raw-secret-message" },
|
|
],
|
|
},
|
|
);
|
|
render(
|
|
<FormHarness submit={async () => ({ ok: false, error: failure })} />,
|
|
);
|
|
await user.type(screen.getByRole("textbox", { name: /Name/ }), "Valid");
|
|
await user.click(screen.getByRole("button", { name: "Submit" }));
|
|
|
|
expect(await screen.findByRole("alert")).toHaveTextContent("필수 입력값입니다.");
|
|
expect(screen.getByRole("alert")).toHaveTextContent(
|
|
"서버가 확인하지 못한 입력 항목",
|
|
);
|
|
expect(document.body).not.toHaveTextContent("raw-secret-message");
|
|
});
|
|
|
|
// 백엔드 1101/02-01 후속. The paired backend answers a field validation
|
|
// failure with 400 VALIDATION_FAILED and details [{field, code, message}]
|
|
// (its docs/web/http-contract.md §4). It reaches the form through the V2
|
|
// client and lands on the same allowed fields a 422 does.
|
|
it("maps a paired backend 400 VALIDATION_FAILED onto the form fields", async () => {
|
|
const user = userEvent.setup();
|
|
const client = createHttpClient({
|
|
...TEST_HTTP_CONTRACT,
|
|
baseUrl: "https://api.test",
|
|
fetcher: async () =>
|
|
Response.json(
|
|
{
|
|
success: false,
|
|
error: {
|
|
code: "VALIDATION_FAILED",
|
|
category: "VALIDATION",
|
|
message: "요청 값이 올바르지 않습니다.",
|
|
retryable: false,
|
|
details: [
|
|
{ field: "name", code: "NOT_BLANK", message: "raw backend copy" },
|
|
{ field: "request", code: "INVALID", message: "raw backend copy" },
|
|
],
|
|
},
|
|
meta: { requestId: "request-1", traceId: "trace-1" },
|
|
},
|
|
{ status: 400 },
|
|
),
|
|
});
|
|
render(
|
|
<FormHarness
|
|
submit={async (command) => {
|
|
const result = await client.execute("CREATE_ENTITY", {
|
|
body: { name: command.name },
|
|
idempotencyKey: "key-1",
|
|
});
|
|
if (result.ok) throw new Error("expected a validation failure");
|
|
return result;
|
|
}}
|
|
/>,
|
|
);
|
|
await user.type(screen.getByRole("textbox", { name: /Name/ }), "Valid");
|
|
await user.click(screen.getByRole("button", { name: "Submit" }));
|
|
|
|
await waitFor(() =>
|
|
expect(screen.getByTestId("result")).toHaveTextContent("validation-error"),
|
|
);
|
|
expect(screen.getByRole("textbox", { name: /Name/ })).toHaveAttribute(
|
|
"aria-invalid",
|
|
"true",
|
|
);
|
|
expect(screen.getByRole("textbox", { name: /Note/ })).not.toHaveAttribute(
|
|
"aria-invalid",
|
|
);
|
|
// A class-level error names no form field.
|
|
expect(screen.getByRole("alert")).toHaveTextContent(
|
|
"서버가 확인하지 못한 입력 항목",
|
|
);
|
|
expect(document.body).not.toHaveTextContent("raw backend copy");
|
|
});
|
|
|
|
it.each([
|
|
[
|
|
"AUTH_REQUIRED",
|
|
"reauth-required",
|
|
"계속하려면 로그인이 필요합니다.",
|
|
"로그인",
|
|
],
|
|
[
|
|
"FORBIDDEN",
|
|
"forbidden",
|
|
"이 작업을 수행할 권한이 없습니다.",
|
|
"안전한 화면으로 이동",
|
|
],
|
|
[
|
|
"RATE_LIMITED",
|
|
"retry-later",
|
|
"요청이 많습니다. 잠시 후 다시 시도해 주세요.",
|
|
"다시 시도",
|
|
],
|
|
] as const)(
|
|
"shows %s as its own save state, not an input error",
|
|
async (kind, result, copy, action) => {
|
|
const user = userEvent.setup();
|
|
const onFailureAction = vi.fn();
|
|
const submit = vi.fn(async () => ({
|
|
ok: false as const,
|
|
error: createFailure(kind, "CREATE_ENTITY", 0, {
|
|
effect: "NOT_APPLIED",
|
|
}),
|
|
}));
|
|
render(
|
|
<FormHarness submit={submit} onFailureAction={onFailureAction} />,
|
|
);
|
|
await user.type(screen.getByRole("textbox", { name: /Name/ }), "Valid");
|
|
await user.click(screen.getByRole("button", { name: "Submit" }));
|
|
|
|
expect(await screen.findByTestId("result")).toHaveTextContent(result);
|
|
expect(screen.getByRole("alert")).toHaveTextContent(copy);
|
|
expect(document.body).not.toHaveTextContent("입력 내용을 확인해 주세요.");
|
|
expect(document.body).not.toHaveTextContent("저장하지 못했습니다.");
|
|
expect(
|
|
document.body.textContent?.includes("입력한 내용은 사라집니다"),
|
|
).toBe(kind === "AUTH_REQUIRED");
|
|
expect(screen.getByRole("textbox", { name: /Name/ })).toHaveValue("Valid");
|
|
|
|
await user.click(screen.getByRole("button", { name: action }));
|
|
if (kind === "RATE_LIMITED") {
|
|
expect(submit).toHaveBeenCalledTimes(2);
|
|
expect(onFailureAction).not.toHaveBeenCalled();
|
|
} else {
|
|
expect(onFailureAction).toHaveBeenCalledOnce();
|
|
}
|
|
},
|
|
);
|
|
|
|
// F-10 (08-01). A save that failed for a reason the user cannot fix in the
|
|
// input is a status with its own action, never an input error summary.
|
|
it.each([
|
|
["NOT_FOUND", "요청한 항목을 찾을 수 없습니다.", "안전한 화면으로 이동"],
|
|
["UNKNOWN_CLIENT_FAILURE", "요청을 처리할 수 없습니다.", "지원 정보 확인"],
|
|
] as const)(
|
|
"shows an unavailable %s save as a status, not an input error",
|
|
async (kind, copy, action) => {
|
|
const user = userEvent.setup();
|
|
const onFailureAction = vi.fn();
|
|
render(
|
|
<FormHarness
|
|
submit={async () => ({
|
|
ok: false,
|
|
error: createFailure(kind, "CREATE_ENTITY", 0, {
|
|
effect: "NOT_APPLIED",
|
|
}),
|
|
})}
|
|
onFailureAction={onFailureAction}
|
|
/>,
|
|
);
|
|
await user.type(screen.getByRole("textbox", { name: /Name/ }), "Valid");
|
|
await user.click(screen.getByRole("button", { name: "Submit" }));
|
|
|
|
expect(await screen.findByTestId("result")).toHaveTextContent(
|
|
"unavailable",
|
|
);
|
|
expect(screen.getByRole("alert")).toHaveTextContent(copy);
|
|
expect(document.body).not.toHaveTextContent("입력 내용을 확인해 주세요.");
|
|
await user.click(screen.getByRole("button", { name: action }));
|
|
expect(onFailureAction).toHaveBeenCalledOnce();
|
|
},
|
|
);
|
|
|
|
// 0929/08-04. A failed or unknown save carries the id a user quotes to
|
|
// support, the same as a failed query.
|
|
it("shows the save failure's request id as its support reference", async () => {
|
|
const user = userEvent.setup();
|
|
render(
|
|
<FormHarness
|
|
submit={async () => ({
|
|
ok: false,
|
|
error: createFailure("UNKNOWN_CLIENT_FAILURE", "CREATE_ENTITY", 0, {
|
|
effect: "NOT_APPLIED",
|
|
requestId: "corr-save-400",
|
|
}),
|
|
})}
|
|
/>,
|
|
);
|
|
await user.type(screen.getByRole("textbox", { name: /Name/ }), "Valid");
|
|
await user.click(screen.getByRole("button", { name: "Submit" }));
|
|
|
|
expect(await screen.findByRole("alert")).toHaveTextContent(
|
|
"지원 참조: corr-save-400",
|
|
);
|
|
expect(screen.getByTestId("support")).toHaveTextContent("corr-save-400");
|
|
});
|
|
|
|
it("keeps the request id of a save whose effect is unknown", async () => {
|
|
const user = userEvent.setup();
|
|
render(
|
|
<FormHarness
|
|
submit={async () => ({
|
|
ok: false,
|
|
error: createFailure("SERVER_FAILURE", "CREATE_ENTITY", 0, {
|
|
effect: "MAYBE_APPLIED",
|
|
requestId: "corr-save-500",
|
|
}),
|
|
})}
|
|
resetOnSuccess={false}
|
|
/>,
|
|
);
|
|
await user.type(screen.getByRole("textbox", { name: /Name/ }), "Valid");
|
|
await user.click(screen.getByRole("button", { name: "Submit" }));
|
|
|
|
expect(await screen.findByTestId("result")).toHaveTextContent("effect-unknown");
|
|
expect(screen.getByTestId("support")).toHaveTextContent("corr-save-500");
|
|
|
|
await user.click(screen.getByRole("button", { name: "Confirm applied" }));
|
|
expect(screen.getByTestId("support")).toHaveTextContent("");
|
|
});
|
|
|
|
it("keeps conflict input out of URL and storage", async () => {
|
|
const user = userEvent.setup();
|
|
localStorage.clear();
|
|
window.history.replaceState({}, "", "/form-test");
|
|
render(
|
|
<FormHarness
|
|
submit={async () => ({
|
|
ok: false,
|
|
error: createFailure("CONFLICT", "CREATE_ENTITY", 0),
|
|
})}
|
|
/>,
|
|
);
|
|
const secretLike = "token-like-do-not-copy";
|
|
await user.type(screen.getByRole("textbox", { name: /Name/ }), secretLike);
|
|
await user.click(screen.getByRole("button", { name: "Submit" }));
|
|
|
|
expect(await screen.findByText(/다른 변경과 충돌했습니다/)).toBeVisible();
|
|
expect(screen.getByRole("textbox", { name: /Name/ })).toHaveValue(secretLike);
|
|
expect(window.location.href).not.toContain(secretLike);
|
|
expect(JSON.stringify(localStorage)).not.toContain(secretLike);
|
|
});
|
|
|
|
it("blocks a second submit while the prior effect remains unknown", async () => {
|
|
const user = userEvent.setup();
|
|
const submit = vi.fn(async () => ({
|
|
ok: false as const,
|
|
error: createFailure("SERVER_FAILURE", "CREATE_ENTITY", 0, {
|
|
effect: "MAYBE_APPLIED",
|
|
}),
|
|
}));
|
|
render(<FormHarness submit={submit} resetOnSuccess={false} />);
|
|
const name = screen.getByRole("textbox", { name: /Name/ });
|
|
await user.type(name, "Alpha");
|
|
await user.click(screen.getByRole("button", { name: "Submit" }));
|
|
expect(await screen.findByTestId("result")).toHaveTextContent(
|
|
"effect-unknown",
|
|
);
|
|
|
|
await user.clear(name);
|
|
await user.type(name, "Beta");
|
|
await user.click(screen.getByRole("button", { name: "Submit" }));
|
|
|
|
expect(submit).toHaveBeenCalledOnce();
|
|
expect(screen.getByTestId("result")).toHaveTextContent("effect-unknown");
|
|
});
|
|
|
|
it("settles the submitted unknown snapshot without accepting later edits", async () => {
|
|
const user = userEvent.setup();
|
|
const submit = vi.fn(async () => ({
|
|
ok: false as const,
|
|
error: createFailure("SERVER_FAILURE", "CREATE_ENTITY", 0, {
|
|
effect: "MAYBE_APPLIED",
|
|
}),
|
|
}));
|
|
render(<FormHarness submit={submit} resetOnSuccess={false} />);
|
|
const name = screen.getByRole("textbox", { name: /Name/ });
|
|
await user.type(name, "Alpha");
|
|
await user.click(screen.getByRole("button", { name: "Submit" }));
|
|
await screen.findByText("effect-unknown");
|
|
await user.clear(name);
|
|
await user.type(name, "Beta");
|
|
|
|
await user.click(screen.getByRole("button", { name: "Confirm applied" }));
|
|
|
|
expect(name).toHaveValue("Beta");
|
|
expect(screen.getByTestId("result")).toHaveTextContent("success");
|
|
expect(screen.getByTestId("dirty")).toHaveTextContent("true");
|
|
await user.clear(name);
|
|
await user.type(name, "Alpha");
|
|
expect(screen.getByTestId("dirty")).toHaveTextContent("false");
|
|
});
|
|
|
|
it("releases an unknown submission only after explicit not-applied settlement", async () => {
|
|
const user = userEvent.setup();
|
|
const submit = vi
|
|
.fn()
|
|
.mockResolvedValueOnce({
|
|
ok: false as const,
|
|
error: createFailure("SERVER_FAILURE", "CREATE_ENTITY", 0, {
|
|
effect: "MAYBE_APPLIED",
|
|
}),
|
|
})
|
|
.mockResolvedValueOnce({ ok: true as const, value: "saved" });
|
|
render(<FormHarness submit={submit} resetOnSuccess={false} />);
|
|
await user.type(screen.getByRole("textbox", { name: /Name/ }), "Alpha");
|
|
await user.click(screen.getByRole("button", { name: "Submit" }));
|
|
await screen.findByText("effect-unknown");
|
|
|
|
await user.click(
|
|
screen.getByRole("button", { name: "Confirm not applied" }),
|
|
);
|
|
expect(screen.getByTestId("result")).toHaveTextContent("idle");
|
|
await user.click(screen.getByRole("button", { name: "Submit" }));
|
|
|
|
expect(submit).toHaveBeenCalledTimes(2);
|
|
});
|
|
});
|
|
|
|
describe("dirty navigation guard", () => {
|
|
it("blocks navigation, restores focus on stay and proceeds explicitly", async () => {
|
|
const user = userEvent.setup();
|
|
|
|
function GuardedPage() {
|
|
const navigate = useNavigate();
|
|
const [dirty, setDirty] = useState(false);
|
|
const guard = useDirtyNavigationGuard(dirty);
|
|
return (
|
|
<>
|
|
<label htmlFor="guard-field">Guard field</label>
|
|
<input
|
|
id="guard-field"
|
|
onChange={() => setDirty(true)}
|
|
/>
|
|
<Button onClick={() => navigate("/target")}>Leave</Button>
|
|
<DirtyNavigationDialog guard={guard} />
|
|
</>
|
|
);
|
|
}
|
|
|
|
const router = createMemoryRouter(
|
|
[
|
|
{ path: "/", element: <GuardedPage /> },
|
|
{ path: "/target", element: <h1>Target</h1> },
|
|
],
|
|
{ initialEntries: ["/"] },
|
|
);
|
|
render(<RouterProvider router={router} />);
|
|
await user.type(screen.getByRole("textbox", { name: "Guard field" }), "x");
|
|
const leave = screen.getByRole("button", { name: "Leave" });
|
|
await user.click(leave);
|
|
expect(
|
|
screen.getByRole("dialog", { name: "저장하지 않은 변경이 있습니다." }),
|
|
).toHaveAttribute("open");
|
|
|
|
await user.click(screen.getByRole("button", { name: "계속 작성" }));
|
|
await waitFor(() => expect(leave).toHaveFocus());
|
|
await user.click(leave);
|
|
await user.click(screen.getByRole("button", { name: "변경 버리고 이동" }));
|
|
expect(await screen.findByRole("heading", { name: "Target" })).toBeVisible();
|
|
});
|
|
});
|
|
|
|
describe("submission timing", () => {
|
|
it("submits once when a second submit arrives during async validation", async () => {
|
|
const user = userEvent.setup();
|
|
let releaseValidation: () => void = () => {};
|
|
const validationGate = new Promise<void>((resolve) => {
|
|
releaseValidation = resolve;
|
|
});
|
|
const asyncSchema = schema.refine(async () => {
|
|
await validationGate;
|
|
return true;
|
|
});
|
|
const submit = vi.fn(async () => ({ ok: true as const, value: "saved" }));
|
|
|
|
function AsyncForm() {
|
|
const form = useAppForm({
|
|
schema: asyncSchema,
|
|
defaultValues: defaults,
|
|
allowedServerFields: ["name", "note"],
|
|
mapToCommand: (values) => ({ name: values.name }),
|
|
submit,
|
|
});
|
|
return (
|
|
<Form pending={form.pending} onSubmit={(event) => void form.submitForm(event)}>
|
|
<FormField {...form.field("name")} label="Name" required />
|
|
<Button type="submit">Submit</Button>
|
|
<output data-testid="result">{form.result}</output>
|
|
<output data-testid="support">{form.supportReference ?? ""}</output>
|
|
</Form>
|
|
);
|
|
}
|
|
|
|
render(<AsyncForm />);
|
|
await user.type(screen.getByRole("textbox", { name: /Name/ }), "Ready");
|
|
await user.click(screen.getByRole("button", { name: "Submit" }));
|
|
await user.click(screen.getByRole("button", { name: "Submit" }));
|
|
releaseValidation();
|
|
|
|
await waitFor(() =>
|
|
expect(screen.getByTestId("result")).toHaveTextContent("success"),
|
|
);
|
|
expect(submit).toHaveBeenCalledOnce();
|
|
});
|
|
|
|
it("does not ask to discard changes when navigating right after a save", async () => {
|
|
const user = userEvent.setup();
|
|
|
|
function SaveThenLeave() {
|
|
const navigate = useNavigate();
|
|
const form = useAppForm({
|
|
schema,
|
|
defaultValues: defaults,
|
|
allowedServerFields: ["name", "note"],
|
|
mapToCommand: (values) => ({ name: values.name }),
|
|
submit: async () => ({ ok: true as const, value: "saved" }),
|
|
});
|
|
const guard = useDirtyNavigationGuard(form.dirty);
|
|
return (
|
|
<Form
|
|
onSubmit={(event) => {
|
|
void form.submitForm(event).then((outcome) => {
|
|
if (outcome?.ok) void navigate("/done");
|
|
});
|
|
}}
|
|
pending={form.pending}
|
|
>
|
|
<FormField {...form.field("name")} label="Name" required />
|
|
<Button type="submit">Save</Button>
|
|
<DirtyNavigationDialog guard={guard} />
|
|
</Form>
|
|
);
|
|
}
|
|
|
|
const router = createMemoryRouter(
|
|
[
|
|
{ path: "/", element: <SaveThenLeave /> },
|
|
{ path: "/done", element: <h1>Done</h1> },
|
|
],
|
|
{ initialEntries: ["/"] },
|
|
);
|
|
render(<RouterProvider router={router} />);
|
|
await user.type(screen.getByRole("textbox", { name: /Name/ }), "Ready");
|
|
await user.click(screen.getByRole("button", { name: "Save" }));
|
|
|
|
expect(await screen.findByRole("heading", { name: "Done" })).toBeVisible();
|
|
expect(
|
|
screen.queryByRole("dialog", { name: "저장하지 않은 변경이 있습니다." }),
|
|
).not.toBeInTheDocument();
|
|
});
|
|
});
|
|
|
|
/**
|
|
* A server validation refusal through the V2 client and the mutation
|
|
* coordinator, with the reference form page's gate: the save button is off
|
|
* while the coordinator holds an unknown effect.
|
|
*/
|
|
describe("correcting a field after a V2 validation refusal", () => {
|
|
let token = 0;
|
|
const scope = {
|
|
...scopeSnapshot(),
|
|
identities: createRuntimeIdentityRegistry({
|
|
tokenFactory: () => `form-identity-token-${String(++token).padStart(4, "0")}`,
|
|
}),
|
|
};
|
|
|
|
function CoordinatedForm(props: Readonly<{ fetcher: typeof fetch }>) {
|
|
const [client] = useState(() =>
|
|
createHttpClient({
|
|
...TEST_HTTP_CONTRACT,
|
|
baseUrl: "https://api.test",
|
|
fetcher: props.fetcher,
|
|
}),
|
|
);
|
|
const mutation = useApplicationMutation<
|
|
Readonly<{ name: string; note?: string }>,
|
|
unknown
|
|
>({
|
|
definitionId: "v2-create-v1",
|
|
definitionVersion: 1,
|
|
operationId: "CREATE_ENTITY",
|
|
requiresIdempotencyKey: true,
|
|
owner: "platform-test",
|
|
duplicatePolicy: "REJECT_WHILE_ACTIVE",
|
|
scope,
|
|
invalidate: [],
|
|
execute: (command, { intent }) =>
|
|
client.execute("CREATE_ENTITY", {
|
|
body: { name: command.name },
|
|
idempotencyKey: intent.idempotencyKey,
|
|
}),
|
|
});
|
|
const form = useAppForm({
|
|
schema,
|
|
defaultValues: defaults,
|
|
allowedServerFields: ["name", "note"],
|
|
mapToCommand: (values) => ({ name: values.name }),
|
|
submit: mutation.submit,
|
|
});
|
|
const blocked =
|
|
mutation.state.indicator === "mutation-effect-unknown" ||
|
|
mutation.state.indicator === "mutation-pending";
|
|
return (
|
|
<Form pending={form.pending} onSubmit={(event) => void form.submitForm(event)}>
|
|
<FormField {...form.field("name")} label="Name" required />
|
|
<Button type="submit" disabled={form.pending || blocked}>
|
|
Submit
|
|
</Button>
|
|
<output data-testid="result">{form.result}</output>
|
|
</Form>
|
|
);
|
|
}
|
|
|
|
const meta = { requestId: "request-1", traceId: "trace-1" };
|
|
|
|
function answerFirst(status: number, error: unknown) {
|
|
return vi
|
|
.fn<typeof fetch>()
|
|
.mockResolvedValueOnce(
|
|
Response.json({ success: false, error, meta }, { status }),
|
|
)
|
|
.mockImplementation(async () =>
|
|
Response.json({
|
|
success: true,
|
|
data: { id: "entity-1", name: "Fixed" },
|
|
meta,
|
|
}),
|
|
);
|
|
}
|
|
|
|
// 백엔드 1101/02-01 후속. The paired backend's 400 VALIDATION_FAILED with
|
|
// the field list (its docs/web/http-contract.md §4).
|
|
it("saves the corrected value after a 400 field error", async () => {
|
|
const user = userEvent.setup();
|
|
const fetcher = answerFirst(400, {
|
|
code: "VALIDATION_FAILED",
|
|
details: [{ field: "name", code: "NOT_BLANK", message: "필수 값이 없습니다." }],
|
|
});
|
|
render(<CoordinatedForm fetcher={fetcher} />, {
|
|
wrapper: wrapper(queryClient()),
|
|
});
|
|
const name = screen.getByRole("textbox", { name: /Name/ });
|
|
|
|
await user.type(name, "Rejected");
|
|
await user.click(screen.getByRole("button", { name: "Submit" }));
|
|
await waitFor(() => expect(name).toHaveAttribute("aria-invalid", "true"));
|
|
|
|
await user.clear(name);
|
|
await user.type(name, "Fixed");
|
|
expect(screen.getByRole("button", { name: "Submit" })).toBeEnabled();
|
|
await user.click(screen.getByRole("button", { name: "Submit" }));
|
|
|
|
await waitFor(() =>
|
|
expect(screen.getByTestId("result")).toHaveTextContent("success"),
|
|
);
|
|
expect(fetcher).toHaveBeenCalledTimes(2);
|
|
});
|
|
|
|
// 1101/14.4. A body the backend could not read is refused while binding,
|
|
// before any write (frontend contract 6.1), so the save is not held.
|
|
it("saves again after a 400 VALIDATION_FAILED whose body did not parse", async () => {
|
|
const user = userEvent.setup();
|
|
const fetcher = answerFirst(400, {
|
|
code: "VALIDATION_FAILED",
|
|
details: { cause: "JsonParseException" },
|
|
});
|
|
render(<CoordinatedForm fetcher={fetcher} />, {
|
|
wrapper: wrapper(queryClient()),
|
|
});
|
|
|
|
await user.type(screen.getByRole("textbox", { name: /Name/ }), "Fixed");
|
|
await user.click(screen.getByRole("button", { name: "Submit" }));
|
|
await waitFor(() => expect(fetcher).toHaveBeenCalledTimes(1));
|
|
await waitFor(() =>
|
|
expect(screen.getByRole("button", { name: "Submit" })).toBeEnabled(),
|
|
);
|
|
await user.click(screen.getByRole("button", { name: "Submit" }));
|
|
|
|
await waitFor(() =>
|
|
expect(screen.getByTestId("result")).toHaveTextContent("success"),
|
|
);
|
|
expect(fetcher).toHaveBeenCalledTimes(2);
|
|
});
|
|
|
|
// 1101/14.4. Outside IDEMPOTENT_REQUEST_MISMATCH a 422 may come after a
|
|
// write (fileserver INTEGRITY_MISMATCH), so the coordinator holds it as an
|
|
// unknown result even though the form shows the field.
|
|
it("keeps the save off after a 422 the backend may have applied", async () => {
|
|
const user = userEvent.setup();
|
|
const fetcher = answerFirst(422, {
|
|
code: "INVALID_INPUT",
|
|
details: { issues: [{ path: "name", code: "REQUIRED" }] },
|
|
});
|
|
render(<CoordinatedForm fetcher={fetcher} />, {
|
|
wrapper: wrapper(queryClient()),
|
|
});
|
|
const name = screen.getByRole("textbox", { name: /Name/ });
|
|
|
|
await user.type(name, "Rejected");
|
|
await user.click(screen.getByRole("button", { name: "Submit" }));
|
|
await waitFor(() => expect(name).toHaveAttribute("aria-invalid", "true"));
|
|
|
|
expect(screen.getByRole("button", { name: "Submit" })).toBeDisabled();
|
|
expect(fetcher).toHaveBeenCalledTimes(1);
|
|
});
|
|
});
|