문제 제품 확장 지점이 실행 경로에서는 동작했지만 타입 검사 경로에서 막혔다. (a) 문서대로 product-composition.ts에서 FeaturePlatformCapabilities를 보강하면 check:types:node가 실패했다. scripts 프로그램은 기능 코드를 끌어오지만 product-composition.ts는 끌어오지 않아 보강이 보이지 않았고, 오류는 기능 파일을 가리켰다. (b) 기본값 있는 제품 설정 키(.default()) 하나가 RuntimeConfig를 리터럴로 쓰는 템플릿 테스트 7개 파일의 타입을 깼다. 픽스처는 vi.mock이라 이 경로를 지나지 않았다. 고른 방법 - 제품 소유 빈 파일 src/features/product-capabilities.ts를 두고 FeaturePlatformCapabilities가 그 ProductFeaturePlatformCapabilities를 extends한다. feature-adapter-contribution.ts가 import하므로 기능을 보는 모든 프로그램에 들어간다. 문서만 "기능 파일 안에서 보강"으로 고치는 최소안은 capability 하나를 여러 기능이 쓸 때 보강 위치가 갈려 버렸다. 기존 제품 소유 파일에 칸을 더하지 않고 새 파일로 둔 이유: 템플릿은 복사 뒤 제품 소유 파일을 고치지 않으므로, 새 파일이어야 동기화 때 충돌 없이 들어간다. - tests/helpers/runtime-config.ts의 testRuntimeConfig: 템플릿 키는 테스트가 쓰고, 제품 키는 실제 스키마(validateRuntimeConfig)로 기본값을 채운다. 템플릿 테스트 6개 파일이 이것을 쓰고, release-coherence는 문서 타입을 z.input으로 바꿨다. 제품 키를 모두 Partial로 하는 대안은 기본값 키에도 undefined 처리를 강요해 버렸다. - tests/unit/product-extension-typecheck.test.ts: 복사본에 제품 소유 파일 세 개와 기능 하나를 실제 파일로 채우고 tsc app·node·test를 돈다. - 문서: starter-experience 표, 매뉴얼 01·03·patterns·create-feature, frontend-application-foundation, 계약 주석. 위험·한계 - 기본값 없는 필수 제품 키는 여전히 템플릿 테스트에서 실패한다(이제 타입이 아니라 helper가 이유를 적고 throw). 문서에 ".default() 또는 .optional()"을 적었다. - product-composition.ts 안에서 이미 보강한 다운스트림은 보강을 새 파일로 옮겨야 node 검사가 통과한다. 검증 - RED: 새 typecheck 테스트가 수정 전 app·node(보강 미연결)와 test(템플릿 테스트 8건, E-PROD와 같은 위치)에서 실패. - 수정 후 그 테스트와 영향받는 9개 테스트 파일 → 10 files / 83 tests 통과. - check:types(tsc app·node·test), check:architecture, eslint, verify:documentation PASS_SCOPED. Refs: docs/reviews/2026-11-03-maturity-review/09-app-core.md 09-02
484 lines
16 KiB
TypeScript
484 lines
16 KiB
TypeScript
import { describe, expect, it, vi } from "vitest";
|
|
|
|
import { createRuntimeAdapters } from "../../src/bootstrap/runtime-adapters.ts";
|
|
import { createBrowserMutationIntentFactory } from "../../src/adapters/platform/browser-mutation-intent-factory.ts";
|
|
import { createApplication } from "../../src/application/create-application.ts";
|
|
import type { ApplicationFeatureId } from "../../src/application/ports/in/application-api.ts";
|
|
import { INSTALLED_PRODUCT_FEATURE_IDS } from "../../src/features/installed-product-manifest.ts";
|
|
import { testRuntimeConfig } from "../helpers/runtime-config.ts";
|
|
|
|
type Runtime = Parameters<typeof createRuntimeAdapters>[0]["runtime"];
|
|
type Release = Parameters<typeof createRuntimeAdapters>[0]["release"];
|
|
|
|
const runtime: Runtime = {
|
|
config: testRuntimeConfig({
|
|
APP_ENV: "local",
|
|
API_BASE_URL: "http://localhost:8080",
|
|
TELEMETRY_ENABLED: false,
|
|
AUTH_MODE: "demo",
|
|
REQUEST_TIMEOUT_MS: 4321,
|
|
MAX_RETRY_ATTEMPTS: 0,
|
|
RELEASE_MANIFEST_URL: "/release-manifest.json",
|
|
CONFIG_SCHEMA_VERSION: "2.0",
|
|
CAPABILITY_OVERRIDES: {
|
|
REALTIME: "DEFAULT",
|
|
WEB_WORKER: "DEFAULT",
|
|
SERVICE_WORKER: "DEFAULT",
|
|
OFFLINE_COMMANDS: "DEFAULT",
|
|
},
|
|
FEATURE_OVERRIDES: {},
|
|
}),
|
|
configSchema: "V2",
|
|
build: {
|
|
buildId: "build-a",
|
|
commitSha: "abc123",
|
|
routerBasePath: "/",
|
|
runtimeConfigUrl: "/config.json",
|
|
},
|
|
validationDurationMs: 0,
|
|
};
|
|
const release: Release = {
|
|
schemaVersion: 2,
|
|
appVersion: "0.1.0",
|
|
buildId: "build-a",
|
|
commitSha: "abc123",
|
|
configSchemaVersion: "2.0",
|
|
contractSet: {
|
|
setAlgorithm: "CA_CONTRACT_SET_V1",
|
|
setDigest: `sha256:${"0".repeat(64)}`,
|
|
packages: [],
|
|
},
|
|
assetManifestHash: "hash-a",
|
|
releaseId: "release-a",
|
|
builtAt: "2026-07-25T00:00:00Z",
|
|
routeChunks: { "route-home": "assets/home.js" },
|
|
};
|
|
|
|
describe("runtime adapter composition", () => {
|
|
it("creates validated intent and idempotency identities with independent UUID calls", () => {
|
|
const randomUUID = vi
|
|
.fn<() => string>()
|
|
.mockReturnValueOnce("intent-uuid")
|
|
.mockReturnValueOnce("idempotency-uuid");
|
|
const factory = createBrowserMutationIntentFactory({
|
|
randomUUID,
|
|
monotonicNow: () => 12.5,
|
|
});
|
|
|
|
const intent = factory.create({
|
|
operationId: "CREATE_ENTITY",
|
|
canonicalInputIdentity: "opaque-canonical-input",
|
|
requiresIdempotencyKey: true,
|
|
});
|
|
|
|
expect(intent).toEqual({
|
|
intentId: "intent-uuid",
|
|
operationId: "CREATE_ENTITY",
|
|
canonicalInputIdentity: "opaque-canonical-input",
|
|
idempotencyKey: "idempotency-uuid",
|
|
createdAtMonotonicMs: 12.5,
|
|
});
|
|
expect(Object.isFrozen(intent)).toBe(true);
|
|
expect(randomUUID).toHaveBeenCalledTimes(2);
|
|
});
|
|
|
|
it("rejects invalid or unbounded mutation intent values", () => {
|
|
const factory = createBrowserMutationIntentFactory({
|
|
randomUUID: () => "opaque-runtime-identifier",
|
|
monotonicNow: () => 1,
|
|
});
|
|
|
|
expect(() =>
|
|
factory.create({
|
|
operationId: " ",
|
|
canonicalInputIdentity: "valid-identity",
|
|
requiresIdempotencyKey: false,
|
|
}),
|
|
).toThrow(TypeError);
|
|
expect(() =>
|
|
factory.create({
|
|
operationId: "CREATE_ENTITY",
|
|
canonicalInputIdentity: "x".repeat(16_385),
|
|
requiresIdempotencyKey: false,
|
|
}),
|
|
).toThrow(TypeError);
|
|
expect(() =>
|
|
createBrowserMutationIntentFactory({
|
|
randomUUID: () => "opaque-runtime-identifier",
|
|
monotonicNow: () => -1,
|
|
}).create({
|
|
operationId: "CREATE_ENTITY",
|
|
canonicalInputIdentity: "valid-identity",
|
|
requiresIdempotencyKey: false,
|
|
}),
|
|
).toThrow(TypeError);
|
|
});
|
|
|
|
it("constructs the local demo seam and infrastructure adapters", async () => {
|
|
const adapters = await createRuntimeAdapters({
|
|
runtime,
|
|
release,
|
|
host: {},
|
|
});
|
|
|
|
expect(adapters.outputPorts.session.getState()).toBe("unauthenticated");
|
|
await expect(adapters.outputPorts.releaseInfo.getCurrent()).resolves.toMatchObject({
|
|
releaseId: "release-a",
|
|
});
|
|
expect(adapters.infrastructure.queryClient).toBeDefined();
|
|
expect(adapters.infrastructure.queryInvalidation).toBeDefined();
|
|
expect(adapters.infrastructure.mutationIntentFactory).toBeDefined();
|
|
expect(
|
|
adapters.infrastructure.crossContextInvalidationStatus(),
|
|
).toBe("DEGRADED_LOCAL_ONLY");
|
|
expect(adapters.outputPorts.diagnostics.record).toEqual(expect.any(Function));
|
|
expect(adapters.outputPorts.telemetry.emit).toEqual(expect.any(Function));
|
|
expect(adapters.outputPorts.telemetry.pendingCount()).toBe(0);
|
|
expect(adapters).not.toHaveProperty("http");
|
|
expect(adapters).not.toHaveProperty("storage");
|
|
adapters.infrastructure.dispose();
|
|
});
|
|
|
|
it("runtime infrastructure disposal disposes telemetry first", async () => {
|
|
const fetcher = vi.fn(async () => new Response(null, { status: 204 }));
|
|
const adapters = await createRuntimeAdapters({
|
|
runtime: {
|
|
...runtime,
|
|
config: {
|
|
...runtime.config,
|
|
TELEMETRY_ENABLED: true,
|
|
TELEMETRY_ENDPOINT: "https://telemetry.test/events",
|
|
},
|
|
} as Runtime,
|
|
release,
|
|
host: {},
|
|
fetcher: fetcher as unknown as typeof fetch,
|
|
});
|
|
|
|
adapters.outputPorts.telemetry.emit("api.request.failed", {
|
|
error_kind: "SERVER_FAILURE",
|
|
http_status_group: "5xx",
|
|
attempt_count_bucket: "1",
|
|
route_id: "TEST_ROUTE",
|
|
});
|
|
expect(adapters.outputPorts.telemetry.pendingCount()).toBe(1);
|
|
|
|
adapters.infrastructure.dispose();
|
|
|
|
expect(adapters.outputPorts.telemetry.pendingCount()).toBe(0);
|
|
await Promise.resolve();
|
|
await Promise.resolve();
|
|
expect(fetcher).not.toHaveBeenCalled();
|
|
});
|
|
|
|
it("sends telemetry stamped with the release identity (13-11)", async () => {
|
|
const bodies: { events: Record<string, unknown>[] }[] = [];
|
|
const fetcher = vi.fn(async (_url: RequestInfo | URL, init?: RequestInit) => {
|
|
if (String(_url) === "https://telemetry.test/events") {
|
|
bodies.push(JSON.parse(String(init?.body)));
|
|
}
|
|
return new Response(null, { status: 204 });
|
|
});
|
|
const adapters = await createRuntimeAdapters({
|
|
runtime: {
|
|
...runtime,
|
|
config: {
|
|
...runtime.config,
|
|
TELEMETRY_ENABLED: true,
|
|
TELEMETRY_ENDPOINT: "https://telemetry.test/events",
|
|
},
|
|
} as Runtime,
|
|
release,
|
|
host: {},
|
|
fetcher: fetcher as unknown as typeof fetch,
|
|
});
|
|
|
|
adapters.outputPorts.telemetry.emit("api.request.failed", {
|
|
error_kind: "SERVER_FAILURE",
|
|
http_status_group: "5xx",
|
|
attempt_count_bucket: "1",
|
|
route_id: "TEST_ROUTE",
|
|
});
|
|
await adapters.outputPorts.telemetry.flush();
|
|
|
|
expect(bodies[0]?.events[0]).toMatchObject({
|
|
eventName: "api.request.failed",
|
|
build_id: "build-a",
|
|
release_id: "release-a",
|
|
});
|
|
adapters.infrastructure.dispose();
|
|
});
|
|
|
|
it("replaces the QueryClient and coordinator for each session generation", async () => {
|
|
const adapters = await createRuntimeAdapters({ runtime, release, host: {} });
|
|
const previousClient = adapters.infrastructure.queryClient;
|
|
const previousCoordinator = adapters.infrastructure.queryInvalidation;
|
|
const runtimeMutationIntentFactory =
|
|
adapters.infrastructure.mutationIntentFactory;
|
|
const clearPrevious = vi.spyOn(previousClient, "clear");
|
|
|
|
await adapters.outputPorts.session.beginSignIn();
|
|
|
|
await vi.waitFor(() =>
|
|
expect(adapters.infrastructure.queryClient).not.toBe(previousClient),
|
|
);
|
|
expect(adapters.infrastructure.queryInvalidation).not.toBe(
|
|
previousCoordinator,
|
|
);
|
|
expect(adapters.infrastructure.mutationIntentFactory).toBe(
|
|
runtimeMutationIntentFactory,
|
|
);
|
|
|
|
const clearCallsAfterReplacement = clearPrevious.mock.calls.length;
|
|
await previousCoordinator.resetLocal();
|
|
expect(clearPrevious).toHaveBeenCalledTimes(clearCallsAfterReplacement);
|
|
|
|
adapters.infrastructure.dispose();
|
|
});
|
|
|
|
it("does not fail boot when Web Storage capability getters throw", async () => {
|
|
const host: Record<string, unknown> = {};
|
|
Object.defineProperties(host, {
|
|
localStorage: {
|
|
get() {
|
|
throw new DOMException("denied", "SecurityError");
|
|
},
|
|
},
|
|
sessionStorage: {
|
|
get() {
|
|
throw new DOMException("denied", "SecurityError");
|
|
},
|
|
},
|
|
});
|
|
|
|
const adapters = await createRuntimeAdapters({
|
|
runtime,
|
|
release,
|
|
host,
|
|
});
|
|
|
|
expect(adapters.infrastructure.queryClient).toBeDefined();
|
|
expect(adapters.outputPorts.preferences.read("COLOR_SCHEME")).toEqual({
|
|
ok: true,
|
|
value: undefined,
|
|
});
|
|
adapters.infrastructure.dispose();
|
|
});
|
|
|
|
it("fails closed when an external auth owner was not installed", async () => {
|
|
const adapters = await createRuntimeAdapters({
|
|
runtime: {
|
|
...runtime,
|
|
config: { ...runtime.config, AUTH_MODE: "external" },
|
|
},
|
|
release,
|
|
host: {},
|
|
});
|
|
expect(adapters.outputPorts.session.getState()).toBe("integration-failed");
|
|
});
|
|
|
|
describe("installed external auth owner shape", () => {
|
|
const externalRuntime: Runtime = {
|
|
...runtime,
|
|
config: { ...runtime.config, AUTH_MODE: "external" },
|
|
};
|
|
const completeOwner = () => ({
|
|
readState: () => "authenticated",
|
|
readSubject: () => "user-a",
|
|
subscribe: () => () => {},
|
|
beginSignIn: async () => {},
|
|
signOut: async () => {},
|
|
attachCredential: async () => ({ headers: {} }),
|
|
recoverSession: async () => "no-session",
|
|
notifyUnauthenticated: () => {},
|
|
});
|
|
|
|
it("uses an owner that implements every method", async () => {
|
|
const adapters = await createRuntimeAdapters({
|
|
runtime: externalRuntime,
|
|
release,
|
|
host: { __CA_FRONTEND_AUTH_OWNER__: completeOwner() },
|
|
});
|
|
expect(adapters.outputPorts.session.getState()).toBe("authenticated");
|
|
expect(adapters.outputPorts.session.getSubject()).toBe("user-a");
|
|
adapters.infrastructure.dispose();
|
|
});
|
|
|
|
it.each(["readSubject", "readState"])(
|
|
"fails closed when the owner lacks %s",
|
|
async (method) => {
|
|
const owner: Record<string, unknown> = completeOwner();
|
|
delete owner[method];
|
|
const adapters = await createRuntimeAdapters({
|
|
runtime: externalRuntime,
|
|
release,
|
|
host: { __CA_FRONTEND_AUTH_OWNER__: owner },
|
|
});
|
|
expect(adapters.outputPorts.session.getState()).toBe(
|
|
"integration-failed",
|
|
);
|
|
adapters.infrastructure.dispose();
|
|
},
|
|
);
|
|
});
|
|
|
|
it("reports the static selection when no capability override disables it", async () => {
|
|
const adapters = await createRuntimeAdapters({ runtime, release, host: {} });
|
|
|
|
const snapshot = adapters.outputPorts.runtimeCapabilities.getSnapshot();
|
|
|
|
expect(snapshot.map((status) => status.capabilityId)).toEqual([
|
|
"REALTIME",
|
|
"WEB_WORKER",
|
|
"SERVICE_WORKER",
|
|
"OFFLINE_COMMANDS",
|
|
]);
|
|
expect(snapshot.every((status) => status.override === "DEFAULT")).toBe(true);
|
|
});
|
|
|
|
it("carries a disabling override into the capability snapshot", async () => {
|
|
const adapters = await createRuntimeAdapters({
|
|
runtime: {
|
|
...runtime,
|
|
config: {
|
|
...runtime.config,
|
|
CAPABILITY_OVERRIDES: {
|
|
...runtime.config.CAPABILITY_OVERRIDES,
|
|
SERVICE_WORKER: "DISABLED",
|
|
},
|
|
FEATURE_OVERRIDES: {},
|
|
},
|
|
},
|
|
release,
|
|
host: {},
|
|
});
|
|
|
|
const serviceWorker = adapters.outputPorts.runtimeCapabilities
|
|
.getSnapshot()
|
|
.find((status) => status.capabilityId === "SERVICE_WORKER");
|
|
|
|
expect(serviceWorker?.override).toBe("DISABLED");
|
|
expect(serviceWorker?.active).toBe(0);
|
|
});
|
|
|
|
it("gives a feature switched off by FEATURE_OVERRIDES no application API (Q-6.9-5)", async () => {
|
|
const [disabledId, ...activeIds] = INSTALLED_PRODUCT_FEATURE_IDS;
|
|
const adapters = await createRuntimeAdapters({
|
|
runtime: {
|
|
...runtime,
|
|
config: {
|
|
...runtime.config,
|
|
FEATURE_OVERRIDES: { [disabledId!]: "DISABLED" },
|
|
},
|
|
},
|
|
release,
|
|
host: {},
|
|
});
|
|
const application = createApplication(
|
|
adapters.outputPorts,
|
|
{},
|
|
adapters.featureLoaders,
|
|
);
|
|
|
|
expect(adapters.outputPorts.productFeatures.isActive(disabledId!)).toBe(false);
|
|
// 15-01. A switched-off feature gets no loader, so loading installs nothing.
|
|
await application.features.load(disabledId!);
|
|
expect(application.features.has(disabledId!)).toBe(false);
|
|
expect(() =>
|
|
application.features.get(disabledId as ApplicationFeatureId),
|
|
).toThrow(/not installed/u);
|
|
for (const featureId of activeIds) {
|
|
await application.features.load(featureId);
|
|
expect(application.features.has(featureId)).toBe(true);
|
|
}
|
|
adapters.infrastructure.dispose();
|
|
});
|
|
|
|
it("still resolves every installed feature API when nothing is switched off", async () => {
|
|
const adapters = await createRuntimeAdapters({ runtime, release, host: {} });
|
|
const application = createApplication(
|
|
adapters.outputPorts,
|
|
{},
|
|
adapters.featureLoaders,
|
|
);
|
|
|
|
for (const featureId of INSTALLED_PRODUCT_FEATURE_IDS) {
|
|
// 15-01. Not loaded until the router asks for the feature's routes.
|
|
expect(() =>
|
|
application.features.get(featureId as ApplicationFeatureId),
|
|
).toThrow(/not loaded yet/u);
|
|
await application.features.load(featureId);
|
|
expect(application.features.has(featureId)).toBe(true);
|
|
expect(
|
|
application.features.get(featureId as ApplicationFeatureId),
|
|
).toBeDefined();
|
|
}
|
|
adapters.infrastructure.dispose();
|
|
});
|
|
|
|
it("states contract identity as a digest for a V2 release manifest", async () => {
|
|
const adapters = await createRuntimeAdapters({ runtime, release, host: {} });
|
|
|
|
const current = await adapters.outputPorts.releaseInfo.getCurrent();
|
|
|
|
expect(current.contractSetDigest).toBe(release.contractSet?.setDigest);
|
|
expect(current.apiContractVersion).toBeUndefined();
|
|
expect(current).not.toHaveProperty("contractSet");
|
|
});
|
|
|
|
it("states contract identity as the legacy scalar for a V1 release manifest", async () => {
|
|
const adapters = await createRuntimeAdapters({
|
|
runtime,
|
|
release: {
|
|
...release,
|
|
schemaVersion: 1,
|
|
contractSet: null,
|
|
legacyApiContractVersion: "1.4",
|
|
},
|
|
host: {},
|
|
});
|
|
|
|
const current = await adapters.outputPorts.releaseInfo.getCurrent();
|
|
|
|
expect(current.apiContractVersion).toBe("1.4");
|
|
expect(current.contractSetDigest).toBeUndefined();
|
|
expect(current).not.toHaveProperty("legacyApiContractVersion");
|
|
});
|
|
|
|
it("refetches the active release manifest with no-store semantics", async () => {
|
|
const activeRelease = {
|
|
...release,
|
|
buildId: "build-b",
|
|
releaseId: "release-b",
|
|
routeChunks: { "route-home": "assets/home-b.js" },
|
|
};
|
|
const fetcher = vi.fn(async () =>
|
|
new Response(JSON.stringify(activeRelease), {
|
|
headers: { "content-type": "application/json" },
|
|
}),
|
|
);
|
|
const adapters = await createRuntimeAdapters({
|
|
runtime,
|
|
release,
|
|
fetcher,
|
|
host: {},
|
|
});
|
|
|
|
await expect(adapters.outputPorts.releaseInfo.refresh()).resolves.toMatchObject({
|
|
buildId: "build-b",
|
|
releaseId: "release-b",
|
|
});
|
|
expect(fetcher).toHaveBeenCalledWith(
|
|
"/release-manifest.json",
|
|
expect.objectContaining({
|
|
method: "GET",
|
|
cache: "no-store",
|
|
credentials: "same-origin",
|
|
redirect: "error",
|
|
referrerPolicy: "no-referrer",
|
|
headers: { Accept: "application/json" },
|
|
}),
|
|
);
|
|
});
|
|
});
|