문제: runtime은 object URL lease registry 하나를 preview와 download에 같이 넘긴다. 두 쪽의 dispose()가 모두 registry 전체의 dispose()를 불러, 누가 만든 lease인지 구분하지 않고 전부 revoke한다. runtime.previews.dispose()를 부르면 30초 grace 중인 download blob URL까지 바로 revoke된다(E-9). 브라우저가 아직 blob을 읽기 전이면 그 download가 실패할 수 있다. 반대로 download의 dispose()는 다른 화면의 preview URL을 끊는다. registry 주석은 이 dispose를 "route teardown" 에서 쓰라고 읽혔다. 고른 방법(리뷰 5.2절의 (나)): 한도는 같이 쓰고 해제 권한만 나눈다. registry에 scope()를 두어 소비자마다 자기가 만든 lease 집합을 들고, scope의 dispose()는 그것만 release한다. preview와 download adapter는 각자 scope로 lease를 만든다. registry 전체 dispose()는 runtime.dispose()만 부른다. 포트 시그니처는 그대로이고, TransientPreviewPort.dispose()에 효과 범위를 주석으로 적었다. 설계 문서 3.5절에 해제 권한과 route 정리 방법을 적고, 바뀐 줄 번호를 맞췄다. 버린 대안: - 포트 주석만 고친다(가). 함정이 코드에 그대로 남는다. - 소비자마다 registry를 나눈다(다). 해제 범위는 맞지만 탭 전체의 합계 바이트 상한이 두 곳으로 갈라진다. - TransientPreviewPort에서 dispose()를 뺀다(라). 공개 포트 변경이라 이번 범위(포트는 추가만)를 넘는다. (나)와 함께 할 수 있어 남겨 둔다. 위험·한계: - previews.dispose() 뒤 그 runtime의 preview가 계속 UNAVAILABLE인 것(영향 ②)과, previews.dispose()가 다른 화면의 preview lease까지 푸는 것(영향 ①, 같은 소비자 안)은 그대로다. 문서에 route 정리는 lease마다 release()로 하라고 적었다. 완전히 막으려면 (라)가 필요하다. - scope가 들고 있는 release 함수 집합만큼 메모리가 조금 는다. lease release 때 집합에서 빠지므로 lease 수 상한(기본 16)을 넘지 않는다. - file-transfer 레시피 번들이 55,856 → 55,937 gzip bytes가 되어 예산 55,900을 넘었다. 다음 백 단위 규칙대로 56,000으로 올렸다. 검증: - RED(수정 전): browser-file-runtime.test.ts 새 1건 "expected [ 'blob:runtime-download' ] to deeply equal []"(previews.dispose()가 download URL을 revoke). browser-file-download.test.ts 새 1건 "expected [ 'blob:shared-1', 'blob:shared-2' ] to deeply equal [ 'blob:shared-2' ]"(download dispose()가 다른 소비자의 lease를 revoke). - GREEN: browser-file 단위 5파일 64건 통과. runtime dispose가 모든 lease를 즉시 revoke하는 기존 테스트도 통과. - 회귀: browser-file·presigned·json-schema 단위 10파일 168건 통과. tsc app·test·recipes 통과. 바꾼 파일 eslint 통과. check-architecture (exec 전용 shim) 통과, check-adapter-inventory 통과, verify-documentation-readiness PASS_SCOPED, check-optional-recipes(source) file-transfer 55937/56000. Refs: docs/reviews/2026-11-01-maturity-review/02-adapters-browser-files-cache.md
421 lines
11 KiB
TypeScript
421 lines
11 KiB
TypeScript
// @vitest-environment jsdom
|
|
|
|
import { describe, expect, it, vi } from "vitest";
|
|
|
|
import type {
|
|
FileVerificationReceipt,
|
|
LocalFileRef,
|
|
} from "../../src/application/ports/browser-file-storage/file.ts";
|
|
import {
|
|
browserFilePolicyReference,
|
|
createBrowserFileRuntime,
|
|
type BrowserFilePolicyProfile,
|
|
} from "../../src/adapters/browser-files/index.ts";
|
|
|
|
const filePolicy = browserFilePolicyReference(
|
|
"runtime-file",
|
|
"select-and-preview",
|
|
);
|
|
const downloadPolicy = browserFilePolicyReference(
|
|
"runtime-download",
|
|
"bounded-generated-bin",
|
|
);
|
|
const policies: readonly BrowserFilePolicyProfile[] = [
|
|
{
|
|
reference: filePolicy,
|
|
selection: {
|
|
policyId: "attachment-v1",
|
|
purpose: "attachment",
|
|
classification: "PERSONAL",
|
|
multiple: false,
|
|
maxCount: 1,
|
|
maxFileBytes: 8,
|
|
maxTotalBytes: 8,
|
|
allowEmpty: false,
|
|
accept: [{ mediaType: "text/plain", extensions: [".txt"] }],
|
|
},
|
|
inspection: {
|
|
policyId: "preview-v1",
|
|
maxInspectionBytes: 8,
|
|
acceptedSignatures: [
|
|
{
|
|
mediaType: "image/png",
|
|
extensions: [".png"],
|
|
patterns: [{ offset: 0, bytes: [0x89] }],
|
|
},
|
|
],
|
|
},
|
|
preview: {
|
|
allowedMediaTypes: ["image/png"],
|
|
maxPreviewBytes: 8,
|
|
},
|
|
},
|
|
{
|
|
reference: downloadPolicy,
|
|
download: {
|
|
strategy: "BOUNDED_OBJECT_URL",
|
|
mediaType: "application/octet-stream",
|
|
safeExtension: ".bin",
|
|
maxTransferBytes: 8,
|
|
maxBufferedBytes: 8,
|
|
integrity: "OPTIONAL",
|
|
},
|
|
},
|
|
];
|
|
const unusedBrowserManagedCapabilities = {
|
|
resolve() {
|
|
return {
|
|
ok: false as const,
|
|
error: {
|
|
code: "POLICY_REJECTED" as const,
|
|
operation: "DOWNLOAD" as const,
|
|
retryable: false,
|
|
recovery: "NONE" as const,
|
|
},
|
|
};
|
|
},
|
|
};
|
|
|
|
function fileInput(): HTMLInputElement {
|
|
const label = document.createElement("label");
|
|
label.textContent = "Attachment";
|
|
const input = document.createElement("input");
|
|
input.type = "file";
|
|
label.append(input);
|
|
document.body.append(label);
|
|
return input;
|
|
}
|
|
|
|
describe("browser file runtime hard limits and disposal", () => {
|
|
it("revokes active download leases immediately on runtime dispose", async () => {
|
|
const revoked: string[] = [];
|
|
let scheduled: (() => void) | undefined;
|
|
const runtime = createBrowserFileRuntime({
|
|
input: fileInput(),
|
|
policies,
|
|
limits: {
|
|
hardMaxPreviewBytes: 8,
|
|
hardMaxObjectUrlBytes: 8,
|
|
hardMaxTransferBytes: 16,
|
|
},
|
|
objectUrlApi: {
|
|
createObjectURL: () => "blob:runtime-download",
|
|
revokeObjectURL: (url) => revoked.push(url),
|
|
},
|
|
download: {
|
|
host: { handoff: vi.fn() },
|
|
browserManagedCapabilities:
|
|
unusedBrowserManagedCapabilities,
|
|
scheduler: {
|
|
setTimeout(callback) {
|
|
scheduled = callback;
|
|
return 1;
|
|
},
|
|
},
|
|
},
|
|
});
|
|
|
|
const delivery = {
|
|
policy: downloadPolicy,
|
|
source: {
|
|
kind: "GENERATED" as const,
|
|
bytes: {
|
|
byteLength: 3,
|
|
async *stream() {
|
|
yield {
|
|
ok: true as const,
|
|
value: new Uint8Array([1, 2, 3]),
|
|
};
|
|
},
|
|
},
|
|
},
|
|
suggestedFileName: "artifact",
|
|
maxTransferBytes: 8,
|
|
maxBufferedBytes: 8,
|
|
signal: new AbortController().signal,
|
|
onProgress() {},
|
|
};
|
|
expect(await runtime.downloads.deliver(delivery)).toMatchObject({
|
|
ok: true,
|
|
value: { kind: "BROWSER_HANDOFF" },
|
|
});
|
|
expect(revoked).toEqual([]);
|
|
|
|
runtime.dispose();
|
|
expect(revoked).toEqual(["blob:runtime-download"]);
|
|
expect(await runtime.downloads.deliver(delivery)).toMatchObject({
|
|
ok: false,
|
|
error: { code: "UNAVAILABLE" },
|
|
});
|
|
expect(
|
|
await runtime.content.readRange({
|
|
ref: "file:disposed" as LocalFileRef,
|
|
offset: 0,
|
|
length: 0,
|
|
signal: new AbortController().signal,
|
|
}),
|
|
).toMatchObject({
|
|
ok: false,
|
|
error: { code: "UNAVAILABLE" },
|
|
});
|
|
expect(
|
|
await runtime.previews.create({
|
|
ref: "file:disposed" as LocalFileRef,
|
|
verificationReceipt:
|
|
"verification:disposed" as FileVerificationReceipt,
|
|
policy: filePolicy,
|
|
maxPreviewBytes: 1,
|
|
signal: new AbortController().signal,
|
|
}),
|
|
).toMatchObject({
|
|
ok: false,
|
|
error: { code: "UNAVAILABLE" },
|
|
});
|
|
scheduled?.();
|
|
runtime.dispose();
|
|
expect(revoked).toEqual(["blob:runtime-download"]);
|
|
});
|
|
|
|
it("keeps a download URL in its grace period when only previews are disposed (2026-11-01 02-01)", async () => {
|
|
const revoked: string[] = [];
|
|
const runtime = createBrowserFileRuntime({
|
|
input: fileInput(),
|
|
policies,
|
|
limits: {
|
|
hardMaxPreviewBytes: 8,
|
|
hardMaxObjectUrlBytes: 8,
|
|
hardMaxTransferBytes: 16,
|
|
},
|
|
objectUrlApi: {
|
|
createObjectURL: () => "blob:runtime-download",
|
|
revokeObjectURL: (url) => revoked.push(url),
|
|
},
|
|
download: {
|
|
host: { handoff: vi.fn() },
|
|
browserManagedCapabilities:
|
|
unusedBrowserManagedCapabilities,
|
|
// The 30 s grace never ends inside this test.
|
|
scheduler: { setTimeout: () => 1 },
|
|
},
|
|
});
|
|
|
|
expect(
|
|
await runtime.downloads.deliver({
|
|
policy: downloadPolicy,
|
|
source: {
|
|
kind: "GENERATED",
|
|
bytes: {
|
|
byteLength: 3,
|
|
async *stream() {
|
|
yield { ok: true as const, value: new Uint8Array([1, 2, 3]) };
|
|
},
|
|
},
|
|
},
|
|
suggestedFileName: "artifact",
|
|
maxTransferBytes: 8,
|
|
maxBufferedBytes: 8,
|
|
signal: new AbortController().signal,
|
|
onProgress() {},
|
|
}),
|
|
).toMatchObject({ ok: true, value: { kind: "BROWSER_HANDOFF" } });
|
|
|
|
runtime.previews.dispose();
|
|
expect(revoked).toEqual([]);
|
|
|
|
runtime.dispose();
|
|
expect(revoked).toEqual(["blob:runtime-download"]);
|
|
});
|
|
|
|
it("reports exhausted object URL leases as retryable until the grace ends (02-04)", async () => {
|
|
const scheduled: Array<() => void> = [];
|
|
let urlSequence = 0;
|
|
const runtime = createBrowserFileRuntime({
|
|
input: fileInput(),
|
|
policies,
|
|
limits: {
|
|
hardMaxPreviewBytes: 8,
|
|
hardMaxObjectUrlBytes: 8,
|
|
hardMaxTransferBytes: 16,
|
|
hardMaxActiveObjectUrls: 2,
|
|
},
|
|
objectUrlApi: {
|
|
createObjectURL: () => `blob:runtime-download-${urlSequence++}`,
|
|
revokeObjectURL() {},
|
|
},
|
|
download: {
|
|
host: { handoff: vi.fn() },
|
|
browserManagedCapabilities:
|
|
unusedBrowserManagedCapabilities,
|
|
scheduler: {
|
|
setTimeout(callback) {
|
|
scheduled.push(callback);
|
|
return scheduled.length;
|
|
},
|
|
},
|
|
},
|
|
});
|
|
const deliver = () =>
|
|
runtime.downloads.deliver({
|
|
policy: downloadPolicy,
|
|
source: {
|
|
kind: "GENERATED",
|
|
bytes: {
|
|
byteLength: 3,
|
|
async *stream() {
|
|
yield { ok: true, value: new Uint8Array([1, 2, 3]) };
|
|
},
|
|
},
|
|
},
|
|
suggestedFileName: "artifact",
|
|
signal: new AbortController().signal,
|
|
onProgress() {},
|
|
});
|
|
|
|
// Each handoff keeps its lease for the revoke grace, so the third
|
|
// download inside that window finds every slot in use.
|
|
expect(await deliver()).toMatchObject({ ok: true });
|
|
expect(await deliver()).toMatchObject({ ok: true });
|
|
expect(await deliver()).toMatchObject({
|
|
ok: false,
|
|
error: {
|
|
code: "LIMIT_EXCEEDED",
|
|
retryable: true,
|
|
recovery: "RETRY",
|
|
},
|
|
});
|
|
|
|
for (const release of scheduled.splice(0)) release();
|
|
expect(await deliver()).toMatchObject({
|
|
ok: true,
|
|
value: { kind: "BROWSER_HANDOFF" },
|
|
});
|
|
runtime.dispose();
|
|
});
|
|
|
|
it("aborts a pending native picker and prevents event resurrection", async () => {
|
|
const input = fileInput();
|
|
Object.defineProperty(input, "click", {
|
|
configurable: true,
|
|
value: vi.fn(),
|
|
});
|
|
const runtime = createBrowserFileRuntime({
|
|
input,
|
|
policies,
|
|
limits: {
|
|
hardMaxPreviewBytes: 8,
|
|
hardMaxObjectUrlBytes: 8,
|
|
hardMaxTransferBytes: 16,
|
|
},
|
|
vault: {
|
|
createReference: () => "file:must-not-exist",
|
|
},
|
|
download: {
|
|
host: { handoff() {} },
|
|
browserManagedCapabilities:
|
|
unusedBrowserManagedCapabilities,
|
|
},
|
|
});
|
|
const pending = runtime.baselinePicker.select({
|
|
policy: filePolicy,
|
|
});
|
|
|
|
runtime.dispose();
|
|
expect(await pending).toMatchObject({
|
|
ok: false,
|
|
error: { code: "ABORTED" },
|
|
});
|
|
Object.defineProperty(input, "files", {
|
|
configurable: true,
|
|
value: [
|
|
new File(["late"], "late.txt", {
|
|
type: "text/plain",
|
|
lastModified: 1,
|
|
}),
|
|
],
|
|
});
|
|
input.dispatchEvent(new Event("change"));
|
|
expect(
|
|
await runtime.baselinePicker.select({
|
|
policy: filePolicy,
|
|
}),
|
|
).toMatchObject({
|
|
ok: false,
|
|
error: { code: "UNAVAILABLE" },
|
|
});
|
|
});
|
|
|
|
it("aborts a generated download whose producer ignores cancellation", async () => {
|
|
let reportStarted: (() => void) | undefined;
|
|
const started = new Promise<void>((resolve) => {
|
|
reportStarted = resolve;
|
|
});
|
|
let unblockProducer: (() => void) | undefined;
|
|
const producerBlock = new Promise<void>((resolve) => {
|
|
unblockProducer = resolve;
|
|
});
|
|
const runtime = createBrowserFileRuntime({
|
|
input: fileInput(),
|
|
policies,
|
|
limits: {
|
|
hardMaxPreviewBytes: 8,
|
|
hardMaxObjectUrlBytes: 8,
|
|
hardMaxTransferBytes: 16,
|
|
},
|
|
download: {
|
|
host: { handoff() {} },
|
|
browserManagedCapabilities:
|
|
unusedBrowserManagedCapabilities,
|
|
},
|
|
});
|
|
const pending = runtime.downloads.deliver({
|
|
policy: downloadPolicy,
|
|
source: {
|
|
kind: "GENERATED",
|
|
bytes: {
|
|
byteLength: 1,
|
|
async *stream() {
|
|
reportStarted?.();
|
|
await producerBlock;
|
|
yield {
|
|
ok: true as const,
|
|
value: new Uint8Array([1]),
|
|
};
|
|
},
|
|
},
|
|
},
|
|
suggestedFileName: "blocked",
|
|
maxTransferBytes: 8,
|
|
maxBufferedBytes: 8,
|
|
signal: new AbortController().signal,
|
|
onProgress() {},
|
|
});
|
|
|
|
await started;
|
|
runtime.dispose();
|
|
expect(await pending).toMatchObject({
|
|
ok: false,
|
|
error: { code: "ABORTED", operation: "DOWNLOAD" },
|
|
});
|
|
unblockProducer?.();
|
|
});
|
|
|
|
it("rejects inconsistent absolute limits during composition", () => {
|
|
expect(() =>
|
|
createBrowserFileRuntime({
|
|
input: fileInput(),
|
|
policies,
|
|
limits: {
|
|
hardMaxPreviewBytes: 8,
|
|
hardMaxObjectUrlBytes: 17,
|
|
hardMaxTransferBytes: 16,
|
|
},
|
|
download: {
|
|
host: { handoff() {} },
|
|
browserManagedCapabilities:
|
|
unusedBrowserManagedCapabilities,
|
|
},
|
|
}),
|
|
).toThrowError("Browser file runtime hard limits are invalid.");
|
|
});
|
|
});
|