DongHyeonka
b693600103
fix(ci): 테스트가 만드는 로컬 빌드는 CI=true에서도 release 빌드로 검사되지 않는다
...
문제
workflow는 모든 job에 CI=true와 CI 빌드 식별값을 준다. 메인 세션이 깨끗한
clone에서 그 env 그대로(CI=true 포함) merge 단계 14개를 돌리자 FE-GATE-005·
008·020이 실패했다.
- vitest 안의 fixture 빌드(tests/e2e/support/fixture-builds.ts →
build-frontend.ts)가 CI=true를 물려받아 release 빌드처럼 검사된다.
af312de가 vitest에서 VITE_COMMIT_SHA를 지워 "missing required CI build
environment: VITE_COMMIT_SHA"로 멈춘다(service-worker-build-output 7건이
돌지 않음, 제거 드릴 안에서도 같다).
- 시각 골든 build(9bddfa5 )가 VITE_COMMIT_SHA="local"을 받는데 CI=true가
40·64자리 hex를 요구해 webServer가 뜨지 않는다.
내 X4가 CI=true 없이 돌아 놓쳤다. 1103/11-07과 같은 원인이다.
고른 방법
- scripts/lib/build-environment.ts에 둘을 둔다.
- localBuildEnvironment(env): spawn하는 로컬 빌드용. CI와 CI 빌드 식별값을
뺀 사본. fixture-builds.ts, service-worker-builds.ts가 쓴다.
- LOCAL_BUILD_IDENTITY: Playwright web server용. Playwright가 env를
process.env 위에 합치므로 CI를 지우지 않고 ""로 덮는다(검사는
CI === "true"일 때만). visual·capabilities·dev 설정이 쓴다.
- assertCiBuildEnvironment의 CI=true 검사는 그대로다. job 자신의 release
빌드(build:release-candidate 등)는 계속 검사된다.
- 버린 대안: 로컬 빌드에 유효한 가짜 커밋 id(0×40)를 주기. CI=true 검사의
다른 칸(CI_RUNNER_IMAGE, SOURCE_DATE_EPOCH)도 함께 맞춰야 하고, 로컬
빌드가 release 빌드인 척한다.
위험·한계
- 로컬 빌드 안에서 CI를 읽어 동작을 바꾸는 코드가 있으면 그 빌드는 이제
CI가 아닌 쪽으로 돈다(지금은 build-environment 검사뿐이다).
검증
- tests/unit/local-build-environment.test.ts 3건: 구현 전 2건 실패(RED),
CI job 자체 검사는 유지.
- CI=true·VITE_COMMIT_SHA·VITE_BUILD_ID=gitea-41-1·RELEASE_ID·
CI_RUNNER_IMAGE·SOURCE_DATE_EPOCH로: service-worker-build-output 7건,
test:visual 6/6, test:unit 2,883, test:component 270, test:integration 189
통과. 수정 전 service-worker-build-output은 7건 미실행.
- check:types, lint 통과.
Refs: docs/reviews/2026-11-03-maturity-review/README.md 13절 11-08
2026-11-05 04:26:44 +09:00
..
2026-11-04 20:18:40 +09:00
2026-11-03 00:55:33 +09:00
2026-11-04 21:28:13 +09:00
2026-11-04 22:59:03 +09:00
2026-09-24 15:33:13 +09:00
2026-11-04 22:56:52 +09:00
2026-11-01 23:44:29 +09:00
2026-11-04 21:10:19 +09:00
2026-09-25 22:37:21 +09:00
2026-09-25 22:49:32 +09:00
2026-09-25 22:58:37 +09:00
2026-09-24 16:25:22 +09:00
2026-11-04 21:03:40 +09:00
2026-11-04 20:38:12 +09:00
2026-11-03 21:12:34 +09:00
2026-09-24 00:42:21 +09:00
2026-11-04 20:59:25 +09:00
2026-11-04 20:59:25 +09:00
2026-09-26 00:29:34 +09:00
2026-11-04 21:18:51 +09:00
2026-11-01 23:14:47 +09:00
2026-11-01 22:25:41 +09:00
2026-09-24 00:42:21 +09:00
2026-11-04 20:25:48 +09:00
2026-09-24 00:42:21 +09:00
2026-11-04 20:22:27 +09:00
2026-09-25 22:54:40 +09:00
2026-11-01 22:49:13 +09:00
2026-11-04 20:22:27 +09:00
2026-09-24 00:42:21 +09:00
2026-09-24 13:58:35 +09:00
2026-09-24 00:42:21 +09:00
2026-11-04 23:10:59 +09:00
2026-09-24 00:42:21 +09:00
2026-11-04 22:59:48 +09:00
2026-09-26 00:04:25 +09:00
2026-09-24 13:41:45 +09:00
2026-09-24 13:45:37 +09:00
2026-11-03 00:55:33 +09:00
2026-11-03 21:37:48 +09:00
2026-09-24 13:45:37 +09:00
2026-11-03 00:55:33 +09:00
2026-11-04 20:22:13 +09:00
2026-11-04 23:42:00 +09:00
2026-11-01 23:14:47 +09:00
2026-09-24 13:41:45 +09:00
2026-11-03 07:17:49 +09:00
2026-11-04 22:50:22 +09:00
2026-11-03 06:52:43 +09:00
2026-09-24 00:42:21 +09:00
2026-11-03 01:24:31 +09:00
2026-11-03 01:24:31 +09:00
2026-11-05 03:30:56 +09:00
2026-09-24 00:42:21 +09:00
2026-09-25 22:52:33 +09:00
2026-11-04 23:11:22 +09:00
2026-11-04 20:28:49 +09:00
2026-09-26 00:16:55 +09:00
2026-11-04 22:56:52 +09:00
2026-11-04 20:30:47 +09:00
2026-09-25 23:10:19 +09:00
2026-11-04 21:31:16 +09:00
2026-11-04 20:34:39 +09:00
2026-09-24 00:42:21 +09:00
2026-09-27 13:20:12 +09:00
2026-11-05 01:26:27 +09:00
2026-09-24 12:25:01 +09:00
2026-11-04 20:57:17 +09:00
2026-09-24 00:42:21 +09:00
2026-09-24 00:42:21 +09:00
2026-09-25 23:58:52 +09:00
2026-09-24 13:32:37 +09:00
2026-09-24 00:42:21 +09:00
2026-11-01 23:14:47 +09:00
2026-09-24 00:42:21 +09:00
2026-09-25 22:57:51 +09:00
2026-09-25 22:33:44 +09:00
2026-11-04 20:38:17 +09:00
2026-09-25 22:52:29 +09:00
2026-09-24 13:30:26 +09:00
2026-09-25 21:18:39 +09:00
2026-09-24 00:42:21 +09:00
2026-09-27 13:14:03 +09:00
2026-11-03 02:00:45 +09:00
2026-11-05 04:26:44 +09:00
2026-09-25 23:00:43 +09:00
2026-09-24 00:42:21 +09:00
2026-09-25 22:07:53 +09:00
2026-09-25 22:18:00 +09:00
2026-11-04 22:34:58 +09:00
2026-11-01 23:18:45 +09:00
2026-11-04 20:54:24 +09:00
2026-11-01 22:16:26 +09:00
2026-11-04 20:29:34 +09:00
2026-11-04 20:56:03 +09:00
2026-09-24 00:42:21 +09:00
2026-11-01 22:56:29 +09:00
2026-11-04 20:22:27 +09:00
2026-11-04 22:28:30 +09:00
2026-09-27 13:32:33 +09:00
2026-09-27 13:47:35 +09:00
2026-09-25 22:25:44 +09:00
2026-09-27 13:47:35 +09:00
2026-09-27 13:32:33 +09:00
2026-11-04 20:48:50 +09:00
2026-11-03 20:23:14 +09:00
2026-11-05 01:33:38 +09:00
2026-11-05 03:30:56 +09:00
2026-11-03 01:52:18 +09:00
2026-11-01 22:16:26 +09:00
2026-11-04 20:35:11 +09:00
2026-11-04 20:46:40 +09:00
2026-11-01 21:57:53 +09:00
2026-09-24 00:42:21 +09:00
2026-11-01 20:50:00 +09:00
2026-11-04 21:00:22 +09:00
2026-09-24 00:42:21 +09:00
2026-11-04 21:01:49 +09:00
2026-09-26 00:26:17 +09:00
2026-09-24 00:42:21 +09:00
2026-09-24 00:42:21 +09:00
2026-09-24 00:42:21 +09:00
2026-09-24 00:42:21 +09:00
2026-11-03 01:50:12 +09:00
2026-11-04 20:38:14 +09:00
2026-09-25 23:19:41 +09:00
2026-11-04 20:30:47 +09:00
2026-11-04 21:31:16 +09:00
2026-09-27 13:16:31 +09:00
2026-11-04 20:19:33 +09:00
2026-09-26 00:36:49 +09:00
2026-11-04 20:20:51 +09:00
2026-11-01 23:14:47 +09:00
2026-11-01 23:14:48 +09:00
2026-09-25 22:25:44 +09:00
2026-11-04 20:59:31 +09:00
2026-09-24 11:55:57 +09:00
2026-09-27 13:32:33 +09:00
2026-09-24 00:42:21 +09:00
2026-11-03 21:12:34 +09:00
2026-11-01 23:44:29 +09:00
2026-09-24 00:42:21 +09:00
2026-11-04 21:23:52 +09:00
2026-11-04 20:30:47 +09:00
2026-11-04 20:30:47 +09:00
2026-11-04 21:50:30 +09:00
2026-11-04 23:04:17 +09:00
2026-09-24 00:42:21 +09:00
2026-11-04 23:35:33 +09:00
2026-11-04 23:35:33 +09:00
2026-09-24 00:42:21 +09:00
2026-09-24 00:42:21 +09:00
2026-09-27 13:32:33 +09:00
2026-09-24 00:42:21 +09:00
2026-09-24 16:25:22 +09:00
2026-09-27 12:57:41 +09:00
2026-11-04 20:35:11 +09:00
2026-11-04 20:40:11 +09:00
2026-11-01 22:49:38 +09:00
2026-09-24 00:42:21 +09:00
2026-11-04 20:57:19 +09:00
2026-09-25 22:38:34 +09:00
2026-09-25 21:34:12 +09:00
2026-09-24 00:42:21 +09:00
2026-11-01 22:42:44 +09:00
2026-11-04 20:32:17 +09:00
2026-11-03 07:17:49 +09:00
2026-09-26 01:01:49 +09:00
2026-09-26 00:22:16 +09:00
2026-11-03 21:37:48 +09:00
2026-09-24 00:42:21 +09:00
2026-11-03 01:24:31 +09:00
2026-09-25 22:23:01 +09:00
2026-09-24 00:42:21 +09:00
2026-09-24 00:42:21 +09:00
2026-09-24 00:42:21 +09:00
2026-11-01 23:18:45 +09:00
2026-09-25 23:19:41 +09:00
2026-09-24 13:54:42 +09:00
2026-09-24 00:42:21 +09:00
2026-09-24 00:42:21 +09:00
2026-09-24 00:42:21 +09:00
2026-09-26 00:32:19 +09:00
2026-11-04 20:24:14 +09:00
2026-11-03 01:58:38 +09:00