문제
workflow는 모든 job에 CI=true와 CI 빌드 식별값을 준다. 메인 세션이 깨끗한
clone에서 그 env 그대로(CI=true 포함) merge 단계 14개를 돌리자 FE-GATE-005·
008·020이 실패했다.
- vitest 안의 fixture 빌드(tests/e2e/support/fixture-builds.ts →
build-frontend.ts)가 CI=true를 물려받아 release 빌드처럼 검사된다.
af312de가 vitest에서 VITE_COMMIT_SHA를 지워 "missing required CI build
environment: VITE_COMMIT_SHA"로 멈춘다(service-worker-build-output 7건이
돌지 않음, 제거 드릴 안에서도 같다).
- 시각 골든 build(9bddfa5)가 VITE_COMMIT_SHA="local"을 받는데 CI=true가
40·64자리 hex를 요구해 webServer가 뜨지 않는다.
내 X4가 CI=true 없이 돌아 놓쳤다. 1103/11-07과 같은 원인이다.
고른 방법
- scripts/lib/build-environment.ts에 둘을 둔다.
- localBuildEnvironment(env): spawn하는 로컬 빌드용. CI와 CI 빌드 식별값을
뺀 사본. fixture-builds.ts, service-worker-builds.ts가 쓴다.
- LOCAL_BUILD_IDENTITY: Playwright web server용. Playwright가 env를
process.env 위에 합치므로 CI를 지우지 않고 ""로 덮는다(검사는
CI === "true"일 때만). visual·capabilities·dev 설정이 쓴다.
- assertCiBuildEnvironment의 CI=true 검사는 그대로다. job 자신의 release
빌드(build:release-candidate 등)는 계속 검사된다.
- 버린 대안: 로컬 빌드에 유효한 가짜 커밋 id(0×40)를 주기. CI=true 검사의
다른 칸(CI_RUNNER_IMAGE, SOURCE_DATE_EPOCH)도 함께 맞춰야 하고, 로컬
빌드가 release 빌드인 척한다.
위험·한계
- 로컬 빌드 안에서 CI를 읽어 동작을 바꾸는 코드가 있으면 그 빌드는 이제
CI가 아닌 쪽으로 돈다(지금은 build-environment 검사뿐이다).
검증
- tests/unit/local-build-environment.test.ts 3건: 구현 전 2건 실패(RED),
CI job 자체 검사는 유지.
- CI=true·VITE_COMMIT_SHA·VITE_BUILD_ID=gitea-41-1·RELEASE_ID·
CI_RUNNER_IMAGE·SOURCE_DATE_EPOCH로: service-worker-build-output 7건,
test:visual 6/6, test:unit 2,883, test:component 270, test:integration 189
통과. 수정 전 service-worker-build-output은 7건 미실행.
- check:types, lint 통과.
Refs: docs/reviews/2026-11-03-maturity-review/README.md 13절 11-08
338 lines
12 KiB
TypeScript
338 lines
12 KiB
TypeScript
import { spawnSync } from "node:child_process";
|
|
import { existsSync } from "node:fs";
|
|
import {
|
|
cp,
|
|
mkdtemp,
|
|
readFile,
|
|
rename,
|
|
rm,
|
|
writeFile,
|
|
} from "node:fs/promises";
|
|
import { createServer, type Server } from "node:http";
|
|
import type { AddressInfo } from "node:net";
|
|
import { tmpdir } from "node:os";
|
|
import path from "node:path";
|
|
import { pathToFileURL } from "node:url";
|
|
import { gzipSync } from "node:zlib";
|
|
|
|
import { SERVICE_WORKER_ASSETS_OUTPUT } from "../../../scripts/generate-service-worker-assets.ts";
|
|
import { localBuildEnvironment } from "../../../scripts/lib/build-environment.ts";
|
|
import { linkFixtureNodeModules } from "../../../scripts/lib/fixture-node-modules.ts";
|
|
import type { StaticAssetManifestV1 } from "../../../src/contracts/service-worker.ts";
|
|
|
|
/**
|
|
* R3-6 test helper: two real production builds with the Service Worker on,
|
|
* and a static server that can switch which one it serves.
|
|
*
|
|
* The template ships with `serviceWorker: null`. The supported way to turn the
|
|
* worker on is the static capability selection in the product-owned
|
|
* `src/features/product-capabilities.ts` (`mode: "ACTIVE"` with the
|
|
* `PWA_STATIC_ASSETS` handler); `scripts/build-frontend.ts` then runs the
|
|
* two-pass worker build. Runtime Config can only disable it. So the helper
|
|
* copies the repo to a temp dir, edits the selection there, and runs the
|
|
* repo's own build scripts twice with different `VITE_BUILD_ID`s. The working
|
|
* tree and its `dist` (served by the e2e preview server) are never touched.
|
|
*
|
|
* The app composes the worker host but nothing subscribes to it yet, and it is
|
|
* not reachable from outside. The copy therefore also wraps
|
|
* `createServiceWorkerRuntimeHost` so the page records the host's own
|
|
* `onUpdateWaiting` / `onReloadRequired` callbacks and `start()` outcome on
|
|
* `globalThis.__caServiceWorkerTest`. Only the temp copy is edited.
|
|
*
|
|
* 0929/11-03. What the copy relies on, and where to change it when a product
|
|
* changes that code:
|
|
* 1. `src/features/product-capabilities.ts` has one
|
|
* `const SERVICE_WORKER: InstalledServiceWorkerSelection | null = …;`.
|
|
* A selection that is already `ACTIVE` (a product that turned the worker
|
|
* on) is kept as it is; anything else becomes `ACTIVE_VALUE`.
|
|
* 2. `src/bootstrap/register-service-worker.ts` declares
|
|
* `export function createServiceWorkerRuntimeHost(` once (the probe).
|
|
* 3. The build writes its precache list to `SERVICE_WORKER_ASSETS_OUTPUT`.
|
|
* `precached` is read from there, so a product that precaches more than
|
|
* `dist/assets` still compares against what its worker installs.
|
|
* A broken premise fails `prepareServiceWorkerBuilds` with the file and the
|
|
* text it expected.
|
|
*/
|
|
|
|
const repoRoot = path.resolve(import.meta.dirname, "../../..");
|
|
const skipped = new Set([
|
|
"node_modules",
|
|
".git",
|
|
".claude",
|
|
".generated",
|
|
"dist",
|
|
"artifacts",
|
|
"graphify-out",
|
|
]);
|
|
|
|
export type BuildName = "a" | "b";
|
|
export type ServiceWorkerBuilds = Readonly<{
|
|
root: string;
|
|
dist: Readonly<Record<BuildName, string>>;
|
|
/** Sorted URLs of each build's generated precache list (premise 3). */
|
|
precached: Readonly<Record<BuildName, readonly string[]>>;
|
|
}>;
|
|
|
|
const SELECTION_FILE = "src/features/product-capabilities.ts";
|
|
const SELECTION_DECLARATION =
|
|
/(const SERVICE_WORKER: InstalledServiceWorkerSelection \| null = )([\s\S]*?);\n/gu;
|
|
|
|
export const ACTIVE_VALUE = `{
|
|
mode: "ACTIVE",
|
|
scriptPath: "service-worker.js",
|
|
handlers: ["PWA_STATIC_ASSETS"],
|
|
}`;
|
|
|
|
const HOST_PROBE = `
|
|
export function createServiceWorkerRuntimeHost(
|
|
input: ServiceWorkerHostInput,
|
|
): ServiceWorkerRuntimeHost | null {
|
|
const host = createServiceWorkerRuntimeHostUnobserved(input);
|
|
if (!host) return host;
|
|
const events: string[] = [];
|
|
host.onUpdateWaiting(() => events.push("update-waiting"));
|
|
host.onReloadRequired(() => events.push("reload-required"));
|
|
const observed: ServiceWorkerRuntimeHost = Object.freeze({
|
|
...host,
|
|
start: async () => {
|
|
const outcome = await host.start();
|
|
events.push("start:" + JSON.stringify(outcome));
|
|
return outcome;
|
|
},
|
|
});
|
|
Object.assign(globalThis, { __caServiceWorkerTest: { host: observed, events } });
|
|
return observed;
|
|
}
|
|
`;
|
|
|
|
export async function replaceOnce(
|
|
file: string,
|
|
search: string,
|
|
replacement: string,
|
|
): Promise<void> {
|
|
const source = await readFile(file, "utf8");
|
|
if (source.split(search).length !== 2) {
|
|
throw new Error(`Expected exactly one "${search}" in ${file}.`);
|
|
}
|
|
await writeFile(file, source.replace(search, replacement));
|
|
}
|
|
|
|
/**
|
|
* Premise 1. Replaces the value of the one `SERVICE_WORKER` declaration in
|
|
* the temp copy with `next(current)`, whatever the value is now.
|
|
*/
|
|
export async function setServiceWorkerSelection(
|
|
root: string,
|
|
next: (current: string) => string,
|
|
): Promise<void> {
|
|
const file = path.join(root, SELECTION_FILE);
|
|
const source = await readFile(file, "utf8");
|
|
if ([...source.matchAll(SELECTION_DECLARATION)].length !== 1) {
|
|
throw new Error(
|
|
`Expected exactly one "const SERVICE_WORKER: InstalledServiceWorkerSelection | null = …;" in ${file} (premise 1 of tests/e2e/support/service-worker-builds.ts).`,
|
|
);
|
|
}
|
|
await writeFile(
|
|
file,
|
|
source.replace(
|
|
SELECTION_DECLARATION,
|
|
(_declaration, head: string, current: string) =>
|
|
`${head}${next(current)};\n`,
|
|
),
|
|
);
|
|
}
|
|
|
|
/**
|
|
* 0929/06-04, 0929/11-03. Turns the copy's worker on whatever the selection is
|
|
* now, but keeps a selection a product already set to `ACTIVE`, so the specs
|
|
* exercise that product's own handlers rather than the template's.
|
|
*/
|
|
export async function turnOnServiceWorker(root: string): Promise<void> {
|
|
await setServiceWorkerSelection(root, (current) =>
|
|
/\bmode:\s*"ACTIVE"/u.test(current) ? current : ACTIVE_VALUE,
|
|
);
|
|
}
|
|
|
|
/**
|
|
* Premise 3. The build wrote this list; the worker installs exactly it. A
|
|
* build without an `ACTIVE` worker (06-03's `REMOVE_REGISTRATION` release)
|
|
* writes none and precaches nothing: `scripts/build-frontend.ts` deletes the
|
|
* directory before every build, so a missing file is that build's answer.
|
|
*/
|
|
async function precachedUrls(root: string, name: BuildName): Promise<string[]> {
|
|
const file = path.join(root, SERVICE_WORKER_ASSETS_OUTPUT);
|
|
if (!existsSync(file)) return [];
|
|
const generated = pathToFileURL(file);
|
|
// Both builds write the same file; the query keeps B from reusing A's module.
|
|
generated.search = `build=${name}`;
|
|
const { SERVICE_WORKER_ASSETS } = (await import(generated.href)) as {
|
|
SERVICE_WORKER_ASSETS: StaticAssetManifestV1;
|
|
};
|
|
return SERVICE_WORKER_ASSETS.assets.map((asset) => asset.url).sort();
|
|
}
|
|
|
|
function run(cwd: string, script: string, buildId: string): void {
|
|
const result = spawnSync("node", [script], {
|
|
cwd,
|
|
encoding: "utf8",
|
|
// 1103/11-08. A local build, not the CI job's release build.
|
|
env: { ...localBuildEnvironment(), VITE_BUILD_ID: buildId, RELEASE_ID: buildId },
|
|
});
|
|
if (result.status !== 0) {
|
|
throw new Error(
|
|
`${script} failed for ${buildId}:\n${result.stdout}\n${result.stderr}`,
|
|
);
|
|
}
|
|
}
|
|
|
|
/**
|
|
* `beforeBuild` edits the temp copy right before build `name` (06-03: a
|
|
* broken worker A, then a `REMOVE_REGISTRATION` release B). Edits persist
|
|
* into the later build.
|
|
*/
|
|
export async function prepareServiceWorkerBuilds(
|
|
options: Readonly<{
|
|
beforeBuild?: (name: BuildName, root: string) => Promise<void>;
|
|
}> = {},
|
|
): Promise<ServiceWorkerBuilds> {
|
|
const root = await mkdtemp(path.join(tmpdir(), "ca-sw-builds-"));
|
|
try {
|
|
await cp(repoRoot, root, {
|
|
recursive: true,
|
|
filter: (source) =>
|
|
!skipped.has(path.relative(repoRoot, source).split(path.sep)[0]!),
|
|
});
|
|
await linkFixtureNodeModules(root, repoRoot);
|
|
await turnOnServiceWorker(root);
|
|
const hostFile = path.join(root, "src/bootstrap/register-service-worker.ts");
|
|
await replaceOnce(
|
|
hostFile,
|
|
"export function createServiceWorkerRuntimeHost(",
|
|
"function createServiceWorkerRuntimeHostUnobserved(",
|
|
);
|
|
await writeFile(hostFile, (await readFile(hostFile, "utf8")) + HOST_PROBE);
|
|
|
|
const dist = { a: path.join(root, "dist-a"), b: path.join(root, "dist-b") };
|
|
const precached: Record<BuildName, readonly string[]> = { a: [], b: [] };
|
|
for (const name of ["a", "b"] as const) {
|
|
await options.beforeBuild?.(name, root);
|
|
run(root, "scripts/generate-product-feature-index.ts", `sw-e2e-${name}`);
|
|
run(root, "scripts/build-frontend.ts", `sw-e2e-${name}`);
|
|
await rename(path.join(root, "dist"), dist[name]);
|
|
precached[name] = await precachedUrls(root, name);
|
|
}
|
|
return { root, dist, precached };
|
|
} catch (error) {
|
|
// The spec never receives `root` from a failed setup, so afterAll cannot
|
|
// remove it.
|
|
await rm(root, { recursive: true, force: true });
|
|
throw error;
|
|
}
|
|
}
|
|
|
|
export async function removeServiceWorkerBuilds(
|
|
builds: ServiceWorkerBuilds | undefined,
|
|
): Promise<void> {
|
|
if (builds) await rm(builds.root, { recursive: true, force: true });
|
|
}
|
|
|
|
export type AssetHeaders = Readonly<{
|
|
/** Sent for every `.js` file, the worker script included. */
|
|
javascriptContentType: string;
|
|
/** gzip every `/assets/*` body; Content-Length is the compressed size. */
|
|
gzip: boolean;
|
|
}>;
|
|
|
|
export type ServedResponse = Readonly<{
|
|
path: string;
|
|
contentType: string;
|
|
contentEncoding: string | null;
|
|
contentLength: number;
|
|
decodedLength: number;
|
|
}>;
|
|
|
|
const CONTENT_TYPES: Readonly<Record<string, string>> = {
|
|
".html": "text/html; charset=utf-8",
|
|
".css": "text/css",
|
|
".json": "application/json",
|
|
".svg": "image/svg+xml",
|
|
".png": "image/png",
|
|
".webp": "image/webp",
|
|
".woff2": "font/woff2",
|
|
};
|
|
|
|
/**
|
|
* Serves one dist directory at a time from an ephemeral 127.0.0.1 port, so
|
|
* every test gets its own origin (and its own Service Worker registration).
|
|
* Paths without an extension get `index.html`; a missing file is a plain 404,
|
|
* never the SPA fallback, so a chunk that the served build lacks really 404s.
|
|
*/
|
|
export async function startBuildServer(
|
|
dist: Readonly<Record<BuildName, string>>,
|
|
headers: AssetHeaders = {
|
|
javascriptContentType: "text/javascript",
|
|
gzip: false,
|
|
},
|
|
) {
|
|
let current: BuildName = "a";
|
|
const served: ServedResponse[] = [];
|
|
const server: Server = createServer((request, response) => {
|
|
void (async () => {
|
|
const pathname = decodeURIComponent(
|
|
new URL(request.url ?? "/", "http://127.0.0.1").pathname,
|
|
);
|
|
const root = dist[current];
|
|
const file = path.extname(pathname)
|
|
? path.join(root, path.normalize(pathname))
|
|
: path.join(root, "index.html");
|
|
let body: Buffer;
|
|
try {
|
|
if (!file.startsWith(root + path.sep)) throw new Error("outside root");
|
|
body = await readFile(file);
|
|
} catch {
|
|
response.writeHead(404, { "cache-control": "no-store" }).end();
|
|
return;
|
|
}
|
|
const extension = path.extname(file);
|
|
const contentType =
|
|
extension === ".js"
|
|
? headers.javascriptContentType
|
|
: (CONTENT_TYPES[extension] ?? "application/octet-stream");
|
|
const encoded = headers.gzip && pathname.startsWith("/assets/");
|
|
const payload = encoded ? gzipSync(body) : body;
|
|
served.push({
|
|
path: pathname,
|
|
contentType,
|
|
contentEncoding: encoded ? "gzip" : null,
|
|
contentLength: payload.byteLength,
|
|
decodedLength: body.byteLength,
|
|
});
|
|
response
|
|
.writeHead(200, {
|
|
"content-type": contentType,
|
|
"content-length": String(payload.byteLength),
|
|
"cache-control": "no-cache",
|
|
...(encoded
|
|
? { "content-encoding": "gzip", vary: "Accept-Encoding" }
|
|
: {}),
|
|
})
|
|
.end(request.method === "HEAD" ? undefined : payload);
|
|
})();
|
|
});
|
|
await new Promise<void>((resolve) =>
|
|
server.listen(0, "127.0.0.1", () => resolve()),
|
|
);
|
|
const { port } = server.address() as AddressInfo;
|
|
return {
|
|
origin: `http://127.0.0.1:${port}`,
|
|
served,
|
|
serve(name: BuildName) {
|
|
current = name;
|
|
},
|
|
async close() {
|
|
server.closeAllConnections();
|
|
await new Promise<void>((resolve) => server.close(() => resolve()));
|
|
},
|
|
};
|
|
}
|