문제: 매뉴얼 1단계 예시 ID는 invoice-feature이고 11단계가 `test:sample-removal -- --feature=invoice-feature`로 그 기능을 지운다. 드릴은 제품 기능의 잔여를 src·tests 모든 파일에서 기능 ID의 대소문자 무시 부분 문자열로 찾았다. 템플릿 소유 tests/unit/create-feature.test.ts가 같은 예시 ID를 데이터로 51번 쓰므로, 다른 검사가 모두 통과해도 `fixture-id-residue: residue: tests/unit/create-feature.test.ts`로 rc=1이었다 (리뷰 16-R1). errors.md의 안내는 그 템플릿 파일을 고치라는 것이었다. notice-feature, orders-feature, shop-feature 같은 이름도 같은 충돌이 난다. 고른 방법: 제품 기능의 잔여 판정을 scripts/lib/feature-residue.ts의 productFeatureResidue로 옮기고 범위를 나눈다. - src: 지금처럼 경로나 내용에 기능 ID·폴더 이름이 있으면 잔여. 플랫폼 소스는 제품 기능을 이름으로 부르지 않으므로, 남은 이름은 타입 검사가 못 보는 참조(카탈로그 키, 런타임 오버라이드, 링크)다. - tests: 파일 이름에 기능 ID가 있거나, 기능의 src/features/<dir>/ 또는 tests/features/<dir>/에서 import(동적 import, vi.mock 포함)하는 파일만 잔여. 테스트 본문에 ID를 글자로 적은 것은 세지 않는다. 지운 기능에 기대는 테스트는 같은 드릴의 test:all이 잡는다. 참조 샘플(reference-feature)은 템플릿이 모든 파일을 가지므로 기존 넓은 패턴을 그대로 쓴다. 빌드 산출물(dist) 잔여 검사도 그대로다. 단위 테스트: 저장소 자체(create-feature.test.ts 포함)를 invoice-feature로 훑으면 잔여 0, src/contracts에 ID를 남긴 파일·이름에 ID가 있는 e2e spec·기능 폴더 import는 잔여, 테스트 본문의 예시 데이터는 잔여 아님. 매뉴얼 01 11단계와 errors.md의 판정 문장·안내(템플릿 파일이 나오면 고치지 말고 템플릿에 알린다)를 고쳤다. 버린 대안: - 제거 전에 한 번 훑어 이미 걸리던 파일을 제외: src/contracts에 남긴 잔여도 제거 전부터 ID를 담고 있으므로 같이 빠진다(완료 기준 둘째를 못 지킨다). - 템플릿 테스트의 예시 ID를 예약 접두어로 바꾸기: 부분 문자열 검색이면 접두어를 붙여도 걸리고, create-feature.test.ts의 파생 이름 기대값 수십 곳을 함께 바꿔야 한다. - 생성 명령이 템플릿 테스트에 나오는 ID를 거절: 목록이 따로 낡는다. 위험·한계: tests 안에서 기능 ID를 글자로만 담은 진짜 잔여(예: 기능을 import하지 않고 경로 문자열만 적은 테스트)는 이제 잔여로 나오지 않는다. 그런 테스트가 지운 기능에 기대면 test:all이 실패하고, 기대지 않으면 해가 없다. src 쪽 부분 문자열 검색은 그대로라 items 같은 짧은 ID는 플랫폼 소스의 글자에 여전히 걸릴 수 있다(이번 범위 밖). 실제 드릴 실행(198초)은 단위 테스트로 대신하지 못한다. 검증: desktop batch에서 확인. node scripts/run-vitest.ts run tests/unit/feature-residue.test.ts 16-R1과 같은 순서: create:feature invoice-feature --with-create --keyed 뒤 corepack pnpm test:sample-removal -- --feature=invoice-feature (rc=0 기대), 그리고 src/contracts/invoice-leftover.ts에 "invoice-feature"를 남긴 변이에서 rc=1(fixture-id-residue) 기대 Refs: 1105/16-04
537 lines
20 KiB
TypeScript
537 lines
20 KiB
TypeScript
import {
|
|
access,
|
|
mkdir,
|
|
readdir,
|
|
readFile,
|
|
rm,
|
|
writeFile,
|
|
} from "node:fs/promises";
|
|
import { spawnSync } from "node:child_process";
|
|
import path from "node:path";
|
|
|
|
import { ROUTE_FEATURE_OWNER } from "../src/features/installed-feature-contracts.ts";
|
|
import { createFileSystemDeclarationSource } from "./generate-product-feature-index.ts";
|
|
import { productFeatureResidue } from "./lib/feature-residue.ts";
|
|
import { isProductionModulePath } from "./lib/risk-coverage.ts";
|
|
import {
|
|
createRemovalFixtureRoot,
|
|
filesBelow,
|
|
prepareRemovalFixture,
|
|
pruneRemovalFixtureCiContract,
|
|
pruneScriptOrchestration,
|
|
regenerateRemovalFixtureWorkflow,
|
|
REMOVAL_FIXTURE_COPY_TARGETS,
|
|
REMOVAL_FIXTURE_DOCUMENT_TARGETS,
|
|
renderRemovalJunit,
|
|
requireRemovalFixtureEnvironment,
|
|
runRemovalFixtureCheck,
|
|
runRemovalFixturePnpm,
|
|
sealRemovalFixtureRepository,
|
|
type RemovalCheck,
|
|
} from "./lib/removal-fixture.ts";
|
|
|
|
/**
|
|
* 09-07 (D-10). Removes one installed feature, `--feature=<id>` (default: the
|
|
* reference sample), from a copy of the repository and proves the rest still
|
|
* typechecks, tests, covers and builds. Every feature loses its directory, its
|
|
* tests/features directory, its context when no other feature is left in it,
|
|
* its runtime-profile override and its central policy rows. The sample also
|
|
* owns the extra paths and scripts listed in SAMPLE_EXTRAS.
|
|
*/
|
|
const featureId =
|
|
process.argv.find((argument) => argument.startsWith("--feature="))
|
|
?.slice("--feature=".length) ?? "reference-feature";
|
|
|
|
type FeatureExtras = Readonly<{
|
|
paths: readonly string[];
|
|
ciScripts: readonly string[];
|
|
evidencePathFragments: readonly string[];
|
|
residue: RegExp;
|
|
}>;
|
|
|
|
const SAMPLE_EXTRAS: Readonly<Record<string, FeatureExtras>> = Object.freeze({
|
|
"reference-feature": Object.freeze({
|
|
// 0929/10-02. The HTTP scenario catalog (tests/mocks) and the negative
|
|
// type fixtures of the feature APIs run on the test contracts, so they are
|
|
// platform checks and stay (commonTestPaths below).
|
|
paths: [
|
|
"tests/component/product-feature-switch.test.tsx",
|
|
"tests/e2e/reference-form.spec.ts",
|
|
"tests/e2e/reference-route.spec.ts",
|
|
"tests/e2e/reference-save.spec.ts",
|
|
// 11-04: the growth measurement copies this sample feature.
|
|
"tests/unit/feature-shape-growth.test.ts",
|
|
"scripts/scale/measure-feature-shape-growth.ts",
|
|
"config/scale/feature-shape-growth.json",
|
|
"config/scale/feature-shape-ceilings.json",
|
|
],
|
|
ciScripts: [
|
|
"test:reference-feature",
|
|
],
|
|
evidencePathFragments: [
|
|
"reference-feature.xml",
|
|
],
|
|
residue: /REFERENCE_RESOURCE|reference-feature|reference-resource/i,
|
|
}),
|
|
});
|
|
|
|
function escapeRegExp(value: string): string {
|
|
return value.replace(/[.*+?^${}()|[\]\\]/gu, "\\$&");
|
|
}
|
|
|
|
async function locateFeature(id: string) {
|
|
const source = await createFileSystemDeclarationSource(process.cwd());
|
|
for (const appId of source.appIds()) {
|
|
for (const context of source.contextsOf(appId)) {
|
|
const features = source.featuresOf(context.id);
|
|
const feature = features.find((candidate) => candidate.id === id);
|
|
if (!feature) continue;
|
|
let contextDirectory: string | null = null;
|
|
for (const entry of await readdir("src/contexts", { withFileTypes: true })) {
|
|
if (!entry.isDirectory()) continue;
|
|
const declaration = await readFile(
|
|
path.join("src/contexts", entry.name, "context-module.ts"),
|
|
"utf8",
|
|
).catch(() => "");
|
|
if (
|
|
new RegExp(`CONTEXT_MODULE_ID\\s*=\\s*["']${escapeRegExp(context.id)}["']`, "u")
|
|
.test(declaration)
|
|
) {
|
|
contextDirectory = `src/contexts/${entry.name}`;
|
|
}
|
|
}
|
|
return Object.freeze({
|
|
directory: feature.directory,
|
|
// The context goes with its last feature.
|
|
contextDirectory: features.length === 1 ? contextDirectory : null,
|
|
});
|
|
}
|
|
}
|
|
throw new Error(`No installed feature declares FEATURE_MODULE_ID "${id}"`);
|
|
}
|
|
|
|
const located = await locateFeature(featureId);
|
|
const extras: FeatureExtras = SAMPLE_EXTRAS[featureId] ?? Object.freeze({
|
|
paths: [],
|
|
ciScripts: [],
|
|
evidencePathFragments: [],
|
|
residue: new RegExp(
|
|
`${escapeRegExp(featureId)}|${escapeRegExp(located.directory)}`,
|
|
"i",
|
|
),
|
|
});
|
|
// Captured from this repository before the copy loses them.
|
|
const featureRouteIds = Object.entries(ROUTE_FEATURE_OWNER)
|
|
.filter(([, owner]) => owner === featureId)
|
|
.map(([routeId]) => routeId);
|
|
|
|
const fixtureRoot = await createRemovalFixtureRoot(`${featureId}-removal`);
|
|
const pnpmCli = requireRemovalFixtureEnvironment("npm_execpath");
|
|
const featureSource = `src/features/${located.directory}`;
|
|
const featureTests = `tests/features/${located.directory}`;
|
|
const isSample = featureId in SAMPLE_EXTRAS;
|
|
/**
|
|
* Platform tests that must survive the sample feature's removal. Asserting they
|
|
* are still present is what stops the removal fixture from "passing" by having
|
|
* quietly deleted the platform's own coverage along with the feature.
|
|
*/
|
|
const commonTestPaths = [
|
|
"tests/unit/external-contract-runtime.test.ts",
|
|
"tests/unit/http-execution-v3.test.ts",
|
|
"tests/unit/runtime-adapters.test.ts",
|
|
"tests/integration/http-execution-v3-observability.test.ts",
|
|
// 0929/10-02. HTTP scenario evidence (FE-GATE-007) and the feature API
|
|
// negative type fixtures (FE-GATE-003) run on the test contracts.
|
|
"tests/integration/http-scenario-catalog.test.ts",
|
|
"tests/mocks/scenarios/catalog.ts",
|
|
"tests/mocks/handlers/test-entities.ts",
|
|
// 16-02. Feature tests answer their own operations with it.
|
|
"tests/mocks/handlers/http-scenarios.ts",
|
|
"tests/fixtures/typecheck/fixture-feature-contract.ts",
|
|
"tests/fixtures/typecheck/invalid-feature-input.ts",
|
|
"tests/fixtures/typecheck/invalid-reference-operation.ts",
|
|
"tests/fixtures/typecheck/invalid-http-operation-input.ts",
|
|
"tests/fixtures/typecheck/invalid-http-wire-mapper.ts",
|
|
"tests/fixtures/typecheck/invalid-http-operation-id.ts",
|
|
"tests/fixtures/typecheck/invalid-http-route-id.ts",
|
|
"tests/fixtures/typecheck/invalid-feature-contribution-input.ts",
|
|
"tests/fixtures/typecheck/invalid-feature-capability-selection.ts",
|
|
];
|
|
const featureOwnedPaths = [
|
|
featureSource,
|
|
featureTests,
|
|
// The feature's bounded-context declaration when it was the last feature in
|
|
// it; the template app stays.
|
|
...(located.contextDirectory === null ? [] : [located.contextDirectory]),
|
|
...extras.paths,
|
|
];
|
|
|
|
type CoveragePolicy = {
|
|
repositoryBaseline: number;
|
|
generatedPaths: string[];
|
|
criticalModules: Array<{
|
|
path?: string;
|
|
minimum?: Record<string, number>;
|
|
}>;
|
|
highRiskPaths: string[];
|
|
waivers: Array<{ path?: string }>;
|
|
};
|
|
|
|
type EvidenceContribution = Readonly<{ owner?: string }>;
|
|
type EvidencePolicy = Record<
|
|
"scenarioCatalogs" | "sourceContracts",
|
|
unknown
|
|
>;
|
|
type GovernanceConsumer = Readonly<{ path?: string }>;
|
|
type GovernanceRegistry = Record<string, unknown> & {
|
|
consumers?: unknown;
|
|
consumerDirectories?: unknown;
|
|
};
|
|
type RemovalGovernance = { registries: GovernanceRegistry[] };
|
|
|
|
function runPnpm(script: string, extra: string[] = []): boolean {
|
|
return runRemovalFixturePnpm(fixtureRoot, pnpmCli, script, extra);
|
|
}
|
|
|
|
function check(name: string, script: string, extra: string[] = []): RemovalCheck {
|
|
return runRemovalFixtureCheck(name, fixtureRoot, pnpmCli, script, extra);
|
|
}
|
|
|
|
/** 14-08. A non-command check fails with its own findings, nothing else's. */
|
|
function outcome(name: string, findings: readonly string[], label: string): RemovalCheck {
|
|
return findings.length === 0
|
|
? { name, passed: true }
|
|
: { name, passed: false, failure: `${label}: ${findings.join(", ")}` };
|
|
}
|
|
|
|
try {
|
|
// 1103/14-04. The documents come too: removing a feature must leave them
|
|
// valid, and the fixture used to leave them out with the tests that read
|
|
// them, so a manual naming the sample's files passed here and then failed
|
|
// FE-GATE-017 in the product that removed it.
|
|
await prepareRemovalFixture(fixtureRoot, [
|
|
...REMOVAL_FIXTURE_COPY_TARGETS,
|
|
...REMOVAL_FIXTURE_DOCUMENT_TARGETS,
|
|
]);
|
|
// Fixture-only deletions: a project that removes the sample keeps these.
|
|
// verify:documentation runs in this fixture, so a current contract document
|
|
// must not name them as backtick paths (docs/manual/reference/patterns.md).
|
|
for (const excludedFixtureTest of [
|
|
"tests/unit/ci-workflow-generation.test.ts",
|
|
"tests/unit/__snapshots__/ci-workflow-generation.test.ts.snap",
|
|
"tests/unit/removal-fixture.test.ts",
|
|
"tests/unit/http-scenario-evidence.test.ts",
|
|
]) {
|
|
await rm(path.join(fixtureRoot, excludedFixtureTest), { force: true });
|
|
}
|
|
|
|
const coveragePolicyFile = path.join(
|
|
fixtureRoot,
|
|
"config/testing/risk-coverage.json",
|
|
);
|
|
const coveragePolicy = JSON.parse(
|
|
await readFile(coveragePolicyFile, "utf8"),
|
|
) as CoveragePolicy;
|
|
const generatedProductionModules = new Set(coveragePolicy.generatedPaths);
|
|
|
|
const removedProductionModuleCount = (
|
|
await filesBelow(path.join(fixtureRoot, featureSource))
|
|
)
|
|
.map((file) => path.relative(fixtureRoot, file).split(path.sep).join("/"))
|
|
.filter(
|
|
(file) =>
|
|
isProductionModulePath(file) && !generatedProductionModules.has(file),
|
|
).length;
|
|
|
|
for (const ownedPath of featureOwnedPaths) {
|
|
await rm(path.join(fixtureRoot, ownedPath), {
|
|
recursive: true,
|
|
force: true,
|
|
});
|
|
}
|
|
if (!runPnpm("generate:feature-index")) {
|
|
throw new Error("Feature topology indexes failed to regenerate after sample removal");
|
|
}
|
|
|
|
// Runtime profiles are product configuration. Once the feature is physically
|
|
// removed, its override key must disappear too or the built config still
|
|
// advertises a source capability that no longer exists. public/config.json
|
|
// is the local profile `dev` serves and has to stay equal to it (F-5).
|
|
for (const configPath of [
|
|
"config/runtime/local.json",
|
|
"config/runtime/development.json",
|
|
"config/runtime/staging.json",
|
|
"config/runtime/production.json",
|
|
"public/config.json",
|
|
]) {
|
|
const profilePath = path.join(fixtureRoot, configPath);
|
|
const runtimeConfig = JSON.parse(
|
|
await readFile(profilePath, "utf8"),
|
|
) as {
|
|
FEATURE_OVERRIDES?: Record<string, string>;
|
|
};
|
|
if (runtimeConfig.FEATURE_OVERRIDES) {
|
|
delete runtimeConfig.FEATURE_OVERRIDES[featureId];
|
|
}
|
|
await writeFile(
|
|
profilePath,
|
|
`${JSON.stringify(runtimeConfig, null, 2)}\n`,
|
|
);
|
|
}
|
|
|
|
const retainedCriticalModules = coveragePolicy.criticalModules.filter(
|
|
(modulePolicy) => !modulePolicy.path?.startsWith(`${featureSource}/`),
|
|
);
|
|
if (
|
|
isSample &&
|
|
retainedCriticalModules.length === coveragePolicy.criticalModules.length
|
|
) {
|
|
throw new Error("Reference feature coverage policy is not registered");
|
|
}
|
|
coveragePolicy.criticalModules = retainedCriticalModules;
|
|
coveragePolicy.highRiskPaths = coveragePolicy.highRiskPaths.filter(
|
|
(modulePath) => !modulePath.startsWith(`${featureSource}/`),
|
|
);
|
|
coveragePolicy.waivers = coveragePolicy.waivers.filter(
|
|
(waiver) => !waiver.path?.startsWith(`${featureSource}/`),
|
|
);
|
|
coveragePolicy.generatedPaths = coveragePolicy.generatedPaths.filter(
|
|
(modulePath) => !modulePath.startsWith(`${featureSource}/`),
|
|
);
|
|
coveragePolicy.repositoryBaseline -= removedProductionModuleCount;
|
|
if (coveragePolicy.repositoryBaseline <= 0) {
|
|
throw new Error("Reference feature removal produced an invalid coverage baseline");
|
|
}
|
|
await writeFile(
|
|
coveragePolicyFile,
|
|
`${JSON.stringify(coveragePolicy, null, 2)}\n`,
|
|
);
|
|
|
|
const evidencePolicyFile = path.join(
|
|
fixtureRoot,
|
|
"config/testing/test-evidence.json",
|
|
);
|
|
const evidencePolicy = JSON.parse(
|
|
await readFile(evidencePolicyFile, "utf8"),
|
|
) as EvidencePolicy;
|
|
for (const policyKey of ["scenarioCatalogs", "sourceContracts"] as const) {
|
|
const contributions = evidencePolicy[policyKey];
|
|
if (!Array.isArray(contributions)) {
|
|
throw new Error(`Test evidence policy is missing ${policyKey}`);
|
|
}
|
|
// A feature's own evidence goes with it. The sample has none since
|
|
// 0929/10-02: the HTTP scenario catalog is owned by the platform.
|
|
evidencePolicy[policyKey] = contributions.filter(
|
|
(candidate: unknown) =>
|
|
(candidate as EvidenceContribution).owner !== featureId,
|
|
);
|
|
}
|
|
await writeFile(
|
|
evidencePolicyFile,
|
|
`${JSON.stringify(evidencePolicy, null, 2)}\n`,
|
|
);
|
|
|
|
const governanceFile = path.join(
|
|
fixtureRoot,
|
|
"config/contracts/registry-governance.json",
|
|
);
|
|
const removalGovernance = JSON.parse(
|
|
await readFile(governanceFile, "utf8"),
|
|
) as RemovalGovernance;
|
|
removalGovernance.registries = removalGovernance.registries.map(
|
|
(registry) => ({
|
|
...registry,
|
|
...(Array.isArray(registry.consumers)
|
|
? {
|
|
consumers: registry.consumers.filter(
|
|
(candidate: unknown) => {
|
|
const consumer = candidate as GovernanceConsumer;
|
|
return !consumer.path?.includes(featureSource);
|
|
},
|
|
),
|
|
}
|
|
: {}),
|
|
...(Array.isArray(registry.consumerDirectories)
|
|
? {
|
|
consumerDirectories: registry.consumerDirectories.filter(
|
|
(directory: unknown) =>
|
|
typeof directory !== "string" ||
|
|
!directory.includes(featureSource),
|
|
),
|
|
}
|
|
: {}),
|
|
}),
|
|
);
|
|
await writeFile(
|
|
governanceFile,
|
|
`${JSON.stringify(removalGovernance, null, 2)}\n`,
|
|
);
|
|
|
|
const removedCiScripts = new Set(extras.ciScripts);
|
|
const fixturePackagePath = path.join(fixtureRoot, "package.json");
|
|
const fixturePackage = JSON.parse(await readFile(fixturePackagePath, "utf8")) as {
|
|
scripts: Record<string, string>;
|
|
};
|
|
pruneScriptOrchestration(fixturePackage.scripts, "test:all", removedCiScripts);
|
|
await writeFile(fixturePackagePath, `${JSON.stringify(fixturePackage, null, 2)}\n`);
|
|
await pruneRemovalFixtureCiContract({
|
|
root: fixtureRoot,
|
|
removedScripts: removedCiScripts,
|
|
removedEvidencePathFragments: extras.evidencePathFragments,
|
|
});
|
|
// D-13: removing the sample is a breaking registry change. The fixture
|
|
// records the new registry baseline the way a downstream project does, and
|
|
// the canonical check:registries then runs against it.
|
|
if (!runRemovalFixturePnpm(fixtureRoot, pnpmCli, "update:registry-baseline", [], {
|
|
REGISTRY_BASELINE_OWNER: "removal-fixture",
|
|
REGISTRY_BASELINE_REASON: `${featureId} removed`,
|
|
})) {
|
|
throw new Error("Registry baseline failed to update after sample removal");
|
|
}
|
|
// 1103 X2 #3. The dev server's manifest names the installed contract
|
|
// packages; the removed feature's is gone.
|
|
const devManifest = spawnSync(process.execPath, ["scripts/write-dev-release-manifest.ts"], {
|
|
cwd: fixtureRoot,
|
|
stdio: "inherit",
|
|
});
|
|
if (devManifest.status !== 0) {
|
|
throw new Error("public/release-manifest.json failed to update after the removal");
|
|
}
|
|
// 1103 X2 #2. config/scale/feature-shape-ceilings.json records the initial
|
|
// JavaScript of the features installed now, and test:unit compares a build
|
|
// with it. A product re-records it when it adds a feature; removing that
|
|
// feature changes it again, so the fixture re-records it as the product
|
|
// would. The sample removal deletes the measurement with the sample.
|
|
const measurement = path.join(fixtureRoot, "scripts/scale/measure-feature-shape-growth.ts");
|
|
if (await access(measurement).then(() => true, () => false)) {
|
|
const measured = spawnSync(
|
|
process.execPath,
|
|
[measurement, "--initial-baseline", "--write"],
|
|
{ cwd: fixtureRoot, stdio: "inherit" },
|
|
);
|
|
if (measured.status !== 0) {
|
|
throw new Error("Initial JavaScript record failed to update after the removal");
|
|
}
|
|
}
|
|
await regenerateRemovalFixtureWorkflow(fixtureRoot);
|
|
|
|
const residue: string[] = [];
|
|
if (isSample) {
|
|
for (const root of ["src", "tests"]) {
|
|
for (const file of await filesBelow(path.join(fixtureRoot, root))) {
|
|
const relative = path.relative(fixtureRoot, file);
|
|
const content = await readFile(file, "utf8");
|
|
if (extras.residue.test(`${relative}\n${content}`)) {
|
|
residue.push(relative);
|
|
}
|
|
}
|
|
}
|
|
} else {
|
|
// 1105/16-04. Template tests use example feature IDs as data; only what
|
|
// still points at the removed feature counts (scripts/lib/feature-residue.ts).
|
|
residue.push(...(await productFeatureResidue(fixtureRoot, featureId, located.directory)));
|
|
}
|
|
|
|
const missingCommonTests: string[] = [];
|
|
for (const testPath of commonTestPaths) {
|
|
await access(path.join(fixtureRoot, testPath)).catch(() => {
|
|
missingCommonTests.push(testPath);
|
|
});
|
|
}
|
|
const gateChecks = (prefix: string): RemovalCheck[] => [
|
|
check(`${prefix}typecheck`, "check:types"),
|
|
// 1103/14-04 (FOLLOW-UP 09-07). Merge and documentation gates the drill
|
|
// did not run: the documents, lint, screen text and design tokens can
|
|
// name or use what the removal deleted.
|
|
check(`${prefix}lint`, "lint"),
|
|
check(`${prefix}documentation`, "verify:documentation"),
|
|
check(`${prefix}i18n`, "check:i18n"),
|
|
check(`${prefix}design-system`, "check:design-system"),
|
|
check(`${prefix}architecture`, "check:architecture"),
|
|
check(`${prefix}registries`, "check:registries"),
|
|
check(`${prefix}unit-integration`, "test:all"),
|
|
check(`${prefix}coverage`, "test:coverage"),
|
|
check(`${prefix}test-evidence-source`, "check:test-evidence:source"),
|
|
check(`${prefix}ci-contract`, "check:ci"),
|
|
check(`${prefix}home-smoke`, "exec", [
|
|
"vitest",
|
|
"run",
|
|
"tests/component/router.test.tsx",
|
|
"--reporter=default",
|
|
]),
|
|
check(`${prefix}build`, "build"),
|
|
];
|
|
const checks: RemovalCheck[] = [
|
|
outcome("common-test-evidence", missingCommonTests, "platform tests missing"),
|
|
...gateChecks(""),
|
|
];
|
|
const builtResidue: string[] = [];
|
|
const buildSucceeded =
|
|
checks.find(({ name }) => name === "build")?.passed === true;
|
|
if (buildSucceeded) {
|
|
for (const file of await filesBelow(path.join(fixtureRoot, "dist"))) {
|
|
if (!/\.(?:js|css|html|json)$/.test(file)) continue;
|
|
const content = await readFile(file, "utf8");
|
|
if (extras.residue.test(content)) {
|
|
builtResidue.push(path.relative(fixtureRoot, file));
|
|
}
|
|
}
|
|
}
|
|
const routeCatalog = await import(
|
|
`${new URL(
|
|
"../src/features/installed-feature-contracts.ts",
|
|
`file://${fixtureRoot}/scripts/`,
|
|
).href}?removed=${Date.now()}`
|
|
) as { ROUTE_REGISTRY: Readonly<Record<string, unknown>> };
|
|
const routeIds = new Set(Object.keys(routeCatalog.ROUTE_REGISTRY));
|
|
checks.push(
|
|
outcome(
|
|
"route-absent",
|
|
featureRouteIds.filter((routeId) => routeIds.has(routeId)),
|
|
"routes still registered",
|
|
),
|
|
outcome("fixture-id-residue", residue, "residue"),
|
|
outcome("built-fixture-id-residue", builtResidue, "built residue"),
|
|
);
|
|
|
|
// U7 (decision 4). The same copy, now without the sample, gets one feature
|
|
// from create:feature and runs the same gates again: the command and the
|
|
// feature it writes need nothing from the sample.
|
|
if (isSample) {
|
|
// 1103/09-06. With the write slice (NEVER), which needs nothing from
|
|
// the sample either.
|
|
const created = check("scaffold-create-feature", "create:feature", [
|
|
"scaffold-feature",
|
|
"--with-create",
|
|
]);
|
|
checks.push(created);
|
|
if (created.passed) {
|
|
sealRemovalFixtureRepository(fixtureRoot);
|
|
checks.push(...gateChecks("scaffold-"));
|
|
}
|
|
}
|
|
|
|
const failed = checks.filter((entry) => !entry.passed);
|
|
await mkdir("artifacts/tests", { recursive: true });
|
|
await writeFile(
|
|
isSample
|
|
? "artifacts/tests/sample-removal.xml"
|
|
: `artifacts/tests/feature-removal-${featureId}.xml`,
|
|
renderRemovalJunit(`${featureId}-removal`, checks),
|
|
);
|
|
if (failed.length > 0) {
|
|
process.stderr.write(
|
|
`${featureId} removal failed:\n${failed
|
|
.map((entry) => ` ${entry.name}: ${entry.failure ?? "failed"}`)
|
|
.join("\n")}\n`,
|
|
);
|
|
process.exitCode = 1;
|
|
} else {
|
|
process.stdout.write(
|
|
`${featureId} removal: PASS (${checks.length} checks, no fixture IDs)\n`,
|
|
);
|
|
}
|
|
} finally {
|
|
await rm(fixtureRoot, { recursive: true, force: true });
|
|
}
|