Files
clean-architecture-frontend…/tests/unit/example-feature-rules.test.ts
T
DongHyeonka b4210753f0 perf(scripts): FE-GATE-020 드릴이 같은 시험 파일을 한 복사본에서 두 번 돌지 않는다
문제: FE-GATE-020이 desktop merge 단계 27.4분 중 17.2분이다. 그 안에서
같은 시험 파일이 한 복사본에서 두 번 돈다.
- feature-scaffold 드릴은 merge 단계 명령을 차례로 돌며 test:runtime-schema
  ·test:unit·test:contract·test:component·test:integration을 돌고, 바로
  FE-GATE-005의 test:coverage가 같은 경로를 다시 돈다(약 80초).
- feature-removal 확인은 test:all을 돈 뒤 test:coverage를 돈다. test:all의
  경로는 tests/recipes 말고 모두 coverage 안에 있다(약 110초).

고른 방법:
- scaffold 드릴 제외 목록에 다섯 suite를 넣는다. 그 복사본의 merge 단계에
  test:coverage가 있을 때만 뺀다. 없으면 plain으로 다시 돈다.
- feature-removal은 test:coverage 다음에 coverage 밖에 남는 suite
  (REMOVAL_DRILL_SUITES_OUTSIDE_COVERAGE = test:recipes)만 돈다.
- tests/unit/removal-drill-test-paths.test.ts가 경로를 package.json에서
  읽어 「뺀 suite의 경로 ⊆ coverage 경로」, 「test:all 경로 ⊆ coverage +
  남긴 suite」, coverage가 없으면 다시 도는 것을 지킨다.
- 버린 대안: FE-GATE-005 자체의 plain test:unit·test:contract를 빼고
  coverage 실행에서 junit을 나누기. 그 script가 어느 게이트에서도 안 돌게
  되어 ungated 목록을 늘려야 한다(게이트 기준을 낮추는 일).

위험·한계: plain 실행만의 차이(coverage 계측 없음, worker 수 기본값,
tests/platform을 test:platform처럼 파일 차례로 도는 것)는 드릴에서 더
보지 않는다. merge 단계의 FE-GATE-005가 coverage로 같은 파일을 병렬로
돌고 있어 그 모양이 이미 게이트다. 선택 기능 제거 드릴 셋의 test:all은
그대로다(그 드릴은 coverage를 돌지 않는다).

검증(desktop, 38c0dc7d 위): removal-drill-test-paths·feature-scaffold-drill
·example-feature-rules·test-all-paths·fixture-node-modules 20개 통과,
check:types·eslint rc=0. 변이 두 개(남긴 suite 목록 비우기, test:unit에
tests/recipes 더하기)에서 각각 해당 시험이 실패.
2026-11-11 23:46:41 +09:00

130 lines
6.2 KiB
TypeScript

import { readdir, readFile } from "node:fs/promises";
import path from "node:path";
import { describe, expect, it } from "vitest";
import { loadCiGateContract } from "../../scripts/contracts/ci-gates.ts";
import {
REMOVABLE_TEMPLATE_FEATURES,
type RemovableTemplateFeature,
} from "../../scripts/lib/removable-template-features.ts";
import { INSTALLED_FEATURE_CONTRACTS } from "../../src/features/installed-feature-contracts.ts";
/**
* R4 and R5 of docs/manual/03-outside-feature-folder.md. A sample feature
* that the template or a project ships is listed in
* scripts/lib/removable-template-features.ts, and the list is proven by a
* drill that builds and tests a copy without it (R4). The gates' own targets
* (visual goldens, e2e routes, the gate evidence list, scale measurements)
* are platform screens, test fixtures and generator output, never a sample a
* copy is meant to delete (R5): the template's reference sample was the
* target of nine gates when it was deleted on 2026-11-07.
*/
type ExampleFeature = Readonly<{ featureId: string; routeIds: readonly string[]; routePaths: readonly string[] }>;
type GateTargets = Readonly<{
gotoTargets: readonly Readonly<{ file: string; target: string }>[];
artifactPaths: readonly string[];
scaleFiles: readonly Readonly<{ file: string; text: string }>[];
}>;
function exampleFeatures(features: readonly RemovableTemplateFeature[]): ExampleFeature[] {
return features.map(({ featureId }) => {
// The template installs no feature, so the composed list's type is empty.
const contracts = INSTALLED_FEATURE_CONTRACTS as readonly Readonly<{ featureId: string; routes: object }>[];
const routes = contracts.filter((contract) => contract.featureId === featureId).flatMap(
(contract) => Object.values(contract.routes as Record<string, { routeId: string; path: string }>),
);
return {
featureId,
routeIds: routes.map(({ routeId }) => routeId),
routePaths: routes.map(({ path: routePath }) => routePath).filter((routePath) => routePath !== "/"),
};
});
}
function gateTargetsNamingExamples(examples: readonly ExampleFeature[], targets: GateTargets): string[] {
return examples.flatMap(({ featureId, routeIds, routePaths }) => [
...targets.gotoTargets
.filter(({ target }) => target.includes(featureId) || routePaths.some((routePath) => target === routePath || target.startsWith(`${routePath}/`) || target.startsWith(`${routePath}?`)))
.map(({ file, target }) => `${file}: goto ${target}`),
...targets.artifactPaths
.filter((artifact) => artifact.includes(featureId) || routeIds.some((routeId) => artifact.includes(`/${routeId}.`)))
.map((artifact) => `config/ci/gates.json: ${artifact}`),
...targets.scaleFiles.filter(({ text }) => text.includes(featureId)).map(({ file }) => `${file}: ${featureId}`),
]);
}
async function specFiles(directory: string): Promise<string[]> {
return ((await readdir(directory, { recursive: true })) as string[])
.filter((name) => /\.ts$/u.test(name))
.map((name) => path.join(directory, name));
}
async function repositoryGateTargets(): Promise<GateTargets> {
const gotoTargets: { file: string; target: string }[] = [];
for (const file of [...(await specFiles("tests/visual")), ...(await specFiles("tests/e2e"))]) {
const source = await readFile(file, "utf8");
for (const [, target = ""] of source.matchAll(/\.goto\(\s*["'`]([^"'`]+)["'`]/gu)) gotoTargets.push({ file, target });
}
const contract = await loadCiGateContract(process.cwd());
const scaleFiles = await Promise.all(
(await readdir("config/scale")).map(async (name) => ({
file: `config/scale/${name}`,
text: await readFile(`config/scale/${name}`, "utf8"),
})),
);
return { gotoTargets, artifactPaths: contract.artifacts.map(({ path: artifact }) => artifact), scaleFiles };
}
describe("sample features (R4)", () => {
it("are all proven by the removal drill in FE-GATE-020", async () => {
const contract = await loadCiGateContract(process.cwd());
const removability = contract.gates.find(({ id }) => id === "FE-GATE-020");
const scripts = new Set(
contract.commands
.filter(({ id }) => removability?.commandIds.includes(id))
.map(({ script }) => script),
);
expect(scripts).toContain("test:sample-removal");
// Without `--feature` the drill deletes every listed sample.
const packageScripts = (JSON.parse(await readFile("package.json", "utf8")) as { scripts: Record<string, string> })
.scripts;
expect(packageScripts["test:sample-removal"]).not.toMatch(/--feature/u);
// It builds and tests the copy; a documents-only check does not prove removal.
const drill = await readFile("scripts/test-sample-removal.ts", "utf8");
expect(drill).toMatch(/check\(`\$\{prefix\}build`, "build"\)/u);
// Every test:all path runs once: coverage, then what coverage leaves out
// (tests/unit/removal-drill-test-paths.test.ts).
expect(drill).toMatch(/check\(`\$\{prefix\}coverage`, "test:coverage"\)/u);
expect(drill).toMatch(/\.\.\.REMOVAL_DRILL_SUITES_OUTSIDE_COVERAGE/u);
});
});
describe("gate targets (R5)", () => {
it("name no sample feature", async () => {
expect(gateTargetsNamingExamples(exampleFeatures(REMOVABLE_TEMPLATE_FEATURES), await repositoryGateTargets())).toEqual(
[],
);
});
it("finds a sample's route in a visual spec, the evidence list and a scale record", () => {
const sample = { featureId: "order-feature", routeIds: ["ORDER_LIST"], routePaths: ["/orders"] };
expect(
gateTargetsNamingExamples([sample], {
gotoTargets: [
{ file: "tests/visual/a.visual.spec.ts", target: "/orders?page=2" },
{ file: "tests/visual/a.visual.spec.ts", target: "/examples/platform" },
],
artifactPaths: ["docs/accessibility/route-reviews/ORDER_LIST.md", "artifacts/quality/bundle.json"],
scaleFiles: [{ file: "config/scale/feature-shape-growth.json", text: '{"sourceFeature":"order-feature"}' }],
}),
).toEqual([
"tests/visual/a.visual.spec.ts: goto /orders?page=2",
"config/ci/gates.json: docs/accessibility/route-reviews/ORDER_LIST.md",
"config/scale/feature-shape-growth.json: order-feature",
]);
});
});