From ed8baf3a916b373a075973a5ef9623f4f97ea8ed Mon Sep 17 00:00:00 2001 From: DongHyeonka Date: Sun, 8 Nov 2026 15:30:34 +0900 Subject: [PATCH] =?UTF-8?q?fix(release):=20=EB=B9=84=EB=B0=80=EB=B2=88?= =?UTF-8?q?=ED=98=B8=20=EC=B9=B8=20=EA=B2=80=EC=82=AC=20=EC=8B=A4=ED=8C=A8?= =?UTF-8?q?=EA=B0=80=20=EC=A7=84=EB=8B=A8=20=EA=B2=B0=EA=B3=BC=EC=97=90=20?= =?UTF-8?q?=EB=93=A4=EC=96=B4=EA=B0=80=EA=B2=8C=20=ED=95=9C=EB=8B=A4?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit 앞 커밋이 더한 「SIGNING_PASSWORD에 키 블록」 검사는 PROBLEM 줄만 내고 스크립트 종료 코드에 들어가지 않았다. 다른 검사가 같이 실패해 지금은 결과가 같지만, 이 검사만 걸리는 경우에는 통과로 보였을 것이다. 그 python 블록이 실패하면 fail=1이 되게 했다. 검증: 키 블록을 비밀번호로 준 경우 rc=1. --- scripts/release/check-signing-key.sh | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/scripts/release/check-signing-key.sh b/scripts/release/check-signing-key.sh index 3b79946..20a8db2 100755 --- a/scripts/release/check-signing-key.sh +++ b/scripts/release/check-signing-key.sh @@ -25,8 +25,8 @@ fi [ -n "${SIGNING_PASSWORD:-}" ] || echo "check-signing-key: SIGNING_PASSWORD is empty (only right for a key without a passphrase)" # The passphrase's shape only: a pasted value often carries a line break or spaces the key was not # protected with, and Gradle uses the value as given. -python3 - <<'PY' -import os +python3 - <<'PY' || fail=1 +import os, sys p = os.environ.get("SIGNING_PASSWORD", "") print(f"password shape: {len(p)} characters, line breaks {p.count(chr(10))}, CR {p.count(chr(13))}," f" leading whitespace {'yes' if p[:1].isspace() else 'no'}, trailing whitespace {'yes' if p[-1:].isspace() else 'no'}," @@ -34,6 +34,7 @@ print(f"password shape: {len(p)} characters, line breaks {p.count(chr(10))}, CR if "-----BEGIN PGP" in p or len(p) > 1000: print("PROBLEM: SIGNING_PASSWORD holds a PGP key block (or something as long), not the passphrase." " Put in only the passphrase chosen when the key was made.") + sys.exit(1) PY home=$(mktemp -d)