옮겨 온 메시징 19개 모듈은 템플릿의 src/settings.gradle·build-logic· 카탈로그·registry에 기대고 있어 이 repo만으로는 빌드되지 않는다. repo 루트를 Gradle 루트로 하는 단독 빌드를 만든다. - build-logic/: grpc-library main 2e880c7의 줄인 사본(템플릿 22df3525에서 복사, 템플릿 2959eff0까지의 변경도 같은 내용)에서 gRPC BOM 규칙(ca.grpc-platform-module)만 뺐다. 배포 플러그인 ca.library-publishing과 서명 키 해석(SigningKeys)은 그대로다. 출처·뺀 것·고친 것은 build-logic/UPSTREAM.md. - settings.gradle·build.gradle·gradle.properties: group dev.cakit.messaging, 단계 태스크 ci·mainCheck·releaseCheck와 배포(release·releaseRehearsal·verifySigningKey)는 grpc-library와 같은 모양이다. 메시징만 다른 점: Buf가 없고, 성능 lane이 없고, mainCheck와 releaseCheck가 브로커 인증 증거 게이트 (verifyMessagingCertificationEvidence)를 부른다. 템플릿은 이 게이트를 따로 messaging-certification.yml로 돌렸다. 그 workflow는 지운다. - config/: registry 19행(source_path만 messaging/<leaf>로), 메시징 클래스만 남긴 SpotBugs 제외 목록, 이미지 셋(postgres-16, kafka, toxiproxy, 모두 digest 고정), checkstyle 사본. - gradle/libs.versions.toml: 메시징이 쓰는 항목만(avro, cloudevents, protobuf 4.33.2, toxiproxy, jmh)과 kafka-clients가 끌고 오는 취약 버전을 덮는 pinned-lz4-java·pinned-snappy-java. - 저장소 계약 테스트: MessagingPublicSurfaceContractTest(템플릿 app-bootstrap에서 이력째 옮김)와 새 MessagingSettingsOwnerContractTest (app.messaging 주인은 starter 하나)를 messaging-testkit의 repositoryContractTest lane에 둔다. check에 들어가 PR 단계에서 돈다. - messaging-kafka: 인증 manifest 경로를 새 배치로 고친다. 버린 대안: 계약 테스트를 build-logic 테스트로 두는 안. 빌드 플러그인 시험과 모듈 계약이 섞이고, 소스·build.gradle을 입력으로 선언하는 기존 lane 장치를 쓸 수 없다. 위험: 이 커밋 단독으로는 lockfile을 다시 쓰지 않았다(뒤 커밋에서 desktop에서 쓴다). 패키지는 아직 dev.caskeleton.messaging이다. 검증: desktop ./gradlew projects rc=0(19개 모듈 포함). Refs: design-docs repo-structure/05-library-repos.md 4·10.3·13.1절
94 lines
4.6 KiB
XML
94 lines
4.6 KiB
XML
<?xml version="1.0"?>
|
|
<!DOCTYPE module PUBLIC
|
|
"-//Checkstyle//DTD Checkstyle Configuration 1.3//EN"
|
|
"https://checkstyle.org/dtds/configuration_1_3.dtd">
|
|
|
|
<!--
|
|
feature-static-analysis-quality-contract D2 — custom minimal Checkstyle ruleset.
|
|
|
|
Scope is deliberately limited to what google-java-format (Spotless, D1) CANNOT enforce:
|
|
naming and logical/design rules. Formatting and import-order modules are
|
|
intentionally ABSENT — the formatter owns them. Enabling LineLength/Indentation/Whitespace/
|
|
CustomImportOrder here would fight the formatter (checkstyle #6527) and trap CI in an
|
|
infinite reformat loop.
|
|
|
|
Test-source relaxations live in checkstyle-suppressions.xml (resolved via ${config_loc}).
|
|
-->
|
|
<module name="Checker">
|
|
<property name="charset" value="UTF-8"/>
|
|
<property name="severity" value="error"/>
|
|
<property name="fileExtensions" value="java"/>
|
|
|
|
<!-- Test-source + generated-source relaxations (checkstyleTest is warning-only anyway). -->
|
|
<module name="SuppressionFilter">
|
|
<property name="file" value="${config_loc}/checkstyle-suppressions.xml"/>
|
|
<property name="optional" value="false"/>
|
|
</module>
|
|
|
|
<module name="TreeWalker">
|
|
|
|
<!-- ================= naming (KEEP, blocking) — CS-C2 / CS-C5 ================= -->
|
|
<module name="TypeName"/>
|
|
<module name="MethodName"/>
|
|
<!-- ConstantName: real constants are UPPER_SNAKE_CASE (code-conventions N9), but a
|
|
Logger has mutable observable state so it is NOT a constant — Google §5.2.4 names
|
|
it lowerCamelCase (log/logger). Permit those two idiomatic logger names. -->
|
|
<module name="ConstantName">
|
|
<property name="format" value="^(log|logger|[A-Z][A-Z0-9]*(_[A-Z0-9]+)*)$"/>
|
|
</module>
|
|
<module name="MemberName"/>
|
|
<module name="StaticVariableName"/>
|
|
<module name="ParameterName"/>
|
|
<module name="LambdaParameterName"/>
|
|
<module name="CatchParameterName"/>
|
|
<module name="LocalVariableName"/>
|
|
<module name="LocalFinalVariableName"/>
|
|
<module name="PackageName"/>
|
|
<!-- Type parameters are UPPER alphanumeric. Allows the conventional T/E/K/V/R and the
|
|
F-bounded self-type idiom SELF (see ResourceId<SELF extends ResourceId<SELF>>). -->
|
|
<module name="ClassTypeParameterName">
|
|
<property name="format" value="^[A-Z][A-Z0-9]*$"/>
|
|
</module>
|
|
<module name="InterfaceTypeParameterName">
|
|
<property name="format" value="^[A-Z][A-Z0-9]*$"/>
|
|
</module>
|
|
<module name="MethodTypeParameterName">
|
|
<property name="format" value="^[A-Z][A-Z0-9]*$"/>
|
|
</module>
|
|
<module name="RecordComponentName"/>
|
|
<module name="RecordTypeParameterName">
|
|
<property name="format" value="^[A-Z][A-Z0-9]*$"/>
|
|
</module>
|
|
<module name="PatternVariableName"/>
|
|
|
|
<!-- ================= file/type structure (code-conventions I6) =================
|
|
One top-level type per file, and the file is named after it.
|
|
|
|
These replace the hand-rolled `verifyOneTypePerFile` Gradle task, which matched
|
|
`^public ...` line by line. That regex could not see a package-private top-level type
|
|
(126 main sources declared none that it matched at all), read only `src/main/java`,
|
|
and anchored at column 0 so a block comment or text-block line starting with `public`
|
|
would have counted as a declaration. Checkstyle parses the file, so all three go away.
|
|
|
|
Neither rule is redundant with javac. javac rejects a *public* type whose name does not
|
|
match the file; both of these also hold for package-private top-level types, which
|
|
javac accepts.
|
|
|
|
Scope is main source only, which is exactly what the task it replaces checked. Test
|
|
sources declare 29 co-located fixture types that these rules would reject, and widening
|
|
the rule while claiming to replace a task is two changes wearing one name — the
|
|
exemption is in checkstyle-suppressions.xml with the count. -->
|
|
<module name="OneTopLevelClass"/>
|
|
<module name="OuterTypeFilename"/>
|
|
|
|
<!-- ================= logical / design (KEEP) — google_checks CS-C1 ================= -->
|
|
<module name="NeedBraces"/>
|
|
<module name="FallThrough"/>
|
|
<module name="EmptyCatchBlock">
|
|
<property name="exceptionVariableName" value="expected|ignored"/>
|
|
</module>
|
|
<module name="OneStatementPerLine"/>
|
|
<module name="MissingSwitchDefault"/>
|
|
</module>
|
|
</module>
|