fix: invalidate the TechLog CSRF token on 403 and harden the bootstrap profile wiring
Item 1 (real bug): contractOperations.execute only invalidated the cached CSRF token on UNAUTHENTICATED (401). A CSRF-specific rejection normally arrives as FORBIDDEN (403) -- the platform classifies any 403 response as FORBIDDEN unconditionally -- so a token rejected during an ordinary document save left the stale token cached and every subsequent Studio mutation kept failing until reload. Extracted invalidateTechLogCsrfOnOutcome() so production and the composition test call the identical function; it now invalidates on both UNAUTHENTICATED and FORBIDDEN. Item 2: the upload transport's uncontracted-status fallback hardcoded status 503, so an uncontracted 401/403 body never reached the gateway's error.status === 401 || 403 invalidation check. Passes the real response.status through. Item 3: safeOperation()'s auth-profile parameter is now typed as a union of the two valid profile constants instead of a bare string, and assertExactlyOneTechLogStudioBootstrapOperation() fails composition closed if getStudioSession stops being the sole caller of the credential-free bootstrap profile. Item 4: corrected two stale operation counts in the adapter review doc. Both new tests for items 1 and 2 were run and shown failing before their fix, per this task's TDD standard for error-path changes. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This commit is contained in:
co-authored by
Claude Opus 5
parent
2cab4974b7
commit
35cc5c868a
@@ -4,6 +4,8 @@ import { http, HttpResponse } from "msw";
|
||||
import { setupServer } from "msw/node";
|
||||
|
||||
import { createAssetUploadTransport } from "../../../src/features/tech-log/adapters/http/asset-upload-transport.ts";
|
||||
import { createHttpStudioAssetGateway } from "../../../src/features/tech-log/adapters/http/http-studio-asset-gateway.ts";
|
||||
import { createCsrfTokenProvider } from "../../../src/features/tech-log/adapters/http/studio-session-csrf.ts";
|
||||
import { isStudioGatewayError } from "../../../src/features/tech-log/application/ports/studio-gateway-error.ts";
|
||||
|
||||
const BASE = "http://api.test";
|
||||
@@ -205,3 +207,65 @@ test("maps an aborted upload onto a non-retryable STUDIO_UNAVAILABLE", async ()
|
||||
return true;
|
||||
});
|
||||
});
|
||||
|
||||
// Fix round 2, item 2. The uncontracted-status fallback previously hardcoded
|
||||
// status 503, discarding the real HTTP status the server sent.
|
||||
// http-studio-asset-gateway.ts's uploadAsset() only invalidates the cached
|
||||
// CSRF token when `error.status === 401 || error.status === 403` — an
|
||||
// uncontracted 401/403 body silently became "not 401/403" (503) and never
|
||||
// triggered invalidation.
|
||||
|
||||
test("passes the real HTTP status through for an uncontracted status instead of hardcoding 503", async () => {
|
||||
server.use(
|
||||
http.post(`${BASE}/api/v1/studio/assets`, () =>
|
||||
HttpResponse.json({ message: "token rejected" }, { status: 401 }),
|
||||
),
|
||||
);
|
||||
|
||||
await assert.rejects(transport().upload({ file: svg(), kind: "IMAGE" }, {}), (error: unknown) => {
|
||||
assert.ok(isStudioGatewayError(error));
|
||||
assert.equal(error.code, "STUDIO_UNAVAILABLE");
|
||||
assert.equal(error.status, 401);
|
||||
return true;
|
||||
});
|
||||
});
|
||||
|
||||
test("an uncontracted 401 body still invalidates the cached CSRF token end to end", async () => {
|
||||
server.use(
|
||||
http.post(`${BASE}/api/v1/studio/assets`, () =>
|
||||
HttpResponse.json({ message: "token rejected" }, { status: 401 }),
|
||||
),
|
||||
);
|
||||
|
||||
let executions = 0;
|
||||
const csrf = createCsrfTokenProvider({
|
||||
async execute() {
|
||||
executions += 1;
|
||||
return { csrfToken: `csrf-${executions}`, csrfHeaderName: "X-CSRF-TOKEN" };
|
||||
},
|
||||
});
|
||||
const gateway = createHttpStudioAssetGateway({
|
||||
operations: {
|
||||
async execute() {
|
||||
throw new Error("not used by this test");
|
||||
},
|
||||
},
|
||||
csrf,
|
||||
upload: transport(),
|
||||
});
|
||||
|
||||
await assert.rejects(
|
||||
gateway.uploadAsset(
|
||||
{ file: svg(), kind: "IMAGE" },
|
||||
{ idempotencyKey: "up-1" },
|
||||
),
|
||||
);
|
||||
// The upload itself already consumed one fetch.
|
||||
assert.equal(executions, 1);
|
||||
|
||||
// A fresh token() call after the failure must re-fetch, not replay the
|
||||
// (now-rejected) cached value — proving the gateway actually saw status
|
||||
// 401, not the transport's old default of 503.
|
||||
await csrf.token();
|
||||
assert.equal(executions, 2);
|
||||
});
|
||||
|
||||
Reference in New Issue
Block a user