fix: reject unsafe TechLog network paths

This commit is contained in:
DongHyeonka
2026-08-15 19:00:10 +09:00
parent 16753f53af
commit 8342fb14dc
2 changed files with 47 additions and 1 deletions
@@ -185,9 +185,30 @@ function assertNever(value: never): never {
throw new Error(`Unsupported content node: ${JSON.stringify(value)}`);
}
const trustedRelativeLinkOrigin = "https://techlog.invalid";
function hasAsciiControlCharacter(value: string): boolean {
return Array.from(value).some((character) => {
const codePoint = character.codePointAt(0) ?? 0;
return codePoint <= 0x1f || codePoint === 0x7f;
});
}
function isSafeLink(href: string): boolean {
if (href.includes("\\") || hasAsciiControlCharacter(href)) {
return false;
}
if (href.startsWith("#")) return true;
if (href.startsWith("/")) return !href.startsWith("//");
if (href.startsWith("/")) {
try {
return (
new URL(href, `${trustedRelativeLinkOrigin}/`).origin ===
trustedRelativeLinkOrigin
);
} catch {
return false;
}
}
try {
const url = new URL(href);
@@ -39,6 +39,11 @@ describe("Content Format v1", () => {
"<script>alert(1)</script>",
"[x](javascript:alert(1))",
"[x](//evil.example/path)",
"[x](/\\evil.example/path)",
"[x](/\\\\evil.example/path)",
"[x](</safe\u0001path>)",
"[x](</safe\u001fpath>)",
"[x](</safe\u007fpath>)",
"- outer\n - nested",
"# level one",
"- [ ] task",
@@ -68,6 +73,26 @@ describe("Content Format v1", () => {
}
});
it("keeps explicitly allowed links and same-origin paths", () => {
const [paragraph] = parseCaseContent(
"[fragment](#section) [path](/safe/path?q=one) [http](http://example.com/path) [https](https://example.com/path) [mail](mailto:test@example.com)",
);
expect(paragraph?.type).toBe("PARAGRAPH");
if (paragraph?.type !== "PARAGRAPH") return;
expect(
paragraph.content
.filter((inline) => inline.type === "LINK")
.map((inline) => inline.href),
).toEqual([
"#section",
"/safe/path?q=one",
"http://example.com/path",
"https://example.com/path",
"mailto:test@example.com",
]);
});
it("generates stable Korean heading IDs and suffixes duplicates", () => {
const blocks = parseCaseContent("## 한글 API!\n\n## 한글 API?\n\n## !!!");