From 8422c41e767ab51cadda0fb48c69315d62f80fb6 Mon Sep 17 00:00:00 2001 From: DongHyeonka Date: Thu, 12 Nov 2026 22:38:22 +0900 Subject: [PATCH] =?UTF-8?q?fix(build):=20=EB=B2=88=EB=93=A4=20=EA=B8=B0?= =?UTF-8?q?=EB=8A=A5=20=EC=86=8C=EC=9C=A0=20=EA=B2=80=EC=82=AC=EA=B0=80=20?= =?UTF-8?q?=EC=A7=81=EC=A0=91=20=EC=A1=B0=EB=A6=BD=ED=95=98=EB=8A=94=20Tec?= =?UTF-8?q?hLog=EB=A5=BC=20=EB=B0=9B=EC=95=84=EB=93=A4=EC=9D=B8=EB=8B=A4?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit 문제 FE-GATE-012의 check:app-build-input:bundle은 production 번들에 든 `src/features//` 모듈이 모두 앱의 context가 소유한(생성기로 설치한) 기능이어야 한다고 본다. TechLog는 조립부가 직접 붙이는 기능이라 (`src/features/tech-log/NOT_INSTALLED`) 어떤 context도 소유하지 않는다. 그래서 이 검사는 TechLog의 모든 production 번들을 거절한다. 9-29 템플릿 동기화(af3d8e6)로 들어온 뒤, 같은 게이트의 번들 예산 검사가 먼저 실패해 한 번도 이 단계까지 가지 않았다. 예산을 맞추자 드러났다. 고른 방법 - DIRECTLY_COMPOSED_FEATURE_DIRECTORIES(["tech-log"])를 두고, 번들 쪽 검사에서만 이름으로 허용한다. - 생성 인덱스 쪽 검사는 그대로다. 생성기가 TechLog를 import하면 여전히 실패한다. 버린 대안 - NOT_INSTALLED 표시가 있는 디렉터리를 모두 허용: reference-feature와 local-draft-feature도 NOT_INSTALLED다. 그 샘플이 번들에 새면 이 검사가 잡아야 한다. 위험·한계 - 템플릿 소유 스크립트를 고친다. TechLog를 feature-module.ts로 옮기는 후속 작업(docs/operations/template-sync-2026-09-29.md)을 하면 이 목록을 지운다. 검증 - tests/architecture/app-build-input.test.ts: TechLog 모듈은 받아들이고, 같은 번들의 reference-feature는 거절한다. - desktop CI env에서 이 커밋 전 head로 돌린 FE-GATE-012: 번들 예산은 PASS (229,223 / 230,400 B), check:app-build-input:bundle이 "production bundle contains feature \"tech-log\" not owned by app template-app"으로 실패. --- scripts/check-app-build-input.ts | 18 +++++++++++++++++- tests/architecture/app-build-input.test.ts | 18 ++++++++++++++++++ 2 files changed, 35 insertions(+), 1 deletion(-) diff --git a/scripts/check-app-build-input.ts b/scripts/check-app-build-input.ts index c8c6002..8177407 100644 --- a/scripts/check-app-build-input.ts +++ b/scripts/check-app-build-input.ts @@ -27,6 +27,21 @@ export type AppBuildInputReport = Readonly<{ violations: readonly string[]; }>; +/** + * Template sync (af3d8e6). TechLog is this product's own domain, composed + * directly by the composition root rather than by the index generator + * (`src/features/tech-log/NOT_INSTALLED`). No context owns it, so the + * template's ownership rule refused every production bundle of this product; + * FE-GATE-012 stopped at the bundle budget before reaching it, which hid that. + * + * It is allowed in the bundle by name only. The generated indexes still may not + * import it, and every other directory marked NOT_INSTALLED (the reference and + * local-draft samples) is still refused if it reaches the bundle. + */ +export const DIRECTLY_COMPOSED_FEATURE_DIRECTORIES: readonly string[] = Object.freeze([ + "tech-log", +]); + const GENERATED = [ "src/.generated/product-feature-index.ts", "src/.generated/product-context-index.ts", @@ -99,8 +114,9 @@ export async function inspectAppBuildInput( }), ); bundle = { checked: true, featureDirectories }; + const composedDirectly = new Set(DIRECTLY_COMPOSED_FEATURE_DIRECTORIES); for (const directory of featureDirectories) { - if (!owned.has(directory)) { + if (!owned.has(directory) && !composedDirectly.has(directory)) { violations.push(`production bundle contains feature "${directory}" not owned by app ${appId}`); } } diff --git a/tests/architecture/app-build-input.test.ts b/tests/architecture/app-build-input.test.ts index 6c28bbe..151a5ab 100644 --- a/tests/architecture/app-build-input.test.ts +++ b/tests/architecture/app-build-input.test.ts @@ -84,6 +84,24 @@ describe("app build input isolation gate", () => { ]); }); + it("accepts this product's directly composed TechLog and still refuses an uninstalled sample", async () => { + // TechLog is composed by the composition root (src/features/tech-log/NOT_INSTALLED), + // so it is in every production bundle while no context owns it. The + // reference sample is NOT_INSTALLED too, and must not ride along. + const root = path.resolve("."); + const scratch = await mkdtemp(path.join(tmpdir(), "app-build-input-product-")); + roots.push(scratch); + const bundle = await inventory(scratch, [ + "src/features/tech-log/presentation/public/public-shell.tsx", + "src/features/reference-feature/feature-module.ts", + ]); + const report = await inspectAppBuildInput(root, { bundleInventory: bundle }); + expect(report.bundle.featureDirectories).toEqual(["reference-feature", "tech-log"]); + expect(report.violations).toEqual([ + `production bundle contains feature "reference-feature" not owned by app ${report.appId}`, + ]); + }); + it("holds for this repository's generated indexes", async () => { // The bundle side is gated after a fresh build (check:app-build-input:bundle). const report = await inspectAppBuildInput(path.resolve("."), { bundleInventory: null });