diff --git a/tests/e2e/boot-module-failure.spec.ts b/tests/e2e/boot-module-failure.spec.ts index cbbbbfe..74ebf8c 100644 --- a/tests/e2e/boot-module-failure.spec.ts +++ b/tests/e2e/boot-module-failure.spec.ts @@ -50,6 +50,9 @@ test("shows the boot error shell when a module throws while it evaluates", async await page.goto(`${server.origin}/`); const shell = page.getByRole("alert"); + // The boot error shell replaces the loading shell once the boot has + // failed; see scroll-restoration.spec.ts for why this is not a 5 s window. + await shell.waitFor(); await expect(shell).toContainText("애플리케이션을 시작할 수 없습니다."); await expect(shell).toContainText("BOOT_UNEXPECTED_FAILURE"); await expect(shell).toContainText("TypeError"); diff --git a/tests/e2e/old-tab-chunk-recovery.spec.ts b/tests/e2e/old-tab-chunk-recovery.spec.ts index bbf78e3..b7f51b8 100644 --- a/tests/e2e/old-tab-chunk-recovery.spec.ts +++ b/tests/e2e/old-tab-chunk-recovery.spec.ts @@ -93,6 +93,8 @@ test("an old tab reloads once into the new build, then stops reloading", async ( const server = await startBuildServer(builds.dist); try { await page.goto(`${server.origin}/`); + // The app draws after the document loads; see scroll-restoration.spec.ts. + await page.locator(".site-frame").waitFor(); await expect( page.getByRole("link", { name: PLATFORM.navigationLabel!, exact: true }), ).toBeVisible(); diff --git a/tests/e2e/production-csp.spec.ts b/tests/e2e/production-csp.spec.ts index 811ce0e..1ed1822 100644 --- a/tests/e2e/production-csp.spec.ts +++ b/tests/e2e/production-csp.spec.ts @@ -51,6 +51,8 @@ async function cspViolations(page: Page): Promise { test("boots and changes route under the production security headers", async ({ page }) => { const response = await page.goto("/"); + // The app draws after the document loads; see scroll-restoration.spec.ts. + await page.locator(".site-frame").waitFor(); expect(response?.headers()["content-security-policy"]).toBe( securityHeaders["Content-Security-Policy"], ); diff --git a/tests/e2e/scroll-restoration.spec.ts b/tests/e2e/scroll-restoration.spec.ts index f6b068e..7e4c979 100644 --- a/tests/e2e/scroll-restoration.spec.ts +++ b/tests/e2e/scroll-restoration.spec.ts @@ -1,9 +1,14 @@ import { expect, test, type Page } from "../support/browser/strict-browser-test.ts"; +import { gotoTechLog } from "../support/browser/tech-log-fixtures.ts"; const scrollY = (page: Page) => page.evaluate(() => Math.round(window.scrollY)); // Template sync (af3d8e6). Upstream scrolls its long example page; this product // deleted it, and a TechLog Case (about 6,000px at 1280x720) is the long page. +// Pages open through gotoTechLog, like the rest of this product's browser +// tests: it waits for the app to draw. After a bare page.goto the first +// expectation had 5 s for that, which WebKit on the desktop host sometimes +// needs more than while the other workers run. const LONG_PAGE = "/cases/collection-fetch-join-pagination"; const LONG_PAGE_TITLE = "컬렉션 Fetch Join과 페이징은 왜 충돌하는가"; @@ -12,7 +17,7 @@ const LONG_PAGE_TITLE = "컬렉션 Fetch Join과 페이징은 왜 충돌하는 // scrolls. test("restores the scroll position when navigating back", async ({ page }) => { const heading = page.getByRole("heading", { level: 1 }); - await page.goto(LONG_PAGE); + await gotoTechLog(page, LONG_PAGE); await expect(heading).toHaveText(LONG_PAGE_TITLE); await expect(page.locator("main [aria-busy='true']")).toHaveCount(0); await expect(page.locator("#remaining-cost")).toBeAttached(); @@ -38,7 +43,7 @@ test("restores the scroll position when navigating back", async ({ page }) => { test("opens a hash link at its target below the sticky header", async ({ page, }) => { - await page.goto(`${LONG_PAGE}#separate-loading`); + await gotoTechLog(page, `${LONG_PAGE}#separate-loading`); const target = page.locator("#separate-loading"); await expect(target).toBeInViewport(); const top = await target.evaluate((element) =>