refactor: derive TechLog navigation from the route contract
Both headers carried their own literal list of {label, path}. That made the
route contract and the header two sources for the same three facts — which
routes are navigable, what they are called, and in what order — with nothing
keeping them in step: a renamed route or a reordered menu could be right in one
place and stale in the other.
techLogNavigation(layoutGroup) derives the menu from TECH_LOG_ROUTE_REGISTRY,
where navigationOrder is what makes a route navigable. Output is byte-identical
to the previous literal lists, pinned by a new test.
Derived from TechLog's own route contract rather than from the composed
registries: .dependency-cruiser.json freezes an exact allowlist of files that
may read src/features/installed-*, explicitly so that coupling cannot spread,
and a feature header is not on it.
The studio header keeps its active-state rules — "작업본" stays highlighted
across /studio/documents/* except on the new-document screen — because that is
presentation behaviour the contract has no opinion about.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This commit is contained in:
co-authored by
Claude Opus 5
parent
93ce86eef4
commit
9e5fbd1384
@@ -0,0 +1,45 @@
|
||||
import type { RouteLayoutGroup } from "../../../contracts/routes.ts";
|
||||
import { TECH_LOG_ROUTE_REGISTRY } from "../contracts/tech-log-route-contract.ts";
|
||||
|
||||
/**
|
||||
* The navigation entries for one shell, derived from the route contract.
|
||||
*
|
||||
* Both headers used to carry their own literal list of `{ label, path }`. That
|
||||
* made the route contract and the header two sources for the same three facts —
|
||||
* which routes are navigable, what they are called, and in what order — and
|
||||
* nothing kept them in step: a renamed route or a changed order stayed correct
|
||||
* in one place and silently stale in the other.
|
||||
*
|
||||
* `navigationOrder` is what makes a route navigable; a route with `null` is
|
||||
* reachable but never advertised.
|
||||
*/
|
||||
export type TechLogNavigationEntry = Readonly<{
|
||||
routeId: string;
|
||||
path: string;
|
||||
label: string;
|
||||
}>;
|
||||
|
||||
export function techLogNavigation(
|
||||
layoutGroup: RouteLayoutGroup,
|
||||
): readonly TechLogNavigationEntry[] {
|
||||
return Object.freeze(
|
||||
Object.values(TECH_LOG_ROUTE_REGISTRY)
|
||||
.filter(
|
||||
(definition) =>
|
||||
definition.layoutGroup === layoutGroup &&
|
||||
definition.navigationOrder !== null &&
|
||||
definition.navigationLabel !== null,
|
||||
)
|
||||
.sort(
|
||||
(left, right) =>
|
||||
(left.navigationOrder ?? 0) - (right.navigationOrder ?? 0),
|
||||
)
|
||||
.map((definition) =>
|
||||
Object.freeze({
|
||||
routeId: definition.routeId,
|
||||
path: definition.path,
|
||||
label: definition.navigationLabel as string,
|
||||
}),
|
||||
),
|
||||
);
|
||||
}
|
||||
Reference in New Issue
Block a user