Files
tech-log-frontend/tests/architecture/app-build-input.test.ts
T
DongHyeonka 8422c41e76 fix(build): 번들 기능 소유 검사가 직접 조립하는 TechLog를 받아들인다
문제
FE-GATE-012의 check:app-build-input:bundle은 production 번들에 든
`src/features/<dir>/` 모듈이 모두 앱의 context가 소유한(생성기로 설치한)
기능이어야 한다고 본다. TechLog는 조립부가 직접 붙이는 기능이라
(`src/features/tech-log/NOT_INSTALLED`) 어떤 context도 소유하지 않는다.
그래서 이 검사는 TechLog의 모든 production 번들을 거절한다. 9-29 템플릿
동기화(af3d8e6)로 들어온 뒤, 같은 게이트의 번들 예산 검사가 먼저 실패해
한 번도 이 단계까지 가지 않았다. 예산을 맞추자 드러났다.

고른 방법
- DIRECTLY_COMPOSED_FEATURE_DIRECTORIES(["tech-log"])를 두고, 번들 쪽
  검사에서만 이름으로 허용한다.
- 생성 인덱스 쪽 검사는 그대로다. 생성기가 TechLog를 import하면 여전히
  실패한다.

버린 대안
- NOT_INSTALLED 표시가 있는 디렉터리를 모두 허용: reference-feature와
  local-draft-feature도 NOT_INSTALLED다. 그 샘플이 번들에 새면 이 검사가
  잡아야 한다.

위험·한계
- 템플릿 소유 스크립트를 고친다. TechLog를 feature-module.ts로 옮기는
  후속 작업(docs/operations/template-sync-2026-09-29.md)을 하면 이 목록을
  지운다.

검증
- tests/architecture/app-build-input.test.ts: TechLog 모듈은 받아들이고,
  같은 번들의 reference-feature는 거절한다.
- desktop CI env에서 이 커밋 전 head로 돌린 FE-GATE-012: 번들 예산은 PASS
  (229,223 / 230,400 B), check:app-build-input:bundle이 "production bundle
  contains feature \"tech-log\" not owned by app template-app"으로 실패.
2026-11-12 22:38:22 +09:00

112 lines
5.1 KiB
TypeScript

import { spawnSync } from "node:child_process";
import { mkdtemp, readdir, rm, writeFile } from "node:fs/promises";
import { tmpdir } from "node:os";
import path from "node:path";
import { afterAll, describe, expect, it } from "vitest";
import { inspectAppBuildInput } from "../../scripts/check-app-build-input.ts";
import { renderContextIndex, renderFeatureIndex } from "../../scripts/generate-product-feature-index.ts";
import { APP_A, writeFilesystemTopology } from "../scale/filesystem-topology.ts";
/**
* Deployable-app isolation regression gate: the build input of one app must
* never contain another app's features, whether through the generated index
* or through the production bundle.
*/
const GENERATOR = path.resolve("scripts/generate-product-feature-index.ts");
const roots: string[] = [];
afterAll(async () => {
await Promise.all(roots.map((root) => rm(root, { recursive: true, force: true })));
});
async function multiAppRepo() {
const root = await mkdtemp(path.join(tmpdir(), "app-build-input-"));
roots.push(root);
await writeFilesystemTopology(root, { globalFeatures: 1_100 });
const run = spawnSync(process.execPath, [GENERATOR, `--root=${root}`, `--app=${APP_A.id}`], {
encoding: "utf8",
});
if (run.status !== 0) throw new Error(run.stderr);
return root;
}
async function inventory(root: string, modules: readonly string[]) {
const file = path.join(root, "inventory.json");
await writeFile(file, JSON.stringify({ schemaVersion: 1, chunks: [{ fileName: "a.js", modules }] }));
return file;
}
describe("app build input isolation gate", () => {
it("accepts the production generator's output and an app-local bundle", async () => {
const root = await multiAppRepo();
const bundle = await inventory(root, [
"src/features/app-a-ctx0-f0/feature-module.ts",
"src/features/app-a-ctx1-f49/presentation/page.ts",
"src/platform/traffic/request-budget.ts",
]);
const report = await inspectAppBuildInput(root, { bundleInventory: bundle });
expect(report.violations).toEqual([]);
expect(report.appId).toBe(APP_A.id);
expect(report.generatedFeatureImports).toHaveLength(APP_A.contexts * APP_A.featuresPerContext);
expect(report.bundle.checked).toBe(true);
});
it("rejects a generator regression that imports every discovered feature", async () => {
const root = await multiAppRepo();
const everyFeature = (await readdir(path.join(root, "src/features"))).map((directory) => ({
id: directory,
importPath: `../features/${directory}/feature-module.ts`,
directory,
contextId: directory.replace(/-f\d+$/u, ""),
contextRoutePath: "x/*",
contextMaxFeatures: 200,
}));
await writeFile(path.join(root, "src/.generated/product-feature-index.ts"), renderFeatureIndex(everyFeature));
await writeFile(path.join(root, "src/.generated/product-context-index.ts"), renderContextIndex(everyFeature));
const report = await inspectAppBuildInput(root, { bundleInventory: null });
expect(report.violations.length).toBeGreaterThan(0);
expect(report.violations.join("\n")).toMatch(/imports feature "other-0-ctx0-f0" not owned by app app-a/);
expect(report.violations.join("\n")).toMatch(/declares context "other-0-ctx0" not owned/);
});
it("rejects a production bundle that contains another app's feature", async () => {
const root = await multiAppRepo();
const bundle = await inventory(root, [
"src/features/app-a-ctx0-f0/feature-module.ts",
"src/features/other-0-ctx3-f7/feature-module.ts",
]);
const report = await inspectAppBuildInput(root, { bundleInventory: bundle });
expect(report.violations).toEqual([
'production bundle contains feature "other-0-ctx3-f7" not owned by app app-a',
]);
});
it("accepts this product's directly composed TechLog and still refuses an uninstalled sample", async () => {
// TechLog is composed by the composition root (src/features/tech-log/NOT_INSTALLED),
// so it is in every production bundle while no context owns it. The
// reference sample is NOT_INSTALLED too, and must not ride along.
const root = path.resolve(".");
const scratch = await mkdtemp(path.join(tmpdir(), "app-build-input-product-"));
roots.push(scratch);
const bundle = await inventory(scratch, [
"src/features/tech-log/presentation/public/public-shell.tsx",
"src/features/reference-feature/feature-module.ts",
]);
const report = await inspectAppBuildInput(root, { bundleInventory: bundle });
expect(report.bundle.featureDirectories).toEqual(["reference-feature", "tech-log"]);
expect(report.violations).toEqual([
`production bundle contains feature "reference-feature" not owned by app ${report.appId}`,
]);
});
it("holds for this repository's generated indexes", async () => {
// The bundle side is gated after a fresh build (check:app-build-input:bundle).
const report = await inspectAppBuildInput(path.resolve("."), { bundleInventory: null });
expect(report.violations).toEqual([]);
expect(report.generatedFeatureImports).toEqual(report.ownedFeatureDirectories);
});
});