ci: 다른 단계가 이미 돌리는 workflow job을 지운다
workflow 15개 가운데 모듈 모양 파일들이 PR·main·nightly 단계가 이미 계획하는 Gradle 태스크를 한 번 더 돌린다(설계 design-docs repo-structure/03-ci.md 3.1절 「중복」). - fileserver-pr.yml 다섯 job: 모두 leaf `test`나 그 부분집합이다. `ci`가 매 PR 돌린다. - fileserver-nightly.yml의 --rerun-tasks job 셋: 같은 `test`의 부분집합이다. NFS job만 남긴다. - jpa-nightly.yml의 failure·query plan·security·pool job: 모두 integration()·performance() lane이라 :integrationCheck· :performanceCheck가 돈다. PostgreSQL major 행렬만 남긴다. - notification-platform.yml의 pr job: `ci`와 :integrationCheck의 태스크다. 경로 필터가 docs/adr/로 옮긴 알림 ADR을 보지 못했다. chaos job만 남긴다. - object-storage-qualification.yml의 MinIO job 둘: integration lane이다. 보호된 AWS job만 남긴다. - link-check.yml: 문서 검사라 main 단계로(소유자 결정 2026-09-16). integration-main.yml의 links job으로 옮긴다. fileserver 지원 매트릭스는 지운 job id 대신 그 증거를 실제로 만드는 테스트 클래스·모듈 test·남은 job을 적고, FileserverDocumentation CoverageTest가 행마다 그 이름이 있는지 본다. job이 사라진 시험 문장 (PoolLaneClaimTest의 nightly job 검사, lychee 경로 필터 검사)은 지우거나 새 위치로 맞춘다. 위험: PR에서 경로로 켜지던 컨테이너 lane(notification의 실 PostgreSQL 두 lane, MinIO)은 이제 main push와 nightly에서만 돈다. 어댑터 컨테이너 lane을 main 단계로 옮긴 소유자 결정(2026-11-07 ②)과 같은 쪽이다. 검증: 기준 2959eff0의 desktop worktree에서 workflow의 Gradle 명령 50개를 --dry-run해 태스크 집합을 만들었다. 지운·옮긴 job 27개의 태스크는 모두 :ci·:mainCheck·:integrationCheck·:performanceCheck·:releaseCheck 계획 안에 있다(단계 집계 밖 0). 로그 desktop ~/t2a-backend-ci-logs/wave1-base/. python3 scripts/check-docs.py, check-work-docs.py 통과. Refs: design-docs repo-structure/03-ci.md 7.3절 Wave 1
This commit is contained in:
@@ -1,8 +1,8 @@
|
||||
name: fileserver-nightly
|
||||
|
||||
# The environments that cannot run on every pull request: a real network filesystem, a foreign
|
||||
# filesystem, and the long-running fault matrices. They are nightly rather than skipped because a
|
||||
# green pull-request run is not certification of any of them.
|
||||
# The one environment a pull request cannot provide: a real NFSv4 server. The crash, large-file and
|
||||
# lease suites that used to run here with --rerun-tasks are tests of the leaves' `test`, which the
|
||||
# pull-request `ci` already runs; their second run added no coverage.
|
||||
|
||||
on:
|
||||
workflow_dispatch:
|
||||
@@ -36,49 +36,3 @@ jobs:
|
||||
- name: Tear down the NFS environment
|
||||
if: always()
|
||||
run: docker compose -f src/adapter/outbound/fileserver/compose/nfs/compose.yml down -v
|
||||
|
||||
fileserver-process-kill-matrix:
|
||||
runs-on: ubuntu-latest
|
||||
timeout-minutes: 45
|
||||
steps:
|
||||
- uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # actions/checkout@v4.2.2
|
||||
- uses: ./.github/actions/setup-gradle-java
|
||||
- name: Run the crash matrix and reconciliation suites
|
||||
working-directory: src
|
||||
run: >-
|
||||
./gradlew
|
||||
:adapter:outbound:fileserver:test --tests '*CrashRecoveryMatrixTest'
|
||||
:application-fileserver:test --tests '*FileReconciliationServiceTest'
|
||||
--rerun-tasks
|
||||
--stacktrace
|
||||
|
||||
fileserver-large-file-performance:
|
||||
runs-on: ubuntu-latest
|
||||
timeout-minutes: 60
|
||||
steps:
|
||||
- uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # actions/checkout@v4.2.2
|
||||
- uses: ./.github/actions/setup-gradle-java
|
||||
- name: Run the large-file and slow-client suites under a constrained heap
|
||||
working-directory: src
|
||||
env:
|
||||
GRADLE_OPTS: -Xmx512m
|
||||
run: >-
|
||||
./gradlew
|
||||
:adapter:outbound:fileserver:test --tests '*LargeFileBoundedMemoryTest'
|
||||
:adapter:outbound:fileserver:test --tests '*LocalAppendMemoryTest'
|
||||
--rerun-tasks
|
||||
--stacktrace
|
||||
|
||||
fileserver-multi-instance-lease:
|
||||
runs-on: ubuntu-latest
|
||||
timeout-minutes: 30
|
||||
steps:
|
||||
- uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # actions/checkout@v4.2.2
|
||||
- uses: ./.github/actions/setup-gradle-java
|
||||
- name: Prove no run commits bytes from a stale lease
|
||||
working-directory: src
|
||||
run: >-
|
||||
./gradlew
|
||||
:application-fileserver:test --tests '*MultiInstanceWriterLeaseTest'
|
||||
--rerun-tasks
|
||||
--stacktrace
|
||||
|
||||
@@ -1,110 +0,0 @@
|
||||
name: fileserver-pr
|
||||
|
||||
# Every claim in docs/fileserver/support-matrix.md that says "Stable" is backed by a job here.
|
||||
# A support level with no job behind it is a marketing claim, not an engineering one, and
|
||||
# DocumentationCoverageTest fails the build when the two drift apart.
|
||||
|
||||
on:
|
||||
workflow_dispatch:
|
||||
pull_request:
|
||||
paths:
|
||||
- 'src/application-fileserver/**'
|
||||
- 'src/adapter/inbound/web-fileserver/**'
|
||||
- 'src/adapter/outbound/fileserver/**'
|
||||
- 'src/adapter/outbound/persistence-fileserver/**'
|
||||
- 'src/composition/fileserver-platform/**'
|
||||
- 'src/adapter/outbound/persistence-jpa/src/**/fileserver/**'
|
||||
- 'src/app-bootstrap/src/**/fileserver/**'
|
||||
- 'docs/fileserver/**'
|
||||
# The capability is not only its Java files. A change to the bound settings, the shipped
|
||||
# environment, the registry that documents it, or the container that has to give it a
|
||||
# writable volume changes how it behaves at runtime just as surely — and those were the
|
||||
# exact files that could previously ship unverified.
|
||||
- 'src/app-bootstrap/src/main/resources/application.yml'
|
||||
- 'src/.env'
|
||||
- 'docs/registries/env-keys.yaml'
|
||||
- 'src/Dockerfile'
|
||||
- 'compose.yaml'
|
||||
- 'src/app-bootstrap/compose-lanes/fileserver.yaml'
|
||||
- '.github/workflows/fileserver-pr.yml'
|
||||
# Every Gradle job here installs its toolchain through this composite action, so a change to
|
||||
# it changes what this gate runs.
|
||||
- '.github/actions/setup-gradle-java/action.yml'
|
||||
|
||||
permissions:
|
||||
contents: read
|
||||
|
||||
concurrency:
|
||||
group: ${{ github.workflow }}-${{ github.ref }}
|
||||
cancel-in-progress: true
|
||||
|
||||
jobs:
|
||||
fileserver-unit-and-architecture:
|
||||
runs-on: ubuntu-latest
|
||||
timeout-minutes: 30
|
||||
steps:
|
||||
- uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # actions/checkout@v4.2.2
|
||||
- uses: ./.github/actions/setup-gradle-java
|
||||
# The architecture half of this claim is ci-quality-gates.yml's `architectureCheck`, which runs
|
||||
# the whole ArchUnit suite on the same pull request; a filtered second run here was the repeat
|
||||
# review BUILD-중복-6 removed.
|
||||
- name: Run the fileserver application and assembly suites
|
||||
working-directory: src
|
||||
run: >-
|
||||
./gradlew
|
||||
:application-fileserver:test
|
||||
:composition:fileserver-platform:test
|
||||
--stacktrace
|
||||
|
||||
fileserver-local-ext4-contract:
|
||||
runs-on: ubuntu-latest
|
||||
timeout-minutes: 30
|
||||
steps:
|
||||
- uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # actions/checkout@v4.2.2
|
||||
- uses: ./.github/actions/setup-gradle-java
|
||||
- name: Certify the local content store against the shared contract
|
||||
working-directory: src
|
||||
run: >-
|
||||
./gradlew
|
||||
:adapter:outbound:fileserver:test
|
||||
--stacktrace
|
||||
|
||||
fileserver-http-contract:
|
||||
runs-on: ubuntu-latest
|
||||
timeout-minutes: 30
|
||||
steps:
|
||||
- uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # actions/checkout@v4.2.2
|
||||
- uses: ./.github/actions/setup-gradle-java
|
||||
- name: Run the servlet transport contracts
|
||||
working-directory: src
|
||||
run: >-
|
||||
./gradlew
|
||||
:adapter:inbound:web-fileserver:test
|
||||
--stacktrace
|
||||
|
||||
fileserver-security-suite:
|
||||
runs-on: ubuntu-latest
|
||||
timeout-minutes: 20
|
||||
steps:
|
||||
- uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # actions/checkout@v4.2.2
|
||||
- uses: ./.github/actions/setup-gradle-java
|
||||
- name: Run the path, filename, range, and problem-detail hardening suite
|
||||
working-directory: src
|
||||
run: >-
|
||||
./gradlew
|
||||
:adapter:inbound:web-fileserver:test --tests '*FileserverHardeningContractTest'
|
||||
:adapter:outbound:fileserver:test --tests '*PhysicalPathResolverTest'
|
||||
--stacktrace
|
||||
|
||||
fileserver-bounded-memory:
|
||||
runs-on: ubuntu-latest
|
||||
timeout-minutes: 20
|
||||
steps:
|
||||
- uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # actions/checkout@v4.2.2
|
||||
- uses: ./.github/actions/setup-gradle-java
|
||||
- name: Prove transfer cost does not scale with file size
|
||||
working-directory: src
|
||||
run: >-
|
||||
./gradlew
|
||||
:adapter:outbound:fileserver:test --tests '*LargeFileBoundedMemoryTest'
|
||||
--stacktrace
|
||||
@@ -55,7 +55,7 @@ concurrency:
|
||||
# compared against the registry, and a Markdown table compared against the declared source sets.
|
||||
# Each was a custom parser for a file format nobody controls, and each made a documentation edit a
|
||||
# precondition for a build. A stale sentence is a defect, but it is not one a build can be failed
|
||||
# for, and link-check.yml already answers the one documentation question with a stable machine
|
||||
# for, and the `links` job below answers the one documentation question with a stable machine
|
||||
# answer: does this link resolve.
|
||||
|
||||
jobs:
|
||||
@@ -245,3 +245,24 @@ jobs:
|
||||
name: compose-runtime-smoke-evidence
|
||||
path: src/app-bootstrap/build/evidence/runtime-smoke
|
||||
if-no-files-found: warn
|
||||
|
||||
# Every committed Markdown link, external URLs included (lychee). A documentation check, so the main
|
||||
# stage rather than the pull request (owner decision 2026-09-16); the relative links of every living
|
||||
# document are also checked on each pull request by scripts/check-docs.py, which needs no network.
|
||||
links:
|
||||
runs-on: ubuntu-latest
|
||||
steps:
|
||||
- uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # actions/checkout@v4.2.2
|
||||
- name: Check committed documentation links
|
||||
uses: lycheeverse/lychee-action@7cd0af4c74a61395d455af97419279d86aafaede # lycheeverse/lychee-action@v2.0.2
|
||||
with:
|
||||
args: >-
|
||||
--no-progress
|
||||
--root-dir .
|
||||
README.md
|
||||
src/README.md
|
||||
'src/**/README.md'
|
||||
'src/**/CLAUDE.md'
|
||||
'docs/**/*.md'
|
||||
'.github/**/*.md'
|
||||
fail: true
|
||||
|
||||
@@ -1,11 +1,9 @@
|
||||
name: jpa-nightly
|
||||
|
||||
# The suites that are too slow, too Docker-heavy, or too machine-dependent for a PR, and the middle
|
||||
# of the PostgreSQL matrix.
|
||||
#
|
||||
# The failure-injection lane is the one that matters most and is easiest to lose: it is the only
|
||||
# place the commit-ambiguity scenarios run, and they are the only evidence that a lost commit
|
||||
# acknowledgement produces completion-unknown rather than a retry.
|
||||
# The platform contract on every Stable PostgreSQL major, one major per job. The failure-injection,
|
||||
# query-plan, security and pool lanes that used to have jobs here are `integration()` and
|
||||
# `performance()` lanes, so `:integrationCheck` and `:performanceCheck` (integration-main.yml) run them
|
||||
# on main and nightly; only the per-major fan-out is not in an aggregate.
|
||||
|
||||
on:
|
||||
workflow_dispatch:
|
||||
@@ -38,49 +36,3 @@ jobs:
|
||||
:adapter:outbound:persistence-jpa:jpaPlatformContractTest
|
||||
-Pjpa.matrix.versions=${{ matrix.postgresql }}
|
||||
--stacktrace
|
||||
|
||||
jpa-failure-injection:
|
||||
runs-on: ubuntu-latest
|
||||
timeout-minutes: 45
|
||||
steps:
|
||||
- uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # actions/checkout@v4.2.2
|
||||
- uses: ./.github/actions/setup-gradle-java
|
||||
- name: Reproduce deadlock, serialization, and commit-ambiguity scenarios
|
||||
working-directory: src
|
||||
run: >-
|
||||
./gradlew
|
||||
:adapter:outbound:persistence-jpa:jpaPlatformFailureTest
|
||||
--stacktrace
|
||||
|
||||
jpa-query-plan-and-security:
|
||||
runs-on: ubuntu-latest
|
||||
timeout-minutes: 45
|
||||
steps:
|
||||
- uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # actions/checkout@v4.2.2
|
||||
- uses: ./.github/actions/setup-gradle-java
|
||||
- name: Run the query plan and database security suites
|
||||
working-directory: src
|
||||
run: >-
|
||||
./gradlew
|
||||
:adapter:outbound:persistence-jpa:jpaPlatformQueryPlanTest
|
||||
:adapter:outbound:persistence-jpa:jpaPlatformSecurityTest
|
||||
--stacktrace
|
||||
|
||||
jpa-pool-pressure:
|
||||
runs-on: ubuntu-latest
|
||||
timeout-minutes: 45
|
||||
steps:
|
||||
- uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # actions/checkout@v4.2.2
|
||||
- uses: ./.github/actions/setup-gradle-java
|
||||
- name: Verify pool saturation and REQUIRES_NEW connection behaviour
|
||||
working-directory: src
|
||||
# A behaviour contract, not a measurement. This step used to switch assertions off with an
|
||||
# explicit property and call the result a certification, so the only threshold it ever
|
||||
# asserted was that thresholds were not being asserted. What
|
||||
# it checks now — that REQUIRES_NEW needs two connections per concurrent thread, that a
|
||||
# saturated pool reports its pending count, that a caller waits rather than proceeding
|
||||
# without a connection — is true on any runner, so there is nothing to switch off.
|
||||
run: >-
|
||||
./gradlew
|
||||
:adapter:outbound:persistence-jpa:jpaPlatformPoolContractTest
|
||||
--stacktrace
|
||||
|
||||
@@ -1,49 +0,0 @@
|
||||
name: link-check
|
||||
|
||||
on:
|
||||
pull_request:
|
||||
paths:
|
||||
- "README.md"
|
||||
- "src/README.md"
|
||||
- "src/**/README.md"
|
||||
- "src/**/CLAUDE.md"
|
||||
- "docs/**/*.md"
|
||||
- ".github/**/*.md"
|
||||
- ".github/workflows/link-check.yml"
|
||||
push:
|
||||
branches: ["main"]
|
||||
paths:
|
||||
- "README.md"
|
||||
- "src/README.md"
|
||||
- "src/**/README.md"
|
||||
- "src/**/CLAUDE.md"
|
||||
- "docs/**/*.md"
|
||||
- ".github/**/*.md"
|
||||
- ".github/workflows/link-check.yml"
|
||||
workflow_dispatch:
|
||||
|
||||
permissions:
|
||||
contents: read
|
||||
|
||||
concurrency:
|
||||
group: ${{ github.workflow }}-${{ github.ref }}
|
||||
cancel-in-progress: true
|
||||
|
||||
jobs:
|
||||
lychee:
|
||||
runs-on: ubuntu-latest
|
||||
steps:
|
||||
- uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # actions/checkout@v4.2.2
|
||||
- name: Check committed documentation links
|
||||
uses: lycheeverse/lychee-action@7cd0af4c74a61395d455af97419279d86aafaede # lycheeverse/lychee-action@v2.0.2
|
||||
with:
|
||||
args: >-
|
||||
--no-progress
|
||||
--root-dir .
|
||||
README.md
|
||||
src/README.md
|
||||
'src/**/README.md'
|
||||
'src/**/CLAUDE.md'
|
||||
'docs/**/*.md'
|
||||
'.github/**/*.md'
|
||||
fail: true
|
||||
@@ -1,44 +1,16 @@
|
||||
name: notification-platform
|
||||
|
||||
# Verification tiers for the Notification Delivery Platform.
|
||||
# The notification platform's chaos tier: the fault, race and restart suites run again on their own,
|
||||
# nightly, because they are the ones a single green run says least about.
|
||||
#
|
||||
# The PR tier is deliberately free of any external provider. A gate that depends on a third-party
|
||||
# sandbox fails for reasons that have nothing to do with the change under review, and a gate people
|
||||
# learn to re-run is not a gate. Real provider smoke tests live in the secret-protected tier, where
|
||||
# a failure is an environment signal rather than a merge blocker.
|
||||
#
|
||||
# Every job that invokes Gradle validates the wrapper first with the repository's pinned action;
|
||||
# the wrapper JAR is executable code fetched at build time, so validating it is what keeps a
|
||||
# compromised wrapper from turning any workflow run into arbitrary code execution.
|
||||
# The pull-request tier that used to be here is gone. Its seven steps ran `:application-core:test`,
|
||||
# the notification leaves' `test` and `check`, and `jpaPlatformContractTest`/`jpaPlatformMigrationTest`
|
||||
# — tasks the pull-request `ci` and `:integrationCheck` already run — and its path filter could not
|
||||
# see the notification ADRs once they moved to docs/adr/. NotificationReleaseGateTest holds those in
|
||||
# the notification leaf's `test`, which `ci` runs on every pull request.
|
||||
|
||||
on:
|
||||
pull_request:
|
||||
paths:
|
||||
# The filter used to stop at the four notification source trees, so a change to the
|
||||
# composition root, the settings binding, the schema migrations, or the evidence manifest
|
||||
# ran none of this — and those are exactly the surfaces that decide whether the platform
|
||||
# assembles, binds and migrates at all.
|
||||
- 'src/application-core/src/**/notification/**'
|
||||
- 'src/adapter/outbound/notification/**'
|
||||
- 'src/adapter/outbound/persistence-notification/**'
|
||||
# The notification real-PostgreSQL qualifications still run in the JPA leaf's lane.
|
||||
- 'src/adapter/outbound/persistence-jpa/src/**/notification/**'
|
||||
- 'src/adapter/inbound/web-notification/**'
|
||||
- 'src/composition/notification-platform/**'
|
||||
- 'src/app-bootstrap/src/main/resources/application*.yml'
|
||||
- 'src/gradle/notification-*.gradle'
|
||||
- 'src/config/architecture/modules.json'
|
||||
- 'src/.env'
|
||||
- 'docs/notification/**'
|
||||
- 'src/app-bootstrap/compose-lanes/smoke/notification-smoke.sh'
|
||||
- '.github/workflows/notification-platform.yml'
|
||||
# Every Gradle job here installs its toolchain through this composite action, so a change to
|
||||
# it changes what this gate runs.
|
||||
- '.github/actions/setup-gradle-java/action.yml'
|
||||
push:
|
||||
branches: [ main ]
|
||||
schedule:
|
||||
# Nightly: the chaos tier, which is slower and inherently less deterministic than the PR tier.
|
||||
- cron: '0 17 * * *'
|
||||
workflow_dispatch:
|
||||
|
||||
@@ -50,47 +22,8 @@ concurrency:
|
||||
cancel-in-progress: true
|
||||
|
||||
jobs:
|
||||
pr:
|
||||
name: contract (Java 21, no external provider)
|
||||
runs-on: ubuntu-latest
|
||||
timeout-minutes: 30
|
||||
steps:
|
||||
- uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # actions/checkout@v4.2.2
|
||||
- uses: ./.github/actions/setup-gradle-java
|
||||
- name: Compile and format check
|
||||
working-directory: src
|
||||
run: ./gradlew :application-core:compileJava :adapter:outbound:notification:compileJava --console=plain
|
||||
- name: Application contracts
|
||||
working-directory: src
|
||||
run: ./gradlew :application-core:test --console=plain
|
||||
- name: Provider contract suite
|
||||
working-directory: src
|
||||
run: ./gradlew :adapter:outbound:notification:test --console=plain
|
||||
- name: Persistence and web
|
||||
working-directory: src
|
||||
run: ./gradlew :adapter:outbound:persistence-jpa:test :adapter:inbound:web-notification:test :composition:notification-platform:test --console=plain
|
||||
# The PR tier never touched a database, so every claim about migrations, claim atomicity and
|
||||
# lease fencing rested on a fake. Docker is available on this runner; the lane fails closed
|
||||
# when the container cannot start, because a skipped contract reports success for a database
|
||||
# nobody tested.
|
||||
- name: Notification schema and claim contracts (real PostgreSQL)
|
||||
working-directory: src
|
||||
run: ./gradlew :adapter:outbound:persistence-jpa:jpaPlatformContractTest --console=plain
|
||||
- name: Notification migration upgrade (real PostgreSQL)
|
||||
working-directory: src
|
||||
run: ./gradlew :adapter:outbound:persistence-jpa:jpaPlatformMigrationTest --console=plain
|
||||
# The architecture gates run in ci-quality-gates.yml on the same pull request; the evidence
|
||||
# manifest (NotificationEvidenceVerifierTest) and the environment registry
|
||||
# (NotificationEnvironmentRegistryTest) are leaf tests the steps above already ran.
|
||||
# verifyNotificationApiSurface is part of the leaf's `check` (owner decision 20), so the step
|
||||
# below runs it; a separate API surface step would run it twice.
|
||||
- name: Static analysis and API surface
|
||||
working-directory: src
|
||||
run: ./gradlew :adapter:outbound:notification:check -x test --console=plain
|
||||
|
||||
nightly-chaos:
|
||||
name: chaos (ambiguity, restart recovery, callback burst)
|
||||
if: github.event_name == 'schedule' || github.event_name == 'workflow_dispatch'
|
||||
runs-on: ubuntu-latest
|
||||
timeout-minutes: 60
|
||||
steps:
|
||||
|
||||
@@ -1,17 +1,9 @@
|
||||
name: object-storage-qualification
|
||||
|
||||
# Only pull requests that touch object storage start the MinIO container (review BUILD-계획-B3). The
|
||||
# MinIO lanes left the object storage leaf's `check`; they run in the root `integrationCheck` (main push
|
||||
# and nightly, integration-main.yml) and here.
|
||||
# The protected AWS lane, on request only: it needs the sandbox credentials. The MinIO contract and
|
||||
# fault lanes that used to have jobs here are `integration()` lanes, so `:integrationCheck`
|
||||
# (integration-main.yml, main and nightly) runs them.
|
||||
on:
|
||||
pull_request:
|
||||
paths:
|
||||
- "src/application-objectstorage/**"
|
||||
- "src/adapter/outbound/objectstorage/**"
|
||||
- "src/gradle/**"
|
||||
- ".github/workflows/object-storage-qualification.yml"
|
||||
schedule:
|
||||
- cron: "23 3 * * 2"
|
||||
workflow_dispatch:
|
||||
inputs:
|
||||
run_protected_aws:
|
||||
@@ -27,25 +19,6 @@ env:
|
||||
TESTCONTAINERS_REUSE_ENABLE: "false"
|
||||
|
||||
jobs:
|
||||
minio-managed-contract:
|
||||
runs-on: ubuntu-latest
|
||||
steps:
|
||||
- uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # actions/checkout@v4.2.2
|
||||
- uses: ./.github/actions/setup-gradle-java
|
||||
- name: Run exact-release MinIO managed contract
|
||||
working-directory: src
|
||||
run: ./gradlew :adapter:outbound:objectstorage:objectStorageMinioContractTest --stacktrace
|
||||
|
||||
minio-managed-fault:
|
||||
if: github.event_name == 'schedule' || github.event_name == 'workflow_dispatch'
|
||||
runs-on: ubuntu-latest
|
||||
steps:
|
||||
- uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # actions/checkout@v4.2.2
|
||||
- uses: ./.github/actions/setup-gradle-java
|
||||
- name: Run digest-pinned MinIO and Toxiproxy fault contract
|
||||
working-directory: src
|
||||
run: ./gradlew :adapter:outbound:objectstorage:objectStorageMinioFaultTest --stacktrace
|
||||
|
||||
aws-managed-common-subset:
|
||||
if: >-
|
||||
github.event_name == 'workflow_dispatch'
|
||||
|
||||
@@ -399,7 +399,7 @@ web 경로의 `W/`는 `src/adapter/inbound/web/src/main/java/dev/caskeleton/adap
|
||||
| `verifyNoStaleTraceableJars` | 해당 없음 — leaf jar 이름에 revision이 없어 stale jar가 생기지 않음 | — |
|
||||
| `GrpcStableReleaseGate`/`GrpcAdvancedPromotionGate` | 게이트에 연결된 적 없음(자기 테스트만). release `grpc-stable-release-gate` job은 그대로 | — |
|
||||
| notification evidence·env registry·mongo lane 계약(`test`) | `notificationDocumentContractTest`·`notificationEnvironmentContractTest`·`mongoDocumentContractTest` | `mainCheck` |
|
||||
| objectstorage MinIO 레인(`check`) | objectstorage `mainCheck` + `integrationCheck` + object-storage-qualification.yml(경로 필터) | `mainCheck` |
|
||||
| objectstorage MinIO 레인(`check`) | 루트 `integrationCheck` | main |
|
||||
| `releaseCheck`의 `ci` | ci-quality-gates.yml `:ci`(PR·main push) | PR |
|
||||
| fileserver-pr `architectureTest --tests '*Fileserver*'` | `:ci`의 `architectureCheck`(전체 ArchUnit) | PR |
|
||||
| legacy whole-`byte[]` 포트 `ObjectStoragePort`·`StoredObject` | `src/application-objectstorage/src/main/java/dev/caskeleton/application/storage/` | `c4a066df` | 한 기능에 한 세대(S1-#17b·S4-#11a). canonical semantic 포트로 대체 |
|
||||
|
||||
@@ -1,8 +1,11 @@
|
||||
# Fileserver 지원 매트릭스
|
||||
|
||||
여기의 지원 등급은 의도가 아니라 증거에 대한 주장이다. 행마다 그 증거를 만드는 CI job을 적는다. 행이 없는
|
||||
job을 적으면 `FileserverDocumentationCoverageTest`가 빌드를 실패시킨다. 그래서 등급은 그것을 정당화한 테스트보다
|
||||
오래 살 수 없다.
|
||||
여기의 지원 등급은 의도가 아니라 증거에 대한 주장이다. 행마다 그 증거를 적는다: 테스트 클래스, 모듈의 `test`
|
||||
태스크, 또는 그 테스트를 따로 돌리는 CI job. 없는 테스트·모듈·job을 적거나 증거 칸이 빈 행이 있으면
|
||||
`FileserverDocumentationCoverageTest`가 빌드를 실패시킨다. 그래서 등급은 그것을 정당화한 테스트보다 오래 살 수 없다.
|
||||
|
||||
테스트 클래스와 모듈 `test`는 그 모듈의 `test`가 pull request 단계(`prCheck` 안의 `ci`)에서 매번 돈다. CI job은 그
|
||||
테스트에 환경(NFS 서버)이나 릴리스 시점이 따로 필요할 때만 적는다.
|
||||
|
||||
## 등급
|
||||
|
||||
@@ -11,31 +14,31 @@ job을 적으면 `FileserverDocumentationCoverageTest`가 빌드를 실패시킨
|
||||
| 등급 | 뜻 |
|
||||
|---|---|
|
||||
| Stable | pull request마다 인증한다. 계약 변경은 깨지는 변경이다. |
|
||||
| Beta | 매일 밤 인증한다. 폐기 예고와 함께 계약이 아직 바뀔 수 있다. |
|
||||
| Beta | 증거 칸의 시험으로 인증한다. 폐기 예고와 함께 계약이 아직 바뀔 수 있다. |
|
||||
| Limited | 밝힌 제약 아래에서 릴리스 게이트에서만 인증한다. |
|
||||
| Compatibility | 받아들이지만 최적화하지 않는다. 알려진 주의점은 그 자리에 적는다. |
|
||||
| Experimental | 기본으로 꺼져 있고, 상위 표준이 확정되지 않았으며, 예고 없이 바뀔 수 있다. |
|
||||
|
||||
## 런타임 profile
|
||||
|
||||
| Profile | 등급 | CI job |
|
||||
| Profile | 등급 | 증거 |
|
||||
|---|---|---|
|
||||
| 로컬 파일 시스템(ext4) content 저장소 | Stable | `fileserver-local-ext4-contract` |
|
||||
| Spring MVC transport(raw, multipart, batch, 다운로드) | Stable | `fileserver-http-contract` |
|
||||
| 경로, 파일 이름, range, problem-detail 강화 | Stable | `fileserver-security-suite` |
|
||||
| 메모리 상한이 있는 전송 | Stable | `fileserver-bounded-memory` |
|
||||
| 애플리케이션·아키텍처 불변식 | Stable | `fileserver-unit-and-architecture` |
|
||||
| 런타임 조립(flag를 켜면 capability가 시작한다) | Stable | `fileserver-unit-and-architecture` |
|
||||
| tus 1.0 이어 올리기 업로드 | Stable | `fileserver-http-contract` |
|
||||
| 장애 복구 매트릭스 | Beta | `fileserver-process-kill-matrix` |
|
||||
| 로컬 파일 시스템(ext4) content 저장소 | Stable | `:adapter:outbound:fileserver:test` |
|
||||
| Spring MVC transport(raw, multipart, batch, 다운로드) | Stable | `:adapter:inbound:web-fileserver:test` |
|
||||
| 경로, 파일 이름, range, problem-detail 강화 | Stable | `FileserverHardeningContractTest`, `PhysicalPathResolverTest` |
|
||||
| 메모리 상한이 있는 전송 | Stable | `LargeFileBoundedMemoryTest` |
|
||||
| 애플리케이션·아키텍처 불변식 | Stable | `:application-fileserver:test`, `:composition:fileserver-platform:test` |
|
||||
| 런타임 조립(flag를 켜면 capability가 시작한다) | Stable | `:composition:fileserver-platform:test` |
|
||||
| tus 1.0 이어 올리기 업로드 | Stable | `:adapter:inbound:web-fileserver:test` |
|
||||
| 장애 복구 매트릭스 | Beta | `CrashRecoveryMatrixTest`, `FileReconciliationServiceTest` |
|
||||
| NFSv4 결과 모름 처리 | Beta | `fileserver-nfs-ambiguity` |
|
||||
| 큰 파일·느린 client 성능 | Beta | `fileserver-large-file-performance` |
|
||||
| 여러 인스턴스 writer lease | Beta | `fileserver-multi-instance-lease` |
|
||||
| Nginx `X-Accel-Redirect` 위임 | Limited | `fileserver-http-contract` |
|
||||
| 큰 파일·느린 client 성능 | Beta | `LargeFileBoundedMemoryTest`, `LocalAppendMemoryTest` |
|
||||
| 여러 인스턴스 writer lease | Beta | `MultiInstanceWriterLeaseTest` |
|
||||
| Nginx `X-Accel-Redirect` 위임 | Limited | `:adapter:inbound:web-fileserver:test` |
|
||||
| telemetry 민감 데이터 억제 | Stable | `fileserver-sensitive-telemetry-scan` |
|
||||
| 문서와 지원 주장 범위 | Stable | `fileserver-documentation-gate` |
|
||||
| 전체 릴리스 검증 | Stable | `fileserver-full-verification` |
|
||||
| HTTP resumable uploads draft-12 | Experimental | `fileserver-http-contract` |
|
||||
| HTTP resumable uploads draft-12 | Experimental | `:adapter:inbound:web-fileserver:test` |
|
||||
|
||||
### WebFlux transport 제거
|
||||
|
||||
@@ -45,7 +48,7 @@ SERVLET으로 정한다.
|
||||
|
||||
## 주장하지 않는 것
|
||||
|
||||
아래는 job이 없고, 그래서 주장도 없다.
|
||||
아래는 증거가 없고, 그래서 주장도 없다.
|
||||
|
||||
- Kubernetes PVC(ReadWriteOnce 포함). 이 repo는 클러스터 매니페스트와 그것을 검사하던 release job을
|
||||
2026-11-07에 지웠다. volume이 지켜야 할 조건은 [operations.md](operations.md) 「운영 환경이 지켜야 할
|
||||
|
||||
@@ -99,9 +99,9 @@ testImplementation testFixtures(project(':adapter:outbound:objectstorage'))
|
||||
### MinIO 검증 lane
|
||||
|
||||
`objectStorageMinioContractTest`와 `objectStorageMinioFaultTest`는 실제 MinIO와 Toxiproxy를 돌린다. 루트
|
||||
`integrationCheck`(main push와 nightly)와, object storage를 건드리는 pull request의
|
||||
`.github/workflows/object-storage-qualification.yml`에서 돈다 — 이 leaf의 `mainCheck`에서는 돌지 않는다.
|
||||
거기서는 main push마다 두 번 돌았다. image는 파일 하나
|
||||
`integrationCheck`(main push와 nightly)에서 돈다. 이 leaf의 `mainCheck`에서는 돌지 않는다. 거기서도 돌던 때는
|
||||
main push마다 두 번 돌았다. object storage를 건드린 pull request에서 따로 돌던 workflow job은 2026-11-08에
|
||||
지웠다(같은 태스크를 `integrationCheck`가 돌린다). image는 파일 하나
|
||||
`src/test/resources/object-storage/minio-provider-evidence.json`에서 읽는다. 그 `image` digest는 옆에 적힌
|
||||
`status`, `excludedProfiles`, `limitations`를 잰 릴리스다. `MinioQualificationImage`(`src/test`에 있고, leaf의
|
||||
`test`가 Docker 없이 검사한다)가 그것을 읽는다.
|
||||
|
||||
@@ -151,8 +151,8 @@ strictTestLanes {
|
||||
description = 'Runs only with explicit protected AWS sandbox authority and exact inputs.'
|
||||
requires 'dev.caskeleton.adapter.outbound.objectstorage.qualification.AwsS3QualificationPreconditionsTest'
|
||||
rejectSkipped = true
|
||||
// The protected environment of object-storage-qualification.yml is the only caller that has
|
||||
// the authority. Without it the lane can only fail, so integrationCheck leaves it out and
|
||||
// The protected AWS workflow job, run on request with the sandbox secrets, is the only caller
|
||||
// that has the authority. Without it the lane can only fail, so integrationCheck leaves it out and
|
||||
// says so (review NEW-16); naming the task still runs it and still fails closed.
|
||||
if (providers.environmentVariable('OBJECT_STORAGE_AWS_QUALIFICATION_ENABLED').getOrElse('') != 'true') {
|
||||
explicitOnly 'it needs OBJECT_STORAGE_AWS_QUALIFICATION_ENABLED=true and the protected AWS sandbox inputs'
|
||||
@@ -162,7 +162,7 @@ strictTestLanes {
|
||||
|
||||
// The MinIO lanes start a container, so they are not this leaf's pull-request `check` (review
|
||||
// BUILD-계획-B3). They are integration lanes, and the root integrationCheck owns every container lane
|
||||
// on main and nightly; object-storage-qualification.yml runs them on pull requests that touch object
|
||||
// storage. This leaf's `mainCheck` used to run them too, so each main push ran them twice in two
|
||||
// parallel jobs (review 2026-11-03 RR-06-09, original 08-04 (d)).
|
||||
// on main and nightly. This leaf's `mainCheck` used to run them too, so each main push ran them twice
|
||||
// in two parallel jobs (review 2026-11-03 RR-06-09, original 08-04 (d)); a path-filtered pull-request
|
||||
// workflow ran them a third time until 2026-11-08.
|
||||
|
||||
|
||||
-14
@@ -34,7 +34,6 @@ class PoolLaneClaimTest {
|
||||
"src/adapter/outbound/persistence-jpa/src/jpaPlatformPerformanceTest/java/dev/caskeleton/adapter/outbound/persistence/platform/pool/PoolPressureContractTest.java",
|
||||
"src/adapter/outbound/persistence-jpa/src/jpaPlatformPerformanceTest/java/dev/caskeleton/adapter/outbound/persistence/platform/pool/HikariPoolSaturationContractTest.java",
|
||||
"src/adapter/outbound/persistence-jpa/src/jpaPlatformPerformanceTest/java/dev/caskeleton/adapter/outbound/persistence/platform/pool/RequiresNewPoolPressureContractTest.java",
|
||||
".github/workflows/jpa-nightly.yml",
|
||||
"docs/jpa/repository-adaptation.md");
|
||||
|
||||
/**
|
||||
@@ -75,19 +74,6 @@ class PoolLaneClaimTest {
|
||||
}
|
||||
}
|
||||
|
||||
@Test
|
||||
@DisplayName("nightly job은 동작 lane을 그 동작 이름으로 돌린다")
|
||||
void theNightlyJobRunsTheBehaviourLane() {
|
||||
String nightly = read(".github/workflows/jpa-nightly.yml");
|
||||
|
||||
assertThat(nightly)
|
||||
.as("the lane that runs must be the one the build registers")
|
||||
.contains(":adapter:outbound:persistence-jpa:jpaPlatformPoolContractTest");
|
||||
assertThat(nightly)
|
||||
.as("the old task name would silently select nothing")
|
||||
.doesNotContain(":adapter:outbound:persistence-jpa:jpaPlatformPerformanceTest");
|
||||
}
|
||||
|
||||
/** Reads a repository-relative file, locating the root by walking up. */
|
||||
private static String read(String repositoryRelativePath) {
|
||||
for (Path directory = Path.of("").toAbsolutePath();
|
||||
|
||||
+15
-43
@@ -32,6 +32,7 @@ import org.yaml.snakeyaml.constructor.SafeConstructor;
|
||||
class DeveloperExperienceContractTest {
|
||||
|
||||
private static final Path REPOSITORY_ROOT = repositoryRoot();
|
||||
private static final String MAIN_WORKFLOW = ".github/workflows/integration-main.yml";
|
||||
|
||||
// The workflow-mutation fixtures that stood here are gone with the tests that used them: a
|
||||
// hex-escaped `uses:`, a line-continued action reference, a `run:` block impersonating a
|
||||
@@ -143,47 +144,24 @@ class DeveloperExperienceContractTest {
|
||||
|
||||
@Test
|
||||
@Tag("repository-contract")
|
||||
void linkCheckIsBlockingAndUsesThePinnedLycheeAction() throws IOException {
|
||||
String workflow = read(".github/workflows/link-check.yml");
|
||||
@DisplayName("링크 검사는 main 단계 job 하나가 고정한 lychee action으로 정해진 문서 범위를 실패하게 검사한다")
|
||||
void linkCheckScansTheExactDocumentationScopeAndFails() throws IOException {
|
||||
// given
|
||||
Map<?, ?> links = requireMap(requireMap(parseYamlMap(read(MAIN_WORKFLOW)), "jobs"), "links");
|
||||
|
||||
assertThat(workflow).contains("lycheeverse/lychee-action@v2.0.2").contains("fail: true");
|
||||
}
|
||||
|
||||
@Test
|
||||
@Tag("repository-contract")
|
||||
void linkCheckTriggersAndScansTheExactDocumentationScope() throws IOException {
|
||||
List<String> expectedPaths =
|
||||
List.of(
|
||||
"README.md",
|
||||
"src/README.md",
|
||||
"src/**/README.md",
|
||||
"src/**/CLAUDE.md",
|
||||
"docs/**/*.md",
|
||||
".github/**/*.md",
|
||||
".github/workflows/link-check.yml");
|
||||
Map<?, ?> workflow = parseYamlMap(read(".github/workflows/link-check.yml"));
|
||||
Map<?, ?> triggers = requireMap(workflow, workflow.containsKey("on") ? "on" : true);
|
||||
|
||||
assertThat(triggers.keySet().stream().map(String::valueOf).toList())
|
||||
.containsExactlyInAnyOrder("pull_request", "push", "workflow_dispatch");
|
||||
assertThat(requireStringList(requireMap(triggers, "pull_request"), "paths"))
|
||||
.containsExactlyElementsOf(expectedPaths);
|
||||
Map<?, ?> push = requireMap(triggers, "push");
|
||||
assertThat(requireStringList(push, "branches")).containsExactly("main");
|
||||
assertThat(requireStringList(push, "paths")).containsExactlyElementsOf(expectedPaths);
|
||||
|
||||
Map<?, ?> lycheeJob = requireMap(requireMap(workflow, "jobs"), "lychee");
|
||||
List<?> steps = requireList(lycheeJob, "steps");
|
||||
// when
|
||||
Map<?, ?> lycheeStep =
|
||||
steps.stream()
|
||||
requireList(links, "steps").stream()
|
||||
.filter(Map.class::isInstance)
|
||||
.map(Map.class::cast)
|
||||
.filter(
|
||||
step ->
|
||||
"lycheeverse/lychee-action@7cd0af4c74a61395d455af97419279d86aafaede"
|
||||
.equals(step.get("uses")))
|
||||
.filter(step -> String.valueOf(step.get("uses")).contains("lychee-action@"))
|
||||
.findFirst()
|
||||
.orElseThrow(() -> new AssertionError("missing pinned lychee action step"));
|
||||
.orElseThrow(() -> new AssertionError("missing lychee action step"));
|
||||
|
||||
// then
|
||||
assertThat(links.containsKey("if")).as("a conditional link check is one nobody sees run").isFalse();
|
||||
assertThat(String.valueOf(lycheeStep.get("uses")))
|
||||
.endsWith("lycheeverse/lychee-action@7cd0af4c74a61395d455af97419279d86aafaede");
|
||||
Map<?, ?> with = requireMap(lycheeStep, "with");
|
||||
assertThat(with.get("fail")).isEqualTo(true);
|
||||
assertThat(shellWords(requireString(with, "args")))
|
||||
@@ -288,16 +266,10 @@ class DeveloperExperienceContractTest {
|
||||
String staleSelector = ":app-bootstrap:test --tests 'dev.caskeleton.bootstrap.architecture.*'";
|
||||
|
||||
// The whole-repository architecture suite runs once per pull request, in ci-quality-gates.yml's
|
||||
// `:ci` (architectureCheck). The fileserver workflow's filtered second run was removed (review
|
||||
// BUILD-중복-6), and the release workflow runs only the tag-only releaseCheck.
|
||||
// `:ci` (architectureCheck), and the release workflow runs only the tag-only releaseCheck.
|
||||
assertThat(read(".github/workflows/ci-quality-gates.yml"))
|
||||
.as("the pull-request gate is the one place the architecture suite runs")
|
||||
.contains("./gradlew :ci");
|
||||
assertThat(read(".github/workflows/fileserver-pr.yml"))
|
||||
.as("the fileserver PR workflow must not repeat the architecture suite")
|
||||
.doesNotContain(":app-bootstrap:architectureTest")
|
||||
.doesNotContain(staleSelector);
|
||||
|
||||
assertThat(read(".github/workflows/release.yml"))
|
||||
.as("the release workflow runs the tag-only checks through releaseCheck")
|
||||
.contains("./gradlew :releaseCheck")
|
||||
|
||||
@@ -63,14 +63,20 @@ dependencies {
|
||||
}
|
||||
|
||||
// FileserverDocumentationCoverageTest reads the fileserver documents, the workflows that define the
|
||||
// support-matrix jobs and the fileserver transport sources. They are inputs of `test`, or Gradle
|
||||
// would call it up to date after an edit to any of them — which is the edit it exists to catch.
|
||||
// support-matrix jobs, the fileserver test sources the matrix names as evidence and the fileserver
|
||||
// transport sources. They are inputs of `test`, or Gradle would call it up to date after an edit to
|
||||
// any of them — which is the edit it exists to catch.
|
||||
def repositoryRoot = rootProject.projectDir.parentFile
|
||||
tasks.named('test') {
|
||||
inputs.dir(new File(repositoryRoot, 'docs/fileserver')).withPropertyName('fileserverDocuments')
|
||||
.withPathSensitivity(PathSensitivity.RELATIVE)
|
||||
inputs.dir(new File(repositoryRoot, '.github/workflows')).withPropertyName('workflows')
|
||||
.withPathSensitivity(PathSensitivity.RELATIVE)
|
||||
inputs.files(['application-fileserver', 'adapter/inbound/web-fileserver', 'adapter/outbound/fileserver',
|
||||
'adapter/outbound/persistence-fileserver', 'composition/fileserver-platform']
|
||||
.collect { rootProject.file("${it}/src/test/java") })
|
||||
.withPropertyName('fileserverTestSources')
|
||||
.withPathSensitivity(PathSensitivity.RELATIVE)
|
||||
inputs.dir(rootProject.file('adapter/inbound/web-fileserver/src/main/java')).withPropertyName('transportSources')
|
||||
.withPathSensitivity(PathSensitivity.RELATIVE)
|
||||
}
|
||||
|
||||
+85
-27
@@ -5,6 +5,7 @@ import static org.assertj.core.api.Assertions.assertThatCode;
|
||||
|
||||
import dev.caskeleton.adapter.outbound.fileserver.platform.autoconfigure.FileserverPlatformSettings;
|
||||
import java.io.IOException;
|
||||
import java.io.UncheckedIOException;
|
||||
import java.nio.file.Files;
|
||||
import java.nio.file.Path;
|
||||
import java.util.ArrayList;
|
||||
@@ -14,6 +15,7 @@ import java.util.Map;
|
||||
import java.util.regex.Matcher;
|
||||
import java.util.regex.Pattern;
|
||||
import java.util.stream.Stream;
|
||||
import org.junit.jupiter.api.DisplayName;
|
||||
import org.junit.jupiter.api.Test;
|
||||
import org.springframework.boot.context.properties.bind.BindHandler;
|
||||
import org.springframework.boot.context.properties.bind.Bindable;
|
||||
@@ -32,21 +34,45 @@ import org.springframework.core.env.StandardEnvironment;
|
||||
*/
|
||||
class FileserverDocumentationCoverageTest {
|
||||
|
||||
private static final Pattern CI_JOB = Pattern.compile("`(fileserver-[a-z0-9-]+)`");
|
||||
private static final String WORKFLOWS = ".github/workflows";
|
||||
private static final Pattern EVIDENCE = Pattern.compile("`([^`]+)`");
|
||||
private static final Pattern CI_JOB = Pattern.compile("fileserver-[a-z0-9-]+");
|
||||
private static final Pattern TEST_TASK = Pattern.compile("(:[a-z0-9:-]+):test");
|
||||
private static final Pattern TEST_CLASS = Pattern.compile("[A-Z][A-Za-z0-9]*Test");
|
||||
private static final Pattern WORKFLOW_JOB = Pattern.compile("^ {2}([a-z0-9-]+):\\s*$");
|
||||
private static final String PROFILE_TABLE_HEADER = "| Profile | 등급 | 증거 |";
|
||||
private static final List<String> FILESERVER_LEAVES =
|
||||
List.of(
|
||||
"src/application-fileserver",
|
||||
"src/adapter/inbound/web-fileserver",
|
||||
"src/adapter/outbound/fileserver",
|
||||
"src/adapter/outbound/persistence-fileserver",
|
||||
"src/composition/fileserver-platform");
|
||||
private static final Pattern MAPPING_PATH =
|
||||
Pattern.compile("\"(/v1/[^\"]*|/internal/fileserver[^\"]*)\"");
|
||||
|
||||
@Test
|
||||
void everySupportClaimNamesAJobThatExists() throws IOException {
|
||||
List<String> claimed =
|
||||
referencedCiJobs(repositoryRoot().resolve("docs/fileserver/support-matrix.md"));
|
||||
List<String> defined = definedWorkflowJobs();
|
||||
@DisplayName("지원 매트릭스의 행마다 있는 테스트·모듈·job을 증거로 적는다")
|
||||
void everySupportClaimNamesEvidenceThatExists() throws IOException {
|
||||
// given
|
||||
Map<String, List<String>> claims =
|
||||
evidenceByProfile(repositoryRoot().resolve("docs/fileserver/support-matrix.md"));
|
||||
|
||||
assertThat(claimed)
|
||||
.as("a support level whose evidence job does not exist is an unbacked claim")
|
||||
.isNotEmpty()
|
||||
.allSatisfy(job -> assertThat(defined).contains(job));
|
||||
// when
|
||||
Map<String, List<String>> unbacked = new LinkedHashMap<>();
|
||||
claims.forEach(
|
||||
(profile, evidence) -> {
|
||||
List<String> missing = evidence.stream().filter(item -> !exists(item)).toList();
|
||||
if (evidence.isEmpty() || !missing.isEmpty()) {
|
||||
unbacked.put(profile, evidence.isEmpty() ? List.of("(none)") : missing);
|
||||
}
|
||||
});
|
||||
|
||||
// then
|
||||
assertThat(claims).isNotEmpty();
|
||||
assertThat(unbacked)
|
||||
.as("a support level whose evidence does not exist is an unbacked claim")
|
||||
.isEmpty();
|
||||
}
|
||||
|
||||
@Test
|
||||
@@ -201,30 +227,62 @@ class FileserverDocumentationCoverageTest {
|
||||
Map.entry("quota.soft-high-water", "0.70"),
|
||||
Map.entry("quota.hard-high-water", "0.85"));
|
||||
|
||||
private static List<String> referencedCiJobs(Path supportMatrix) throws IOException {
|
||||
List<String> jobs = new ArrayList<>();
|
||||
Matcher matcher = CI_JOB.matcher(Files.readString(supportMatrix));
|
||||
while (matcher.find()) {
|
||||
jobs.add(matcher.group(1));
|
||||
/** The evidence cell of every runtime-profile row, keyed by the profile it backs. */
|
||||
private static Map<String, List<String>> evidenceByProfile(Path supportMatrix)
|
||||
throws IOException {
|
||||
Map<String, List<String>> claims = new LinkedHashMap<>();
|
||||
List<String> lines = Files.readAllLines(supportMatrix);
|
||||
int header = lines.indexOf(PROFILE_TABLE_HEADER);
|
||||
assertThat(header).as("the runtime-profile table header").isNotNegative();
|
||||
for (String line : lines.subList(header + 2, lines.size())) {
|
||||
if (!line.startsWith("|")) {
|
||||
break;
|
||||
}
|
||||
String[] cells = line.split("\\|", -1);
|
||||
List<String> evidence = new ArrayList<>();
|
||||
Matcher matcher = EVIDENCE.matcher(cells[3]);
|
||||
while (matcher.find()) {
|
||||
evidence.add(matcher.group(1));
|
||||
}
|
||||
claims.put(cells[1].trim(), evidence);
|
||||
}
|
||||
return jobs;
|
||||
return claims;
|
||||
}
|
||||
|
||||
/**
|
||||
* Job identifiers across every fileserver workflow and the release workflow (which holds the
|
||||
* certification jobs since review BUILD-계획-B2), read from the two-space indent level.
|
||||
* Whether one evidence item names something real: a CI job defined in a workflow, a project whose
|
||||
* {@code test} has test sources, or a test class of a fileserver leaf.
|
||||
*/
|
||||
private static boolean exists(String evidence) {
|
||||
try {
|
||||
if (CI_JOB.matcher(evidence).matches()) {
|
||||
return definedWorkflowJobs().contains(evidence);
|
||||
}
|
||||
Matcher task = TEST_TASK.matcher(evidence);
|
||||
if (task.matches()) {
|
||||
return Files.isDirectory(
|
||||
repositoryRoot().resolve("src" + task.group(1).replace(':', '/') + "/src/test/java"));
|
||||
}
|
||||
if (TEST_CLASS.matcher(evidence).matches()) {
|
||||
for (String leaf : FILESERVER_LEAVES) {
|
||||
try (Stream<Path> files = Files.walk(repositoryRoot().resolve(leaf + "/src/test/java"))) {
|
||||
if (files.anyMatch(file -> file.getFileName().toString().equals(evidence + ".java"))) {
|
||||
return true;
|
||||
}
|
||||
}
|
||||
}
|
||||
}
|
||||
return false;
|
||||
} catch (IOException unreadable) {
|
||||
throw new UncheckedIOException(unreadable);
|
||||
}
|
||||
}
|
||||
|
||||
/** Job identifiers of every workflow, read from the two-space indent level. */
|
||||
private static List<String> definedWorkflowJobs() throws IOException {
|
||||
List<String> jobs = new ArrayList<>();
|
||||
Path workflows = repositoryRoot().resolve(".github/workflows");
|
||||
try (Stream<Path> files = Files.list(workflows)) {
|
||||
for (Path file :
|
||||
files
|
||||
.filter(
|
||||
path ->
|
||||
path.getFileName().toString().startsWith("fileserver-")
|
||||
|| path.getFileName().toString().equals("release.yml"))
|
||||
.toList()) {
|
||||
try (Stream<Path> files = Files.list(repositoryRoot().resolve(WORKFLOWS))) {
|
||||
for (Path file : files.toList()) {
|
||||
for (String line : Files.readAllLines(file)) {
|
||||
Matcher matcher = WORKFLOW_JOB.matcher(line);
|
||||
if (matcher.matches()) {
|
||||
@@ -269,7 +327,7 @@ class FileserverDocumentationCoverageTest {
|
||||
private static Path repositoryRoot() {
|
||||
Path working = Path.of("").toAbsolutePath();
|
||||
Path candidate = working;
|
||||
while (candidate != null && !Files.isDirectory(candidate.resolve(".github/workflows"))) {
|
||||
while (candidate != null && !Files.isDirectory(candidate.resolve(WORKFLOWS))) {
|
||||
candidate = candidate.getParent();
|
||||
}
|
||||
if (candidate == null) {
|
||||
|
||||
Reference in New Issue
Block a user