test(removal-fixture): check the evidence copy against a temporary tree (10-01)
The test counted git-ignored artifacts/release/* files in the working directory, so a fresh clone or CI runner had none and failed. It now writes fake evidence and regenerated-tree files into a temp source root. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
co-authored by
Claude Opus 5.5
parent
c5f379b82c
commit
23336f2300
@@ -96,39 +96,39 @@ describe("release evidence fixture copy", () => {
|
||||
const { RELEASE_CANDIDATE_EVIDENCE_PATHS } = await import(
|
||||
"../../scripts/lib/release-candidate.ts"
|
||||
);
|
||||
const { mkdtemp, access, readdir } = await import("node:fs/promises");
|
||||
const { tmpdir } = await import("node:os");
|
||||
const nodePath = (await import("node:path")).default;
|
||||
const { access, readdir } = await import("node:fs/promises");
|
||||
|
||||
const root = await mkdtemp(nodePath.join(tmpdir(), "release-evidence-"));
|
||||
await copyReleaseEvidenceTree(process.cwd(), root);
|
||||
// The source is a fake checkout, not process.cwd(): release evidence is
|
||||
// git-ignored, so a fresh clone has none of it and the copy would be
|
||||
// checked against nothing.
|
||||
const source = await mkdtemp(path.join(tmpdir(), "release-evidence-source-"));
|
||||
const target = await mkdtemp(path.join(tmpdir(), "release-evidence-target-"));
|
||||
temporaryRoots.push(source, target);
|
||||
const evidencePaths = RELEASE_CANDIDATE_EVIDENCE_PATHS.filter((evidence) =>
|
||||
evidence.startsWith("artifacts/")
|
||||
);
|
||||
expect(evidencePaths.length).toBeGreaterThan(0);
|
||||
for (const relative of [
|
||||
...evidencePaths,
|
||||
...RELEASE_EVIDENCE_REGENERATED_TREES.map((tree) => `${tree}/trace.zip`),
|
||||
]) {
|
||||
await mkdir(path.dirname(path.join(source, relative)), { recursive: true });
|
||||
await writeFile(path.join(source, relative), "{}\n");
|
||||
}
|
||||
|
||||
// Every release artifact that exists here has to survive the copy; a
|
||||
// fixture missing one cannot build a candidate at all, and every provider
|
||||
// suite then fails while constructing its own fixture.
|
||||
//
|
||||
// Which ones exist depends on what this checkout has generated — a product
|
||||
// repository that has not run the release chain has fewer than the template
|
||||
// does — so the subject is preservation, not the presence of a full chain.
|
||||
// Requiring at least one keeps that from quietly asserting nothing.
|
||||
let preserved = 0;
|
||||
for (const evidence of RELEASE_CANDIDATE_EVIDENCE_PATHS) {
|
||||
if (!evidence.startsWith("artifacts/")) continue;
|
||||
try {
|
||||
await access(evidence);
|
||||
} catch {
|
||||
continue;
|
||||
}
|
||||
await expect(access(nodePath.join(root, evidence)), evidence).resolves.toBeUndefined();
|
||||
preserved += 1;
|
||||
await copyReleaseEvidenceTree(source, target);
|
||||
|
||||
// Every release artifact has to survive the copy; a fixture missing one
|
||||
// cannot build a candidate at all, and every provider suite then fails
|
||||
// while constructing its own fixture.
|
||||
for (const evidence of evidencePaths) {
|
||||
await expect(access(path.join(target, evidence)), evidence).resolves.toBeUndefined();
|
||||
}
|
||||
expect(preserved).toBeGreaterThan(0);
|
||||
// The regenerated trees are why this is a filter and not a plain copy: they
|
||||
// are tens of megabytes of traces and coverage HTML. They still exist,
|
||||
// because the repository inventory expects the directories.
|
||||
for (const tree of RELEASE_EVIDENCE_REGENERATED_TREES) {
|
||||
await expect(access(nodePath.join(root, tree)), tree).resolves.toBeUndefined();
|
||||
await expect(readdir(nodePath.join(root, tree)), tree).resolves.toEqual([]);
|
||||
await expect(readdir(path.join(target, tree)), tree).resolves.toEqual([]);
|
||||
}
|
||||
});
|
||||
});
|
||||
|
||||
Reference in New Issue
Block a user