fix(security): CSP 검사가 브라우저처럼 읽고 hosting fixture가 선언을 복사하지 않는다
frontend-quality-gates / merge / tests (pull_request) Canceled after 0s
frontend-quality-gates / merge / browser tests (pull_request) Canceled after 0s
frontend-quality-gates / FE-GATE-014 / config-compatibility (pull_request) Canceled after 0s
frontend-quality-gates / FE-GATE-026 / lab-performance (pull_request) Canceled after 0s
frontend-quality-gates / FE-GATE-028 / manual-accessibility-review (pull_request) Canceled after 0s
frontend-quality-gates / FE-GATE-015 / immutable-release-candidate (pull_request) Canceled after 0s
frontend-quality-gates / external-vulnerability-provider (pull_request) Canceled after 0s
frontend-quality-gates / external-provenance-provider (pull_request) Canceled after 0s
frontend-quality-gates / promote-verified-immutable-candidate (pull_request) Canceled after 0s
frontend-quality-gates / deploy-promoted-release (pull_request) Canceled after 0s
frontend-quality-gates / FE-GATE-019 / hosting-header (pull_request) Canceled after 0s
frontend-quality-gates / FE-GATE-021 / runbook-boot-config (pull_request) Canceled after 0s
frontend-quality-gates / FE-GATE-022 / runbook-chunk-mismatch (pull_request) Canceled after 0s
frontend-quality-gates / FE-GATE-023 / runbook-api-degradation (pull_request) Canceled after 0s
frontend-quality-gates / FE-GATE-024 / runbook-telemetry (pull_request) Canceled after 0s
frontend-quality-gates / FE-GATE-025 / runbook-release-rollback (pull_request) Canceled after 0s
frontend-quality-gates / FE-GATE-018 / field-web-vitals (pull_request) Canceled after 0s
frontend-quality-gates / FE-GATE-017 / diagram-review (pull_request) Canceled after 0s
frontend-quality-gates / main / checker self-tests (pull_request) Canceled after 0s
frontend-quality-gates / merge / static checks (pull_request) Canceled after 51s

앞 커밋 뒤 확인 리뷰가 셋을 찾았다.

- 같은 지시어가 두 번이면 검사는 뒤 값을, 브라우저는 앞 값을 쓴다(CSP3).
  키워드도 대소문자를 가려 비교한다. 그래서 `script-src 'self' 'unsafe-inline';
  script-src 'self'`와 `'Unsafe-Inline'`이 통과한다.
- 0929/13-04 완료 기준 「CSP를 바꿀 때 한 파일만 고친다」가 안 됐다. hosting
  fixture가 선언한 보안 header 일곱을 표면 넷에 그대로 복사한다.
- check:browser-security가 검사를 부르는 연결을 지키는 시험이 없다.

고른 방법: 지시어는 첫 것만, 이름과 키워드는 소문자로 읽는다. 선언 문서를
읽는 declaredCspProblems를 두고 check:browser-security가 그것을 부른다.
check:security:fixtures(FE-GATE-029)가 거절 fixture(대소문자를 바꾼
'unsafe-inline'이 앞 script-src에 있음)를 거절하고 선언을 받는지 본다. hosting
fixture에서 보안 header를 지우고, verify-hosting-headers의 fixture 모드는
보안 header가 필요한 표면에 선언을 답으로 채운다. fixture가 적은 값은 그대로
host의 답으로 비교한다. 버린 대안: fixture를 선언에서 생성하는 스크립트(생성물이
하나 더 생기고 대조할 것은 같다).

위험·한계: fixture 모드의 보안 header 비교는 선언끼리의 비교가 된다. 전에도
fixture 모드는 UNVERIFIED였다(live 모드만 host를 본다).

검증: csp-policy.test.ts 새 시험(브라우저처럼 읽기 다섯, 뒤 지시어 무시,
declaredCspProblems 넷)과 hosting-probe.test.ts 새 시험 둘(선언만 바꾼 뒤
fixture 통과, fixture가 적은 header는 비교)을 고치기 전 코드에서 RED로 보고
desktop에서 GREEN·FE-GATE-029를 돌린다(PR 본문).

Refs: 0929/13-04
This commit is contained in:
DongHyeonka
2026-11-13 00:12:23 +09:00
parent 9f469b6065
commit afcd248780
10 changed files with 153 additions and 42 deletions
+6
View File
@@ -7,6 +7,12 @@ production source map.
선언된 header 집합은 `config/hosting/security-headers.json`이다. hosting 검증은
이 선언과 실제 응답을 비교한다. CSP는 일부러 `unsafe-inline`과 `unsafe-eval`을
뺀다. production 코드와 빌드된 asset은 이 기준선에서도 동작해야 한다.
`check:browser-security`(FE-GATE-013)는 선언한 CSP가 `'unsafe-inline'`,
`'unsafe-eval'`, `*`, script의 scheme 통째 허용(`https:`)을 담으면 실패한다.
브라우저처럼 같은 지시어가 두 번이면 앞의 것을 읽고, 키워드의 대소문자를 가리지
않는다(`scripts/lib/csp-policy.ts`). hosting fixture
(`tests/fixtures/hosting/response-headers.json`)는 이 header를 복사하지 않는다.
fixture 모드는 선언을 그대로 답으로 쓰므로 CSP를 바꿀 때 선언 파일 하나만 고친다.
`tests/e2e/production-csp.spec.ts`(`test:e2e`의 일부, FE-GATE-008)는 이 header로
빌드를 서빙한다. 그리고 `securitypolicyviolation` 이벤트나 console 오류가 나면
실패한다(리뷰 13-08). zod는 첫 object schema에서 `Function("")`을 시험 삼아
+2 -6
View File
@@ -1,7 +1,7 @@
import { readdir, readFile } from "node:fs/promises";
import { spawnSync } from "node:child_process";
import { cspPolicyProblems } from "./lib/csp-policy.ts";
import { declaredCspProblems } from "./lib/csp-policy.ts";
function requiredPnpmCli(): string {
const executable = process.env.npm_execpath;
@@ -38,11 +38,7 @@ const distFiles = await readdir("dist", { recursive: true });
const publicSourceMaps = distFiles.filter((file) => String(file).endsWith(".map"));
const SECURITY_HEADERS = "config/hosting/security-headers.json";
const declared = (
JSON.parse(await readFile(SECURITY_HEADERS, "utf8")) as { headers?: Record<string, string> }
).headers?.["Content-Security-Policy"];
const cspProblems =
declared === undefined ? ["no Content-Security-Policy header"] : cspPolicyProblems(declared);
const cspProblems = declaredCspProblems(await readFile(SECURITY_HEADERS, "utf8"));
if (
allowed.status !== 0 ||
+3 -1
View File
@@ -1,10 +1,12 @@
import {
checkDeclaredCspFixtures,
checkNonmatchingSecurityIncludeFixture,
checkSecurityFixtures,
} from "./lib/security-fixture-check.ts";
await checkNonmatchingSecurityIncludeFixture();
await checkSecurityFixtures();
await checkDeclaredCspFixtures();
process.stdout.write(
"Security fixtures: unmatched include rejected; 3 forbidden files detected\n",
"Security fixtures: unmatched include rejected; 3 forbidden files detected; unsafe CSP fixture rejected\n",
);
+32 -5
View File
@@ -1,8 +1,9 @@
/**
* 0929/13-04. What the declared Content-Security-Policy
* (config/hosting/security-headers.json) may not allow. The hosting fixtures
* copy it and scripts/verify-hosting-headers.ts compares them; this reads what
* it allows. check:browser-security (FE-GATE-013) runs it.
* (config/hosting/security-headers.json) may not allow.
* scripts/verify-hosting-headers.ts compares a host's answer with it; this
* reads what it allows. check:browser-security (FE-GATE-013) runs it, and
* check:security:fixtures (FE-GATE-029) holds it to a rejected fixture.
*/
const UNSAFE_SOURCES = new Set(["'unsafe-inline'", "'unsafe-eval'", "*"]);
/** Directives whose sources decide what script or plugin code may run or style may apply. */
@@ -20,12 +21,24 @@ const CODE_DIRECTIVES = new Set([
const SCHEME_ONLY = /^[a-z][a-z0-9+.-]*:$/u;
const SCRIPT_DIRECTIVES = new Set(["default-src", "script-src", "script-src-elem", "object-src"]);
export function cspPolicyProblems(policy: string): string[] {
/**
* The directives as a browser reads them (CSP3): names and keywords in any
* case, and the first of a repeated directive, the later ones ignored.
*/
function directivesOf(policy: string): Map<string, readonly string[]> {
const directives = new Map<string, readonly string[]>();
for (const part of policy.split(";")) {
const [name, ...sources] = part.trim().split(/\s+/u);
if (name) directives.set(name.toLowerCase(), sources);
const key = name?.toLowerCase();
if (key && !directives.has(key)) {
directives.set(key, sources.map((source) => source.toLowerCase()));
}
}
return directives;
}
export function cspPolicyProblems(policy: string): string[] {
const directives = directivesOf(policy);
const problems: string[] = [];
if (!directives.has("script-src") && !directives.has("default-src")) {
problems.push("no script-src and no default-src");
@@ -41,3 +54,17 @@ export function cspPolicyProblems(policy: string): string[] {
}
return problems;
}
/**
* The problems of the policy a security-headers document (the shape of
* config/hosting/security-headers.json) declares, its header name in any case.
*/
export function declaredCspProblems(securityHeadersJson: string): string[] {
const document = JSON.parse(securityHeadersJson) as { headers?: Record<string, unknown> };
const policy = Object.entries(document.headers ?? {}).find(
([name]) => name.toLowerCase() === "content-security-policy",
)?.[1];
return typeof policy === "string"
? cspPolicyProblems(policy)
: ["no Content-Security-Policy header"];
}
+24
View File
@@ -3,6 +3,8 @@ import { mkdtemp, readFile, rm } from "node:fs/promises";
import { tmpdir } from "node:os";
import path from "node:path";
import { declaredCspProblems } from "./csp-policy.ts";
type ScanResult = Readonly<{
error?: Error;
status: number | null;
@@ -168,3 +170,25 @@ export async function checkNonmatchingSecurityIncludeFixture(
await cleanup(directory);
}
}
/**
* 0929/13-04. The policy check check:browser-security runs rejects its
* fixture (a keyword in another case, in the first of two script-src) and
* accepts the declared policy.
*/
export async function checkDeclaredCspFixtures(): Promise<void> {
const fixture = "tests/fixtures/security/csp/rejected-security-headers.json";
const rejected = declaredCspProblems(await readFile(fixture, "utf8"));
const expected = ["script-src allows 'unsafe-inline'"];
if (JSON.stringify(rejected) !== JSON.stringify(expected)) {
throw new Error(
`${fixture}: expected ${expected.join(", ")}; received ${rejected.join(", ") || "no problem"}`,
);
}
const declared = declaredCspProblems(
await readFile("config/hosting/security-headers.json", "utf8"),
);
if (declared.length > 0) {
throw new Error(`config/hosting/security-headers.json: ${declared.join("; ")}`);
}
}
+14 -1
View File
@@ -131,7 +131,20 @@ if (liveTarget?.passed && !slotEmpty) {
const fixture = await readDocument(
"tests/fixtures/hosting/response-headers.json",
);
responses = responseHeaders(fixture.responses);
// 0929/13-04. The fixture host answers with the declared security headers
// wherever the fixture names none, so a policy change is one file. A value
// the fixture names is compared like a host's answer.
const declaredAnswer = Object.fromEntries(
Object.entries(securityHeaders).map(([header, value]) => [header.toLowerCase(), value]),
);
responses = Object.fromEntries(
Object.entries(responseHeaders(fixture.responses)).map(([surface, headers]) => [
surface,
recordValue(cacheSurfaces[surface]).securityHeaders === true
? { ...declaredAnswer, ...headers }
: headers,
]),
);
}
const results: ProbeResult[] = [...probeResults];
+4 -28
View File
@@ -3,33 +3,15 @@
"responses": {
"index": {
"cache-control": "no-cache",
"content-type": "text/html; charset=utf-8",
"content-security-policy": "default-src 'self'; base-uri 'self'; object-src 'none'; frame-ancestors 'none'; form-action 'self'; script-src 'self'; style-src 'self'; img-src 'self' data:; connect-src 'self' https:; font-src 'self'; upgrade-insecure-requests",
"strict-transport-security": "max-age=31536000; includeSubDomains",
"x-frame-options": "DENY",
"referrer-policy": "strict-origin-when-cross-origin",
"x-content-type-options": "nosniff",
"permissions-policy": "camera=(), microphone=(), geolocation=()"
"content-type": "text/html; charset=utf-8"
},
"runtimeConfig": {
"cache-control": "no-store",
"content-type": "application/json; charset=utf-8",
"content-security-policy": "default-src 'self'; base-uri 'self'; object-src 'none'; frame-ancestors 'none'; form-action 'self'; script-src 'self'; style-src 'self'; img-src 'self' data:; connect-src 'self' https:; font-src 'self'; upgrade-insecure-requests",
"strict-transport-security": "max-age=31536000; includeSubDomains",
"x-frame-options": "DENY",
"referrer-policy": "strict-origin-when-cross-origin",
"x-content-type-options": "nosniff",
"permissions-policy": "camera=(), microphone=(), geolocation=()"
"content-type": "application/json; charset=utf-8"
},
"releaseManifest": {
"cache-control": "no-store",
"content-type": "application/json; charset=utf-8",
"content-security-policy": "default-src 'self'; base-uri 'self'; object-src 'none'; frame-ancestors 'none'; form-action 'self'; script-src 'self'; style-src 'self'; img-src 'self' data:; connect-src 'self' https:; font-src 'self'; upgrade-insecure-requests",
"strict-transport-security": "max-age=31536000; includeSubDomains",
"x-frame-options": "DENY",
"referrer-policy": "strict-origin-when-cross-origin",
"x-content-type-options": "nosniff",
"permissions-policy": "camera=(), microphone=(), geolocation=()"
"content-type": "application/json; charset=utf-8"
},
"hashedAsset": {
"cache-control": "public, max-age=31536000, immutable",
@@ -38,13 +20,7 @@
},
"appRoute": {
"cache-control": "no-cache",
"content-type": "text/html; charset=utf-8",
"content-security-policy": "default-src 'self'; base-uri 'self'; object-src 'none'; frame-ancestors 'none'; form-action 'self'; script-src 'self'; style-src 'self'; img-src 'self' data:; connect-src 'self' https:; font-src 'self'; upgrade-insecure-requests",
"strict-transport-security": "max-age=31536000; includeSubDomains",
"x-frame-options": "DENY",
"referrer-policy": "strict-origin-when-cross-origin",
"x-content-type-options": "nosniff",
"permissions-policy": "camera=(), microphone=(), geolocation=()"
"content-type": "text/html; charset=utf-8"
},
"serviceWorker": {
"cache-control": "no-cache",
@@ -0,0 +1,5 @@
{
"headers": {
"content-security-policy": "default-src 'self'; script-src 'self' 'Unsafe-Inline'; script-src 'self'; object-src 'none'"
}
}
+33 -1
View File
@@ -2,7 +2,7 @@ import { readFileSync } from "node:fs";
import { describe, expect, it } from "vitest";
import { cspPolicyProblems } from "../../scripts/lib/csp-policy.ts";
import { cspPolicyProblems, declaredCspProblems } from "../../scripts/lib/csp-policy.ts";
/**
* 0929/13-04. The hosting fixtures copy the declared policy and a check
@@ -40,4 +40,36 @@ describe("cspPolicyProblems", () => {
it("refuses a policy without script-src or default-src", () => {
expect(cspPolicyProblems("img-src 'self'")).toContain("no script-src and no default-src");
});
// round9 confirm review. A browser uses the first of a repeated directive
// and reads keywords in any case (CSP3), so the check does too.
it.each([
["script-src 'self' 'unsafe-inline'; script-src 'self'", "script-src allows 'unsafe-inline'"],
["Script-Src 'self' 'unsafe-inline'; script-src 'self'", "script-src allows 'unsafe-inline'"],
["script-src 'self' 'Unsafe-Inline'", "script-src allows 'unsafe-inline'"],
["script-src 'self' 'UNSAFE-EVAL'", "script-src allows 'unsafe-eval'"],
["script-src 'self' HTTPS:", "script-src allows the whole scheme https:"],
])("reads %s as a browser does", (policy, problem) => {
expect(cspPolicyProblems(policy)).toContain(problem);
});
it("does not read a repeated directive's later sources", () => {
expect(cspPolicyProblems("script-src 'self'; script-src 'unsafe-inline'")).toEqual([]);
});
});
// The check check:browser-security runs on config/hosting/security-headers.json.
describe("declaredCspProblems", () => {
it.each([
["the declared file", readFileSync("config/hosting/security-headers.json", "utf8"), []],
["a header name in another case", JSON.stringify({ headers: { "content-security-policy": "script-src 'self'" } }), []],
["no policy", JSON.stringify({ headers: { "X-Frame-Options": "DENY" } }), ["no Content-Security-Policy header"]],
[
"an unsafe policy",
JSON.stringify({ headers: { "Content-Security-Policy": "script-src 'self' 'unsafe-inline'" } }),
["script-src allows 'unsafe-inline'"],
],
])("reads %s", (_label, text, problems) => {
expect(declaredCspProblems(text)).toEqual(problems);
});
});
+30
View File
@@ -507,6 +507,7 @@ describe("verify-hosting-headers on a promoted release root (1101/13-01)", () =>
distFiles: Readonly<Record<string, string>>,
env: Readonly<Record<string, string>> = {},
editFixture?: (responses: Record<string, Record<string, string>>) => void,
editDeclared?: (headers: Record<string, string>) => void,
) {
const root = await mkdtemp(path.join(tmpdir(), "hosting-release-root-"));
try {
@@ -514,6 +515,14 @@ describe("verify-hosting-headers on a promoted release root (1101/13-01)", () =>
for (const file of ["cache-policy.json", "security-headers.json"]) {
await copyFile(`config/hosting/${file}`, path.join(root, "config/hosting", file));
}
if (editDeclared) {
const declaredPath = path.join(root, "config/hosting/security-headers.json");
const declared = JSON.parse(await readFile(declaredPath, "utf8")) as {
headers: Record<string, string>;
};
editDeclared(declared.headers);
await writeFile(declaredPath, JSON.stringify(declared));
}
await mkdir(path.join(root, "tests/fixtures/hosting"), { recursive: true });
await copyFile(
"tests/fixtures/hosting/response-headers.json",
@@ -590,6 +599,27 @@ describe("verify-hosting-headers on a promoted release root (1101/13-01)", () =>
);
});
// 0929/13-04. A policy change is one file: the fixture host answers with
// the declared security headers wherever the fixture names none.
it("passes the fixture host after only the declared policy changes", async () => {
const result = await verify(DIST, {}, undefined, (headers) => {
headers["Content-Security-Policy"] = (headers["Content-Security-Policy"] ?? "").replace(
"img-src 'self' data:",
"img-src 'self' data: https://images.example.test",
);
});
expect(result.failed, result.stderr).toEqual([]);
expect(result.mode).toBe("fixture");
}, childProcessTimeout(1_931));
it("still compares a security header the fixture host answers with", async () => {
const result = await verify(DIST, {}, (responses) => {
responses["index"] = { ...responses["index"], "x-frame-options": "SAMEORIGIN" };
});
expect(result.failed, result.stderr).toEqual(["index x-frame-options"]);
expect(result.status).toBe(1);
}, childProcessTimeout(1_931));
it("fails a hashed asset served without a declared content encoding", async () => {
const result = await verify(DIST, {}, (responses) => {
delete responses["hashedAsset"]?.["content-encoding"];