refactor(scale): vite 빌드 입력 목록을 한 모듈에 둔다
문제: 초기 JS 측정(scripts/scale/measure-feature-shape-growth.ts)과
VITE_PRODUCT_FEATURES=none 빌드 테스트
(tests/unit/product-feature-selection-build.test.ts)가 임시 폴더에 복사할
빌드 입력 8개를 따로 적는다. vite.config.ts가 새 로컬 파일을 import하면
두 목록이 함께 낡고, 한쪽만 고치면 원인을 말하지 않는 "Could not resolve"로
실패한다(7f9a515, 799ab7f가 두 곳을 같이 고쳤다).
고른 방법: scripts/lib/vite-build-inputs.ts에 VITE_BUILD_INPUTS 하나를 두고
두 파일이 import한다. 측정 스크립트가 테스트 파일을 import하지 않는다.
새 tests/unit/vite-build-inputs.test.ts가 (1) 두 소비자에 자기 목록이
없고 이 모듈을 쓰는지, (2) vite.config.ts가 상대 경로로 닿는 모든 파일이
목록 안에 있는지 본다. (2)는 새 로컬 import를 목록에 넣지 않으면 빌드
전에 그 파일 이름으로 실패한다.
버린 대안: 목록을 vite.config.ts에서 export — 설정 파일을 빌드 도구 밖에서
import하면 플러그인 초기화가 따라온다.
위험·한계: import 그래프는 정규식으로 따라간다. 동적 import나 alias로
읽는 파일은 보지 못한다(지금은 없다). scripts/lib/removal-fixture.ts의
복사 목록은 저장소 전체 사본용이라 목적이 달라 합치지 않았다. 측정
스크립트는 참조 기능과 함께 지워지므로(test:sample-removal), (1)은 있는
소비자만 본다. 템플릿에서 그 파일이 없어지면
tests/unit/feature-shape-growth.test.ts가 import에서 실패한다.
검증: desktop batch에서 확인.
node scripts/run-vitest.ts run tests/unit/vite-build-inputs.test.ts
tests/unit/product-feature-selection-build.test.ts
tests/unit/feature-shape-growth.test.ts
corepack pnpm ci:gate FE-GATE-020 (참조 기능을 지운 사본의 test:all)
Refs: 1105/15-03
This commit is contained in:
@@ -0,0 +1,20 @@
|
||||
/**
|
||||
* 1105/15-03. The files `vite build` reads from the repository root, for the
|
||||
* measurements and tests that copy them into a temporary root and build
|
||||
* there: scripts/scale/measure-feature-shape-growth.ts (initial JavaScript
|
||||
* record) and tests/unit/product-feature-selection-build.test.ts
|
||||
* (`VITE_PRODUCT_FEATURES=none`). Each used to keep its own copy of this list;
|
||||
* a new local import in vite.config.ts broke both, and both had to be edited
|
||||
* (7f9a515, 799ab7f). tests/unit/vite-build-inputs.test.ts fails, naming the
|
||||
* file, when vite.config.ts imports a local file this list does not cover.
|
||||
*/
|
||||
export const VITE_BUILD_INPUTS = Object.freeze([
|
||||
"src",
|
||||
"public",
|
||||
"index.html",
|
||||
"package.json",
|
||||
"vite.config.ts",
|
||||
"tsconfig.base.json",
|
||||
"tsconfig.app.json",
|
||||
"scripts/lib/vite-module-inventory.ts",
|
||||
] as const);
|
||||
@@ -7,6 +7,7 @@ import { gzipSync } from "node:zlib";
|
||||
|
||||
import { classifyViteJavascript } from "../lib/classify-vite-bundle.ts";
|
||||
import { linkFixtureNodeModules } from "../lib/fixture-node-modules.ts";
|
||||
import { VITE_BUILD_INPUTS } from "../lib/vite-build-inputs.ts";
|
||||
import { parseTscExtendedDiagnostics, type TscDiagnostics } from "./collect-tsc-diagnostics.ts";
|
||||
|
||||
/**
|
||||
@@ -37,16 +38,6 @@ export const FEATURE_SHAPE_CEILINGS_PATH = "config/scale/feature-shape-ceilings.
|
||||
|
||||
const SOURCE_FEATURE = "src/features/reference-feature";
|
||||
const FEATURES_PER_CONTEXT = 200;
|
||||
const BUILD_INPUTS = [
|
||||
"src",
|
||||
"public",
|
||||
"index.html",
|
||||
"package.json",
|
||||
"vite.config.ts",
|
||||
"tsconfig.base.json",
|
||||
"tsconfig.app.json",
|
||||
"scripts/lib/vite-module-inventory.ts",
|
||||
] as const;
|
||||
// Platform-owned names that only happen to contain "reference".
|
||||
const PLATFORM_TOKENS = [
|
||||
"REFERENCE_FEATURE_V1",
|
||||
@@ -110,7 +101,7 @@ async function copyRenamed(from: string, to: string, rename: (text: string) => s
|
||||
|
||||
async function createFixture(features: number): Promise<string> {
|
||||
const root = await mkdtemp(path.join(tmpdir(), `feature-shape-${features}-`));
|
||||
for (const input of BUILD_INPUTS) {
|
||||
for (const input of VITE_BUILD_INPUTS) {
|
||||
await mkdir(path.dirname(path.join(root, input)), { recursive: true });
|
||||
await cp(path.resolve(input), path.join(root, input), { recursive: true });
|
||||
}
|
||||
|
||||
@@ -8,6 +8,7 @@ import { afterAll, describe, expect, it } from "vitest";
|
||||
|
||||
import { linkFixtureNodeModules } from "../../scripts/lib/fixture-node-modules.ts";
|
||||
import { filesBelow } from "../../scripts/lib/removal-fixture.ts";
|
||||
import { VITE_BUILD_INPUTS } from "../../scripts/lib/vite-build-inputs.ts";
|
||||
import { ROUTE_FEATURE_OWNER } from "../../src/features/installed-feature-contracts.ts";
|
||||
import { COMPILED_PRODUCT_FEATURE_IDS } from "../../src/features/installed-product-manifest.ts";
|
||||
|
||||
@@ -16,19 +17,10 @@ import { COMPILED_PRODUCT_FEATURE_IDS } from "../../src/features/installed-produ
|
||||
* every consumer, not only the browser bundle: the generated context index
|
||||
* (router), the installed contract contributions (Node contract-set
|
||||
* generation) and the built assets. This runs the production generator and a
|
||||
* Vite build over a copy of the build inputs. Written against whatever
|
||||
* features the tree declares, so it holds after the sample's removal too.
|
||||
* Vite build over a copy of the build inputs (scripts/lib/vite-build-inputs.ts,
|
||||
* 1105/15-03). Written against whatever features the tree declares, so it
|
||||
* holds after the sample's removal too.
|
||||
*/
|
||||
const BUILD_INPUTS = [
|
||||
"src",
|
||||
"public",
|
||||
"index.html",
|
||||
"package.json",
|
||||
"vite.config.ts",
|
||||
"tsconfig.base.json",
|
||||
"tsconfig.app.json",
|
||||
"scripts/lib/vite-module-inventory.ts",
|
||||
] as const;
|
||||
// Feature ids stay: the generated index still declares them so the platform
|
||||
// overview reports NOT_INSTALLED. Their modules and route ids go.
|
||||
const FEATURE_ROUTE_IDS = Object.keys(ROUTE_FEATURE_OWNER);
|
||||
@@ -44,7 +36,7 @@ describe("VITE_PRODUCT_FEATURES=none build (09-02)", () => {
|
||||
it("leaves every feature out of the context index, the contract set and dist", async () => {
|
||||
const root = await mkdtemp(path.join(tmpdir(), "product-selection-build-"));
|
||||
roots.push(root);
|
||||
for (const input of BUILD_INPUTS) {
|
||||
for (const input of VITE_BUILD_INPUTS) {
|
||||
await mkdir(path.dirname(path.join(root, input)), { recursive: true });
|
||||
await cp(path.resolve(input), path.join(root, input), { recursive: true });
|
||||
}
|
||||
|
||||
@@ -0,0 +1,72 @@
|
||||
import { existsSync, readFileSync } from "node:fs";
|
||||
import path from "node:path";
|
||||
|
||||
import { describe, expect, it } from "vitest";
|
||||
|
||||
/**
|
||||
* 1105/15-03. Two copies of the list of files `vite build` reads from the
|
||||
* root (the initial JavaScript measurement and the
|
||||
* `VITE_PRODUCT_FEATURES=none` build test) had to change together each time
|
||||
* vite.config.ts imported a new local file (7f9a515, 799ab7f), and a missed
|
||||
* copy failed with an unexplained "Could not resolve". There is one list
|
||||
* now, and it has to cover what vite.config.ts imports.
|
||||
*/
|
||||
const LIST_MODULE = "scripts/lib/vite-build-inputs.ts";
|
||||
// The measurement goes with the reference feature it copies
|
||||
// (test:sample-removal), so a project without that feature checks the build
|
||||
// test alone. In the template, tests/unit/feature-shape-growth.test.ts
|
||||
// imports the measurement and fails if the file is gone.
|
||||
const CONSUMERS = [
|
||||
"scripts/scale/measure-feature-shape-growth.ts",
|
||||
"tests/unit/product-feature-selection-build.test.ts",
|
||||
].filter((file) => existsSync(file));
|
||||
|
||||
const LOCAL_IMPORT =
|
||||
/\bfrom\s+["'](\.{1,2}\/[^"']+)["']|\bimport\s+["'](\.{1,2}\/[^"']+)["']/gu;
|
||||
|
||||
/** Every repository file vite.config.ts reaches through relative imports. */
|
||||
function localImportGraph(entry: string): string[] {
|
||||
const seen = new Set<string>();
|
||||
const pending = [entry];
|
||||
while (pending.length > 0) {
|
||||
const file = pending.pop()!;
|
||||
if (seen.has(file)) continue;
|
||||
seen.add(file);
|
||||
const source = readFileSync(file, "utf8");
|
||||
for (const match of source.matchAll(LOCAL_IMPORT)) {
|
||||
const specifier = match[1] ?? match[2]!;
|
||||
const resolved = path
|
||||
.relative(process.cwd(), path.resolve(path.dirname(file), specifier))
|
||||
.split(path.sep)
|
||||
.join("/");
|
||||
if (existsSync(resolved)) pending.push(resolved);
|
||||
}
|
||||
}
|
||||
return [...seen];
|
||||
}
|
||||
|
||||
describe("vite build inputs (1105/15-03)", () => {
|
||||
it("defines the list in one module that both builds import", () => {
|
||||
for (const consumer of CONSUMERS) {
|
||||
const source = readFileSync(consumer, "utf8");
|
||||
expect(source, consumer).not.toMatch(/\bconst BUILD_INPUTS\s*=/u);
|
||||
expect(source, consumer).toMatch(/\bVITE_BUILD_INPUTS\b/u);
|
||||
expect(source, consumer).toContain("vite-build-inputs.ts");
|
||||
}
|
||||
});
|
||||
|
||||
it("covers every local file vite.config.ts imports", async () => {
|
||||
// Imported here, not at the top, so the first test still reports the
|
||||
// copies when the module is missing.
|
||||
const { VITE_BUILD_INPUTS } = await import("../../scripts/lib/vite-build-inputs.ts");
|
||||
const covered = (file: string) =>
|
||||
VITE_BUILD_INPUTS.some((input) => file === input || file.startsWith(`${input}/`));
|
||||
|
||||
const missing = localImportGraph("vite.config.ts").filter((file) => !covered(file));
|
||||
|
||||
expect(
|
||||
missing,
|
||||
`vite.config.ts reads files ${LIST_MODULE} does not copy; add them there`,
|
||||
).toEqual([]);
|
||||
});
|
||||
});
|
||||
Reference in New Issue
Block a user