Commit Graph
5 Commits
Author SHA1 Message Date
DongHyeonka f0a8582c72 fix(ci): 시험 fixture가 PR job의 게이트 선택 env를 물려받지 않는다
frontend-quality-gates / merge / static checks (pull_request) Successful in 1m33s
frontend-quality-gates / merge / tests (pull_request) Successful in 12m9s
frontend-quality-gates / merge / browser tests (pull_request) Successful in 5m35s
frontend-quality-gates / FE-GATE-017 / diagram-review (pull_request) Skipped
frontend-quality-gates / main / self-tests and removal drills (pull_request) Skipped
frontend-quality-gates / FE-GATE-014 / config-compatibility (pull_request) Skipped
frontend-quality-gates / FE-GATE-028 / manual-accessibility-review (pull_request) Skipped
frontend-quality-gates / FE-GATE-026 / lab-performance (pull_request) Skipped
frontend-quality-gates / FE-GATE-015 / immutable-release-candidate (pull_request) Skipped
frontend-quality-gates / external-vulnerability-provider (pull_request) Skipped
frontend-quality-gates / external-provenance-provider (pull_request) Skipped
frontend-quality-gates / promote-verified-immutable-candidate (pull_request) Skipped
frontend-quality-gates / deploy-promoted-release (pull_request) Skipped
frontend-quality-gates / FE-GATE-019 / hosting-header (pull_request) Skipped
frontend-quality-gates / FE-GATE-021 / runbook-boot-config (pull_request) Skipped
frontend-quality-gates / FE-GATE-022 / runbook-chunk-mismatch (pull_request) Skipped
frontend-quality-gates / FE-GATE-023 / runbook-api-degradation (pull_request) Skipped
frontend-quality-gates / FE-GATE-024 / runbook-telemetry (pull_request) Skipped
frontend-quality-gates / FE-GATE-025 / runbook-release-rollback (pull_request) Skipped
frontend-quality-gates / FE-GATE-018 / field-web-vitals (pull_request) Skipped
PR run의 merge job은 CI_PR_BASE_REF=main을 둔다. 임시 폴더에서
scripts/run-ci-gate.ts를 띄우는 시험은 env를 그대로 물려줬고, 자식은
그 폴더에 없는 config/ci/pr-gate-selection.json을 열다 ENOENT로
죽었다(runner run 291, tests/unit/ci-gate-failure.test.ts:102).
FE-GATE-005가 깨졌고, scaffold 사본의 test:coverage가 같은 시험을 돌려
FE-GATE-020도 깨졌다. desktop verify.sh merge는 ci_env에 이 변수가 없어
이 길을 타지 않았다.

fixture는 PR의 checkout이 아니므로 그 안의 게이트는 늘 전부 돈다.
FIXTURE_PNPM_ENVIRONMENT가 CI_PR_BASE_REF를 빈 값(main run과 같음)으로
둔다. scaffold 드릴·제거 드릴·provider fixture·run-ci-gate를 띄우는 시험이
모두 이 상수를 쓰므로 한 곳에서 끈다.
- ci-gate-failure 시험은 바깥 env와 상관없이 PR job env(main)를 넣고
  띄운다. 그래서 desktop에서도 CI의 조건을 늘 시험한다.
- run-ci-gate를 띄우는 시험은 이 상수를 써야 한다는 검사를
  fixture-node-modules 시험에 더했다. 그 검사가 상수 없이 띄우던
  ci-workflow-generation 시험 하나를 찾았다. 그 시험은 preflight에서
  먼저 막혀 지금은 가려지지 않지만, 상수를 주고 막힌 이유를 단언한다.

버린 대안:
- prGateSkipReason이 경로표가 없으면 전부 돌기: 원인은 시험 env다. 진짜
  checkout에서 경로표가 없으면 크게 실패하는 편이 맞다.
- verify.sh ci_env에 CI_PR_BASE_REF를 두기: desktop merge가 게이트를
  건너뛰게 되어 「merge 단계 전부 통과」 판정과 맞지 않는다.

위험·한계:
- 시스템 컨테이너(scripts/run-in-system-container.sh)는 CI_PR_BASE_REF를
  넘기지 않는다. 그래서 FE-GATE-013은 PR run에서도 늘 전부 돈다(안전한
  쪽). 이 커밋은 그대로 둔다.

검증(desktop):
- RED: 9f8b2c1c에서 `env CI_PR_BASE_REF=main node scripts/run-vitest.ts
  run tests/unit/ci-gate-failure.test.ts` rc=1, run 291과 같은 ENOENT.
- 고친 뒤 시험 4파일(ci-gate-failure, fixture-node-modules,
  pr-gate-selection, ci-workflow-generation) 471개 통과, 바깥
  CI_PR_BASE_REF=main 있을 때와 없을 때 둘 다.
- 상수의 새 줄만 빼면 바깥 env 없이도 ci-gate-failure 시험이 같은
  ENOENT로 실패한다. 새 검사는 상수를 안 쓰던 시험을 찾아 실패했다.
2026-11-14 03:40:46 +09:00
donghyeon-kaandClaude Opus 5.5 a8520f6dfb fix(fixtures): keep pnpm in a linked fixture from installing (F-4)
pnpm verifies the install before a script, and a fixture running it with
CI=true against an install made without CI saw other settings and installed
through the linked .pnpm and .bin, rewriting the shared lock.yaml and shims.
Every fixture pnpm run now turns that check off; a test pins it for all.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-09-27 13:20:12 +09:00
DongHyeonkaandClaude Opus 5.5 926f448fce fix(scripts): point the fixture's pnpm state at the fixture root (00-01)
A copied state file still named the repository as the validated project,
so pnpm inside a fixture re-verified and started an install through the
linked package directories.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-09-25 21:56:45 +09:00
DongHyeonkaandClaude Opus 5.5 e771e5e032 fix(scripts): copy pnpm state files into fixture node_modules (00-01)
Linking every top-level entry also linked .pnpm-workspace-state-v1.json,
so pnpm running inside a fixture rewrote the repository's own install
state. Top-level files are now copied; directories stay symlinks.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-09-25 21:10:58 +09:00
DongHyeonkaandClaude Opus 5 250531aa43 fix: stop test fixtures from deleting the repository's dependencies
Four fixtures linked the installed dependencies into a throwaway root with a
single directory symlink at <fixture>/node_modules, then ran pnpm inside that
root. pnpm does not recognise the modules directory it finds there and purges
it; with CI=true it does so without a prompt. The purge followed the symlink and
deleted the repository's own node_modules mid-run, so a test suite uninstalled
the workspace it was running in. That is what produced the cascading,
file-unrelated failures a full test:unit run reported, and it happened twice
while running the suites for the adapter re-review.

scripts/lib/fixture-node-modules.ts replaces all four sites: node_modules is a
real directory whose entries are individual symlinks, so a recursive delete
unlinks the fixture's own links instead of walking through one link into the
shared tree. Resolution is unchanged.

tests/unit/fixture-node-modules.test.ts performs the exact recursive delete pnpm
performs and asserts the source tree survives, and check:adapter-inventory now
fails on any reintroduction of the directory-symlink form — verified by putting
the old line back and watching the gate reject it.

A full tests/unit + tests/integration run now leaves the dependencies intact.
removal-fixture, supply-chain and security-followup-archive, the three suites
that had to be excluded before, pass in that run.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
2026-08-14 16:08:32 +09:00