fix(ci): 시험 fixture가 PR job의 게이트 선택 env를 물려받지 않는다
frontend-quality-gates / merge / static checks (pull_request) Successful in 1m33s
frontend-quality-gates / merge / tests (pull_request) Successful in 12m9s
frontend-quality-gates / merge / browser tests (pull_request) Successful in 5m35s
frontend-quality-gates / FE-GATE-017 / diagram-review (pull_request) Skipped
frontend-quality-gates / main / self-tests and removal drills (pull_request) Skipped
frontend-quality-gates / FE-GATE-014 / config-compatibility (pull_request) Skipped
frontend-quality-gates / FE-GATE-028 / manual-accessibility-review (pull_request) Skipped
frontend-quality-gates / FE-GATE-026 / lab-performance (pull_request) Skipped
frontend-quality-gates / FE-GATE-015 / immutable-release-candidate (pull_request) Skipped
frontend-quality-gates / external-vulnerability-provider (pull_request) Skipped
frontend-quality-gates / external-provenance-provider (pull_request) Skipped
frontend-quality-gates / promote-verified-immutable-candidate (pull_request) Skipped
frontend-quality-gates / deploy-promoted-release (pull_request) Skipped
frontend-quality-gates / FE-GATE-019 / hosting-header (pull_request) Skipped
frontend-quality-gates / FE-GATE-021 / runbook-boot-config (pull_request) Skipped
frontend-quality-gates / FE-GATE-022 / runbook-chunk-mismatch (pull_request) Skipped
frontend-quality-gates / FE-GATE-023 / runbook-api-degradation (pull_request) Skipped
frontend-quality-gates / FE-GATE-024 / runbook-telemetry (pull_request) Skipped
frontend-quality-gates / FE-GATE-025 / runbook-release-rollback (pull_request) Skipped
frontend-quality-gates / FE-GATE-018 / field-web-vitals (pull_request) Skipped
frontend-quality-gates / merge / static checks (pull_request) Successful in 1m33s
frontend-quality-gates / merge / tests (pull_request) Successful in 12m9s
frontend-quality-gates / merge / browser tests (pull_request) Successful in 5m35s
frontend-quality-gates / FE-GATE-017 / diagram-review (pull_request) Skipped
frontend-quality-gates / main / self-tests and removal drills (pull_request) Skipped
frontend-quality-gates / FE-GATE-014 / config-compatibility (pull_request) Skipped
frontend-quality-gates / FE-GATE-028 / manual-accessibility-review (pull_request) Skipped
frontend-quality-gates / FE-GATE-026 / lab-performance (pull_request) Skipped
frontend-quality-gates / FE-GATE-015 / immutable-release-candidate (pull_request) Skipped
frontend-quality-gates / external-vulnerability-provider (pull_request) Skipped
frontend-quality-gates / external-provenance-provider (pull_request) Skipped
frontend-quality-gates / promote-verified-immutable-candidate (pull_request) Skipped
frontend-quality-gates / deploy-promoted-release (pull_request) Skipped
frontend-quality-gates / FE-GATE-019 / hosting-header (pull_request) Skipped
frontend-quality-gates / FE-GATE-021 / runbook-boot-config (pull_request) Skipped
frontend-quality-gates / FE-GATE-022 / runbook-chunk-mismatch (pull_request) Skipped
frontend-quality-gates / FE-GATE-023 / runbook-api-degradation (pull_request) Skipped
frontend-quality-gates / FE-GATE-024 / runbook-telemetry (pull_request) Skipped
frontend-quality-gates / FE-GATE-025 / runbook-release-rollback (pull_request) Skipped
frontend-quality-gates / FE-GATE-018 / field-web-vitals (pull_request) Skipped
PR run의 merge job은 CI_PR_BASE_REF=main을 둔다. 임시 폴더에서 scripts/run-ci-gate.ts를 띄우는 시험은 env를 그대로 물려줬고, 자식은 그 폴더에 없는 config/ci/pr-gate-selection.json을 열다 ENOENT로 죽었다(runner run 291, tests/unit/ci-gate-failure.test.ts:102). FE-GATE-005가 깨졌고, scaffold 사본의 test:coverage가 같은 시험을 돌려 FE-GATE-020도 깨졌다. desktop verify.sh merge는 ci_env에 이 변수가 없어 이 길을 타지 않았다. fixture는 PR의 checkout이 아니므로 그 안의 게이트는 늘 전부 돈다. FIXTURE_PNPM_ENVIRONMENT가 CI_PR_BASE_REF를 빈 값(main run과 같음)으로 둔다. scaffold 드릴·제거 드릴·provider fixture·run-ci-gate를 띄우는 시험이 모두 이 상수를 쓰므로 한 곳에서 끈다. - ci-gate-failure 시험은 바깥 env와 상관없이 PR job env(main)를 넣고 띄운다. 그래서 desktop에서도 CI의 조건을 늘 시험한다. - run-ci-gate를 띄우는 시험은 이 상수를 써야 한다는 검사를 fixture-node-modules 시험에 더했다. 그 검사가 상수 없이 띄우던 ci-workflow-generation 시험 하나를 찾았다. 그 시험은 preflight에서 먼저 막혀 지금은 가려지지 않지만, 상수를 주고 막힌 이유를 단언한다. 버린 대안: - prGateSkipReason이 경로표가 없으면 전부 돌기: 원인은 시험 env다. 진짜 checkout에서 경로표가 없으면 크게 실패하는 편이 맞다. - verify.sh ci_env에 CI_PR_BASE_REF를 두기: desktop merge가 게이트를 건너뛰게 되어 「merge 단계 전부 통과」 판정과 맞지 않는다. 위험·한계: - 시스템 컨테이너(scripts/run-in-system-container.sh)는 CI_PR_BASE_REF를 넘기지 않는다. 그래서 FE-GATE-013은 PR run에서도 늘 전부 돈다(안전한 쪽). 이 커밋은 그대로 둔다. 검증(desktop): - RED: 9f8b2c1c에서 `env CI_PR_BASE_REF=main node scripts/run-vitest.ts run tests/unit/ci-gate-failure.test.ts` rc=1, run 291과 같은 ENOENT. - 고친 뒤 시험 4파일(ci-gate-failure, fixture-node-modules, pr-gate-selection, ci-workflow-generation) 471개 통과, 바깥 CI_PR_BASE_REF=main 있을 때와 없을 때 둘 다. - 상수의 새 줄만 빼면 바깥 env 없이도 ci-gate-failure 시험이 같은 ENOENT로 실패한다. 새 검사는 상수를 안 쓰던 시험을 찾아 실패했다.
This commit is contained in:
@@ -1,6 +1,8 @@
|
||||
import { copyFile, mkdir, readdir, readFile, stat, symlink, writeFile } from "node:fs/promises";
|
||||
import path from "node:path";
|
||||
|
||||
import { PR_BASE_REF_VARIABLE } from "./pr-gate-selection.ts";
|
||||
|
||||
/**
|
||||
* Links the repository's installed dependencies into a throwaway fixture root.
|
||||
*
|
||||
@@ -36,9 +38,18 @@ import path from "node:path";
|
||||
* shims. A fixture started through `pnpm <script>` inherits this setting from
|
||||
* pnpm; one started directly (`node scripts/run-vitest.ts run <file>`) did not.
|
||||
* The fixture uses the repository's packages as they are; it never installs.
|
||||
*
|
||||
* A fixture is not the PR's checkout either, so it runs with the PR gate
|
||||
* selection off (`CI_PR_BASE_REF` empty, as in a main run). A PR run's merge
|
||||
* jobs set it, and a fixture that inherited it ran `scripts/run-ci-gate.ts`
|
||||
* against a path table the fixture root does not have (runner run 291: ENOENT
|
||||
* on config/ci/pr-gate-selection.json, FE-GATE-005 and, through the scaffold
|
||||
* copy's coverage run, FE-GATE-020). A gate a fixture runs always runs; a
|
||||
* test of the selection itself sets the variable after this spread.
|
||||
*/
|
||||
export const FIXTURE_PNPM_ENVIRONMENT = Object.freeze({
|
||||
pnpm_config_verify_deps_before_run: "false",
|
||||
[PR_BASE_REF_VARIABLE]: "",
|
||||
});
|
||||
|
||||
export async function linkFixtureNodeModules(
|
||||
|
||||
@@ -8,6 +8,7 @@ import { describe, expect, it } from "vitest";
|
||||
import { loadCiGateContract } from "../../scripts/contracts/ci-gates.ts";
|
||||
import { formatGateFailure } from "../../scripts/lib/ci-gate-failure.ts";
|
||||
import { FIXTURE_PNPM_ENVIRONMENT } from "../../scripts/lib/fixture-node-modules.ts";
|
||||
import { PR_BASE_REF_VARIABLE } from "../../scripts/lib/pr-gate-selection.ts";
|
||||
import { childProcessTimeout } from "../helpers/child-process-timeout.ts";
|
||||
|
||||
/**
|
||||
@@ -92,10 +93,14 @@ describe("run-ci-gate on a failing command", { timeout: childProcessTimeout(871)
|
||||
await writeFile(path.join(root, "config/ci/gates.json"), `${JSON.stringify(contract)}\n`);
|
||||
await writeFile(path.join(root, "package.json"), `${JSON.stringify(packageDocument)}\n`);
|
||||
|
||||
// The job environment of a PR run: its merge jobs set the PR's base
|
||||
// branch (runner run 291). The fixture environment turns the selection
|
||||
// off, so this gate runs here whatever run this test is in.
|
||||
const prRunEnvironment = { ...process.env, [PR_BASE_REF_VARIABLE]: "main" };
|
||||
const result = spawnSync(
|
||||
process.execPath,
|
||||
[path.resolve("scripts/run-ci-gate.ts"), "FE-GATE-004"],
|
||||
{ cwd: root, encoding: "utf8", env: { ...process.env, ...FIXTURE_PNPM_ENVIRONMENT, CI: "false" } },
|
||||
{ cwd: root, encoding: "utf8", env: { ...prRunEnvironment, ...FIXTURE_PNPM_ENVIRONMENT, CI: "false" } },
|
||||
);
|
||||
|
||||
expect(result.status).toBe(1);
|
||||
|
||||
@@ -24,6 +24,7 @@ import {
|
||||
workflowGateExecutionFailures,
|
||||
type CiWorkflowFileSystem,
|
||||
} from "../../scripts/generate-ci-workflow.ts";
|
||||
import { FIXTURE_PNPM_ENVIRONMENT } from "../../scripts/lib/fixture-node-modules.ts";
|
||||
import {
|
||||
isNpmScopeEnvironmentName,
|
||||
validateInstallScriptPolicy,
|
||||
@@ -1598,8 +1599,13 @@ describe("CI gate contract", () => {
|
||||
packageDocument.scripts["check:ci"] = `node -e 'require("node:fs").writeFileSync(${JSON.stringify(marker)}, "spawned")'`;
|
||||
await writeFile(path.join(root, "config/ci/gates.json"), `${JSON.stringify(contract)}\n`);
|
||||
await writeFile(path.join(root, "package.json"), `${JSON.stringify(packageDocument)}\n`);
|
||||
const result = spawnSync(process.execPath, [path.resolve("scripts/run-ci-gate.ts"), "FE-GATE-010"], { cwd: root, encoding: "utf8" });
|
||||
const result = spawnSync(process.execPath, [path.resolve("scripts/run-ci-gate.ts"), "FE-GATE-010"], {
|
||||
cwd: root,
|
||||
encoding: "utf8",
|
||||
env: { ...process.env, ...FIXTURE_PNPM_ENVIRONMENT },
|
||||
});
|
||||
expect(result.status).not.toBe(0);
|
||||
expect(result.stderr).toContain("check:ci must use the exact canonical non-recursive orchestration");
|
||||
await expect(readFile(marker)).rejects.toMatchObject({ code: "ENOENT" });
|
||||
}, childProcessTimeout(1_298));
|
||||
|
||||
|
||||
@@ -289,4 +289,23 @@ describe("pnpm inside a linked fixture (F-4)", { timeout: childProcessTimeout(94
|
||||
}
|
||||
expect(offenders).toEqual([]);
|
||||
});
|
||||
|
||||
// Runner run 291. A fixture that runs scripts/run-ci-gate.ts with the PR
|
||||
// run's job environment read the fixture root's missing path table. Every
|
||||
// such fixture starts the gate with the fixture environment.
|
||||
it("is used by every fixture that runs scripts/run-ci-gate.ts", async () => {
|
||||
const listed = spawnSync(
|
||||
"git",
|
||||
["grep", "-l", "-F", 'resolve("scripts/run-ci-gate.ts")', "--", ...selectRepositoryPaths("fixture-code")],
|
||||
{ encoding: "utf8" },
|
||||
);
|
||||
expect(listed.status, listed.stderr).toBe(0);
|
||||
const files = listed.stdout.trim().split("\n").filter((file) => file !== "tests/unit/fixture-node-modules.test.ts");
|
||||
expect(files.length).toBeGreaterThan(0);
|
||||
const offenders: string[] = [];
|
||||
for (const file of files) {
|
||||
if (!(await readFile(file, "utf8")).includes("FIXTURE_PNPM_ENVIRONMENT")) offenders.push(file);
|
||||
}
|
||||
expect(offenders).toEqual([]);
|
||||
});
|
||||
});
|
||||
|
||||
Reference in New Issue
Block a user